<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>230328</bug_id>
          
          <creation_ts>2021-09-15 17:09:45 -0700</creation_ts>
          <short_desc>Allow use of --git-index and --git-commit at the same time when using with --only-files</short_desc>
          <delta_ts>2021-09-16 11:09:15 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Hoa Dinh">dvh</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>jbedard</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1793904</commentid>
    <comment_count>0</comment_count>
    <who name="Hoa Dinh">dvh</who>
    <bug_when>2021-09-15 17:09:45 -0700</bug_when>
    <thetext>We should we be able to use --git-index and --git-commit to asks for the list of changes between the specific commit and HEAD plus the current git index.
Since it&apos;s mainly useful in the case of --only-files, we&apos;ll allow it only for this case.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1793914</commentid>
    <comment_count>1</comment_count>
      <attachid>438308</attachid>
    <who name="Hoa Dinh">dvh</who>
    <bug_when>2021-09-15 17:33:01 -0700</bug_when>
    <thetext>Created attachment 438308
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1794113</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-09-16 11:08:21 -0700</bug_when>
    <thetext>Committed r282562 (241750@main): &lt;https://commits.webkit.org/241750@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438308.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1794114</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-09-16 11:09:15 -0700</bug_when>
    <thetext>&lt;rdar://problem/83205119&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>438308</attachid>
            <date>2021-09-15 17:33:01 -0700</date>
            <delta_ts>2021-09-16 11:08:21 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-230328-20210915173300.patch</filename>
            <type>text/plain</type>
            <size>1839</size>
            <attacher name="Hoa Dinh">dvh</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyNDY1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjIzZjQwY2JhNjhjZTEwYzgyNzlkOGY0NDkzMDBlMmQy
YzkxYzI2MS4uNmQ0NTRhNDYwMDUxOTA3Yzk3YzAyYzVmNGZmNzhjZTAyZTZhMDk1ZCAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3
IEBACisyMDIxLTA5LTE1ICBIb2EgRGluaCAgPGR2aEBhcHBsZS5jb20+CisKKyAgICAgICAgQWxs
b3cgdXNlIG9mIC0tZ2l0LWluZGV4IGFuZCAtLWdpdC1jb21taXQgYXQgdGhlIHNhbWUgdGltZSB3
aGVuIHVzaW5nIHdpdGggLS1vbmx5LWZpbGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu
b3JnL3Nob3dfYnVnLmNnaT9pZD0yMzAzMjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKworICAgICAgICBXaGVuIHNwZWNpZnlpbmcgLS1naXQtaW5kZXggYW5kIC0tZ2l0
LWNvbW1pdCwgaXQgd2lsbCBjb21wdXRlIHRoZSBkaWZmIGJldHdlZW4gdGhlIHBhcmVudCBjb21t
aXQgb2YgdGhlIHNwZWNpZmllZCBjb21taXQKKyAgICAgICAgYW5kIEhFQUQsIGluY2x1ZGluZyB0
aGUgY3VycmVudCBzdGFnZWQgY2hhbmdlcy4KKworICAgICAgICAqIFNjcmlwdHMvcHJlcGFyZS1D
aGFuZ2VMb2c6CisgICAgICAgIChtYWluKToKKyAgICAgICAgKGRpZmZGcm9tVG9TdHJpbmcpOgor
CiAyMDIxLTA5LTE1ICBHZXphIExvcmUgIDxnZXphbG9yZUBnbWFpbC5jb20+CiAKICAgICAgICAg
Q2FjaGUgcmVzb3VyY2UgcGF0aHMgaW4gcnVuLWpzYy1zdHJlc3MtdGVzdHMgZm9yIHNwZWVkdXAK
ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cgYi9Ub29scy9TY3Jp
cHRzL3ByZXBhcmUtQ2hhbmdlTG9nCmluZGV4IDJjZDYwMzUwYzJhMmExYTY3MmQ5ZWNiYzU1YWJi
YWEyNDUxOTRjMzkuLjQ3OWQ3NzlhNDRmODg1ZjdhMTg3YjdhMjg4YmJkMjk5NDBlNGEzYWUgMTAw
NzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cKKysrIGIvVG9vbHMvU2Ny
aXB0cy9wcmVwYXJlLUNoYW5nZUxvZwpAQCAtMTg5LDcgKzE4OSw3IEBAIHN1YiBtYWluKCkKICAg
ICAgICAgc3lzdGVtICIkRmluZEJpbjo6QmluL2NoZWNrLXdlYmtpdC1zdHlsZSI7CiAgICAgfQog
Ci0gICAgZGllICItLWdpdC1jb21taXQgYW5kIC0tZ2l0LWluZGV4IGFyZSBpbmNvbXBhdGlibGUu
IiBpZiAoJGdpdEluZGV4ICYmICRnaXRDb21taXQpOworICAgIGRpZSAiLS1naXQtY29tbWl0IGFu
ZCAtLWdpdC1pbmRleCBhcmUgaW5jb21wYXRpYmxlIHdoZW4gbm90IHVzZWQgd2l0aCAtLW9ubHkt
ZmlsZXMuIiBpZiAoJGdpdEluZGV4ICYmICRnaXRDb21taXQgJiYgISRvbmx5RmlsZXMpOwogCiAg
ICAgaXNTVk4oKSB8fCBpc0dpdCgpIHx8IGRpZSAiQ291bGRuJ3QgZGV0ZXJtaW5lIHlvdXIgdmVy
c2lvbiBjb250cm9sIHN5c3RlbS4iOwogCkBAIC0yMDY4LDYgKzIwNjgsNyBAQCBzdWIgZGlmZkZy
b21Ub1N0cmluZygkJCQpCiAKICAgICByZXR1cm4gIiIgaWYgaXNTVk4oKTsKICAgICByZXR1cm4g
JGdpdENvbW1pdCBpZiAkZ2l0Q29tbWl0ID1+IG0vLitcLlwuLisvOworICAgIHJldHVybiAiLS1j
YWNoZWQgXCIkZ2l0Q29tbWl0XlwiIiBpZiAkZ2l0Q29tbWl0ICYmICRnaXRJbmRleDsKICAgICBy
ZXR1cm4gIlwiJGdpdENvbW1pdF5cIiBcIiRnaXRDb21taXRcIiIgaWYgJGdpdENvbW1pdDsKICAg
ICByZXR1cm4gIi0tY2FjaGVkIiBpZiAkZ2l0SW5kZXg7CiAgICAgcmV0dXJuICRtZXJnZUJhc2Ug
aWYgJG1lcmdlQmFzZTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>