230282 2021-09-14 15:59:25 -0700 Fix -Wredundant-move warnings 2021-09-14 16:48:22 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro achristensen kkinnunen mcatanzaro webkit-bug-importer oldest_to_newest 1793486 0 mcatanzaro 2021-09-14 15:59:25 -0700 Fix -Wredundant-move warnings Hi Alex, I'm CCing you because you introduced one of these in 241547@main, and it technically requires owner approval to fix.... 1793487 1 438185 mcatanzaro 2021-09-14 16:00:28 -0700 Created attachment 438185 Patch 1793488 2 mcatanzaro 2021-09-14 16:01:47 -0700 (BTW the difference here is: GCC warns whenever a WTFMove is redundant in return values, whereas clang only warns when a WTFMove actually prevents copy elision from happening. I don't know the differences between the two cases.) 1793489 3 438185 mcatanzaro 2021-09-14 16:04:13 -0700 Comment on attachment 438185 Patch Thanks. 1793512 4 ews-feeder 2021-09-14 16:48:01 -0700 Committed r282421 (241680@main): <https://commits.webkit.org/241680@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438185. 1793514 5 webkit-bug-importer 2021-09-14 16:48:22 -0700 <rdar://problem/83122939> 438185 2021-09-14 16:00:28 -0700 2021-09-14 16:48:02 -0700 Patch bug-230282-20210914180027.patch text/plain 2274 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyNDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGRjODNlYjE0ZDM5ZGNlMjRj ZDM3OWNlMmU4MmUwZjhlMDA4ZmE0MzIuLmJiOWZlM2U1Y2UzNDlkMjRiMWE3NWM0OTI0MTc2Njcz YmVjMWVjZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMDktMTQgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAgRml4IC1XcmVkdW5k YW50LW1vdmUgd2FybmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIzMDI4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogUGxhdGZvcm0vSVBDL0FyZ3VtZW50Q29kZXJzLmNwcDoKKyAgICAgICAgKElQ Qzo6QXJndW1lbnRDb2RlcjxDU3RyaW5nPjo6ZGVjb2RlKToKKyAgICAgICAgKiBTaGFyZWQvc291 cC9XZWJDb3JlQXJndW1lbnRDb2RlcnNTb3VwLmNwcDoKKyAgICAgICAgKElQQzo6QXJndW1lbnRD b2RlcjxDZXJ0aWZpY2F0ZUluZm8+OjpkZWNvZGUpOgorCiAyMDIxLTA5LTE0ICBGdWppaSBIaXJv bm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgogCiAgICAgICAgIEVuYWJsZSBJUENNZXNz YWdlcyBkZWJ1ZyBsb2dnaW5nIGZvciBub24tQ29jb2EgcG9ydHMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvUGxhdGZvcm0vSVBDL0FyZ3VtZW50Q29kZXJzLmNwcCBiL1NvdXJjZS9XZWJLaXQv UGxhdGZvcm0vSVBDL0FyZ3VtZW50Q29kZXJzLmNwcAppbmRleCBmNTk2YmQ3ODEwMmFmMjQwNTY3 MjI2MTM0ODkzYzJmNWI1YTFjNDYyLi5hMzIwNTUxODc5OGI3NGRjZWRiOGEwMTNmOWM5Yzk4ODVh YWU2NjE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9Bcmd1bWVudENv ZGVycy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvQXJndW1lbnRDb2RlcnMu Y3BwCkBAIC0xMjIsNyArMTIyLDcgQEAgc3RkOjpvcHRpb25hbDxDU3RyaW5nPiBBcmd1bWVudENv ZGVyPENTdHJpbmc+OjpkZWNvZGUoRGVjb2RlciYgZGVjb2RlcikKICAgICBpZiAoIWRlY29kZXIu ZGVjb2RlRml4ZWRMZW5ndGhEYXRhKHJlaW50ZXJwcmV0X2Nhc3Q8dWludDhfdCo+KGJ1ZmZlciks ICpsZW5ndGgsIDEpKQogICAgICAgICByZXR1cm4gc3RkOjpudWxsb3B0OwogCi0gICAgcmV0dXJu IFdURk1vdmUoc3RyaW5nKTsKKyAgICByZXR1cm4gc3RyaW5nOwogfQogdGVtcGxhdGUKIHN0ZDo6 b3B0aW9uYWw8Q1N0cmluZz4gQXJndW1lbnRDb2RlcjxDU3RyaW5nPjo6ZGVjb2RlPERlY29kZXI+ KERlY29kZXImKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL3NvdXAvV2ViQ29y ZUFyZ3VtZW50Q29kZXJzU291cC5jcHAgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9zb3VwL1dlYkNv cmVBcmd1bWVudENvZGVyc1NvdXAuY3BwCmluZGV4IDJlOTdkN2QyZjFmYTgyNTE1ZmU2MmMwODhj OWU2MDRiMzRhOTc0ZWMuLjA0M2IzMDg4N2YwMDgxZGY3ZjEzYTVmYjc5ZjMwYTQ4YzhhZjFmODkg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL3NvdXAvV2ViQ29yZUFyZ3VtZW50Q29k ZXJzU291cC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvc291cC9XZWJDb3JlQXJndW1l bnRDb2RlcnNTb3VwLmNwcApAQCAtODgsNyArODgsNyBAQCBzdGQ6Om9wdGlvbmFsPENlcnRpZmlj YXRlSW5mbz4gQXJndW1lbnRDb2RlcjxDZXJ0aWZpY2F0ZUluZm8+OjpkZWNvZGUoRGVjb2RlciYg ZAogICAgICAgICBjZXJ0aWZpY2F0ZUluZm8uc2V0VExTRXJyb3JzKHN0YXRpY19jYXN0PEdUbHND ZXJ0aWZpY2F0ZUZsYWdzPigqdGxzRXJyb3JzKSk7CiAgICAgfQogCi0gICAgcmV0dXJuIFdURk1v dmUoY2VydGlmaWNhdGVJbmZvKTsKKyAgICByZXR1cm4gY2VydGlmaWNhdGVJbmZvOwogfQogdGVt cGxhdGUgc3RkOjpvcHRpb25hbDxDZXJ0aWZpY2F0ZUluZm8+IEFyZ3VtZW50Q29kZXI8Q2VydGlm aWNhdGVJbmZvPjo6ZGVjb2RlPERlY29kZXI+KERlY29kZXImKTsKIHRlbXBsYXRlIHN0ZDo6b3B0 aW9uYWw8Q2VydGlmaWNhdGVJbmZvPiBBcmd1bWVudENvZGVyPENlcnRpZmljYXRlSW5mbz46OmRl Y29kZTxXZWJLaXQ6OlBDTTo6RGVjb2Rlcj4oV2ViS2l0OjpQQ006OkRlY29kZXImKTsK