230275 2021-09-14 13:46:31 -0700 [Win] JSRemoteInspector.h missing stdint include 2021-09-14 15:10:16 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ross.kirsling ross.kirsling don.olmstead ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1793417 0 ross.kirsling 2021-09-14 13:46:31 -0700 [WinCairo] Add missing include for testapi 1793418 1 438163 ross.kirsling 2021-09-14 13:46:49 -0700 Created attachment 438163 Patch 1793421 2 438163 don.olmstead 2021-09-14 13:52:54 -0700 Comment on attachment 438163 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438163&action=review r=me with nits. > Source/JavaScriptCore/ChangeLog:3 > + [WinCairo] Add missing include for testapi I would have this be [Win] JSRemoteInspector.h missing stdint include At one point we found it with testapi but the actual reason is were missing a definition for uint8_t when including JSRemoteInspector.h on its own. > Source/JavaScriptCore/ChangeLog:7 > + Reason is basically "Include stdint for uint8_t definition on Windows" 1793423 3 438166 ross.kirsling 2021-09-14 13:54:53 -0700 Created attachment 438166 Patch 1793457 4 ews-feeder 2021-09-14 15:09:26 -0700 Committed r282413 (241672@main): <https://commits.webkit.org/241672@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438166. 1793458 5 webkit-bug-importer 2021-09-14 15:10:16 -0700 <rdar://problem/83118735> 438163 2021-09-14 13:46:49 -0700 2021-09-14 13:54:51 -0700 Patch bug-230275-20210914134648.patch text/plain 1138 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyNDA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 YWM0Mzg3MGQwNDEzOTkyYjAzODdiYjYzNjVkYmU3MjAyYTgzZDgzLi4yN2E5Y2EwZDVlNTI2NDdk MjhjMDRjOWY4OTE3MzI5N2Y0MzZmMDg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAyMS0wOS0xNCAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u eS5jb20+CisKKyAgICAgICAgW1dpbkNhaXJvXSBBZGQgbWlzc2luZyBpbmNsdWRlIGZvciB0ZXN0 YXBpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzAy NzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEFQ SS9KU1JlbW90ZUluc3BlY3Rvci5oOgorCiAyMDIxLTA5LTE0ICBYYW4gTG9wZXogIDx4YW5AaWdh bGlhLmNvbT4KIAogICAgICAgICBbSlNDXSBSZW1vdmUgdW5uZWNlc3NhcnkgZXhjZXB0aW9uIGNo ZWNrcyBpbiBERkdPcGVyYXRpb25zCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv QVBJL0pTUmVtb3RlSW5zcGVjdG9yLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTUmVt b3RlSW5zcGVjdG9yLmgKaW5kZXggODU3NjhlNGQ2NTc3ODFiZTRhNzgwN2U1YWE4ZDQwNGE0NzMy ODBkYi4uMDBjYTI4ZDhmZjQ0ZGIzYWIzZDI5MDY0YTU4MzllOTVjYWEwODQ5NCAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU1JlbW90ZUluc3BlY3Rvci5oCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNSZW1vdGVJbnNwZWN0b3IuaApAQCAtMzAsNiArMzAs NyBAQAogI2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL1dlYktpdEF2YWlsYWJpbGl0eS5oPgogCiAj aWYgZGVmaW5lZChXSU4zMikgfHwgZGVmaW5lZChfV0lOMzIpCisjaW5jbHVkZSA8c3RkaW50Lmg+ CiB0eXBlZGVmIGludCBKU1Byb2Nlc3NJRDsKICNlbHNlCiAjaW5jbHVkZSA8dW5pc3RkLmg+Cg== 438166 2021-09-14 13:54:53 -0700 2021-09-14 15:09:27 -0700 Patch bug-230275-20210914135452.patch text/plain 1201 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyNDA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 YWM0Mzg3MGQwNDEzOTkyYjAzODdiYjYzNjVkYmU3MjAyYTgzZDgzLi43NDc4NzRiMDY0ODM5MjU0 NDA1MjQ5YzIwNzZlYzA5YzA0ZGU3NzVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAyMS0wOS0xNCAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u eS5jb20+CisKKyAgICAgICAgW1dpbl0gSlNSZW1vdGVJbnNwZWN0b3IuaCBtaXNzaW5nIHN0ZGlu dCBpbmNsdWRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMzAyNzUKKworICAgICAgICBSZXZpZXdlZCBieSBEb24gT2xtc3RlYWQuCisKKyAgICAgICAg KiBBUEkvSlNSZW1vdGVJbnNwZWN0b3IuaDoKKyAgICAgICAgSW5jbHVkZSBzdGRpbnQgZm9yIHVp bnQ4X3QgZGVmaW5pdGlvbiBvbiBXaW5kb3dzLgorCiAyMDIxLTA5LTE0ICBYYW4gTG9wZXogIDx4 YW5AaWdhbGlhLmNvbT4KIAogICAgICAgICBbSlNDXSBSZW1vdmUgdW5uZWNlc3NhcnkgZXhjZXB0 aW9uIGNoZWNrcyBpbiBERkdPcGVyYXRpb25zCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQVBJL0pTUmVtb3RlSW5zcGVjdG9yLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJ L0pTUmVtb3RlSW5zcGVjdG9yLmgKaW5kZXggODU3NjhlNGQ2NTc3ODFiZTRhNzgwN2U1YWE4ZDQw NGE0NzMyODBkYi4uMDBjYTI4ZDhmZjQ0ZGIzYWIzZDI5MDY0YTU4MzllOTVjYWEwODQ5NCAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU1JlbW90ZUluc3BlY3Rvci5oCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNSZW1vdGVJbnNwZWN0b3IuaApAQCAtMzAs NiArMzAsNyBAQAogI2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL1dlYktpdEF2YWlsYWJpbGl0eS5o PgogCiAjaWYgZGVmaW5lZChXSU4zMikgfHwgZGVmaW5lZChfV0lOMzIpCisjaW5jbHVkZSA8c3Rk aW50Lmg+CiB0eXBlZGVmIGludCBKU1Byb2Nlc3NJRDsKICNlbHNlCiAjaW5jbHVkZSA8dW5pc3Rk Lmg+Cg==