230218 2021-09-13 07:17:32 -0700 [JSC] run-javascriptcore-tests script fails on linux 2021-09-21 07:54:47 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P4 Trivial --- 1 pmates webkit-unassigned angelos ews-watchlist jbedard webkit-bug-importer oldest_to_newest 1792941 0 438038 pmates 2021-09-13 07:17:32 -0700 Created attachment 438038 fix for the bug When I run ``` $ Tools/Scripts/run-javascriptcore-tests --jsc-only --debug ``` I see one warning: ``` Can't exec "xcodebuild": No such file or directory at /home/mates/igalia/WebKit/Tools/Scripts/webkitdirs.pm line 634. ``` and one error: ``` Unrecognized option `--64-bit' ``` adding `--no-build` allows me to run the tests, so it seems that `run-javascriptcore-tests`, has issues when dispatching to the `build-jsc` command. Attached is a fix for this issue though keep in mind that I'm very new to the build tooling. I also removed the `determineIsWin64FromArchitecture` function, which is unused as far as I can tell from grepping the codebase and right below some code other code I changed in the patch 1792945 1 438038 jbedard 2021-09-13 07:31:04 -0700 Comment on attachment 438038 fix for the bug View in context: https://bugs.webkit.org/attachment.cgi?id=438038&action=review > Tools/Scripts/webkitdirs.pm:-1483 > - $isWin64 = checkForArgumentAndRemoveFromARGV("--64-bit") || ((isAnyWindows() || isJSCOnly()) && !shouldBuild32Bit()); I notice we're stripping the isJSCOnly() call, is that required? 1792946 2 pmates 2021-09-13 07:38:36 -0700 (In reply to Jonathan Bedard from comment #1) > Comment on attachment 438038 [details] > fix for the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=438038&action=review > > > Tools/Scripts/webkitdirs.pm:-1483 > > - $isWin64 = checkForArgumentAndRemoveFromARGV("--64-bit") || ((isAnyWindows() || isJSCOnly()) && !shouldBuild32Bit()); > > I notice we're stripping the isJSCOnly() call, is that required? I think so, given that we want the whole condition to be `false` to exclude the problematic `--64-bit` flag. In this context `!shouldBuild32Bit()` is `true` and `isAnyWindows()` is `false` so we'd need `isJSCOnly()` to be `false` to exclude the `--64-bit` flag, but it is `true`; hence I just dropped it. Dropping it might be the wrong way to resolve this, wasn't totally sure. 1795066 3 webkit-bug-importer 2021-09-20 07:18:16 -0700 <rdar://problem/83305636> 1795470 4 pmates 2021-09-21 01:49:04 -0700 Hi jbedard, could you also set cq+ when you have the chance? thanks! 1795471 5 ews-feeder 2021-09-21 01:55:44 -0700 Unable to find any modified ChangeLog in Attachment 438038 1795475 6 438038 pmates 2021-09-21 02:11:10 -0700 Comment on attachment 438038 fix for the bug diff --git a/Tools/ChangeLog b/Tools/ChangeLog index 675f6cdf35a6..215167b3fb5b 100644 --- a/Tools/ChangeLog +++ b/Tools/ChangeLog @@ -1,3 +1,24 @@ +2021-09-21 Phillip Mates <pmates@igalia.com> + + Fix JSC test runner warnings and errors on linux + https://bugs.webkit.org/show_bug.cgi?id=230218 + + Reviewed by Jonathan Bedard. + + Fixed the following warning that arises in many scripts when they are + run on Linux: + `Can't exec "xcodebuild": No such file or directory at + /home/mates/igalia/WebKit/Tools/Scripts/webkitdirs.pm line 634.` + + Fixed `run-javascriptcore-tests` on Linux, which was failing to invoke + builds before running the test suite with the error: + `Unrecognized option `--64-bit'` + + * Scripts/webkitdirs.pm: + (XcodeOptions): + (determineIsWin64): + (determineIsWin64FromArchitecture): Deleted. + 2021-09-20 Chris Dumez <cdumez@apple.com> Reduce use of makeRefPtr() and use RefPtr { } directly diff --git a/Tools/Scripts/webkitdirs.pm b/Tools/Scripts/webkitdirs.pm index a56fe7ecb944..eb61a3ec298b 100755 --- a/Tools/Scripts/webkitdirs.pm +++ b/Tools/Scripts/webkitdirs.pm @@ -1008,7 +1008,9 @@ sub XcodeOptions determineForceOptimizationLevel(); determineCoverageIsEnabled(); determineLTOMode(); - determineXcodeSDK(); + if (isAppleCocoaWebKit()) { + determineXcodeSDK(); + } my @options; push @options, "-UseSanitizedBuildSystemEnvironment=YES"; @@ -1480,14 +1482,7 @@ sub isWin64() sub determineIsWin64() { return if defined($isWin64); - $isWin64 = checkForArgumentAndRemoveFromARGV("--64-bit") || ((isAnyWindows() || isJSCOnly()) && !shouldBuild32Bit()); -} - -sub determineIsWin64FromArchitecture($) -{ - my $arch = shift; - $isWin64 = ($arch eq "x86_64"); - return $isWin64; + $isWin64 = checkForArgumentAndRemoveFromARGV("--64-bit") || (isAnyWindows() && !shouldBuild32Bit()); } sub isCygwin() 1795476 7 ews-feeder 2021-09-21 02:11:25 -0700 pmates@igalia.com does not have committer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json. Rejecting attachment 438038 from commit queue. 1795478 8 438796 pmates 2021-09-21 02:15:06 -0700 Created attachment 438796 Patch 1795481 9 438796 pmates 2021-09-21 02:21:41 -0700 Comment on attachment 438796 Patch sorry for the noise on this patch. I feel like a bull in a china shop when it comes to navigating this interface 1795543 10 ews-feeder 2021-09-21 07:54:45 -0700 Committed r282815 (241946@main): <https://commits.webkit.org/241946@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438796. 438038 2021-09-13 07:17:32 -0700 2021-09-21 02:15:00 -0700 fix for the bug patch text/plain 974 pmates ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbSBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0ZGlycy5wbQppbmRleCBhNTZmZTdlY2I5NDQuLmViNjFhM2VjMjk4YiAxMDA3NTUKLS0t IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 ZGlycy5wbQpAQCAtMTAwOCw3ICsxMDA4LDkgQEAgc3ViIFhjb2RlT3B0aW9ucwogICAgIGRldGVy bWluZUZvcmNlT3B0aW1pemF0aW9uTGV2ZWwoKTsKICAgICBkZXRlcm1pbmVDb3ZlcmFnZUlzRW5h YmxlZCgpOwogICAgIGRldGVybWluZUxUT01vZGUoKTsKLSAgICBkZXRlcm1pbmVYY29kZVNESygp OworICAgIGlmIChpc0FwcGxlQ29jb2FXZWJLaXQoKSkgeworICAgICAgZGV0ZXJtaW5lWGNvZGVT REsoKTsKKyAgICB9CiAKICAgICBteSBAb3B0aW9uczsKICAgICBwdXNoIEBvcHRpb25zLCAiLVVz ZVNhbml0aXplZEJ1aWxkU3lzdGVtRW52aXJvbm1lbnQ9WUVTIjsKQEAgLTE0ODAsMTQgKzE0ODIs NyBAQCBzdWIgaXNXaW42NCgpCiBzdWIgZGV0ZXJtaW5lSXNXaW42NCgpCiB7CiAgICAgcmV0dXJu IGlmIGRlZmluZWQoJGlzV2luNjQpOwotICAgICRpc1dpbjY0ID0gY2hlY2tGb3JBcmd1bWVudEFu ZFJlbW92ZUZyb21BUkdWKCItLTY0LWJpdCIpIHx8ICgoaXNBbnlXaW5kb3dzKCkgfHwgaXNKU0NP bmx5KCkpICYmICFzaG91bGRCdWlsZDMyQml0KCkpOwotfQotCi1zdWIgZGV0ZXJtaW5lSXNXaW42 NEZyb21BcmNoaXRlY3R1cmUoJCkKLXsKLSAgICBteSAkYXJjaCA9IHNoaWZ0OwotICAgICRpc1dp bjY0ID0gKCRhcmNoIGVxICJ4ODZfNjQiKTsKLSAgICByZXR1cm4gJGlzV2luNjQ7CisgICAgJGlz V2luNjQgPSBjaGVja0ZvckFyZ3VtZW50QW5kUmVtb3ZlRnJvbUFSR1YoIi0tNjQtYml0IikgfHwg KGlzQW55V2luZG93cygpICYmICFzaG91bGRCdWlsZDMyQml0KCkpOwogfQogCiBzdWIgaXNDeWd3 aW4oKQo= 438796 2021-09-21 02:15:06 -0700 2021-09-21 07:54:46 -0700 Patch bug-230218-20210921111504.patch text/plain 2151 pmates U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyODA2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjc1ZjZjZGYzNWE2NTU5NzUyYjFhYTAzZjhiMmFjZWQz NzVjZGE5ZC4uMjE1MTY3YjNmYjViZGMyMjBlY2JiNjg4NjE1NjEwZTc2ZTExY2MyMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDIxLTA5LTIxICBQaGlsbGlwIE1hdGVzICA8cG1hdGVzQGlnYWxpYS5jb20+CisKKyAg ICAgICAgRml4IEpTQyB0ZXN0IHJ1bm5lciB3YXJuaW5ncyBhbmQgZXJyb3JzIG9uIGxpbnV4Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzAyMTgKKwor ICAgICAgICBSZXZpZXdlZCBieSBKb25hdGhhbiBCZWRhcmQuCisKKyAgICAgICAgRml4ZWQgdGhl IGZvbGxvd2luZyB3YXJuaW5nIHRoYXQgYXJpc2VzIGluIG1hbnkgc2NyaXB0cyB3aGVuIHRoZXkg YXJlCisgICAgICAgIHJ1biBvbiBMaW51eDoKKyAgICAgICAgYENhbid0IGV4ZWMgInhjb2RlYnVp bGQiOiBObyBzdWNoIGZpbGUgb3IgZGlyZWN0b3J5IGF0CisgICAgICAgIC9ob21lL21hdGVzL2ln YWxpYS9XZWJLaXQvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGxpbmUgNjM0LmAKKworICAg ICAgICBGaXhlZCBgcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzYCBvbiBMaW51eCwgd2hpY2ggd2Fz IGZhaWxpbmcgdG8gaW52b2tlCisgICAgICAgIGJ1aWxkcyBiZWZvcmUgcnVubmluZyB0aGUgdGVz dCBzdWl0ZSB3aXRoIHRoZSBlcnJvcjoKKyAgICAgICAgYFVucmVjb2duaXplZCBvcHRpb24gYC0t NjQtYml0J2AKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKFhj b2RlT3B0aW9ucyk6CisgICAgICAgIChkZXRlcm1pbmVJc1dpbjY0KToKKyAgICAgICAgKGRldGVy bWluZUlzV2luNjRGcm9tQXJjaGl0ZWN0dXJlKTogRGVsZXRlZC4KKwogMjAyMS0wOS0yMCAgQ2hy aXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFJlZHVjZSB1c2Ugb2YgbWFr ZVJlZlB0cigpIGFuZCB1c2UgUmVmUHRyIHsgfSBkaXJlY3RseQpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4 IGE1NmZlN2VjYjk0NDRjMjJkNjcyOTQwNzMyZTkwM2JmNGRkNDI1NjguLmViNjFhM2VjMjk4YjJi NTYwZjM5YmEyOWRjODM3MzQ5MGRmZmQ2ZTggMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTEwMDgsNyAr MTAwOCw5IEBAIHN1YiBYY29kZU9wdGlvbnMKICAgICBkZXRlcm1pbmVGb3JjZU9wdGltaXphdGlv bkxldmVsKCk7CiAgICAgZGV0ZXJtaW5lQ292ZXJhZ2VJc0VuYWJsZWQoKTsKICAgICBkZXRlcm1p bmVMVE9Nb2RlKCk7Ci0gICAgZGV0ZXJtaW5lWGNvZGVTREsoKTsKKyAgICBpZiAoaXNBcHBsZUNv Y29hV2ViS2l0KCkpIHsKKyAgICAgIGRldGVybWluZVhjb2RlU0RLKCk7CisgICAgfQogCiAgICAg bXkgQG9wdGlvbnM7CiAgICAgcHVzaCBAb3B0aW9ucywgIi1Vc2VTYW5pdGl6ZWRCdWlsZFN5c3Rl bUVudmlyb25tZW50PVlFUyI7CkBAIC0xNDgwLDE0ICsxNDgyLDcgQEAgc3ViIGlzV2luNjQoKQog c3ViIGRldGVybWluZUlzV2luNjQoKQogewogICAgIHJldHVybiBpZiBkZWZpbmVkKCRpc1dpbjY0 KTsKLSAgICAkaXNXaW42NCA9IGNoZWNrRm9yQXJndW1lbnRBbmRSZW1vdmVGcm9tQVJHVigiLS02 NC1iaXQiKSB8fCAoKGlzQW55V2luZG93cygpIHx8IGlzSlNDT25seSgpKSAmJiAhc2hvdWxkQnVp bGQzMkJpdCgpKTsKLX0KLQotc3ViIGRldGVybWluZUlzV2luNjRGcm9tQXJjaGl0ZWN0dXJlKCQp Ci17Ci0gICAgbXkgJGFyY2ggPSBzaGlmdDsKLSAgICAkaXNXaW42NCA9ICgkYXJjaCBlcSAieDg2 XzY0Iik7Ci0gICAgcmV0dXJuICRpc1dpbjY0OworICAgICRpc1dpbjY0ID0gY2hlY2tGb3JBcmd1 bWVudEFuZFJlbW92ZUZyb21BUkdWKCItLTY0LWJpdCIpIHx8IChpc0FueVdpbmRvd3MoKSAmJiAh c2hvdWxkQnVpbGQzMkJpdCgpKTsKIH0KIAogc3ViIGlzQ3lnd2luKCkK