230214 2021-09-13 05:26:52 -0700 REGRESSION(r274929): [CoordinatedGraphics] DrawingAreaCoordinatedGraphics::createDisplayRefreshMonitor is no longer used 2021-11-04 22:31:31 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=223648 https://bugs.webkit.org/show_bug.cgi?id=230333 https://bugs.webkit.org/show_bug.cgi?id=230307 https://bugs.webkit.org/show_bug.cgi?id=232745 Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned aperez bugs-noreply cdumez clopez crzwdjk simon.fraser oldest_to_newest 1792926 0 cgarcia 2021-09-13 05:26:52 -0700 That means we use the right display refresh monitor in the threaded compositor but a different one for rendering update scheduler. 1792928 1 438032 cgarcia 2021-09-13 05:31:05 -0700 Created attachment 438032 Patch 1793240 2 cgarcia 2021-09-14 02:32:36 -0700 Committed r282383 (241645@main): <https://commits.webkit.org/241645@main> 1793317 3 crzwdjk 2021-09-14 08:51:07 -0700 This regressed animations/steps-transform-rendering-updates.html: --- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/animations/steps-transform-rendering-updates-expected.txt +++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/animations/steps-transform-rendering-updates-actual.txt @@ -1,5 +1,5 @@ PASS count is 0 -PASS count < 6 is true +FAIL count < 6 should be true. Was false. PASS successfullyParsed is true TEST COMPLETE 1793690 4 crzwdjk 2021-09-15 06:57:45 -0700 I opened bug 230307 for the test failure which was apparently not so much caused by this change as unmasked by it. 1793938 5 clopez 2021-09-15 19:35:37 -0700 See also bug 230333 .. seems this may have caused flaky timeouts triggering the test run to stop early (it stops at 50 timeouts/crashes) 438032 2021-09-13 05:31:05 -0700 2021-09-13 06:09:38 -0700 Patch wk2-drawing-area-display-refresh-monitor-factory.diff text/plain 1692 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNjBjODg3YzRhMDU1Li5hODQ3OTU4NDMzZTYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTggQEAKKzIwMjEtMDktMTMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjI3NDkyOSk6IFtDb29yZGluYXRlZEdyYXBo aWNzXSBEcmF3aW5nQXJlYUNvb3JkaW5hdGVkR3JhcGhpY3M6OmNyZWF0ZURpc3BsYXlSZWZyZXNo TW9uaXRvciBpcyBubyBsb25nZXIgdXNlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjMwMjE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhhdCBtZWFucyB3ZSB1c2UgdGhlIHJpZ2h0IGRpc3BsYXkgcmVm cmVzaCBtb25pdG9yIGluIHRoZSB0aHJlYWRlZCBjb21wb3NpdG9yIGJ1dCBhIGRpZmZlcmVudCBv bmUgZm9yIHJlbmRlcmluZworICAgICAgICB1cGRhdGUgc2NoZWR1bGVyLgorCisgICAgICAgICog V2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQuY3BwOgorICAgICAgICAo V2ViS2l0OjpXZWJDaHJvbWVDbGllbnQ6OmRpc3BsYXlSZWZyZXNoTW9uaXRvckZhY3RvcnkgY29u c3QpOiBSZW1vdmUgcGxhdGZvcm0gaWZkZWYsIERyYXdpbmdBcmVhCisgICAgICAgIHVuY29uZGl0 aW9uYWxseSBpbmhlcml0cyBmcm9tIERpc3BsYXlSZWZyZXNoTW9uaXRvckZhY3RvcnkgYW5kIHRo ZSBkZWZhdWx0IGltcGxlbWVudGF0aW9uIG9mCisgICAgICAgIGNyZWF0ZURpc3BsYXlSZWZyZXNo TW9uaXRvcigpIHJldHVybnMgbnVsbHB0ci4KKwogMjAyMS0wOS0xMiAgTXlsZXMgQy4gTWF4Zmll bGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gRHJhd2luZyB0aGUg cm91bmRlZCBzeXN0ZW0gdWkgZm9udCBpbnRvIGNhbnZhcyBjYXVzZXMgYSBjcmFzaApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkNocm9tZUNs aWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViQ2hy b21lQ2xpZW50LmNwcAppbmRleCA3ZDM0ZWUxOWUwMTcuLmQ1Mzg3YTBmMDhmNSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkNocm9tZUNsaWVu dC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkNo cm9tZUNsaWVudC5jcHAKQEAgLTkyMywxMSArOTIzLDcgQEAgR3JhcGhpY3NMYXllckZhY3Rvcnkq IFdlYkNocm9tZUNsaWVudDo6Z3JhcGhpY3NMYXllckZhY3RvcnkoKSBjb25zdAogCiBXZWJDb3Jl OjpEaXNwbGF5UmVmcmVzaE1vbml0b3JGYWN0b3J5KiBXZWJDaHJvbWVDbGllbnQ6OmRpc3BsYXlS ZWZyZXNoTW9uaXRvckZhY3RvcnkoKSBjb25zdAogewotI2lmIFBMQVRGT1JNKENPQ09BKQogICAg IHJldHVybiBtX3BhZ2UuZHJhd2luZ0FyZWEoKTsKLSNlbHNlCi0gICAgcmV0dXJuIG51bGxwdHI7 Ci0jZW5kaWYKIH0KIAogI2lmIEVOQUJMRShHUFVfUFJPQ0VTUykK