230208 2021-09-12 21:26:30 -0700 REGRESSION(r282278): ASSERTION FAILED: !m_needExceptionCheck in JSC::VM::verifyExceptionCheckNeedIsSatisfied 2021-09-13 13:22:21 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=230207 InRadar P2 Normal --- 230146 1 fujii fujii webkit-bug-importer youennf oldest_to_newest 1792848 0 fujii 2021-09-12 21:26:30 -0700 REGRESSION(r282278): ASSERTION FAILED: !m_needExceptionCheck in JSC::VM::verifyExceptionCheckNeedIsSatisfied r282278 (Bug 230146) introduced a new assertion failure for WinCairo Debug WK2 test. Regressions: Unexpected crashes (1) js/dom/transform-stream.html [ Crash ] ERROR: 00000220F35B8AE0 - ResourceLoadStatisticsDatabaseStore::turnOnIncrementalAutoVacuum failed, error message: not an error C:\home\webkit\gc\Source\WebKit\NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp(315) : WebKit::ResourceLoadStatisticsDatabaseStore::ResourceLoadStatisticsDatabaseStore ERROR: Unchecked JS exception: This scope can throw a JS exception: JSC::JSObject::get @ C:\home\webkit\gc\WebKitBuild\Debug\JavaScriptCore\PrivateHeaders\JavaScriptCore\JSObject.h:1504 (ExceptionScope::m_recursionDepth was 13) But the exception was unchecked as of this scope: WebCore::invokeWritableStreamFunction @ C:\home\webkit\gc\Source\WebCore\bindings/js/InternalWritableStream.cpp:42 (ExceptionScope::m_recursionDepth was 13) Unchecked exception detected at: 1 00007FFC0D8A464F JSC::VM::verifyExceptionCheckNeedIsSatisfied 2 00007FFC0D878924 JSC::ThrowScope::ThrowScope 3 00007FFBEE14D4EB WebCore::invokeWritableStreamFunction 4 00007FFBEE14C6E1 WebCore::InternalWritableStream::create 5 00007FFBEDF0733C WebCore::WritableStream::create 6 00007FFBEDF07207 WebCore::WritableStream::create 7 00007FFBEDAF98B6 WebCore::JSDOMConstructor<WebCore::JSWritableStream>::construct 8 00007FFC0D05BB6F JSC::NativeFunction::operator() 9 00007FFC0D05BBBC JSC::TaggedNativeFunction::operator() 10 00007FFC0D0F567B JSC::LLInt::handleHostCall 11 00007FFC0D10BC4A JSC::LLInt::setUpCall 12 00007FFC0D1016D6 JSC::LLInt::genericCall<JSC::OpConstruct> 13 00007FFC0D0EDBAF llint_slow_path_construct 14 00007FFC0C02C4C6 llint_entry ASSERTION FAILED: !m_needExceptionCheck C:\home\webkit\gc\Source\JavaScriptCore\runtime/VM.cpp(1490) : JSC::VM::verifyExceptionCheckNeedIsSatisfied 1 00007FFC0A1F1DEB WTFCrash 2 00007FFC0C02FFBE WTFCrashWithInfo 3 00007FFC0D8A4790 JSC::VM::verifyExceptionCheckNeedIsSatisfied 4 00007FFC0D878924 JSC::ThrowScope::ThrowScope 5 00007FFBEE14D4EB WebCore::invokeWritableStreamFunction 6 00007FFBEE14C6E1 WebCore::InternalWritableStream::create 7 00007FFBEDF0733C WebCore::WritableStream::create 8 00007FFBEDF07207 WebCore::WritableStream::create 9 00007FFBEDAF98B6 WebCore::JSDOMConstructor<WebCore::JSWritableStream>::construct 10 00007FFC0D05BB6F JSC::NativeFunction::operator() 11 00007FFC0D05BBBC JSC::TaggedNativeFunction::operator() 12 00007FFC0D0F567B JSC::LLInt::handleHostCall 13 00007FFC0D10BC4A JSC::LLInt::setUpCall 14 00007FFC0D1016D6 JSC::LLInt::genericCall<JSC::OpConstruct> 15 00007FFC0D0EDBAF llint_slow_path_construct 16 00007FFC0C02C4C6 llint_entry 1792870 1 438019 fujii 2021-09-13 00:55:45 -0700 Created attachment 438019 Patch 1792873 2 fujii 2021-09-13 01:00:31 -0700 This is not WinCairo specific issue. Other bug (Bug 230207) seems to hide this. Fixing Bug 230207 reveals this for Mac port. 1792889 3 438019 youennf 2021-09-13 01:59:14 -0700 Comment on attachment 438019 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438019&action=review > Source/WebCore/bindings/js/InternalWritableStream.cpp:47 > auto result = call(&globalObject, function, callData, JSC::jsUndefined(), arguments); Can we also change the if(UNLIKELY(...) return Exception... with: RETURN_IF_EXCEPTION(scope, Exception { ExistingExceptionError }); This is more inline with other parts of the codebase. 1793051 4 438066 fujii 2021-09-13 12:52:54 -0700 Created attachment 438066 Patch for landing 1793059 5 438066 fujii 2021-09-13 13:21:45 -0700 Comment on attachment 438066 Patch for landing Clearing flags on attachment: 438066 Committed r282351 (241617@main): <https://commits.webkit.org/241617@main> 1793060 6 fujii 2021-09-13 13:21:49 -0700 All reviewed patches have been landed. Closing bug. 1793061 7 webkit-bug-importer 2021-09-13 13:22:21 -0700 <rdar://problem/83069483> 438019 2021-09-13 00:55:45 -0700 2021-09-13 12:52:45 -0700 Patch bug-230208-20210913165543.patch text/plain 2069 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyMzIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzA4YzA2ZGQ4NzllYzU4 YTg1YTBlYmM1ZjlhOWIyMzJhM2I4MjEzNi4uZjAxNGZkMjYxYTI0Mjg1NzU2YTljZDViZjY1NDZm ODY4ZTA0M2I3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIxLTA5LTEzICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFJFR1JFU1NJ T04ocjI4MjI3OCk6IEFTU0VSVElPTiBGQUlMRUQ6ICFtX25lZWRFeGNlcHRpb25DaGVjayBpbiBK U0M6OlZNOjp2ZXJpZnlFeGNlcHRpb25DaGVja05lZWRJc1NhdGlzZmllZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMwMjA4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcjI4MjI3OCBpbnRyb2R1Y2VkIGEg bmV3IGFzc2VydGlvbiBmYWlsdXJlIGZvcgorICAgICAgICBqcy9kb20vdHJhbnNmb3JtLXN0cmVh bS5odG1sIGluIFdpbkNhaXJvIERlYnVnIFdLMi4KKworICAgICAgICBKU09iamVjdDo6Z2V0IHRo cm93cyBhbiBzaW11bGF0ZWQgZXhjZXB0aW9uLiBERUNMQVJFX1RIUk9XX1NDT1BFCisgICAgICAg IGZhaWxlZCB0aGUgYXNzZXJ0aW9uIGFmdGVyIHRoYXQuCisKKyAgICAgICAgKiBiaW5kaW5ncy9q cy9JbnRlcm5hbFdyaXRhYmxlU3RyZWFtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Omludm9rZVdy aXRhYmxlU3RyZWFtRnVuY3Rpb24pOiBSZW1vdmVkCisgICAgICAgIERFQ0xBUkVfVEhST1dfU0NP UEUgYmVjYXVzZSB0aGlzIGZ1bmN0aW9uIGRvZXNuJ3QgdGhyb3cuIEFkZGVkCisgICAgICAgIERF Q0xBUkVfQ0FUQ0hfU0NPUEUgdG8gdXNlIGFzc2VydE5vRXhjZXB0aW9uRXhjZXB0VGVybWluYXRp b24KKyAgICAgICAgYWZ0ZXIgSlNPYmplY3Q6OmdldC4KKwogMjAyMS0wOS0xMiAgQWxhbiBCdWp0 YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bSUZDXSBBZGQgc2Nyb2xsYWJs ZSBvdmVyZmxvdyB0byBMaW5lR2VvbWV0cnkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL2pzL0ludGVybmFsV3JpdGFibGVTdHJlYW0uY3BwIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvanMvSW50ZXJuYWxXcml0YWJsZVN0cmVhbS5jcHAKaW5kZXggYzBhYTZhZjhkZDEzNmQ1 ZDhjYjdkYjdhZjgwYjRiZTdlMzcxNDlmMy4uMjc5OTk2NTM5NGZiMTQ0ODNlZWYxMmE5ZmEyY2E1 MDM0MzU2ZTJjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSW50ZXJu YWxXcml0YWJsZVN0cmVhbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSW50 ZXJuYWxXcml0YWJsZVN0cmVhbS5jcHAKQEAgLTM2LDEwICszNiwxMiBAQCBzdGF0aWMgRXhjZXB0 aW9uT3I8SlNDOjpKU1ZhbHVlPiBpbnZva2VXcml0YWJsZVN0cmVhbUZ1bmN0aW9uKEpTQzo6SlNH bG9iYWxPYmplYwogICAgIEpTQzo6Vk0mIHZtID0gZ2xvYmFsT2JqZWN0LnZtKCk7CiAgICAgSlND OjpKU0xvY2tIb2xkZXIgbG9jayh2bSk7CiAKKyAgICBhdXRvIHNjb3BlID0gREVDTEFSRV9DQVRD SF9TQ09QRSh2bSk7CisKICAgICBhdXRvIGZ1bmN0aW9uID0gZ2xvYmFsT2JqZWN0LmdldCgmZ2xv YmFsT2JqZWN0LCBpZGVudGlmaWVyKTsKICAgICBBU1NFUlQoZnVuY3Rpb24uaXNDYWxsYWJsZSh2 bSkpOworICAgIHNjb3BlLmFzc2VydE5vRXhjZXB0aW9uRXhjZXB0VGVybWluYXRpb24oKTsKIAot ICAgIGF1dG8gc2NvcGUgPSBERUNMQVJFX1RIUk9XX1NDT1BFKHZtKTsKICAgICBhdXRvIGNhbGxE YXRhID0gSlNDOjpnZXRDYWxsRGF0YSh2bSwgZnVuY3Rpb24pOwogCiAgICAgYXV0byByZXN1bHQg PSBjYWxsKCZnbG9iYWxPYmplY3QsIGZ1bmN0aW9uLCBjYWxsRGF0YSwgSlNDOjpqc1VuZGVmaW5l ZCgpLCBhcmd1bWVudHMpOwo= 438066 2021-09-13 12:52:54 -0700 2021-09-13 12:52:54 -0700 Patch for landing bug-230208-20210914045253.patch text/plain 2277 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyMzQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzYwMmM2MDU3Y2NjNThi YTE4OWVkNjY1YThmYzQ4YjE5Y2U0OTFjYS4uZmM5MjFkMTRkYmQzMWQyNzliZjBmOGYxMzNlMmFm NDU1MjIzNjBiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIxLTA5LTEzICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFJFR1JFU1NJ T04ocjI4MjI3OCk6IEFTU0VSVElPTiBGQUlMRUQ6ICFtX25lZWRFeGNlcHRpb25DaGVjayBpbiBK U0M6OlZNOjp2ZXJpZnlFeGNlcHRpb25DaGVja05lZWRJc1NhdGlzZmllZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMwMjA4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgWW91ZW5uIEZhYmxldC4KKworICAgICAgICByMjgyMjc4IGludHJvZHVjZWQgYSBu ZXcgYXNzZXJ0aW9uIGZhaWx1cmUgZm9yCisgICAgICAgIGpzL2RvbS90cmFuc2Zvcm0tc3RyZWFt Lmh0bWwgaW4gV2luQ2Fpcm8gRGVidWcgV0syLgorCisgICAgICAgIEpTT2JqZWN0OjpnZXQgdGhy b3dzIGFuIHNpbXVsYXRlZCBleGNlcHRpb24uIERFQ0xBUkVfVEhST1dfU0NPUEUKKyAgICAgICAg ZmFpbGVkIHRoZSBhc3NlcnRpb24gYWZ0ZXIgdGhhdC4KKworICAgICAgICAqIGJpbmRpbmdzL2pz L0ludGVybmFsV3JpdGFibGVTdHJlYW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6aW52b2tlV3Jp dGFibGVTdHJlYW1GdW5jdGlvbik6IFJlbW92ZWQKKyAgICAgICAgREVDTEFSRV9USFJPV19TQ09Q RSBiZWNhdXNlIHRoaXMgZnVuY3Rpb24gZG9lc24ndCB0aHJvdy4gQWRkZWQKKyAgICAgICAgREVD TEFSRV9DQVRDSF9TQ09QRSB0byB1c2UgYXNzZXJ0Tm9FeGNlcHRpb25FeGNlcHRUZXJtaW5hdGlv bgorICAgICAgICBhZnRlciBKU09iamVjdDo6Z2V0LgorCiAyMDIxLTA5LTEzICBBbGFuIEJ1anRh cyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtJRkNdIERvIG5vdCBwYXNzIGlu IHRoZSBJbnZhbGlkYXRpb25TdGF0ZSB0byB0aGUgbGF5b3V0IGZ1bmN0aW9ucwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSW50ZXJuYWxXcml0YWJsZVN0cmVhbS5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9JbnRlcm5hbFdyaXRhYmxlU3RyZWFtLmNwcApp bmRleCBjMGFhNmFmOGRkMTM2ZDVkOGNiN2RiN2FmODBiNGJlN2UzNzE0OWYzLi5mNGY5YmZkZWIx MzZlZTZlODUzN2FlZTcxNzM0NTc4NGYxNDUyZGVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9qcy9JbnRlcm5hbFdyaXRhYmxlU3RyZWFtLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9qcy9JbnRlcm5hbFdyaXRhYmxlU3RyZWFtLmNwcApAQCAtMzYsMTUgKzM2 LDE2IEBAIHN0YXRpYyBFeGNlcHRpb25PcjxKU0M6OkpTVmFsdWU+IGludm9rZVdyaXRhYmxlU3Ry ZWFtRnVuY3Rpb24oSlNDOjpKU0dsb2JhbE9iamVjCiAgICAgSlNDOjpWTSYgdm0gPSBnbG9iYWxP YmplY3Qudm0oKTsKICAgICBKU0M6OkpTTG9ja0hvbGRlciBsb2NrKHZtKTsKIAorICAgIGF1dG8g c2NvcGUgPSBERUNMQVJFX0NBVENIX1NDT1BFKHZtKTsKKwogICAgIGF1dG8gZnVuY3Rpb24gPSBn bG9iYWxPYmplY3QuZ2V0KCZnbG9iYWxPYmplY3QsIGlkZW50aWZpZXIpOwogICAgIEFTU0VSVChm dW5jdGlvbi5pc0NhbGxhYmxlKHZtKSk7CisgICAgc2NvcGUuYXNzZXJ0Tm9FeGNlcHRpb25FeGNl cHRUZXJtaW5hdGlvbigpOwogCi0gICAgYXV0byBzY29wZSA9IERFQ0xBUkVfVEhST1dfU0NPUEUo dm0pOwogICAgIGF1dG8gY2FsbERhdGEgPSBKU0M6OmdldENhbGxEYXRhKHZtLCBmdW5jdGlvbik7 CiAKICAgICBhdXRvIHJlc3VsdCA9IGNhbGwoJmdsb2JhbE9iamVjdCwgZnVuY3Rpb24sIGNhbGxE YXRhLCBKU0M6OmpzVW5kZWZpbmVkKCksIGFyZ3VtZW50cyk7Ci0gICAgaWYgKFVOTElLRUxZKHNj b3BlLmV4Y2VwdGlvbigpKSkKLSAgICAgICAgcmV0dXJuIEV4Y2VwdGlvbiB7IEV4aXN0aW5nRXhj ZXB0aW9uRXJyb3IgfTsKKyAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBFeGNlcHRpb24g eyBFeGlzdGluZ0V4Y2VwdGlvbkVycm9yIH0pOwogCiAgICAgcmV0dXJuIHJlc3VsdDsKIH0K