230198 2021-09-12 02:47:09 -0700 Postprocess framework headers in parallel 2022-04-15 15:35:21 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=230300 InRadar P2 Normal --- 1 thorton thorton ap emw mitz sam simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1792764 0 thorton 2021-09-12 02:47:09 -0700 Postprocess framework headers in parallel 1792765 1 437983 thorton 2021-09-12 02:50:30 -0700 Created attachment 437983 Patch 1792766 2 thorton 2021-09-12 02:52:53 -0700 (if anybody knows how to easily limit the parallelism here, I'm all ears) 1792768 3 thorton 2021-09-12 02:54:24 -0700 (In reply to Tim Horton from comment #2) > (if anybody knows how to easily limit the parallelism here, I'm all ears) (at the same time, it doesn't really seem to be a problem?) 1792777 4 437983 mitz 2021-09-12 07:59:22 -0700 Comment on attachment 437983 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437983&action=review My understanding is that this script shouldn’t even get invoked when using Xcode’s modern build system. Are you fixing a problem seen when using the legacy build system? > Source/WebKit/ChangeLog:20 > + of time launching processes; it's likely possible to get further wins Refactoring ${POSTPROCESS_HEADER_RULE}s to declare a function and using it from here would likely help more than this. 1792840 5 thorton 2021-09-12 20:59:56 -0700 (In reply to mitz from comment #4) > Comment on attachment 437983 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=437983&action=review > > My understanding is that this script shouldn’t even get invoked when using > Xcode’s modern build system. Are you fixing a problem seen when using the > legacy build system? Yes, we currently still use the legacy build system when building locally. > > Source/WebKit/ChangeLog:20 > > + of time launching processes; it's likely possible to get further wins > > Refactoring ${POSTPROCESS_HEADER_RULE}s to declare a function and using it > from here would likely help more than this. Likely! 1793118 6 437983 thorton 2021-09-13 15:13:15 -0700 Comment on attachment 437983 Patch Let's see how this goes (we should see if we can improve more, though now WebKitAdditions rewriting is the hot path, not this). 1793122 7 ews-feeder 2021-09-13 15:26:27 -0700 Committed r282367 (241630@main): <https://commits.webkit.org/241630@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437983. 1793123 8 webkit-bug-importer 2021-09-13 15:27:32 -0700 <rdar://problem/83075272> 1793181 9 wenson_hsieh 2021-09-13 18:38:22 -0700 (In reply to Tim Horton from comment #6) > Comment on attachment 437983 [details] > Patch > > Let's see how this goes (we should see if we can improve more, though now > WebKitAdditions rewriting is the hot path, not this). (Assuming you're referring to replace-webkit-additions-includes.py, and the build phase that calls into it) I think we should actually be able to remove that build phase and script altogether, since we don't currently have any public APIs whose name cannot be landed in open source. I think that if we need it again in the future, we can just resurrect it (since it exists in git history anyways). 1793637 10 thorton 2021-09-15 01:50:21 -0700 (In reply to Wenson Hsieh from comment #9) > (In reply to Tim Horton from comment #6) > > Comment on attachment 437983 [details] > > Patch > > > > Let's see how this goes (we should see if we can improve more, though now > > WebKitAdditions rewriting is the hot path, not this). > > (Assuming you're referring to replace-webkit-additions-includes.py, and the > build phase that calls into it) I think we should actually be able to remove > that build phase and script altogether, since we don't currently have any > public APIs whose name cannot be landed in open source. > > I think that if we need it again in the future, we can just resurrect it > (since it exists in git history anyways). Good call, that's another 4 seconds (down to 11!) 1861932 11 437983 emw 2022-04-15 15:07:08 -0700 Comment on attachment 437983 Patch The good news is that XCBuild doesn't use this script at all: It runs the postprocessing step on each header in parellel. But this seems fine to me as a temporary stopgap :) 1861933 12 emw 2022-04-15 15:09:23 -0700 (In reply to Elliott Williams from comment #11) > Comment on attachment 437983 [details] > Patch > > The good news is that XCBuild doesn't use this script at all: It runs the > postprocessing step on each header in parellel. But this seems fine to me as > a temporary stopgap :) Er, actually, we've already deleted this file as part of the XCBuild migration -- this headers phase is one of the parts of the build that has adopted XCBuild early. 1861939 13 thorton 2022-04-15 15:35:21 -0700 (In reply to Elliott Williams from comment #12) > (In reply to Elliott Williams from comment #11) > > Comment on attachment 437983 [details] > > Patch > > > > The good news is that XCBuild doesn't use this script at all: It runs the > > postprocessing step on each header in parellel. But this seems fine to me as > > a temporary stopgap :) > > Er, actually, we've already deleted this file as part of the XCBuild > migration -- this headers phase is one of the parts of the build that has > adopted XCBuild early. This landed a long time ago! 437983 2021-09-12 02:50:30 -0700 2021-09-13 15:26:28 -0700 Patch bug-230198-20210912025030.patch text/plain 2016 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyMjc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ2YTgyNjZiY2Y2ZWU5YmUz YmU2ZjkxMWEzOWEzYzNkMWE4NjBmYzEuLjZhZjkzNDQ2MDQ5YjM1YjI1NGRlMmU3MmQ4ZWY0OWQy MDY2NTU0NDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMjEtMDktMTIgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUG9zdHByb2Nlc3MgZnJh bWV3b3JrIGhlYWRlcnMgaW4gcGFyYWxsZWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIzMDE5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogbWFjL3Bvc3Rwcm9jZXNzLWZyYW1ld29yay1oZWFkZXJzLnNo OgorICAgICAgICBQcmV2aW91c2x5LCB0aGUgZnJhbWV3b3JrIGhlYWRlciBwb3N0cHJvY2Vzc2lu ZyBzdGVwIG9wZXJhdGVkIHNlcmlhbGx5CisgICAgICAgIG9uIGVhY2ggb2Ygb3VyIDY2NSBmcmFt ZXdvcmsgaGVhZGVyczsgbm90IGRvaW5nIGEgcGFydGljdWxhcmx5IGxhcmdlCisgICAgICAgIGFt b3VudCBvZiB3b3JrIG9uIGFueSwgYnV0IHN0aWxsLCAyMCB3YWxsIGNsb2NrIG1zICogNjY1IGhl YWRlcnMgaXMKKyAgICAgICAgYSBnb29kIGNodW5rIG9mIHRpbWUuCisKKyAgICAgICAgSW5zdGVh ZCwgcnVuIHRoZW0gaW4gcGFyYWxsZWwgYW5kIHdhaXQgb24gdGhlIHJlc3VsdC4KKworICAgICAg ICBPbiBhIDEwIGNvcmUgbWFjaGluZSwgdGhpcyBiZXR0ZXIgdGhhbiBoYWx2ZXMgdGhlIHRpbWUg b2YgYSBXZWJLaXQtb25seQorICAgICAgICBudWxsIGJ1aWxkIChmcm9tIDM2IHNlY29uZHMgdG8g MTUpLgorCisgICAgICAgIFRoaXMgaXMgZGVmaW5pdGVseSBub3QgYW4gaWRlYWwgc29sdXRpb247 IHdlJ3JlIHN0aWxsIHdhc3RpbmcgYSB0b24KKyAgICAgICAgb2YgdGltZSBsYXVuY2hpbmcgcHJv Y2Vzc2VzOyBpdCdzIGxpa2VseSBwb3NzaWJsZSB0byBnZXQgZnVydGhlciB3aW5zCisgICAgICAg IGhlcmU7IG9uIHRoZSBvdGhlciBoYW5kLCBoZWFkZXIgcG9zdHByb2Nlc3Npbmcgb25seSB0YWtl cyAyIHNlY29uZHMgbm93LgorCiAyMDIxLTA5LTEwICBQZXIgQXJuZSBWb2xsYW4gPHB2b2xsYW5A YXBwbGUuY29tPgogCiAgICAgICAgIFttYWNPU10gVXNlIG1hY3JvIHRvIGNsb3NlIFhQQyBjb25u ZWN0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9wb3N0cHJvY2Vzcy1mcmFtZXdv cmstaGVhZGVycy5zaCBiL1NvdXJjZS9XZWJLaXQvbWFjL3Bvc3Rwcm9jZXNzLWZyYW1ld29yay1o ZWFkZXJzLnNoCmluZGV4IGJiNDBlMGRkYWI5MzQ2NTRjYmE4Y2ExYmVhZTAzYWQ0NDRlZjk2MTYu LmY0OGFhOTcxM2FhYzg5NTdhM2VhOGUxMzc2NzkwM2JiYmQ0NDYwNjcgMTAwNzU1Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvbWFjL3Bvc3Rwcm9jZXNzLWZyYW1ld29yay1oZWFkZXJzLnNoCisrKyBiL1Nv dXJjZS9XZWJLaXQvbWFjL3Bvc3Rwcm9jZXNzLWZyYW1ld29yay1oZWFkZXJzLnNoCkBAIC0zMyw4 ICszMyw5IEBAIGZ1bmN0aW9uIHJld3JpdGVfaGVhZGVycyAoKQogICAgICAgICBTQ1JJUFRfSEVB REVSX1ZJU0lCSUxJVFk9IiR7Mn0iIFwKICAgICAgICAgU0NSSVBUX0lOUFVUX0ZJTEU9IiR7SEVB REVSX1BBVEh9IiBcCiAgICAgICAgIFNDUklQVF9PVVRQVVRfRklMRV8wPSIke0hFQURFUl9QQVRI fSIgXAotICAgICAgICAgICAgIiR7UE9TVFBST0NFU1NfSEVBREVSX1JVTEV9IgorICAgICAgICAg ICAgIiR7UE9TVFBST0NFU1NfSEVBREVSX1JVTEV9IiAmCiAgICAgZG9uZQorICAgIHdhaXQKIH0K IAogcmV3cml0ZV9oZWFkZXJzICIke1RBUkdFVF9CVUlMRF9ESVJ9LyR7UFVCTElDX0hFQURFUlNf Rk9MREVSX1BBVEh9IiBQdWJsaWMK