230197 2021-09-11 21:51:36 -0700 Implement getClientRects() for SVG elements 2021-09-12 11:42:20 -0700 1 1 1 Unclassified WebKit SVG WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser cdumez cmarcelo esprehn+autocc ews-watchlist kangil.han sabouhallawa sam simon.fraser webkit-bug-importer zimmermann oldest_to_newest 1792759 0 simon.fraser 2021-09-11 21:51:36 -0700 Implement getClientRects() for SVG elements 1792760 1 437980 simon.fraser 2021-09-11 21:52:25 -0700 Created attachment 437980 Patch 1792783 2 437980 sam 2021-09-12 10:58:03 -0700 Comment on attachment 437980 Patch I am so ashamed that I wrote that comment in 2009 and never got to this :( https://trac.webkit.org/changeset/40837/webkit. Does this match other browsers? 1792787 3 simon.fraser 2021-09-12 11:23:10 -0700 It does, yes. 1792788 4 simon.fraser 2021-09-12 11:41:31 -0700 https://trac.webkit.org/changeset/282316/webkit 1792789 5 webkit-bug-importer 2021-09-12 11:42:20 -0700 <rdar://problem/83031917> 437980 2021-09-11 21:52:25 -0700 2021-09-12 10:58:03 -0700 Patch bug-230197-20210911215224.patch text/plain 5673 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyMzE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDdjZDZiMjgwNjA5ODA0 NWNkNTQ5NTQ2MTBkOGEyZTg2YzE3NzBlYi4uZTEyY2ExOTI5NGY1MGJmZTQ0NDhiZjk3NDI0ZjIx YTFmZWY5YTg0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA5LTExICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEltcGxlbWVudCBn ZXRDbGllbnRSZWN0cygpIGZvciBTVkcgZWxlbWVudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMDE5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvciBTVkcgZWxlbWVudHMgd2UgY2FuIGp1c3QgdXNl IGFic29sdXRlUXVhZHMoKS4KKworICAgICAgICBUZXN0OiBzdmcvY3VzdG9tL2dldENsaWVudFJl Y3RzLnhodG1sCisKKyAgICAgICAgKiBkb20vRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpFbGVtZW50OjpnZXRDbGllbnRSZWN0cyk6CisKIDIwMjEtMDktMTEgIEFudHRpIEtvaXZpc3Rv ICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIE1vdmUgcmVzdCBvZiB0aGUgTGVnYWN5SW5s aW5lVGV4dEJveCBwYWludGluZyBjb2RlIHRvIFRleHRCb3hQYWludGVyCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVu dC5jcHAKaW5kZXggOGQ2NDVhNDM1OTdkYzhmYzZjYzMyMGE0NTVjYWRhMjIxN2IwYmFlNS4uZjAz NTBjZjAzNWViMmJjYzZkMTIzNDJmNjAzMDI4MGFhYjUwNzM5ZiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50 LmNwcApAQCAtMTY0MSw4ICsxNjQxLDkgQEAgUmVmPERPTVJlY3RMaXN0PiBFbGVtZW50OjpnZXRD bGllbnRSZWN0cygpCiAgICAgICAgIHF1YWRzLmFwcGVuZChyZW5kZXJlci0+bG9jYWxUb0Fic29s dXRlUXVhZChGbG9hdFF1YWQgeyBwYWlyLnZhbHVlKCkuc2Vjb25kIH0pKTsKICAgICB9IGVsc2Ug aWYgKGF1dG8qIHJlbmRlckJveE1vZGVsT2JqZWN0ID0gdGhpcy0+cmVuZGVyQm94TW9kZWxPYmpl Y3QoKSkKICAgICAgICAgcmVuZGVyQm94TW9kZWxPYmplY3QtPmFic29sdXRlUXVhZHMocXVhZHMp OworICAgIGVsc2UgaWYgKGlzU1ZHRWxlbWVudCgpICYmIHJlbmRlcmVyKQorICAgICAgICByZW5k ZXJlci0+YWJzb2x1dGVRdWFkcyhxdWFkcyk7CiAKLSAgICAvLyBGSVhNRTogSGFuZGxlIFNWRyBl bGVtZW50cy4KICAgICAvLyBGSVhNRTogSGFuZGxlIHRhYmxlL2lubGluZS10YWJsZSB3aXRoIGEg Y2FwdGlvbi4KIAogICAgIGlmIChxdWFkcy5pc0VtcHR5KCkpCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZDBjMzVhNzc0ZTMz NDE3N2EyMjVlNzMwYWI2NDRlNzYwZGU3YmEyZS4uYmU5Yzg3ZmFhYTg1MDJhNmUzZWJlNGJkMjdm NmYxM2U0YTQwM2YyOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIxLTA5LTExICBTaW1vbiBG cmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEltcGxlbWVudCBnZXRD bGllbnRSZWN0cygpIGZvciBTVkcgZWxlbWVudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMDE5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogc3ZnL2N1c3RvbS9nZXRDbGllbnRSZWN0cy1leHBlY3Rl ZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHN2Zy9jdXN0b20vZ2V0Q2xpZW50UmVjdHMueGh0bWw6 IEFkZGVkLgorCiAyMDIxLTA5LTExICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUu Y29tPgogCiAgICAgICAgIFVwZGF0ZSBjc3MvY3Nzb20tdmlldyBXUFQgdGVzdHMKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vZ2V0Q2xpZW50UmVjdHMtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9nZXRDbGllbnRSZWN0cy1leHBlY3RlZC50eHQKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uMDNiOTQzYTc2MGVmYzY0YTI5YjlhN2E5ZTg1NDY2NmFhM2Q4OTg0ZAotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vZ2V0Q2xpZW50UmVjdHMtZXhwZWN0ZWQu dHh0CkBAIC0wLDAgKzEsMjQgQEAKKworQSBCQworVGhpcyB0ZXN0IGNoZWNrcyBnZXRDbGllbnRS ZWN0cygpIG9uIFNWRyBlbGVtZW50cworCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJp ZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKK2dl dENsaWVudFJlY3RzIG9uIGEgcmVjdCBhdCBhYnNvbHV0ZSBjb29yZGluYXRlczoKK3sgeCAyMC4w MCB5IDMwLjAwIHdpZHRoIDQwLjAwIGhlaWdodCA1MC4wMCB9CisKK2dldENsaWVudFJlY3RzIG9u IGEgcm90YXRlZCByZWN0OgoreyB4IDMwLjM2IHkgMTE0LjM2IHdpZHRoIDEzOS4yNyBoZWlnaHQg MTM5LjI3IH0KKworZ2V0Q2xpZW50UmVjdHMgb24gYSBnOgoreyB4IDAuMDAgeSAxMDQuMDAgd2lk dGggMjYwLjAwIGhlaWdodCAxMTAuMDAgfQorCitnZXRDbGllbnRSZWN0cyBvbiBhIHBhdGg6Cit7 IHggMjUuMDAgeSAxMzkuMDAgd2lkdGggNjAuMDAgaGVpZ2h0IDYwLjAwIH0KKworZ2V0Q2xpZW50 UmVjdHMgb24gdGV4dDoKK3sgeCAyNS4wMCB5IDEzOS4wMCB3aWR0aCA2MC4wMCBoZWlnaHQgNjAu MDAgfQorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vZ2V0Q2xpZW50UmVjdHMueGh0bWwg Yi9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL2dldENsaWVudFJlY3RzLnhodG1sCm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu LjA0Nzg0MWFiNGVhZjM0YzhiMDAwZjMzNDdhNTI5MThhMzY2MzBjYzYKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL2dldENsaWVudFJlY3RzLnhodG1sCkBAIC0wLDAg KzEsNjYgQEAKKzxodG1sIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hodG1sIj4KKzxo ZWFkPgorPC9oZWFkPgorPGJvZHkgc3R5bGU9Im1hcmdpbjowOyBib3JkZXI6MDsgcGFkZGluZzow OyI+CisKKzxkaXYgc3R5bGU9IndpZHRoOjUwMHB4O2hlaWdodDoyMDBweDsiPgorPHN2ZyB4bWxu cz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZlcnNpb249IjEuMSIgd2lkdGg9IjEwMHB4 IiBoZWlnaHQ9IjEwMHB4Ij4KKyAgPHJlY3QgaWQ9InIxIiB4PSIyMCIgeT0iMzAiIHdpZHRoPSI0 MCIgaGVpZ2h0PSI1MCIgZmlsbD0iYmx1ZSIgLz4KKzwvc3ZnPgorPHN2ZyB4bWxucz0iaHR0cDov L3d3dy53My5vcmcvMjAwMC9zdmciIHZlcnNpb249IjEuMSIgd2lkdGg9IjIwMHB4IiBoZWlnaHQ9 IjEwMHB4IiB2aWV3Qm94PSIwIDAgNTAgMjAwIiBwcmVzZXJ2ZUFzcGVjdFJhdGlvPSJub25lIj4K KyAgPHJlY3QgaWQ9InIyIiB4PSIyMCIgeT0iMzAiIHdpZHRoPSI0MCIgaGVpZ2h0PSI1MCIgZmls bD0iZ3JlZW4iIC8+Cis8L3N2Zz4KKzxzdmcgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAv c3ZnIiB2ZXJzaW9uPSIxLjEiIHdpZHRoPSIyMDBweCIgaGVpZ2h0PSIxMDBweCI+CisgIDxnIGlk PSJyZWN0LWdyb3VwIj4KKyAgICA8cmVjdCB4PSIwIiB5PSIwIiB3aWR0aD0iMjAwcHgiIGhlaWdo dD0iNTBweCIgZmlsbD0ieWVsbG93IiBvdmVyZmxvdz0iaGlkZGVuIiAvPgorICAgIDxyZWN0IHg9 IjUwcHgiIHk9IjUwcHgiIHdpZHRoPSIyMTBweCIgaGVpZ2h0PSI2MHB4IiBmaWxsPSJvcmFuZ2Ui IG92ZXJmbG93PSJ2aXNpYmxlIiAvPgorICA8L2c+CisgIDxyZWN0IGlkPSJyMyIgdHJhbnNmb3Jt PSJ0cmFuc2xhdGUoNTAsIDMwKSByb3RhdGUoMzUsIDUwLCA1MCkiIGZpbGw9ImdyZWVuIiB3aWR0 aD0iMTAwIiBoZWlnaHQ9IjEwMCIvPgorICA8cGF0aCBpZD0icGF0aDEiIGZpbGw9ImdyZWVuIiBz dHJva2U9ImJsYWNrIiBzdHJva2Utd2lkdGg9IjEwIiBkPSJNIDMwIDQwIEwgODAgNDAgTCA4MCA5 MCAgTCAzMCA5MCBaIi8+CisgIDx0ZXh0IGlkPSJ0ZXh0IiB4PSIxMCIgeT0iMzAiPjx0c3Bhbj5B PHRzcGFuIGR5PSItNSI+IEI8L3RzcGFuPjx0c3BhbiBkeT0iMTAiPjx0c3Bhbj5DPC90c3Bhbj48 L3RzcGFuPjwvdHNwYW4+PC90ZXh0PgorPC9zdmc+Cis8L2Rpdj4KKworPGRpdiBpZD0iZGVzY3Jp cHRpb24iPjwvZGl2PgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CisKKzxzY3JpcHQgc3JjPSIu Li8uLi9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KKworZnVu Y3Rpb24gcmVjdFRvU3RyaW5nKHIpCit7CisgICAgcmV0dXJuIGB7IHggJHtyLmxlZnQudG9GaXhl ZCgyKX0geSAke3IudG9wLnRvRml4ZWQoMil9IHdpZHRoICR7ci53aWR0aC50b0ZpeGVkKDIpfSBo ZWlnaHQgJHtyLmhlaWdodC50b0ZpeGVkKDIpfSB9YDsKK30KKworZnVuY3Rpb24gZHVtcFJlY3Rz KHJlY3RMaXN0KQoreworICAgIGZvciAobGV0IHJlY3Qgb2YgcmVjdExpc3QpCisgICAgICAgIGRl YnVnKHJlY3RUb1N0cmluZyhyZWN0KSk7Cit9CisKK2Rlc2NyaXB0aW9uKCJUaGlzIHRlc3QgY2hl Y2tzIGdldENsaWVudFJlY3RzKCkgb24gU1ZHIGVsZW1lbnRzIik7CisKK2RlYnVnKCJnZXRDbGll bnRSZWN0cyBvbiBhIHJlY3QgYXQgYWJzb2x1dGUgY29vcmRpbmF0ZXM6Iik7CitkdW1wUmVjdHMo ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInIxIikuZ2V0Q2xpZW50UmVjdHMoKSk7CisKK2RlYnVn KCIiKTsKK2RlYnVnKCJnZXRDbGllbnRSZWN0cyBvbiBhIHJvdGF0ZWQgcmVjdDoiKTsKK2R1bXBS ZWN0cyhkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicjMiKS5nZXRDbGllbnRSZWN0cygpKTsKKwor ZGVidWcoIiIpOworZGVidWcoImdldENsaWVudFJlY3RzIG9uIGEgZzoiKTsKK2R1bXBSZWN0cyhk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVjdC1ncm91cCIpLmdldENsaWVudFJlY3RzKCkpOwor CitkZWJ1ZygiIik7CitkZWJ1ZygiZ2V0Q2xpZW50UmVjdHMgb24gYSBwYXRoOiIpOworZHVtcFJl Y3RzKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJwYXRoMSIpLmdldENsaWVudFJlY3RzKCkpOwor CitkZWJ1ZygiIik7CitkZWJ1ZygiZ2V0Q2xpZW50UmVjdHMgb24gdGV4dDoiKTsKK2R1bXBSZWN0 cyhkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicGF0aDEiKS5nZXRDbGllbnRSZWN0cygpKTsKKwor PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+ PC9zY3JpcHQ+CisKKzwvYm9keT4KKzwvaHRtbD4K