230190 2021-09-11 10:49:48 -0700 Linker warnings for WKWebViewConfiguration.limitsNavigationsToAppBoundDomains property methods 2021-09-13 10:02:22 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 210620 1 ddkilzer ddkilzer bfulgham katherine_cheney kkinnunen webkit-bug-importer oldest_to_newest 1792720 0 ddkilzer 2021-09-11 10:49:48 -0700 Linker warnings for WKWebViewConfiguration.limitsNavigationsToAppBoundDomains property methods when building for iOS: ld: warning: method '-limitsNavigationsToAppBoundDomains' in category from WebKitBuild/WebKit.build/Release-iphoneos/WebKit.build/Objects-normal/arm64e/UnifiedSource25-mm.o overrides method from class in WebKitBuild/WebKit.build/Release-iphoneos/WebKit.build/Objects-normal/arm64e/UnifiedSource25-mm.o ld: warning: method '-setLimitsNavigationsToAppBoundDomains:' in category from WebKitBuild/WebKit.build/Release-iphoneos/WebKit.build/Objects-normal/arm64e/UnifiedSource25-mm.o overrides method from class in WebKitBuild/WebKit.build/Release-iphoneos/WebKit.build/Objects-normal/arm64e/UnifiedSource25-mm.o This happens because the methods are implemented in category WKWebViewConfiguration (WKPrivate), but should be moved to WKWebViewConfiguration since the property was added as API in r260228. 1792721 1 437958 ddkilzer 2021-09-11 10:52:53 -0700 Created attachment 437958 Patch v1 1792724 2 437958 ddkilzer 2021-09-11 11:07:30 -0700 Comment on attachment 437958 Patch v1 This needs PLATFORM(IOS) guards. 1792727 3 437961 ddkilzer 2021-09-11 11:56:57 -0700 Created attachment 437961 Patch v2 1792832 4 437961 katherine_cheney 2021-09-12 19:39:23 -0700 Comment on attachment 437961 Patch v2 r=me 1792983 5 ews-feeder 2021-09-13 10:01:24 -0700 Committed r282332 (241600@main): <https://commits.webkit.org/241600@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437961. 1792984 6 webkit-bug-importer 2021-09-13 10:02:22 -0700 <rdar://problem/83060079> 437958 2021-09-11 10:52:53 -0700 2021-09-11 11:17:31 -0700 Patch v1 bug-230190-20210911105252.patch text/plain 2613 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxODE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGNmZGRiMmNiMDMwYjU2ODll Nzc0NGRjMzg4MjNjOTY2NGJlN2EzZDcuLjE1MWQ4YTM4Yjg3YWY0ODE1NzU1N2RlOWQ2YzVkN2U4 YTg4OTdiZDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDktMTEgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBMaW5rZXIgd2FybmluZ3MgZm9y IFdLV2ViVmlld0NvbmZpZ3VyYXRpb24ubGltaXRzTmF2aWdhdGlvbnNUb0FwcEJvdW5kRG9tYWlu cyBwcm9wZXJ0eSBtZXRob2RzCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8yMzAxOTA+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld0NvbmZpZ3VyYXRpb24ubW06CisgICAgICAgICgtW1dL V2ViVmlld0NvbmZpZ3VyYXRpb24gbGltaXRzTmF2aWdhdGlvbnNUb0FwcEJvdW5kRG9tYWluc10p OgorICAgICAgICAoLVtXS1dlYlZpZXdDb25maWd1cmF0aW9uIHNldExpbWl0c05hdmlnYXRpb25z VG9BcHBCb3VuZERvbWFpbnM6XSk6CisgICAgICAgIC0gTW92ZSBtZXRob2RzIGZyb20gY2F0ZWdv cnkgV0tXZWJWaWV3Q29uZmlndXJhdGlvbiAoV0tQcml2YXRlKSB0bworICAgICAgICAgIEBpbXBs ZW1lbnRhdGlvbiBXS1dlYlZpZXdDb25maWd1cmF0aW9uIHRvIGZpeCB0aGUgd2FybmluZ3MuCisK IDIwMjEtMDktMTEgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAg ICBDRk5vdGlmaWNhdGlvbkNlbnRlckFkZE9ic2VydmVyKCkgc2hvdWxkIHVzZSB3ZWFrIG9ic2Vy dmVycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vi Vmlld0NvbmZpZ3VyYXRpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tXZWJWaWV3Q29uZmlndXJhdGlvbi5tbQppbmRleCA4MTc4M2M3M2NiNGU4ZDNiMDU0MTQ1OGZk NmIzOTM1ZDgxNTNjNmE3Li4xNjJmMjk5MTQ3YjQxMzc2ZGNkM2RjNzkzNGI4MWFiYjAyNTI1MWE4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3 Q29uZmlndXJhdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tXZWJWaWV3Q29uZmlndXJhdGlvbi5tbQpAQCAtNTUwLDYgKzU1MCwxNiBAQCAtICh2b2lkKXNl dEFwcGxpY2F0aW9uTmFtZUZvclVzZXJBZ2VudDooTlNTdHJpbmcgKilhcHBsaWNhdGlvbk5hbWVG b3JVc2VyQWdlbnQKICAgICBfYXBwbGljYXRpb25OYW1lRm9yVXNlckFnZW50LmVtcGxhY2UoYWRv cHROUyhhcHBsaWNhdGlvbk5hbWVGb3JVc2VyQWdlbnQuY29weSkpOwogfQogCistIChCT09MKWxp bWl0c05hdmlnYXRpb25zVG9BcHBCb3VuZERvbWFpbnMKK3sKKyAgICByZXR1cm4gX3BhZ2VDb25m aWd1cmF0aW9uLT5saW1pdHNOYXZpZ2F0aW9uc1RvQXBwQm91bmREb21haW5zKCk7Cit9CisKKy0g KHZvaWQpc2V0TGltaXRzTmF2aWdhdGlvbnNUb0FwcEJvdW5kRG9tYWluczooQk9PTClsaW1pdHNU b0FwcEJvdW5kRG9tYWlucworeworICAgIF9wYWdlQ29uZmlndXJhdGlvbi0+c2V0TGltaXRzTmF2 aWdhdGlvbnNUb0FwcEJvdW5kRG9tYWlucyhsaW1pdHNUb0FwcEJvdW5kRG9tYWlucyk7Cit9CisK IC0gKF9XS1Zpc2l0ZWRMaW5rU3RvcmUgKilfdmlzaXRlZExpbmtTdG9yZQogewogICAgIHJldHVy biBfdmlzaXRlZExpbmtTdG9yZS5nZXQoW10geyByZXR1cm4gYWRvcHROUyhbW19XS1Zpc2l0ZWRM aW5rU3RvcmUgYWxsb2NdIGluaXRdKTsgfSk7CkBAIC04MzUsMTYgKzg0NSw2IEBAIC0gKGlkIDxf VUlDbGlja0ludGVyYWN0aW9uRHJpdmluZz4pX2NsaWNrSW50ZXJhY3Rpb25Ecml2ZXJGb3JUZXN0 aW5nCiAgICAgcmV0dXJuIF9wYWdlQ29uZmlndXJhdGlvbi0+Y2xpY2tJbnRlcmFjdGlvbkRyaXZl ckZvclRlc3RpbmcoKS5nZXQoKTsKIH0KIAotLSAoQk9PTClsaW1pdHNOYXZpZ2F0aW9uc1RvQXBw Qm91bmREb21haW5zCi17Ci0gICAgcmV0dXJuIF9wYWdlQ29uZmlndXJhdGlvbi0+bGltaXRzTmF2 aWdhdGlvbnNUb0FwcEJvdW5kRG9tYWlucygpOwotfQotCi0tICh2b2lkKXNldExpbWl0c05hdmln YXRpb25zVG9BcHBCb3VuZERvbWFpbnM6KEJPT0wpbGltaXRzVG9BcHBCb3VuZERvbWFpbnMKLXsK LSAgICBfcGFnZUNvbmZpZ3VyYXRpb24tPnNldExpbWl0c05hdmlnYXRpb25zVG9BcHBCb3VuZERv bWFpbnMobGltaXRzVG9BcHBCb3VuZERvbWFpbnMpOwotfQotCiBzdGF0aWMgX1dLQXR0cmlidXRp b25PdmVycmlkZVRlc3RpbmcgdG9XS0F0dHJpYnV0aW9uT3ZlcnJpZGVUZXN0aW5nKFdlYktpdDo6 QXR0cmlidXRpb25PdmVycmlkZVRlc3RpbmcgdmFsdWUpCiB7CiAgICAgaWYgKHZhbHVlID09IFdl YktpdDo6QXR0cmlidXRpb25PdmVycmlkZVRlc3Rpbmc6OkFwcEluaXRpYXRlZCkK 437961 2021-09-11 11:56:57 -0700 2021-09-13 10:01:25 -0700 Patch v2 bug-230190-20210911115657.patch text/plain 2609 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxODE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGNmZGRiMmNiMDMwYjU2ODll Nzc0NGRjMzg4MjNjOTY2NGJlN2EzZDcuLjE1MWQ4YTM4Yjg3YWY0ODE1NzU1N2RlOWQ2YzVkN2U4 YTg4OTdiZDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDktMTEgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBMaW5rZXIgd2FybmluZ3MgZm9y IFdLV2ViVmlld0NvbmZpZ3VyYXRpb24ubGltaXRzTmF2aWdhdGlvbnNUb0FwcEJvdW5kRG9tYWlu cyBwcm9wZXJ0eSBtZXRob2RzCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8yMzAxOTA+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld0NvbmZpZ3VyYXRpb24ubW06CisgICAgICAgICgtW1dL V2ViVmlld0NvbmZpZ3VyYXRpb24gbGltaXRzTmF2aWdhdGlvbnNUb0FwcEJvdW5kRG9tYWluc10p OgorICAgICAgICAoLVtXS1dlYlZpZXdDb25maWd1cmF0aW9uIHNldExpbWl0c05hdmlnYXRpb25z VG9BcHBCb3VuZERvbWFpbnM6XSk6CisgICAgICAgIC0gTW92ZSBtZXRob2RzIGZyb20gY2F0ZWdv cnkgV0tXZWJWaWV3Q29uZmlndXJhdGlvbiAoV0tQcml2YXRlKSB0bworICAgICAgICAgIEBpbXBs ZW1lbnRhdGlvbiBXS1dlYlZpZXdDb25maWd1cmF0aW9uIHRvIGZpeCB0aGUgd2FybmluZ3MuCisK IDIwMjEtMDktMTEgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAg ICBDRk5vdGlmaWNhdGlvbkNlbnRlckFkZE9ic2VydmVyKCkgc2hvdWxkIHVzZSB3ZWFrIG9ic2Vy dmVycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vi Vmlld0NvbmZpZ3VyYXRpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tXZWJWaWV3Q29uZmlndXJhdGlvbi5tbQppbmRleCA4MTc4M2M3M2NiNGU4ZDNiMDU0MTQ1OGZk NmIzOTM1ZDgxNTNjNmE3Li5mY2ExYTQ3YTdkN2E4MDQwN2U5YWZmZjVmYWU5ODQwOGIzZDljMzU5 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3 Q29uZmlndXJhdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tXZWJWaWV3Q29uZmlndXJhdGlvbi5tbQpAQCAtNjA0LDYgKzYwNCwxNiBAQCBBTExPV19ERVBS RUNBVEVEX0lNUExFTUVOVEFUSU9OU19FTkQKIEFMTE9XX0RFUFJFQ0FURURfREVDTEFSQVRJT05T X0VORAogCiAjaWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkKKy0gKEJPT0wpbGltaXRzTmF2aWdhdGlv bnNUb0FwcEJvdW5kRG9tYWlucworeworICAgIHJldHVybiBfcGFnZUNvbmZpZ3VyYXRpb24tPmxp bWl0c05hdmlnYXRpb25zVG9BcHBCb3VuZERvbWFpbnMoKTsKK30KKworLSAodm9pZClzZXRMaW1p dHNOYXZpZ2F0aW9uc1RvQXBwQm91bmREb21haW5zOihCT09MKWxpbWl0c1RvQXBwQm91bmREb21h aW5zCit7CisgICAgX3BhZ2VDb25maWd1cmF0aW9uLT5zZXRMaW1pdHNOYXZpZ2F0aW9uc1RvQXBw Qm91bmREb21haW5zKGxpbWl0c1RvQXBwQm91bmREb21haW5zKTsKK30KKwogLSAoV0tXZWJWaWV3 Q29udGVudFByb3ZpZGVyUmVnaXN0cnkgKilfY29udGVudFByb3ZpZGVyUmVnaXN0cnkKIHsKICAg ICByZXR1cm4gX2NvbnRlbnRQcm92aWRlclJlZ2lzdHJ5LmdldChbc2VsZl0geyByZXR1cm4gYWRv cHROUyhbW1dLV2ViVmlld0NvbnRlbnRQcm92aWRlclJlZ2lzdHJ5IGFsbG9jXSBpbml0V2l0aENv bmZpZ3VyYXRpb246c2VsZl0pOyB9KTsKQEAgLTgzNSwxNiArODQ1LDYgQEAgLSAoaWQgPF9VSUNs aWNrSW50ZXJhY3Rpb25Ecml2aW5nPilfY2xpY2tJbnRlcmFjdGlvbkRyaXZlckZvclRlc3RpbmcK ICAgICByZXR1cm4gX3BhZ2VDb25maWd1cmF0aW9uLT5jbGlja0ludGVyYWN0aW9uRHJpdmVyRm9y VGVzdGluZygpLmdldCgpOwogfQogCi0tIChCT09MKWxpbWl0c05hdmlnYXRpb25zVG9BcHBCb3Vu ZERvbWFpbnMKLXsKLSAgICByZXR1cm4gX3BhZ2VDb25maWd1cmF0aW9uLT5saW1pdHNOYXZpZ2F0 aW9uc1RvQXBwQm91bmREb21haW5zKCk7Ci19Ci0KLS0gKHZvaWQpc2V0TGltaXRzTmF2aWdhdGlv bnNUb0FwcEJvdW5kRG9tYWluczooQk9PTClsaW1pdHNUb0FwcEJvdW5kRG9tYWlucwotewotICAg IF9wYWdlQ29uZmlndXJhdGlvbi0+c2V0TGltaXRzTmF2aWdhdGlvbnNUb0FwcEJvdW5kRG9tYWlu cyhsaW1pdHNUb0FwcEJvdW5kRG9tYWlucyk7Ci19Ci0KIHN0YXRpYyBfV0tBdHRyaWJ1dGlvbk92 ZXJyaWRlVGVzdGluZyB0b1dLQXR0cmlidXRpb25PdmVycmlkZVRlc3RpbmcoV2ViS2l0OjpBdHRy aWJ1dGlvbk92ZXJyaWRlVGVzdGluZyB2YWx1ZSkKIHsKICAgICBpZiAodmFsdWUgPT0gV2ViS2l0 OjpBdHRyaWJ1dGlvbk92ZXJyaWRlVGVzdGluZzo6QXBwSW5pdGlhdGVkKQo=