230154 2021-09-10 08:29:02 -0700 Avoid GCC warnings introduced in r282125 2021-09-15 13:19:17 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=229892 InRadar P2 Normal --- 1 mcatanzaro mcatanzaro ews-watchlist fujii keith_miller mark.lam mcatanzaro msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1792349 0 mcatanzaro 2021-09-10 08:29:02 -0700 This is a follow-up to bug #229892. It introduced some GCC warnings discussed in https://bugs.webkit.org/show_bug.cgi?id=229892#c23. Let's avoid those. 1792353 1 437874 mcatanzaro 2021-09-10 08:34:54 -0700 Created attachment 437874 Patch 1793470 2 mcatanzaro 2021-09-14 15:29:36 -0700 Ping JSC reviewers! 1793827 3 ews-feeder 2021-09-15 13:18:35 -0700 Committed r282469 (241717@main): <https://commits.webkit.org/241717@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437874. 1793828 4 webkit-bug-importer 2021-09-15 13:19:17 -0700 <rdar://problem/83164939> 437874 2021-09-10 08:34:54 -0700 2021-09-15 13:18:36 -0700 Patch bug-230154-20210910103453.patch text/plain 2529 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyMjU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj MTQ5NTdkODIxOWVlNGIxMWFhYTFmNzk5YWNkYTljYWJmNTA4NWM2Li4wNGE0ZmM1NTU1NDk0MzBk NDM3OTgzNzliY2IxYmQyZTA3MmY5Nzk4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAyMS0wOS0xMCAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGdu b21lLm9yZz4KKworICAgICAgICBBdm9pZCBHQ0Mgd2FybmluZ3MgaW50cm9kdWNlZCBpbiByMjgy MTI1CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzAx NTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBZdXN1 a2Ugc3VnZ2VzdGVkIGNhc3RpbmcgdG8gVUNoYXIgdG8gYXZvaWQgLVdzd2l0Y2gtb3V0LW9mLXJh bmdlLiBUaGlzIHdvcmtzIQorCisgICAgICAgIEFsc28sIGF2b2lkIC1XcmVkdW5kYW50LW1vdmUg YnkgcmVtb3Zpbmcgb25lIHVubmVjZXNzYXJ5IFdURk1vdmUuCisKKyAgICAgICAgKiBydW50aW1l L0lTTzg2MDEuY3BwOgorICAgICAgICAoSlNDOjpJU084NjAxOjpwYXJzZVRpbWVab25lQnJhY2tl dGVkQW5ub3RhdGlvbik6CisgICAgICAgIChKU0M6OklTTzg2MDE6OmNhbkJlVGltZVpvbmUpOgor ICAgICAgICAoSlNDOjpJU084NjAxOjpwYXJzZVRpbWVab25lKToKKwogMjAyMS0wOS0wOSAgRGFy aW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgSW1wcm92ZSBwZXJmb3JtYW5j ZSBieSB1c2luZyBTdHJpbmdWaWV3LCBub3QgImNvbnN0IFN0cmluZ1ZpZXcmIgpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSVNPODYwMS5jcHAgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9JU084NjAxLmNwcAppbmRleCA4MTgxNTc4MDJiOTlmNTg0N2Q0 ZTkzY2Y4ZjRlODE3ZDA2NjA3MDFlLi5lNzJiZjcyNzdiMjJmMzc2NTI5NjRlZjQ0MzY2MTBlOTYz NDMxZDljIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9JU084NjAx LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9JU084NjAxLmNwcApAQCAt NDQ4LDcgKzQ0OCw3IEBAIHN0YXRpYyBzdGQ6Om9wdGlvbmFsPFZhcmlhbnQ8VmVjdG9yPExDaGFy PiwgaW50NjRfdD4+IHBhcnNlVGltZVpvbmVCcmFja2V0ZWRBbm5vCiAgICAgICAgIHJldHVybiBz dGQ6Om51bGxvcHQ7CiAgICAgYnVmZmVyLmFkdmFuY2UoKTsKIAotICAgIHN3aXRjaCAoKmJ1ZmZl cikgeworICAgIHN3aXRjaCAoc3RhdGljX2Nhc3Q8VUNoYXI+KCpidWZmZXIpKSB7CiAgICAgY2Fz ZSAnKyc6CiAgICAgY2FzZSAnLSc6CiAgICAgY2FzZSBtaW51c1NpZ246IHsKQEAgLTU3Niw3ICs1 NzYsNyBAQCBzdGF0aWMgc3RkOjpvcHRpb25hbDxWYXJpYW50PFZlY3RvcjxMQ2hhcj4sIGludDY0 X3Q+PiBwYXJzZVRpbWVab25lQnJhY2tldGVkQW5ubwogICAgICAgICBpZiAoKmJ1ZmZlciAhPSAn XScpCiAgICAgICAgICAgICByZXR1cm4gc3RkOjpudWxsb3B0OwogICAgICAgICBidWZmZXIuYWR2 YW5jZSgpOwotICAgICAgICByZXR1cm4gV1RGTW92ZShyZXN1bHQpOworICAgICAgICByZXR1cm4g cmVzdWx0OwogICAgIH0KICAgICB9CiB9CkBAIC01ODQsNyArNTg0LDcgQEAgc3RhdGljIHN0ZDo6 b3B0aW9uYWw8VmFyaWFudDxWZWN0b3I8TENoYXI+LCBpbnQ2NF90Pj4gcGFyc2VUaW1lWm9uZUJy YWNrZXRlZEFubm8KIHRlbXBsYXRlPHR5cGVuYW1lIENoYXJhY3RlclR5cGU+CiBzdGF0aWMgYm9v bCBjYW5CZVRpbWVab25lKGNvbnN0IFN0cmluZ1BhcnNpbmdCdWZmZXI8Q2hhcmFjdGVyVHlwZT4m IGJ1ZmZlciwgQ2hhcmFjdGVyVHlwZSBjaGFyYWN0ZXIpCiB7Ci0gICAgc3dpdGNoIChjaGFyYWN0 ZXIpIHsKKyAgICBzd2l0Y2ggKHN0YXRpY19jYXN0PFVDaGFyPihjaGFyYWN0ZXIpKSB7CiAgICAg Ly8gVVRDRGVzaWduYXRvcgogICAgIC8vIGh0dHBzOi8vdGMzOS5lcy9wcm9wb3NhbC10ZW1wb3Jh bC8jcHJvZC1VVENEZXNpZ25hdG9yCiAgICAgY2FzZSAneic6CkBAIC02MTUsNyArNjE1LDcgQEAg c3RhdGljIHN0ZDo6b3B0aW9uYWw8VGltZVpvbmVSZWNvcmQ+IHBhcnNlVGltZVpvbmUoU3RyaW5n UGFyc2luZ0J1ZmZlcjxDaGFyYWN0ZXIKIHsKICAgICBpZiAoYnVmZmVyLmF0RW5kKCkpCiAgICAg ICAgIHJldHVybiBzdGQ6Om51bGxvcHQ7Ci0gICAgc3dpdGNoICgqYnVmZmVyKSB7CisgICAgc3dp dGNoIChzdGF0aWNfY2FzdDxVQ2hhcj4oKmJ1ZmZlcikpIHsKICAgICAvLyBVVENEZXNpZ25hdG9y CiAgICAgLy8gaHR0cHM6Ly90YzM5LmVzL3Byb3Bvc2FsLXRlbXBvcmFsLyNwcm9kLVVUQ0Rlc2ln bmF0b3IKICAgICBjYXNlICd6JzoK