230153 2021-09-10 08:27:46 -0700 Web Inspector: Update naming of WI.CSSCompletions callback used for collecting supported CSS properties from the target 2021-09-13 14:41:07 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 rcaliman rcaliman ews-watchlist hi inspector-bugzilla-changes pangle webkit-bug-importer oldest_to_newest 1792347 0 rcaliman 2021-09-10 08:27:46 -0700 `Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js:82` The callback is confusingly named `propertyNamesCallback()` and has a `names` argument. The payload is actually a list of objects with CSS property names, values, aliases, longhands, etc. The constructor of `WI.CSSCompletions` expects and handles this payload. Seems like `WI.CSSCompletions` began life handling just CSS property names, but overtime got overloaded to support additional use cases. For example, `WI.CSSCompletions` ends up having an instance of itself assigned as a property o_O: ``` WI.CSSCompletions.cssNameCompletions = new WI.CSSCompletions(properties, false); ``` There's a bit of confusing ping-pong between `WI.CSSCompletions` and `WI.CSSKeywordCompletions`. But that's a fix for another patch. 1792354 1 437875 rcaliman 2021-09-10 08:35:40 -0700 Created attachment 437875 Patch 1.0 1792395 2 webkit-bug-importer 2021-09-10 09:29:12 -0700 <rdar://problem/82975738> 1792584 3 437875 hi 2021-09-10 16:12:49 -0700 Comment on attachment 437875 Patch 1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=437875&action=review r=me > Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js:88 > + function propertiesCallback(error, properties) NIT: this should really be named `cssProperties` to match what's used in the protocol 1792971 4 438046 rcaliman 2021-09-13 08:59:54 -0700 Created attachment 438046 Patch 1.1 Carry over R+ 1793105 5 ews-feeder 2021-09-13 14:41:05 -0700 Committed r282360 (241623@main): <https://commits.webkit.org/241623@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438046. 437875 2021-09-10 08:35:40 -0700 2021-09-13 08:59:51 -0700 Patch 1.0 bug-230153-20210910173539.patch text/plain 3303 rcaliman ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGY2YTcyNjZhNmE4OTg1MDViNmJmMmJmNGZjMzZm MWQxYTQ5NDMxNzUuLjAwZmNlZTNjYTI2YWNhZjcyZGM4OGI0OGNlM2ZhMzg0ZDgyNmI0M2QgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTA5LTEwICBSYXp2 YW4gQ2FsaW1hbiAgPHJjYWxpbWFuQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBVcGRhdGUgbmFtaW5nIG9mIFdJLkNTU0NvbXBsZXRpb25zIGNhbGxiYWNrIHVzZWQgZm9yIGNv bGxlY3Rpbmcgc3VwcG9ydGVkIENTUyBwcm9wZXJ0aWVzIGZyb20gdGhlIHRhcmdldAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMwMTUzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVuYW1lIGBXSS5DU1ND b21wbGV0aW9ucy5pbml0aWFsaXplQ1NTQ29tcGxldGlvbnMucHJvcGVydHlOYW1lc0NhbGxiYWNr KG5hbWVzKWAgdG8gYHByb3BlcnRpZXNDYWxsYmFjayhwcm9wZXJ0aWVzKWAgCisgICAgICAgIHRv IHJlbW92ZSBjb25mdXNpb24gYWJvdXQgd2hhdCB0aGUgcGF5bG9hZCBhY3R1YWxseSBjb250YWlu czogbm90IGEgbGlzdCBvZiBwcm9wZXJ0eSBuYW1lcywgYnV0IGEgbGlzdCBvZiBvYmplY3RzIHdp dGggCisgICAgICAgIENTUyBwcm9wZXJ0eSBuYW1lcywgdmFsdWVzLCBhbGlhc2VzLCBsb25naGFu ZHMsIGV0Yy4KKworICAgICAgICBUaGUgY29uc3RydWN0b3Igb2YgYFdJLkNTU0NvbXBsZXRpb25z YCBleHBlY3RzIGFuZCBoYW5kbGVzIHRoaXMgcGF5bG9hZC4KKworICAgICAgICAqIFVzZXJJbnRl cmZhY2UvTW9kZWxzL0NTU0NvbXBsZXRpb25zLmpzOgorICAgICAgICAoV0kuQ1NTQ29tcGxldGlv bnMuaW5pdGlhbGl6ZUNTU0NvbXBsZXRpb25zKToKKyAgICAgICAgKFdJLkNTU0NvbXBsZXRpb25z LmluaXRpYWxpemVDU1NDb21wbGV0aW9ucy5wcm9wZXJ0eU5hbWVzQ2FsbGJhY2spOiBEZWxldGVk LgorCiAyMDIxLTA4LTI3ICBSdXNzZWxsIEVwc3RlaW4gIDxyZXBzdGVpbkBhcHBsZS5jb20+CiAK ICAgICAgICAgTGFuZCBXaW5kb3dzIGJ1aWxkIGZpeGVzIGZyb20gc2FmYXJpLTYxMi4xLjI5LjE0 LWJyYW5jaC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L01vZGVscy9DU1NDb21wbGV0aW9ucy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL01vZGVscy9DU1NDb21wbGV0aW9ucy5qcwppbmRleCBkYWMzMDRhMjc0MGQ3ZmNiZDVi Y2ViZjQ2ODc2NTkzMjg4Mjc5OTJlLi45YWJjYmRmMWMwYzg1YTcxYmRkNTc3MzdmY2M2Y2M0MDdi Mjc3Y2VmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9N b2RlbHMvQ1NTQ29tcGxldGlvbnMuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvTW9kZWxzL0NTU0NvbXBsZXRpb25zLmpzCkBAIC04NSwxNCArODUsMTQgQEAgV0ku Q1NTQ29tcGxldGlvbnMgPSBjbGFzcyBDU1NDb21wbGV0aW9ucwogICAgICAgICBpZiAoV0kuQ1NT Q29tcGxldGlvbnMuY3NzTmFtZUNvbXBsZXRpb25zKQogICAgICAgICAgICAgcmV0dXJuOwogCi0g ICAgICAgIGZ1bmN0aW9uIHByb3BlcnR5TmFtZXNDYWxsYmFjayhlcnJvciwgbmFtZXMpCisgICAg ICAgIGZ1bmN0aW9uIHByb3BlcnRpZXNDYWxsYmFjayhlcnJvciwgcHJvcGVydGllcykKICAgICAg ICAgewogICAgICAgICAgICAgaWYgKGVycm9yKQogICAgICAgICAgICAgICAgIHJldHVybjsKIAot ICAgICAgICAgICAgV0kuQ1NTQ29tcGxldGlvbnMuY3NzTmFtZUNvbXBsZXRpb25zID0gbmV3IFdJ LkNTU0NvbXBsZXRpb25zKG5hbWVzLCBmYWxzZSk7CisgICAgICAgICAgICBXSS5DU1NDb21wbGV0 aW9ucy5jc3NOYW1lQ29tcGxldGlvbnMgPSBuZXcgV0kuQ1NTQ29tcGxldGlvbnMocHJvcGVydGll cywgZmFsc2UpOwogCi0gICAgICAgICAgICBXSS5DU1NLZXl3b3JkQ29tcGxldGlvbnMuYWRkQ3Vz dG9tQ29tcGxldGlvbnMobmFtZXMpOworICAgICAgICAgICAgV0kuQ1NTS2V5d29yZENvbXBsZXRp b25zLmFkZEN1c3RvbUNvbXBsZXRpb25zKHByb3BlcnRpZXMpOwogCiAgICAgICAgICAgICAvLyBD b2RlTWlycm9yIGlzIG5vdCBpbmNsdWRlZCBieSB0ZXN0cyBzbyB3ZSBzaG91bGRuJ3QgYXNzdW1l IGl0IGFsd2F5cyBleGlzdHMuCiAgICAgICAgICAgICAvLyBJZiBpdCBpc24ndCBhdmFpbGFibGUg d2Ugc2tpcCBNSU1FIHR5cGUgYXNzb2NpYXRpb25zLgpAQCAtMTE5LDcgKzExOSw3IEBAIFdJLkNT U0NvbXBsZXRpb25zID0gY2xhc3MgQ1NTQ29tcGxldGlvbnMKICAgICAgICAgICAgICAgICB2YWx1 ZUtleXdvcmRzRm9yQ29kZU1pcnJvcltjb2RlTWlycm9yUHJvcGVydHlOYW1lXSA9IHRydWU7CiAg ICAgICAgICAgICB9CiAKLSAgICAgICAgICAgIGZvciAodmFyIHByb3BlcnR5IG9mIG5hbWVzKQor ICAgICAgICAgICAgZm9yICh2YXIgcHJvcGVydHkgb2YgcHJvcGVydGllcykKICAgICAgICAgICAg ICAgICBjb2xsZWN0UHJvcGVydHlOYW1lRm9yQ29kZU1pcnJvcihwcm9wZXJ0eS5uYW1lKTsKIAog ICAgICAgICAgICAgZm9yICh2YXIgcHJvcGVydHlOYW1lIGluIFdJLkNTU0tleXdvcmRDb21wbGV0 aW9ucy5fcHJvcGVydHlLZXl3b3JkTWFwKSB7CkBAIC0xNjQsNyArMTY0LDcgQEAgV0kuQ1NTQ29t cGxldGlvbnMgPSBjbGFzcyBDU1NDb21wbGV0aW9ucwogICAgICAgICAgICAgV0kuQ1NTS2V5d29y ZENvbXBsZXRpb25zLmFkZFByb3BlcnR5Q29tcGxldGlvblZhbHVlcygiZm9udCIsIGZvbnRGYW1p bHlOYW1lcyk7CiAgICAgICAgIH0KIAotICAgICAgICB0YXJnZXQuQ1NTQWdlbnQuZ2V0U3VwcG9y dGVkQ1NTUHJvcGVydGllcyhwcm9wZXJ0eU5hbWVzQ2FsbGJhY2spOworICAgICAgICB0YXJnZXQu Q1NTQWdlbnQuZ2V0U3VwcG9ydGVkQ1NTUHJvcGVydGllcyhwcm9wZXJ0aWVzQ2FsbGJhY2spOwog ICAgICAgICBpZiAodGFyZ2V0Lmhhc0NvbW1hbmQoIkNTUy5nZXRTdXBwb3J0ZWRTeXN0ZW1Gb250 RmFtaWx5TmFtZXMiKSkKICAgICAgICAgICAgIHRhcmdldC5DU1NBZ2VudC5nZXRTdXBwb3J0ZWRT eXN0ZW1Gb250RmFtaWx5TmFtZXMoZm9udEZhbWlseU5hbWVzQ2FsbGJhY2spOwogICAgIH0K 438046 2021-09-13 08:59:54 -0700 2021-09-13 14:41:06 -0700 Patch 1.1 bug-230153-20210913175953.patch text/plain 3313 rcaliman ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGY2YTcyNjZhNmE4OTg1MDViNmJmMmJmNGZjMzZm MWQxYTQ5NDMxNzUuLjcxZjk5YmYwMTEwYTdlYmU1OWEzMGNlNjA2NWI1YTdhOTY4NGIzZDUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTA5LTEwICBSYXp2 YW4gQ2FsaW1hbiAgPHJjYWxpbWFuQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBVcGRhdGUgbmFtaW5nIG9mIFdJLkNTU0NvbXBsZXRpb25zIGNhbGxiYWNrIHVzZWQgZm9yIGNv bGxlY3Rpbmcgc3VwcG9ydGVkIENTUyBwcm9wZXJ0aWVzIGZyb20gdGhlIHRhcmdldAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMwMTUzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgRGV2aW4gUm91c3NvLgorCisgICAgICAgIFJlbmFtZSBgV0kuQ1NTQ29t cGxldGlvbnMuaW5pdGlhbGl6ZUNTU0NvbXBsZXRpb25zLnByb3BlcnR5TmFtZXNDYWxsYmFjayhu YW1lcylgIHRvIGBwcm9wZXJ0aWVzQ2FsbGJhY2socHJvcGVydGllcylgIAorICAgICAgICB0byBy ZW1vdmUgY29uZnVzaW9uIGFib3V0IHdoYXQgdGhlIHBheWxvYWQgYWN0dWFsbHkgY29udGFpbnM6 IG5vdCBhIGxpc3Qgb2YgcHJvcGVydHkgbmFtZXMsIGJ1dCBhIGxpc3Qgb2Ygb2JqZWN0cyB3aXRo IAorICAgICAgICBDU1MgcHJvcGVydHkgbmFtZXMsIHZhbHVlcywgYWxpYXNlcywgbG9uZ2hhbmRz LCBldGMuCisKKyAgICAgICAgVGhlIGNvbnN0cnVjdG9yIG9mIGBXSS5DU1NDb21wbGV0aW9uc2Ag ZXhwZWN0cyBhbmQgaGFuZGxlcyB0aGlzIHBheWxvYWQuCisKKyAgICAgICAgKiBVc2VySW50ZXJm YWNlL01vZGVscy9DU1NDb21wbGV0aW9ucy5qczoKKyAgICAgICAgKFdJLkNTU0NvbXBsZXRpb25z LmluaXRpYWxpemVDU1NDb21wbGV0aW9ucyk6CisgICAgICAgIChXSS5DU1NDb21wbGV0aW9ucy5p bml0aWFsaXplQ1NTQ29tcGxldGlvbnMucHJvcGVydHlOYW1lc0NhbGxiYWNrKTogRGVsZXRlZC4K KwogMjAyMS0wOC0yNyAgUnVzc2VsbCBFcHN0ZWluICA8cmVwc3RlaW5AYXBwbGUuY29tPgogCiAg ICAgICAgIExhbmQgV2luZG93cyBidWlsZCBmaXhlcyBmcm9tIHNhZmFyaS02MTIuMS4yOS4xNC1i cmFuY2guCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9N b2RlbHMvQ1NTQ29tcGxldGlvbnMuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9Nb2RlbHMvQ1NTQ29tcGxldGlvbnMuanMKaW5kZXggZGFjMzA0YTI3NDBkN2ZjYmQ1YmNl YmY0Njg3NjU5MzI4ODI3OTkyZS4uMmExZjhlNGU0MzRhYTE5NzM2NTM5N2MyZDU0OTI0NDJiM2Ew YjExOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9k ZWxzL0NTU0NvbXBsZXRpb25zLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL01vZGVscy9DU1NDb21wbGV0aW9ucy5qcwpAQCAtODUsMTQgKzg1LDE0IEBAIFdJLkNT U0NvbXBsZXRpb25zID0gY2xhc3MgQ1NTQ29tcGxldGlvbnMKICAgICAgICAgaWYgKFdJLkNTU0Nv bXBsZXRpb25zLmNzc05hbWVDb21wbGV0aW9ucykKICAgICAgICAgICAgIHJldHVybjsKIAotICAg ICAgICBmdW5jdGlvbiBwcm9wZXJ0eU5hbWVzQ2FsbGJhY2soZXJyb3IsIG5hbWVzKQorICAgICAg ICBmdW5jdGlvbiBwcm9wZXJ0aWVzQ2FsbGJhY2soZXJyb3IsIGNzc1Byb3BlcnRpZXMpCiAgICAg ICAgIHsKICAgICAgICAgICAgIGlmIChlcnJvcikKICAgICAgICAgICAgICAgICByZXR1cm47CiAK LSAgICAgICAgICAgIFdJLkNTU0NvbXBsZXRpb25zLmNzc05hbWVDb21wbGV0aW9ucyA9IG5ldyBX SS5DU1NDb21wbGV0aW9ucyhuYW1lcywgZmFsc2UpOworICAgICAgICAgICAgV0kuQ1NTQ29tcGxl dGlvbnMuY3NzTmFtZUNvbXBsZXRpb25zID0gbmV3IFdJLkNTU0NvbXBsZXRpb25zKGNzc1Byb3Bl cnRpZXMsIGZhbHNlKTsKIAotICAgICAgICAgICAgV0kuQ1NTS2V5d29yZENvbXBsZXRpb25zLmFk ZEN1c3RvbUNvbXBsZXRpb25zKG5hbWVzKTsKKyAgICAgICAgICAgIFdJLkNTU0tleXdvcmRDb21w bGV0aW9ucy5hZGRDdXN0b21Db21wbGV0aW9ucyhjc3NQcm9wZXJ0aWVzKTsKIAogICAgICAgICAg ICAgLy8gQ29kZU1pcnJvciBpcyBub3QgaW5jbHVkZWQgYnkgdGVzdHMgc28gd2Ugc2hvdWxkbid0 IGFzc3VtZSBpdCBhbHdheXMgZXhpc3RzLgogICAgICAgICAgICAgLy8gSWYgaXQgaXNuJ3QgYXZh aWxhYmxlIHdlIHNraXAgTUlNRSB0eXBlIGFzc29jaWF0aW9ucy4KQEAgLTExOSw3ICsxMTksNyBA QCBXSS5DU1NDb21wbGV0aW9ucyA9IGNsYXNzIENTU0NvbXBsZXRpb25zCiAgICAgICAgICAgICAg ICAgdmFsdWVLZXl3b3Jkc0ZvckNvZGVNaXJyb3JbY29kZU1pcnJvclByb3BlcnR5TmFtZV0gPSB0 cnVlOwogICAgICAgICAgICAgfQogCi0gICAgICAgICAgICBmb3IgKHZhciBwcm9wZXJ0eSBvZiBu YW1lcykKKyAgICAgICAgICAgIGZvciAodmFyIHByb3BlcnR5IG9mIGNzc1Byb3BlcnRpZXMpCiAg ICAgICAgICAgICAgICAgY29sbGVjdFByb3BlcnR5TmFtZUZvckNvZGVNaXJyb3IocHJvcGVydHku bmFtZSk7CiAKICAgICAgICAgICAgIGZvciAodmFyIHByb3BlcnR5TmFtZSBpbiBXSS5DU1NLZXl3 b3JkQ29tcGxldGlvbnMuX3Byb3BlcnR5S2V5d29yZE1hcCkgewpAQCAtMTY0LDcgKzE2NCw3IEBA IFdJLkNTU0NvbXBsZXRpb25zID0gY2xhc3MgQ1NTQ29tcGxldGlvbnMKICAgICAgICAgICAgIFdJ LkNTU0tleXdvcmRDb21wbGV0aW9ucy5hZGRQcm9wZXJ0eUNvbXBsZXRpb25WYWx1ZXMoImZvbnQi LCBmb250RmFtaWx5TmFtZXMpOwogICAgICAgICB9CiAKLSAgICAgICAgdGFyZ2V0LkNTU0FnZW50 LmdldFN1cHBvcnRlZENTU1Byb3BlcnRpZXMocHJvcGVydHlOYW1lc0NhbGxiYWNrKTsKKyAgICAg ICAgdGFyZ2V0LkNTU0FnZW50LmdldFN1cHBvcnRlZENTU1Byb3BlcnRpZXMocHJvcGVydGllc0Nh bGxiYWNrKTsKICAgICAgICAgaWYgKHRhcmdldC5oYXNDb21tYW5kKCJDU1MuZ2V0U3VwcG9ydGVk U3lzdGVtRm9udEZhbWlseU5hbWVzIikpCiAgICAgICAgICAgICB0YXJnZXQuQ1NTQWdlbnQuZ2V0 U3VwcG9ydGVkU3lzdGVtRm9udEZhbWlseU5hbWVzKGZvbnRGYW1pbHlOYW1lc0NhbGxiYWNrKTsK ICAgICB9Cg==