230142 2021-09-09 19:08:37 -0700 Fix the lldb WTF::HashTable summary provider 2021-09-16 19:09:17 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 1 simon.fraser simon.fraser achristensen dbates simon.fraser webkit-bug-importer oldest_to_newest 1792206 0 simon.fraser 2021-09-09 19:08:37 -0700 Fix the lldb WTF::HashTable summary provider 1792207 1 437824 simon.fraser 2021-09-09 19:10:48 -0700 Created attachment 437824 Patch 1792225 2 437824 achristensen 2021-09-09 20:27:24 -0700 Comment on attachment 437824 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437824&action=review Have you run the unit tests for this? EWS doesn't. > Tools/lldb/lldb_webkit.py:-1076 > - table_pointer = self.valobj.GetChildMemberWithName('m_tableForLLDB') Should we also remove m_tableForLLDB from source then? 1792229 3 simon.fraser 2021-09-09 20:41:09 -0700 I think we could remove m_tableForLLDB, yeah. I did test it, and the lldb tests passed (but, oddly, they passed before this change, when the provider was certainly broken for me). 1794306 4 webkit-bug-importer 2021-09-16 19:09:17 -0700 <rdar://problem/83223014> 437824 2021-09-09 19:10:48 -0700 2021-09-10 09:31:43 -0700 Patch bug-230142-20210909191047.patch text/plain 4970 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyMjU0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTI3ODM5MzQ0ZTYxOTdlZjViMzYzYmE5YWIzNTIwODcy NGQwNGNlMC4uYWI4MTgzMDFjYWU5YjUxMDk1NGU2NGNhNDk3NjVhOGViMGYwN2QzYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3 IEBACisyMDIxLTA5LTA5ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgor CisgICAgICAgIEZpeCB0aGUgbGxkYiBXVEY6Okhhc2hUYWJsZSBzdW1tYXJ5IHByb3ZpZGVyCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzAxNDIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgV1RGOjpI YXNoVGFibGUgc3VtbWFyeSBwcm92aWRlciBhbHdheXMgcmV0dXJuZWQgYSB0YWJsZSBzaXplIG9m IDAgYW5kIGEga2V5IGNvdW50IG9mIDAuCisgICAgICAgIEZpeCBpdCB0byBmaW5kIHRoZSB0YWJs ZSB2aWEgbV90YWJsZSAobV90YWJsZUZvckxMREIgZGlkbid0IHNlZW0gdG8gd29yayksIGhhbmRs ZSBhIG51bGwKKyAgICAgICAgdGFibGUsIGFuZCBkbyB0aGUgb2Zmc2V0dGluZyBpbnRvIG1ldGFk YXRhIGNvcnJlY3RseS4KKworICAgICAgICBBbHNvIGFkZCBhIEtleVZhbHVlUGFpcjw+IHByb3Zp ZGVyIHNvIHRoZSBoYXNoIHRhYmxlIGVudHJpZXMgZ2V0IHN1bW1hcml6ZWQuCisKKyAgICAgICAg KiBsbGRiL2xsZGJfd2Via2l0LnB5OgorICAgICAgICAoX19sbGRiX2luaXRfbW9kdWxlKToKKyAg ICAgICAgKFdURktleVZhbHVlUGFpcl9TdW1tYXJ5UHJvdmlkZXIpOgorICAgICAgICAoV1RGS2V5 VmFsdWVQYWlyUHJvdmlkZXIpOgorICAgICAgICAoV1RGS2V5VmFsdWVQYWlyUHJvdmlkZXIuX19p bml0X18pOgorICAgICAgICAoV1RGS2V5VmFsdWVQYWlyUHJvdmlkZXIudXBkYXRlKToKKyAgICAg ICAgKFdURkhhc2hUYWJsZVByb3ZpZGVyKToKKyAgICAgICAgKFdURkhhc2hUYWJsZVByb3ZpZGVy Lm1ldGFkYXRhV2l0aEluZGV4KToKKyAgICAgICAgKFdURkhhc2hUYWJsZVByb3ZpZGVyLnRhYmxl U2l6ZSk6CisgICAgICAgIChXVEZIYXNoVGFibGVQcm92aWRlci5rZXlDb3VudCk6CisKIDIwMjEt MDktMDkgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAg Rml4IHNvbWUgbGxkYiBkYXRhIHByb3ZpZGVyIGlzc3VlcwpkaWZmIC0tZ2l0IGEvVG9vbHMvbGxk Yi9sbGRiX3dlYmtpdC5weSBiL1Rvb2xzL2xsZGIvbGxkYl93ZWJraXQucHkKaW5kZXggMGFhOTJk OTk3N2QxMGUxZjNiYTk3ZDJjMTUyZmRkNTEwZGNlY2E0OS4uMWY4NGIxM2FmYjg3ODk3OThlOWQ5 OTUwYzVhMzFmZTdjZjVkZmMyMSAxMDA2NDQKLS0tIGEvVG9vbHMvbGxkYi9sbGRiX3dlYmtpdC5w eQorKysgYi9Ub29scy9sbGRiL2xsZGJfd2Via2l0LnB5CkBAIC02MSw2ICs2MSw3IEBAIGRlZiBf X2xsZGJfaW5pdF9tb2R1bGUoZGVidWdnZXIsIGRpY3QpOgogICAgIGRlYnVnZ2VyLkhhbmRsZUNv bW1hbmQoJ3R5cGUgc3VtbWFyeSBhZGQgLS1leHBhbmQgLUYgbGxkYl93ZWJraXQuV1RGU3RyaW5n SW1wbF9TdW1tYXJ5UHJvdmlkZXIgV1RGOjpTdHJpbmdJbXBsJykKICAgICBkZWJ1Z2dlci5IYW5k bGVDb21tYW5kKCd0eXBlIHN1bW1hcnkgYWRkIC0tZXhwYW5kIC1GIGxsZGJfd2Via2l0LldURlN0 cmluZ1ZpZXdfU3VtbWFyeVByb3ZpZGVyIFdURjo6U3RyaW5nVmlldycpCiAgICAgZGVidWdnZXIu SGFuZGxlQ29tbWFuZCgndHlwZSBzdW1tYXJ5IGFkZCAtLWV4cGFuZCAtRiBsbGRiX3dlYmtpdC5X VEZBdG9tU3RyaW5nX1N1bW1hcnlQcm92aWRlciBXVEY6OkF0b21TdHJpbmcnKQorICAgIGRlYnVn Z2VyLkhhbmRsZUNvbW1hbmQoJ3R5cGUgc3VtbWFyeSBhZGQgLS1leHBhbmQgLUYgbGxkYl93ZWJr aXQuV1RGS2V5VmFsdWVQYWlyX1N1bW1hcnlQcm92aWRlciAteCAiXldURjo6S2V5VmFsdWVQYWly PC4rPiQiJykKICAgICBkZWJ1Z2dlci5IYW5kbGVDb21tYW5kKCd0eXBlIHN1bW1hcnkgYWRkIC0t ZXhwYW5kIC1GIGxsZGJfd2Via2l0LldURlZlY3Rvcl9TdW1tYXJ5UHJvdmlkZXIgLXggIl5XVEY6 OlZlY3RvcjwuKz4kIicpCiAgICAgZGVidWdnZXIuSGFuZGxlQ29tbWFuZCgndHlwZSBzdW1tYXJ5 IGFkZCAtLWV4cGFuZCAtRiBsbGRiX3dlYmtpdC5XVEZIYXNoVGFibGVfU3VtbWFyeVByb3ZpZGVy IC14ICJeV1RGOjpIYXNoVGFibGU8Lis+JCInKQogICAgIGRlYnVnZ2VyLkhhbmRsZUNvbW1hbmQo J3R5cGUgc3VtbWFyeSBhZGQgLS1leHBhbmQgLUYgbGxkYl93ZWJraXQuV1RGSGFzaE1hcF9TdW1t YXJ5UHJvdmlkZXIgLXggIl5XVEY6Okhhc2hNYXA8Lis+JCInKQpAQCAtMTQ0LDYgKzE0NSwxMSBA QCBkZWYgV1RGQXRvbVN0cmluZ19TdW1tYXJ5UHJvdmlkZXIodmFsb2JqLCBkaWN0KToKICAgICBy ZXR1cm4gV1RGU3RyaW5nX1N1bW1hcnlQcm92aWRlcih2YWxvYmouR2V0Q2hpbGRNZW1iZXJXaXRo TmFtZSgnbV9zdHJpbmcnKSwgZGljdCkKIAogCitkZWYgV1RGS2V5VmFsdWVQYWlyX1N1bW1hcnlQ cm92aWRlcih2YWxvYmosIGRpY3QpOgorICAgIHByb3ZpZGVyID0gV1RGS2V5VmFsdWVQYWlyUHJv dmlkZXIodmFsb2JqLCBkaWN0KQorICAgIHJldHVybiAieyBrZXkgPSAlcywgdmFsdWUgPSAlcyB9 IiAlIChwcm92aWRlci5rZXksIHByb3ZpZGVyLnZhbHVlKQorCisKIGRlZiBXVEZWZWN0b3JfU3Vt bWFyeVByb3ZpZGVyKHZhbG9iaiwgZGljdCk6CiAgICAgcHJvdmlkZXIgPSBXVEZWZWN0b3JQcm92 aWRlcih2YWxvYmosIGRpY3QpCiAgICAgcmV0dXJuICJ7IHNpemUgPSAlZCwgY2FwYWNpdHkgPSAl ZCB9IiAlIChwcm92aWRlci5zaXplLCBwcm92aWRlci5jYXBhY2l0eSkKQEAgLTk5OCw2ICsxMDA0 LDE2IEBAIGNsYXNzIFdURkNvbXBhY3RQb2ludGVyVHVwbGVQcm92aWRlcihvYmplY3QpOgogICAg ICAgICAgICAgc2VsZi5fdHlwZSA9IHNlbGYudmFsb2JqLkNyZWF0ZVZhbHVlRnJvbURhdGEoJ1sx XScsIHR5cGVfZGF0YSwgdHlwZV90b191c2UpCiAKIAorY2xhc3MgV1RGS2V5VmFsdWVQYWlyUHJv dmlkZXI6CisgICAgZGVmIF9faW5pdF9fKHNlbGYsIHZhbG9iaiwgaW50ZXJuYWxfZGljdCk6Cisg ICAgICAgIHNlbGYudmFsb2JqID0gdmFsb2JqCisgICAgICAgIHNlbGYudXBkYXRlKCkKKworICAg IGRlZiB1cGRhdGUoc2VsZik6CisgICAgICAgIHNlbGYua2V5ID0gc2VsZi52YWxvYmouR2V0Q2hp bGRNZW1iZXJXaXRoTmFtZSgna2V5JykKKyAgICAgICAgc2VsZi52YWx1ZSA9IHNlbGYudmFsb2Jq LkdldENoaWxkTWVtYmVyV2l0aE5hbWUoJ3ZhbHVlJykKKworCiBjbGFzcyBXVEZWZWN0b3JQcm92 aWRlcjoKICAgICBkZWYgX19pbml0X18oc2VsZiwgdmFsb2JqLCBpbnRlcm5hbF9kaWN0KToKICAg ICAgICAgc2VsZi52YWxvYmogPSB2YWxvYmoKQEAgLTEwNjgsMjMgKzEwODQsMjYgQEAgY2xhc3Mg V1RGSGFzaFNldFByb3ZpZGVyOgogCiAKIGNsYXNzIFdURkhhc2hUYWJsZVByb3ZpZGVyOgorICAg IFRBQkxFX1NJWkVfT0ZGU0VUID0gLTEKKyAgICBLRVlfQ09VTlRfT0ZGU0VUID0gLTMKICAgICBk ZWYgX19pbml0X18oc2VsZiwgdmFsb2JqLCBpbnRlcm5hbF9kaWN0KToKICAgICAgICAgc2VsZi52 YWxvYmogPSB2YWxvYmoKICAgICAgICAgc2VsZi51cGRhdGUoKQogCiAgICAgZGVmIG1ldGFkYXRh V2l0aEluZGV4KHNlbGYsIGluZGV4KToKLSAgICAgICAgdGFibGVfcG9pbnRlciA9IHNlbGYudmFs b2JqLkdldENoaWxkTWVtYmVyV2l0aE5hbWUoJ21fdGFibGVGb3JMTERCJykKKyAgICAgICAgdGFi bGVfcG9pbnRlciA9IHNlbGYudmFsb2JqLkdldENoaWxkTWVtYmVyV2l0aE5hbWUoJ21fdGFibGUn KQorICAgICAgICBpZiBub3QgdGFibGVfcG9pbnRlcjoKKyAgICAgICAgICAgIHJldHVybiAwCisK ICAgICAgICAgbWV0YWRhdGFfcG9pbnRlciA9IHRhYmxlX3BvaW50ZXIuR2V0VmFsdWVBc1Vuc2ln bmVkKCkgKyA0ICogaW5kZXgKLSAgICAgICAgYnl0ZV9vcmRlciA9IHNlbGYudmFsb2JqLkdldFRh cmdldCgpLkdldEJ5dGVPcmRlcigpCi0gICAgICAgIGFkZHJlc3NfYnl0ZV9zaXplID0gc2VsZi52 YWxvYmouR2V0VGFyZ2V0KCkuR2V0QWRkcmVzc0J5dGVTaXplKCkKLSAgICAgICAgcG9pbnRlcl9k YXRhID0gbGxkYi5TQkRhdGEuQ3JlYXRlRGF0YUZyb21VSW50NjRBcnJheShieXRlX29yZGVyLCBh ZGRyZXNzX2J5dGVfc2l6ZSwgW21ldGFkYXRhX3BvaW50ZXJdKQotICAgICAgICByZXR1cm4gc2Vs Zi52YWxvYmouQ3JlYXRlVmFsdWVGcm9tRGF0YSgnWzBdJywgcG9pbnRlcl9kYXRhLCB0YWJsZV9w b2ludGVyLkdldFR5cGUoKSkuRGVyZWZlcmVuY2UoKS5HZXRWYWx1ZUFzVW5zaWduZWQoKQorICAg ICAgICB1bnNpZ25lZF90eXBlID0gc2VsZi52YWxvYmouR2V0VGFyZ2V0KCkuRmluZEZpcnN0VHlw ZSgndW5zaWduZWQnKQorICAgICAgICByZXR1cm4gc2VsZi52YWxvYmouQ3JlYXRlVmFsdWVGcm9t QWRkcmVzcygnWzBdJywgbWV0YWRhdGFfcG9pbnRlciwgdW5zaWduZWRfdHlwZSkuR2V0VmFsdWVB c1Vuc2lnbmVkKCkKIAogICAgIGRlZiB0YWJsZVNpemUoc2VsZik6Ci0gICAgICAgIHJldHVybiBz ZWxmLm1ldGFkYXRhV2l0aEluZGV4KC0xKQorICAgICAgICByZXR1cm4gc2VsZi5tZXRhZGF0YVdp dGhJbmRleChzZWxmLlRBQkxFX1NJWkVfT0ZGU0VUKQogCiAgICAgZGVmIGtleUNvdW50KHNlbGYp OgotICAgICAgICByZXR1cm4gc2VsZi5tZXRhZGF0YVdpdGhJbmRleCgtMykKKyAgICAgICAgcmV0 dXJuIHNlbGYubWV0YWRhdGFXaXRoSW5kZXgoc2VsZi5LRVlfQ09VTlRfT0ZGU0VUKQogCiAgICAg IyBTeW50aGV0aWMgY2hpbGRyZW4gcHJvdmlkZXIgbWV0aG9kcy4KICAgICBkZWYgbnVtX2NoaWxk cmVuKHNlbGYpOgo=