230119 2021-09-09 12:49:45 -0700 FontFaceSet's iterators skip items when previous items are removed 2022-09-12 15:09:25 -0700 1 1 1 Unclassified WebKit Text WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 1 mmaxfield mmaxfield ahmad.saleem792 mmaxfield simon.fraser webkit-bug-importer zalan oldest_to_newest 1792035 0 mmaxfield 2021-09-09 12:49:45 -0700 User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.0 Safari/605.1.15 Steps to reproduce: Iterate across a FontFaceSet. When the iterator is halfway through, delete an element from the first half. Then continue iterating. FontFaceSet is Setlike, and JS's set delete functionality is specified as: > Replace the element of entries whose value is e with an element whose value is empty. The purpose of this is to make iterators not skip over items when items are deleted during iteration. 1792036 1 mmaxfield 2021-09-09 12:50:13 -0700 I opened the same bug on Gecko here: https://bugzilla.mozilla.org/show_bug.cgi?id=1729997 1792037 2 mmaxfield 2021-09-09 12:50:43 -0700 WebKit doesn't actually use setlike<FontFace> inside the IDL for FontFaceSet. Migrating to that might fix this. 1792038 3 437769 mmaxfield 2021-09-09 12:51:37 -0700 Created attachment 437769 Test 1792039 4 437770 mmaxfield 2021-09-09 12:52:28 -0700 Created attachment 437770 Highlight API test I also tested the Highlight API (which also uses setlike) and it behaves correctly here. 1792040 5 webkit-bug-importer 2021-09-09 12:53:15 -0700 <rdar://problem/82939287> 1898031 6 ahmad.saleem792 2022-09-12 15:09:10 -0700 *** Safari 16 / STP 153 on macOS 12.6 *** A , A , C - Using "Test" *** Firefox Nightly 106 *** A , A , C - Using "Test" *** Chrome Canary 107 *** A , A , B - Using "Test" _____________ *** Safari 16 / STP 153 on macOS 12.6 *** Just 'Hello' in body but no dialog box - Using "API" test *** Firefox Nightly 106 *** Just 'Hello' in body but no dialog box - Using "API" test *** Chrome Canary 107 *** Just 'Hello' in body but 1 , 1 , 2 dialog alerts - Using "API" test ____ Just wanted to share updated testing results. Thanks! 437769 2021-09-09 12:51:37 -0700 2021-09-09 12:51:37 -0700 Test file.html text/html 529 mmaxfield PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KPC9oZWFkPgo8Ym9keT4KPHNjcmlwdD4KbGV0 IGZvbnRzID0gZG9jdW1lbnQuZm9udHM7CmxldCBhID0gbmV3IEZvbnRGYWNlKCJBIiwgInVybCgn TXlGb250LnR0ZicpIGZvcm1hdCgndHJ1ZXR5cGUnKSIpOwpsZXQgYiA9IG5ldyBGb250RmFjZSgi QiIsICJ1cmwoJ015Rm9udC50dGYnKSBmb3JtYXQoJ3RydWV0eXBlJykiKTsKbGV0IGMgPSBuZXcg Rm9udEZhY2UoIkMiLCAidXJsKCdNeUZvbnQudHRmJykgZm9ybWF0KCd0cnVldHlwZScpIik7CmZv bnRzLmFkZChhKTsKZm9udHMuYWRkKGIpOwpmb250cy5hZGQoYyk7CmxldCBpdGVyYXRvciA9IGZv bnRzLnZhbHVlcygpOwp2YXIgaXRlbSA9IGl0ZXJhdG9yLm5leHQoKTsKYWxlcnQoaXRlbS52YWx1 ZS5mYW1pbHkpOwpmb250cy5kZWxldGUoYSk7CmFsZXJ0KGl0ZW0udmFsdWUuZmFtaWx5KTsKaXRl bSA9IGl0ZXJhdG9yLm5leHQoKTsKYWxlcnQoaXRlbS52YWx1ZS5mYW1pbHkpOwo8L3NjcmlwdD4K PC9ib2R5Pgo8L2h0bWw+Cg== 437770 2021-09-09 12:52:28 -0700 2021-09-09 12:52:28 -0700 Highlight API test test.html text/html 708 mmaxfield PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KPC9oZWFkPgo8Ym9keT4KSGVsbG8KPHNjcmlw dD4KbGV0IGEgPSBuZXcgU3RhdGljUmFuZ2Uoe3N0YXJ0Q29udGFpbmVyOiBkb2N1bWVudC5ib2R5 LCBzdGFydE9mZnNldDogMSwgZW5kQ29udGFpbmVyOiBkb2N1bWVudC5ib2R5LCBlbmRPZmZzZXQ6 IDJ9KTsKbGV0IGIgPSBuZXcgU3RhdGljUmFuZ2Uoe3N0YXJ0Q29udGFpbmVyOiBkb2N1bWVudC5i b2R5LCBzdGFydE9mZnNldDogMiwgZW5kQ29udGFpbmVyOiBkb2N1bWVudC5ib2R5LCBlbmRPZmZz ZXQ6IDN9KTsKbGV0IGMgPSBuZXcgU3RhdGljUmFuZ2Uoe3N0YXJ0Q29udGFpbmVyOiBkb2N1bWVu dC5ib2R5LCBzdGFydE9mZnNldDogMywgZW5kQ29udGFpbmVyOiBkb2N1bWVudC5ib2R5LCBlbmRP ZmZzZXQ6IDR9KTsKbGV0IGhpZ2hsaWdodCA9IG5ldyBIaWdobGlnaHQoYSk7CmhpZ2hsaWdodC5h ZGQoYik7CmhpZ2hsaWdodC5hZGQoYyk7CmxldCBpdGVyYXRvciA9IGhpZ2hsaWdodC52YWx1ZXMo KTsKdmFyIGl0ZW0gPSBpdGVyYXRvci5uZXh0KCk7CmFsZXJ0KGl0ZW0udmFsdWUuc3RhcnRPZmZz ZXQpOwpoaWdobGlnaHQuZGVsZXRlKGEpOwphbGVydChpdGVtLnZhbHVlLnN0YXJ0T2Zmc2V0KTsK aXRlbSA9IGl0ZXJhdG9yLm5leHQoKTsKYWxlcnQoaXRlbS52YWx1ZS5zdGFydE9mZnNldCk7Cjwv c2NyaXB0Pgo8L2JvZHk+CjwvaHRtbD4K