230104 2021-09-09 09:31:21 -0700 [build.webkit.org] Only display filtered build logs 2022-04-13 04:38:36 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified ASSIGNED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap darin dewei_zhu jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1791930 0 aakash_jain 2021-09-09 09:31:21 -0700 Only display filtered build logs for build.webkit.org using filter-build-webkit script. This would also help in keeping the buildbot instance speedy. 1791931 1 aakash_jain 2021-09-09 09:31:42 -0700 Similar to rdar://82628702 1791935 2 437752 aakash_jain 2021-09-09 09:40:48 -0700 Created attachment 437752 Patch 1791939 3 aakash_jain 2021-09-09 09:41:36 -0700 Sample run: https://build.webkit-dev.org/#/builders/49/builds/5 1791958 4 437752 darin 2021-09-09 10:21:09 -0700 Comment on attachment 437752 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437752&action=review > Tools/CISupport/build-webkit-org/steps_unittest.py:423 > + command='perl ./Tools/Scripts/build-webkit --release --prefix=/app/webkit/WebKitBuild/Release/install --gtk | Tools/Scripts/filter-build-webkit', Why are we using a "./" prefix for build-webkit but not for filter-build-webkit? I think it should be used in both cases, since we don’t want $PATH involved. 1791967 5 437752 aakash_jain 2021-09-09 10:33:07 -0700 Comment on attachment 437752 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437752&action=review >> Tools/CISupport/build-webkit-org/steps_unittest.py:423 >> + command='perl ./Tools/Scripts/build-webkit --release --prefix=/app/webkit/WebKitBuild/Release/install --gtk | Tools/Scripts/filter-build-webkit', > > Why are we using a "./" prefix for build-webkit but not for filter-build-webkit? I think it should be used in both cases, since we don’t want $PATH involved. No specific reason apart from "./" being in this configuration from past. Most of our recent buildbot configuration doesn't have "./". This should work without $PATH being involved, as it's still relative path from current directory. 1791971 6 aakash_jain 2021-09-09 10:34:52 -0700 Alexey and Ryan don't think it's a good idea since we might need full logs in certain circumstances. Will skip it for now, until we have another way to get full logs when required. 1791982 7 437752 darin 2021-09-09 10:44:43 -0700 Comment on attachment 437752 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437752&action=review >>> Tools/CISupport/build-webkit-org/steps_unittest.py:423 >>> + command='perl ./Tools/Scripts/build-webkit --release --prefix=/app/webkit/WebKitBuild/Release/install --gtk | Tools/Scripts/filter-build-webkit', >> >> Why are we using a "./" prefix for build-webkit but not for filter-build-webkit? I think it should be used in both cases, since we don’t want $PATH involved. > > No specific reason apart from "./" being in this configuration from past. Most of our recent buildbot configuration doesn't have "./". This should work without $PATH being involved, as it's still relative path from current directory. I think you misunderstood my point. I was talking about relying on $PATH to find the script, bur rather the inverse. Typically the reason one would specify "./" is to make sure that a similarly named script in $PATH does not get used by accident, to avoid unwanted $PATH. But of course the chances that there is another "Tools/Scripts/filter-build-webkit" are so small it’s not a practical concern. I know you’re not planning on landing the patch, so not important. But generally we want to be consistent. 1791993 8 aakash_jain 2021-09-09 11:01:29 -0700 (In reply to Darin Adler from comment #7) > I think you misunderstood my point. I was talking about relying on $PATH to find the script, bur rather the inverse. Typically the reason one would specify "./" is to make sure that a similarly named script in $PATH does not get used by accident, to avoid unwanted $PATH. But of course the chances that there is another "Tools/Scripts/filter-build-webkit" are so small it’s not a practical concern. ok, got it. Agree that the chances of having another "Tools/Scripts/filter-build-webkit" in $PATH are very small. 1792429 9 ap 2021-09-10 10:20:56 -0700 Is PATH actually involved when shell looks for the tool? E.g. this fails even though jsc-stress-test-helpers is a directory in Tools/Scripts, and that is in my PATH. $ jsc-stress-test-helpers/bytecode-cache-test-helper.sh -bash: jsc-stress-test-helpers/bytecode-cache-test-helper.sh: No such file or directory So I think that "./" is only relevant when there isn't any path specified in the invocation. Agreed that we should target a consistent style. 1792459 10 darin 2021-09-10 11:28:05 -0700 (In reply to Alexey Proskuryakov from comment #9) > So I think that "./" is only relevant when there isn't any path specified in > the invocation. Oh, OK my mistake. Didn't realize the path wasn’t involved in that case. I think the old use of "./" here is mysterious, then. Seems like perl probably doesn’t need that "./". Not important, just peculiar. 1792480 11 aakash_jain 2021-09-10 12:08:25 -0700 Removing the old "./" in Bug 230165 to make build.webkit.org configuration consistent with EWS. 1861076 12 webkit-bug-importer 2022-04-13 04:28:04 -0700 <rdar://problem/91681929> 437752 2021-09-09 09:40:48 -0700 2021-09-09 10:21:09 -0700 Patch bug-230104-20210909124047.patch text/plain 4282 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI4MjIxNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIxLTA5LTA5ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbYnVpbGQud2Via2l0Lm9yZ10gT25seSBkaXNwbGF5IGZpbHRlcmVkIGJ1 aWxkIGxvZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIzMDEwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogQ0lTdXBwb3J0L2J1aWxkLXdlYmtpdC1vcmcvc3RlcHMucHk6CisgICAgICAgIChDb21waWxl V2ViS2l0LnN0YXJ0KToKKyAgICAgICAgKiBDSVN1cHBvcnQvYnVpbGQtd2Via2l0LW9yZy9zdGVw c191bml0dGVzdC5weTogVXBkYXRlZCB1bml0LXRlc3RzLgorCiAyMDIxLTA5LTA5ICBBYWthc2gg SmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBSdW4gY2hlY2stZ2l0aHVi LW1pcnJvci1pbnRlZ3JpdHkgbW9yZSBmcmVxdWVudGx5CkluZGV4OiBUb29scy9DSVN1cHBvcnQv YnVpbGQtd2Via2l0LW9yZy9zdGVwcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DSVN1cHBvcnQv YnVpbGQtd2Via2l0LW9yZy9zdGVwcy5weQkocmV2aXNpb24gMjgyMjE3KQorKysgVG9vbHMvQ0lT dXBwb3J0L2J1aWxkLXdlYmtpdC1vcmcvc3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTI5NCw2 ICsyOTQsOCBAQCBjbGFzcyBDb21waWxlV2ViS2l0KHNoZWxsLkNvbXBpbGUpOgogCiAgICAgICAg IGFwcGVuZEN1c3RvbUJ1aWxkRmxhZ3Moc2VsZiwgcGxhdGZvcm0sIHNlbGYuZ2V0UHJvcGVydHko J2Z1bGxQbGF0Zm9ybScpKQogCisgICAgICAgIHNlbGYuc2V0Q29tbWFuZCgnICcuam9pbihzZWxm LmNvbW1hbmQpICsgJyB8IFRvb2xzL1NjcmlwdHMvZmlsdGVyLWJ1aWxkLXdlYmtpdCcpCisKICAg ICAgICAgcmV0dXJuIHNoZWxsLkNvbXBpbGUuc3RhcnQoc2VsZikKIAogICAgIGRlZiBwYXJzZU91 dHB1dExpbmUoc2VsZiwgbGluZSk6CkluZGV4OiBUb29scy9DSVN1cHBvcnQvYnVpbGQtd2Via2l0 LW9yZy9zdGVwc191bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DSVN1cHBvcnQvYnVp bGQtd2Via2l0LW9yZy9zdGVwc191bml0dGVzdC5weQkocmV2aXNpb24gMjgyMjE3KQorKysgVG9v bHMvQ0lTdXBwb3J0L2J1aWxkLXdlYmtpdC1vcmcvc3RlcHNfdW5pdHRlc3QucHkJKHdvcmtpbmcg Y29weSkKQEAgLTQwNCw3ICs0MDQsNyBAQCBjbGFzcyBUZXN0Q29tcGlsZVdlYktpdChCdWlsZFN0 ZXBNaXhpbkFkCiAgICAgICAgICAgICAgICAgd29ya2Rpcj0nd2tkaXInLAogICAgICAgICAgICAg ICAgIHRpbWVvdXQ9MTIwMCwKICAgICAgICAgICAgICAgICBsb2dFbnZpcm9uPVRydWUsCi0gICAg ICAgICAgICAgICAgY29tbWFuZD1bJ3BlcmwnLCAnLi9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtp dCcsICctLXJlbGVhc2UnXSwKKyAgICAgICAgICAgICAgICBjb21tYW5kPSdwZXJsIC4vVG9vbHMv U2NyaXB0cy9idWlsZC13ZWJraXQgLS1yZWxlYXNlIHwgVG9vbHMvU2NyaXB0cy9maWx0ZXItYnVp bGQtd2Via2l0JywKICAgICAgICAgICAgICkgKyAwLAogICAgICAgICApCiAgICAgICAgIHNlbGYu ZXhwZWN0T3V0Y29tZShyZXN1bHQ9U1VDQ0VTUywgc3RhdGVfc3RyaW5nPSdjb21waWxlZCcpCkBA IC00MjAsNyArNDIwLDcgQEAgY2xhc3MgVGVzdENvbXBpbGVXZWJLaXQoQnVpbGRTdGVwTWl4aW5B ZAogICAgICAgICAgICAgICAgIHdvcmtkaXI9J3drZGlyJywKICAgICAgICAgICAgICAgICB0aW1l b3V0PTEyMDAsCiAgICAgICAgICAgICAgICAgbG9nRW52aXJvbj1UcnVlLAotICAgICAgICAgICAg ICAgIGNvbW1hbmQ9WydwZXJsJywgJy4vVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQnLCAnLS1y ZWxlYXNlJywgJy0tcHJlZml4PS9hcHAvd2Via2l0L1dlYktpdEJ1aWxkL1JlbGVhc2UvaW5zdGFs bCcsICctLWd0ayddLAorICAgICAgICAgICAgICAgIGNvbW1hbmQ9J3BlcmwgLi9Ub29scy9TY3Jp cHRzL2J1aWxkLXdlYmtpdCAtLXJlbGVhc2UgLS1wcmVmaXg9L2FwcC93ZWJraXQvV2ViS2l0QnVp bGQvUmVsZWFzZS9pbnN0YWxsIC0tZ3RrIHwgVG9vbHMvU2NyaXB0cy9maWx0ZXItYnVpbGQtd2Vi a2l0JywKICAgICAgICAgICAgICkgKyAwLAogICAgICAgICApCiAgICAgICAgIHNlbGYuZXhwZWN0 T3V0Y29tZShyZXN1bHQ9U1VDQ0VTUywgc3RhdGVfc3RyaW5nPSdjb21waWxlZCcpCkBAIC00MzYs NyArNDM2LDcgQEAgY2xhc3MgVGVzdENvbXBpbGVXZWJLaXQoQnVpbGRTdGVwTWl4aW5BZAogICAg ICAgICAgICAgICAgIHdvcmtkaXI9J3drZGlyJywKICAgICAgICAgICAgICAgICB0aW1lb3V0PTEy MDAsCiAgICAgICAgICAgICAgICAgbG9nRW52aXJvbj1UcnVlLAotICAgICAgICAgICAgICAgIGNv bW1hbmQ9WydwZXJsJywgJy4vVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQnLCAnLS1yZWxlYXNl JywgJy0td3BlJ10sCisgICAgICAgICAgICAgICAgY29tbWFuZD0ncGVybCAuL1Rvb2xzL1Njcmlw dHMvYnVpbGQtd2Via2l0IC0tcmVsZWFzZSAtLXdwZSB8IFRvb2xzL1NjcmlwdHMvZmlsdGVyLWJ1 aWxkLXdlYmtpdCcsCiAgICAgICAgICAgICApICsgMCwKICAgICAgICAgKQogICAgICAgICBzZWxm LmV4cGVjdE91dGNvbWUocmVzdWx0PVNVQ0NFU1MsIHN0YXRlX3N0cmluZz0nY29tcGlsZWQnKQpA QCAtNDUxLDcgKzQ1MSw3IEBAIGNsYXNzIFRlc3RDb21waWxlV2ViS2l0KEJ1aWxkU3RlcE1peGlu QWQKICAgICAgICAgICAgICAgICB3b3JrZGlyPSd3a2RpcicsCiAgICAgICAgICAgICAgICAgdGlt ZW91dD0xMjAwLAogICAgICAgICAgICAgICAgIGxvZ0Vudmlyb249VHJ1ZSwKLSAgICAgICAgICAg ICAgICBjb21tYW5kPVsncGVybCcsICcuL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0JywgJy0t ZGVidWcnXSwKKyAgICAgICAgICAgICAgICBjb21tYW5kPSdwZXJsIC4vVG9vbHMvU2NyaXB0cy9i dWlsZC13ZWJraXQgLS1kZWJ1ZyB8IFRvb2xzL1NjcmlwdHMvZmlsdGVyLWJ1aWxkLXdlYmtpdCcs CiAgICAgICAgICAgICApICsgMgogICAgICAgICAgICAgKyBFeHBlY3RTaGVsbC5sb2coJ3N0ZGlv Jywgc3Rkb3V0PScxIGVycm9yIGdlbmVyYXRlZC4nKSwKICAgICAgICAgKQpAQCAtNDc2LDcgKzQ3 Niw3IEBAIGNsYXNzIFRlc3RDb21waWxlSlNDT25seShCdWlsZFN0ZXBNaXhpbkEKICAgICAgICAg ICAgICAgICB3b3JrZGlyPSd3a2RpcicsCiAgICAgICAgICAgICAgICAgdGltZW91dD0xMjAwLAog ICAgICAgICAgICAgICAgIGxvZ0Vudmlyb249VHJ1ZSwKLSAgICAgICAgICAgICAgICBjb21tYW5k PVsncGVybCcsICcuL1Rvb2xzL1NjcmlwdHMvYnVpbGQtanNjJywgJy0tcmVsZWFzZSddLAorICAg ICAgICAgICAgICAgIGNvbW1hbmQ9J3BlcmwgLi9Ub29scy9TY3JpcHRzL2J1aWxkLWpzYyAtLXJl bGVhc2UgfCBUb29scy9TY3JpcHRzL2ZpbHRlci1idWlsZC13ZWJraXQnLAogICAgICAgICAgICAg KSArIDAsCiAgICAgICAgICkKICAgICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1TVUND RVNTLCBzdGF0ZV9zdHJpbmc9J2NvbXBpbGVkJykKQEAgLTQ5MCw3ICs0OTAsNyBAQCBjbGFzcyBU ZXN0Q29tcGlsZUpTQ09ubHkoQnVpbGRTdGVwTWl4aW5BCiAgICAgICAgICAgICBFeHBlY3RTaGVs bCgKICAgICAgICAgICAgICAgICB3b3JrZGlyPSd3a2RpcicsCiAgICAgICAgICAgICAgICAgbG9n RW52aXJvbj1UcnVlLAotICAgICAgICAgICAgICAgIGNvbW1hbmQ9WydwZXJsJywgJy4vVG9vbHMv U2NyaXB0cy9idWlsZC1qc2MnLCAnLS1kZWJ1ZyddLAorICAgICAgICAgICAgICAgIGNvbW1hbmQ9 J3BlcmwgLi9Ub29scy9TY3JpcHRzL2J1aWxkLWpzYyAtLWRlYnVnIHwgVG9vbHMvU2NyaXB0cy9m aWx0ZXItYnVpbGQtd2Via2l0JywKICAgICAgICAgICAgICkgKyAyCiAgICAgICAgICAgICArIEV4 cGVjdFNoZWxsLmxvZygnc3RkaW8nLCBzdGRvdXQ9JzEgZXJyb3IgZ2VuZXJhdGVkLicpLAogICAg ICAgICApCg==