230022 2021-09-07 13:54:52 -0700 Remove unneeded call on startup of WebContent process 2021-09-08 10:31:06 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham darin webkit-bug-importer oldest_to_newest 1791206 0 pvollan 2021-09-07 13:54:52 -0700 There is no need to call CGSShutdownServerConnections during startup of the WebContent process on macOS, since we already have asserted that there are no open connections at this point. 1791208 1 webkit-bug-importer 2021-09-07 13:55:32 -0700 <rdar://problem/82838000> 1791212 2 437554 pvollan 2021-09-07 14:01:46 -0700 Created attachment 437554 Patch 1791214 3 437554 darin 2021-09-07 14:07:24 -0700 Comment on attachment 437554 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437554&action=review > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:-636 > - // Make sure that we close any WindowServer connections after checking in with Launch Services. > - CGSShutdownServerConnections(); Can we also take this out of CoreGraphicsSPI.h? 1791216 4 pvollan 2021-09-07 14:10:29 -0700 (In reply to Darin Adler from comment #3) > Comment on attachment 437554 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=437554&action=review > > > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:-636 > > - // Make sure that we close any WindowServer connections after checking in with Launch Services. > > - CGSShutdownServerConnections(); > > Can we also take this out of CoreGraphicsSPI.h? Yes, that's a good point, will fix. Thanks for reviewing! 1791244 5 437564 pvollan 2021-09-07 15:34:44 -0700 Created attachment 437564 Patch 1791533 6 ews-feeder 2021-09-08 10:31:04 -0700 Committed r282157 (241449@main): <https://commits.webkit.org/241449@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437564. 437554 2021-09-07 14:01:46 -0700 2021-09-07 14:07:24 -0700 Patch bug-230022-20210907140135.patch text/plain 1699 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyODIxMDUpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA5LTA3ICBQZXIgQXJuZSAg PHB2b2xsYW5AYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSB1bm5lZWRlZCBjYWxsIG9uIHN0 YXJ0dXAgb2YgV2ViQ29udGVudCBwcm9jZXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMzAwMjIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzgyODM4 MDAwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZXJlIGlzIG5vIG5lZWQgdG8gY2FsbCBDR1NTaHV0ZG93blNlcnZlckNvbm5lY3Rpb25zIGR1cmlu ZyBzdGFydHVwIG9mIHRoZSBXZWJDb250ZW50IHByb2Nlc3Mgb24gbWFjT1MsCisgICAgICAgIHNp bmNlIHdlIGFscmVhZHkgaGF2ZSBhc3NlcnRlZCB0aGF0IHRoZXJlIGFyZSBubyBvcGVuIGNvbm5l Y3Rpb25zIGF0IHRoaXMgcG9pbnQuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL2NvY29hL1dlYlBy b2Nlc3NDb2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6cGxhdGZvcm1Jbml0 aWFsaXplUHJvY2Vzcyk6CisKIDIwMjEtMDktMDcgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxl LmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgb3JpZ2luIHBhcnRpdGlvbmluZyAodG9wLW9yaWdp bi9mcmFtZS1vcmlnaW4pIGZvciBCcm9hZGNhc3RDaGFubmVsCkluZGV4OiBTb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0JKHJldmlzaW9uIDI4 MjAyMykKKysrIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2Eu bW0JKHdvcmtpbmcgY29weSkKQEAgLTYzMiw4ICs2MzIsNiBAQCB2b2lkIFdlYlByb2Nlc3M6OnBs YXRmb3JtSW5pdGlhbGl6ZVByb2NlCiAgICAgLy8gVGhpcyBjYWxsIHdpbGwgbm90IHN1Y2NlZWQg aWYgdGhlcmUgYXJlIG9wZW4gV2luZG93U2VydmVyIGNvbm5lY3Rpb25zIGF0IHRoaXMgcG9pbnQu CiAgICAgYXV0byByZXR2YWwgPSBDR1NTZXREZW55V2luZG93U2VydmVyQ29ubmVjdGlvbnModHJ1 ZSk7CiAgICAgUkVMRUFTRV9BU1NFUlQocmV0dmFsID09IGtDR0Vycm9yU3VjY2Vzcyk7Ci0gICAg Ly8gTWFrZSBzdXJlIHRoYXQgd2UgY2xvc2UgYW55IFdpbmRvd1NlcnZlciBjb25uZWN0aW9ucyBh ZnRlciBjaGVja2luZyBpbiB3aXRoIExhdW5jaCBTZXJ2aWNlcy4KLSAgICBDR1NTaHV0ZG93blNl cnZlckNvbm5lY3Rpb25zKCk7CiAKICAgICBTd2l0Y2hpbmdHUFVDbGllbnQ6OnNldFNpbmdsZXRv bihXZWJTd2l0Y2hpbmdHUFVDbGllbnQ6OnNpbmdsZXRvbigpKTsKICAgICBNYWluVGhyZWFkU2hh cmVkVGltZXI6OnNob3VsZFNldHVwUG93ZXJPYnNlcnZlcigpID0gZmFsc2U7Cg== 437564 2021-09-07 15:34:44 -0700 2021-09-08 10:31:05 -0700 Patch bug-230022-20210907153433.patch text/plain 3009 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvUEFML0NoYW5nZUxvZwkocmV2aXNpb24gMjgyMTExKQorKysgU291cmNlL1dlYkNv cmUvUEFML0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIxLTA5 LTA3ICBQZXIgQXJuZSAgPHB2b2xsYW5AYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSB1bm5l ZWRlZCBjYWxsIG9uIHN0YXJ0dXAgb2YgV2ViQ29udGVudCBwcm9jZXNzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzAwMjIKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzgyODM4MDAwPgorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgor CisgICAgICAgICogcGFsL3NwaS9jZy9Db3JlR3JhcGhpY3NTUEkuaDoKKwogMjAyMS0wOC0zMSAg TXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIFtDb2Nv YV0gRHJhd2luZyBzeXN0ZW0gZmFsbGJhY2sgZm9udHMgdG8gY2FudmFzIGNhdXNlcyBhIGNyYXNo CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9jZy9Db3JlR3JhcGhpY3NTUEkuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9jZy9Db3JlR3JhcGhpY3NT UEkuaAkocmV2aXNpb24gMjgyMDIzKQorKysgU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvY2cv Q29yZUdyYXBoaWNzU1BJLmgJKHdvcmtpbmcgY29weSkKQEAgLTMzNSw4ICszMzUsNiBAQCB2b2lk IENHQ29udGV4dFNldEZvY3VzUmluZ1dpdGhDb2xvcihDR0NvCiAKIGJvb2wgQ0dEaXNwbGF5VXNl c0ZvcmNlVG9HcmF5KHZvaWQpOwogCi12b2lkIENHU1NodXRkb3duU2VydmVyQ29ubmVjdGlvbnMo dm9pZCk7Ci0KIENHU0Nvbm5lY3Rpb25JRCBDR1NNYWluQ29ubmVjdGlvbklEKHZvaWQpOwogQ0ZB cnJheVJlZiBDR1NIV0NhcHR1cmVXaW5kb3dMaXN0KENHU0Nvbm5lY3Rpb25JRCwgQ0dTV2luZG93 SURMaXN0IHdpbmRvd0xpc3QsIENHU1dpbmRvd0NvdW50LCBDR1NXaW5kb3dDYXB0dXJlT3B0aW9u cyk7CiBDR0Vycm9yIENHU1NldENvbm5lY3Rpb25Qcm9wZXJ0eShDR1NDb25uZWN0aW9uSUQsIENH U0Nvbm5lY3Rpb25JRCBvd25lckNpZCwgQ0ZTdHJpbmdSZWYga2V5LCBDRlR5cGVSZWYgdmFsdWUp OwpJbmRleDogU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdC9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4MjEwNSkKKysrIFNvdXJjZS9XZWJLaXQvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDktMDcgIFBlciBBcm5l ICA8cHZvbGxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHVubmVlZGVkIGNhbGwgb24g c3RhcnR1cCBvZiBXZWJDb250ZW50IHByb2Nlc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMDAyMgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODI4 MzgwMDA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAgVGhl cmUgaXMgbm8gbmVlZCB0byBjYWxsIENHU1NodXRkb3duU2VydmVyQ29ubmVjdGlvbnMgZHVyaW5n IHN0YXJ0dXAgb2YgdGhlIFdlYkNvbnRlbnQgcHJvY2VzcyBvbiBtYWNPUywKKyAgICAgICAgc2lu Y2Ugd2UgYWxyZWFkeSBoYXZlIGFzc2VydGVkIHRoYXQgdGhlcmUgYXJlIG5vIG9wZW4gY29ubmVj dGlvbnMgYXQgdGhpcyBwb2ludC4KKworICAgICAgICAqIFdlYlByb2Nlc3MvY29jb2EvV2ViUHJv Y2Vzc0NvY29hLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzOjpwbGF0Zm9ybUluaXRp YWxpemVQcm9jZXNzKToKKwogMjAyMS0wOS0wNyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUu Y29tPgogCiAgICAgICAgIEltcGxlbWVudCBvcmlnaW4gcGFydGl0aW9uaW5nICh0b3Atb3JpZ2lu L2ZyYW1lLW9yaWdpbikgZm9yIEJyb2FkY2FzdENoYW5uZWwKSW5kZXg6IFNvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbQkocmV2aXNpb24gMjgy MDIzKQorKysgU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5t bQkod29ya2luZyBjb3B5KQpAQCAtNjMyLDggKzYzMiw2IEBAIHZvaWQgV2ViUHJvY2Vzczo6cGxh dGZvcm1Jbml0aWFsaXplUHJvY2UKICAgICAvLyBUaGlzIGNhbGwgd2lsbCBub3Qgc3VjY2VlZCBp ZiB0aGVyZSBhcmUgb3BlbiBXaW5kb3dTZXJ2ZXIgY29ubmVjdGlvbnMgYXQgdGhpcyBwb2ludC4K ICAgICBhdXRvIHJldHZhbCA9IENHU1NldERlbnlXaW5kb3dTZXJ2ZXJDb25uZWN0aW9ucyh0cnVl KTsKICAgICBSRUxFQVNFX0FTU0VSVChyZXR2YWwgPT0ga0NHRXJyb3JTdWNjZXNzKTsKLSAgICAv LyBNYWtlIHN1cmUgdGhhdCB3ZSBjbG9zZSBhbnkgV2luZG93U2VydmVyIGNvbm5lY3Rpb25zIGFm dGVyIGNoZWNraW5nIGluIHdpdGggTGF1bmNoIFNlcnZpY2VzLgotICAgIENHU1NodXRkb3duU2Vy dmVyQ29ubmVjdGlvbnMoKTsKIAogICAgIFN3aXRjaGluZ0dQVUNsaWVudDo6c2V0U2luZ2xldG9u KFdlYlN3aXRjaGluZ0dQVUNsaWVudDo6c2luZ2xldG9uKCkpOwogICAgIE1haW5UaHJlYWRTaGFy ZWRUaW1lcjo6c2hvdWxkU2V0dXBQb3dlck9ic2VydmVyKCkgPSBmYWxzZTsK