230018 2021-09-07 12:56:19 -0700 [LFC][IFC] Construct line spanning inline boxes first 2021-09-07 18:58:21 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1791172 0 zalan 2021-09-07 12:56:19 -0700 no need to construct them at the end anymore (and use insert instead of just a simple append) 1791173 1 437545 zalan 2021-09-07 13:00:55 -0700 Created attachment 437545 Patch 1791311 2 ews-feeder 2021-09-07 18:57:12 -0700 Committed r282122 (241419@main): <https://commits.webkit.org/241419@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437545. 1791312 3 webkit-bug-importer 2021-09-07 18:58:21 -0700 <rdar://problem/82850374> 437545 2021-09-07 13:00:55 -0700 2021-09-07 18:57:13 -0700 Patch bug-230018-20210907130054.patch text/plain 6877 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyMDg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzIxZDJkMTdmMGU4ZTAy ZTdhNjQ1N2Q3MjNjNDk3ZmEzZjhiMTQwMi4uZjVkMmVhYTcwMDRjY2U5MzM3MThhYWU1YzJmOWYz ZjU4MDY4NTk4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTA5LTA3ICBBbGFu IEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbTEZDXVtJRkNdIENvbnN0cnVj dCBsaW5lIHNwYW5uaW5nIGlubGluZSBib3hlcyBmaXJzdAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMwMDE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUnVucyBmb3IgbGluZSBzcGFubmluZyBpbmxpbmUg Ym94ZXMgKGUuZy4gPHNwYW4+Zmlyc3QgbGluZTxicj5zZWNvbmQgbGluZTwvc3Bhbj4pIGNhbiBu b3cgYmUgY29uc3RyY3V0ZWQgYmVmb3JlIGdldHRpbmcgdG8gdGhlIGFjdHVhbCBsaW5lIGNvbnRl bnQuCisgICAgICAgIChJdCBzaW1wbHkgbWVhbnMgdGhhdCB3ZSBjYW4ga2VlcCBhZGRpbmcgcnVu cyB0byB0aGUgdmVjdG9yIGluc3RlYWQgb2YgdXNpbmcgaW5zZXJ0IHRvIHBvc2l0aW9uIHRoZSBs aW5lIHNwYW5uaW5nIGlubGluZSBib3ggcnVucyByaWdodCBhZnRlciB0aGUgcm9vdCBpbmxpbmUg Ym94IHJ1bi4pIAorCisgICAgICAgICogbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9pbmxpbmUv SW5saW5lRGlzcGxheUNvbnRlbnRCdWlsZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91 dDo6SW5saW5lRGlzcGxheUNvbnRlbnRCdWlsZGVyOjpidWlsZCk6CisgICAgICAgIChXZWJDb3Jl OjpMYXlvdXQ6OklubGluZURpc3BsYXlDb250ZW50QnVpbGRlcjo6Y3JlYXRlUnVuc0FuZFVwZGF0 ZUdlb21ldHJ5Rm9yTGluZUNvbnRlbnQpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpJbmxp bmVEaXNwbGF5Q29udGVudEJ1aWxkZXI6OmNyZWF0ZVJ1bnNBbmRVcGRhdGVHZW9tZXRyeUZvckxp bmVTcGFubmluZ0lubGluZUJveGVzKToKKyAgICAgICAgKiBsYXlvdXQvZm9ybWF0dGluZ0NvbnRl eHRzL2lubGluZS9JbmxpbmVEaXNwbGF5Q29udGVudEJ1aWxkZXIuaDoKKwogMjAyMS0wOS0wNyAg QnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbd3B0LWltcHJv dmVtZW50XSBJbXByb3ZlIENTUCBzdXBwb3J0IGZvciB3aW5kb3cgcmV1c2UKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL0lubGluZURp c3BsYXlDb250ZW50QnVpbGRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0dGlu Z0NvbnRleHRzL2lubGluZS9JbmxpbmVEaXNwbGF5Q29udGVudEJ1aWxkZXIuY3BwCmluZGV4IGNk YTBkYjI3NTE1MjdhZjE3YjNhOTI5ODU3ODlkYTM1NDU5ZDhlNmEuLmMxZjk3MDQ4NTY2YWVlNmI3 NmFhZTUwZjlmYjMzZDdhODg0MjZkNDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91 dC9mb3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL0lubGluZURpc3BsYXlDb250ZW50QnVpbGRlci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9pbmxpbmUv SW5saW5lRGlzcGxheUNvbnRlbnRCdWlsZGVyLmNwcApAQCAtNTAsMTAgKzUwLDggQEAgdm9pZCBJ bmxpbmVEaXNwbGF5Q29udGVudEJ1aWxkZXI6OmJ1aWxkKGNvbnN0IExpbmVCdWlsZGVyOjpMaW5l Q29udGVudCYgbGluZUNvbnQKICAgICBhdXRvIHJvb3RJbmxpbmVCb3hSZWN0ID0gbGluZUJveC5s b2dpY2FsUmVjdEZvclJvb3RJbmxpbmVCb3goKTsKICAgICByb290SW5saW5lQm94UmVjdC5tb3Zl QnkobGluZUJveExvZ2ljYWxUb3BMZWZ0KTsKICAgICBmb3JtYXR0aW5nU3RhdGUuYWRkUnVuKHsg bGluZUluZGV4LCBSdW46OlR5cGU6OlJvb3RJbmxpbmVCb3gsIHJvb3QoKSwgcm9vdElubGluZUJv eFJlY3QsIHJvb3RJbmxpbmVCb3hSZWN0LCB7IH0sIHsgfSwgIGxpbmVCb3gucm9vdElubGluZUJv eCgpLmhhc0NvbnRlbnQoKX0pOwotICAgIC8vIFNwYW5uaW5nIGlubGluZSBib3hlcyBzdGFydCBh dCB0aGUgdmVyeSBiZWdpbm5pbmcgb2YgdGhlIGxpbmUuCi0gICAgYXV0byBsaW5lU3Bhbm5pbmdJ bmxpbmVCb3hJbmRleCA9IGZvcm1hdHRpbmdTdGF0ZS5ydW5zKCkuc2l6ZSgpOworICAgIGNyZWF0 ZVJ1bnNBbmRVcGRhdGVHZW9tZXRyeUZvckxpbmVTcGFubmluZ0lubGluZUJveGVzKGxpbmVCb3gs IGxpbmVCb3hMb2dpY2FsVG9wTGVmdCwgbGluZUluZGV4KTsKICAgICBjcmVhdGVSdW5zQW5kVXBk YXRlR2VvbWV0cnlGb3JMaW5lQ29udGVudChsaW5lQ29udGVudCwgbGluZUJveCwgbGluZUJveExv Z2ljYWxUb3BMZWZ0LCBsaW5lSW5kZXgpOwotICAgIGNyZWF0ZVJ1bnNBbmRVcGRhdGVHZW9tZXRy eUZvckxpbmVTcGFubmluZ0lubGluZUJveGVzKGxpbmVCb3gsIGxpbmVCb3hMb2dpY2FsVG9wTGVm dCwgbGluZUluZGV4LCBsaW5lU3Bhbm5pbmdJbmxpbmVCb3hJbmRleCk7CiB9CiAKIHZvaWQgSW5s aW5lRGlzcGxheUNvbnRlbnRCdWlsZGVyOjpjcmVhdGVSdW5zQW5kVXBkYXRlR2VvbWV0cnlGb3JM aW5lQ29udGVudChjb25zdCBMaW5lQnVpbGRlcjo6TGluZUNvbnRlbnQmIGxpbmVDb250ZW50LCBj b25zdCBMaW5lQm94JiBsaW5lQm94LCBjb25zdCBJbmxpbmVMYXlvdXRQb2ludCYgbGluZUJveExv Z2ljYWxUb3BMZWZ0LCBjb25zdCBzaXplX3QgbGluZUluZGV4KQpAQCAtNjEsNyArNTksNyBAQCB2 b2lkIElubGluZURpc3BsYXlDb250ZW50QnVpbGRlcjo6Y3JlYXRlUnVuc0FuZFVwZGF0ZUdlb21l dHJ5Rm9yTGluZUNvbnRlbnQoY29ucwogICAgIGF1dG8mIGZvcm1hdHRpbmdTdGF0ZSA9IHRoaXMt PmZvcm1hdHRpbmdTdGF0ZSgpOwogICAgIC8vIExlZ2FjeSBpbmxpbmUgdHJlZSBpbnRlZ3JhbCBy b3VuZHMgdGhlIHZlcnRpY2FsIHBvc2l0aW9uIGZvciBjZXJ0YWluIGNvbnRlbnQgKHNlZSBMZWdh Y3lJbmxpbmVGbG93Qm94OjpwbGFjZUJveGVzSW5CbG9ja0RpcmVjdGlvbiBhbmQgOjphZGRUb0xp bmUpLgogICAgIC8vIFNlZSBzaG91bGRDbGVhckRlc2NlbmRhbnRzSGF2ZVNhbWVMaW5lSGVpZ2h0 QW5kQmFzZWxpbmUgaW4gTGVnYWN5SW5saW5lRmxvd0JveDo6YWRkVG9MaW5lLgotICAgIGF1dG8g bGluZU5lZWRJbnRlZ3JhbFBvc2l0aW9uID0gdHJ1ZTsKKyAgICBhdXRvIGxpbmVOZWVkSW50ZWdy YWxQb3NpdGlvbiA9IGZvcm1hdHRpbmdTdGF0ZS5saW5lcygpLmxhc3QoKS5uZWVkc0ludGVncmFs UG9zaXRpb24oKTsKICAgICBhdXRvJiByb290U3R5bGUgPSByb290KCkuc3R5bGUoKTsKICAgICAv LyBDcmVhdGUgdGhlIGlubGluZSBydW5zIG9uIHRoZSBjdXJyZW50IGxpbmUuIFRoaXMgaXMgbW9z dGx5IHRleHQgYW5kIGF0b21pYyBpbmxpbmUgcnVucy4KICAgICBmb3IgKGF1dG8mIGxpbmVSdW4g OiBsaW5lQ29udGVudC5ydW5zKSB7CkBAIC0xNzksNyArMTc3LDcgQEAgdm9pZCBJbmxpbmVEaXNw bGF5Q29udGVudEJ1aWxkZXI6OmNyZWF0ZVJ1bnNBbmRVcGRhdGVHZW9tZXRyeUZvckxpbmVDb250 ZW50KGNvbnMKICAgICBmb3JtYXR0aW5nU3RhdGUubGluZXMoKS5sYXN0KCkuc2V0TmVlZHNJbnRl Z3JhbFBvc2l0aW9uKGxpbmVOZWVkSW50ZWdyYWxQb3NpdGlvbik7CiB9CiAKLXZvaWQgSW5saW5l RGlzcGxheUNvbnRlbnRCdWlsZGVyOjpjcmVhdGVSdW5zQW5kVXBkYXRlR2VvbWV0cnlGb3JMaW5l U3Bhbm5pbmdJbmxpbmVCb3hlcyhjb25zdCBMaW5lQm94JiBsaW5lQm94LCBjb25zdCBJbmxpbmVM YXlvdXRQb2ludCYgbGluZUJveExvZ2ljYWxUb3BMZWZ0LCBjb25zdCBzaXplX3QgbGluZUluZGV4 LCBzaXplX3QgbGluZVNwYW5uaW5nSW5saW5lQm94SW5kZXgpCit2b2lkIElubGluZURpc3BsYXlD b250ZW50QnVpbGRlcjo6Y3JlYXRlUnVuc0FuZFVwZGF0ZUdlb21ldHJ5Rm9yTGluZVNwYW5uaW5n SW5saW5lQm94ZXMoY29uc3QgTGluZUJveCYgbGluZUJveCwgY29uc3QgSW5saW5lTGF5b3V0UG9p bnQmIGxpbmVCb3hMb2dpY2FsVG9wTGVmdCwgY29uc3Qgc2l6ZV90IGxpbmVJbmRleCkKIHsKICAg ICBpZiAoIWxpbmVCb3guaGFzQ29udGVudCgpKSB7CiAgICAgICAgIC8vIFdoZW4gYSBzcGFubmlu ZyBpbmxpbmUgYm94IChlLmcuIDxkaXY+dGV4dDxzcGFuPjxicj48L3NwYW4+PC9kaXY+KSBsYW5k cyBvbiBhbiBlbXB0eSBsaW5lCkBAIC0xOTAsNyArMTg4LDcgQEAgdm9pZCBJbmxpbmVEaXNwbGF5 Q29udGVudEJ1aWxkZXI6OmNyZWF0ZVJ1bnNBbmRVcGRhdGVHZW9tZXRyeUZvckxpbmVTcGFubmlu Z0lubGkKIAogICAgIGF1dG8mIHJvb3RTdHlsZSA9IHJvb3QoKS5zdHlsZSgpOwogICAgIGF1dG8m IGZvcm1hdHRpbmdTdGF0ZSA9IHRoaXMtPmZvcm1hdHRpbmdTdGF0ZSgpOwotICAgIGF1dG8gbGlu ZU5lZWRJbnRlZ3JhbFBvc2l0aW9uID0gZm9ybWF0dGluZ1N0YXRlLmxpbmVzKCkubGFzdCgpLm5l ZWRzSW50ZWdyYWxQb3NpdGlvbigpOworICAgIGF1dG8gbGluZU5lZWRJbnRlZ3JhbFBvc2l0aW9u ID0gdHJ1ZTsKICAgICBmb3IgKGF1dG8mIGlubGluZUxldmVsQm94IDogbGluZUJveC5ub25Sb290 SW5saW5lTGV2ZWxCb3hlcygpKSB7CiAgICAgICAgIGlmICghaW5saW5lTGV2ZWxCb3guaXNMaW5l U3Bhbm5pbmdJbmxpbmVCb3goKSkKICAgICAgICAgICAgIGNvbnRpbnVlOwpAQCAtMjAwLDcgKzE5 OCw3IEBAIHZvaWQgSW5saW5lRGlzcGxheUNvbnRlbnRCdWlsZGVyOjpjcmVhdGVSdW5zQW5kVXBk YXRlR2VvbWV0cnlGb3JMaW5lU3Bhbm5pbmdJbmxpCiAgICAgICAgIGF1dG8gaW5saW5lQm94Qm9y ZGVyQm94ID0gbGluZUJveC5sb2dpY2FsQm9yZGVyQm94Rm9ySW5saW5lQm94KGxheW91dEJveCwg Ym94R2VvbWV0cnkpOwogICAgICAgICBpbmxpbmVCb3hCb3JkZXJCb3gubW92ZUJ5KGxpbmVCb3hM b2dpY2FsVG9wTGVmdCk7CiAKLSAgICAgICAgZm9ybWF0dGluZ1N0YXRlLnJ1bnMoKS5pbnNlcnQo bGluZVNwYW5uaW5nSW5saW5lQm94SW5kZXgrKywgeyBsaW5lSW5kZXgsIFJ1bjo6VHlwZTo6Tm9u Um9vdElubGluZUJveCwgbGF5b3V0Qm94LCBpbmxpbmVCb3hCb3JkZXJCb3gsIGlubGluZUJveEJv cmRlckJveCwgeyB9LCB7IH0sIGlubGluZUxldmVsQm94Lmhhc0NvbnRlbnQoKSwgdHJ1ZSB9KTsK KyAgICAgICAgZm9ybWF0dGluZ1N0YXRlLmFkZFJ1bih7IGxpbmVJbmRleCwgUnVuOjpUeXBlOjpO b25Sb290SW5saW5lQm94LCBsYXlvdXRCb3gsIGlubGluZUJveEJvcmRlckJveCwgaW5saW5lQm94 Qm9yZGVyQm94LCB7IH0sIHsgfSwgaW5saW5lTGV2ZWxCb3guaGFzQ29udGVudCgpLCB0cnVlIH0p OwogCiAgICAgICAgIGF1dG8gaW5saW5lQm94U2l6ZSA9IExheW91dFNpemUgeyBMYXlvdXRVbml0 Ojpmcm9tRmxvYXRDZWlsKGlubGluZUJveEJvcmRlckJveC53aWR0aCgpKSwgTGF5b3V0VW5pdDo6 ZnJvbUZsb2F0Q2VpbChpbmxpbmVCb3hCb3JkZXJCb3guaGVpZ2h0KCkpIH07CiAgICAgICAgIGF1 dG8gbG9naWNhbFJlY3QgPSBSZWN0IHsgTGF5b3V0UG9pbnQgeyBpbmxpbmVCb3hCb3JkZXJCb3gu dG9wTGVmdCgpIH0sIGlubGluZUJveFNpemUgfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL0lubGluZURpc3BsYXlDb250ZW50QnVp bGRlci5oIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9pbmxpbmUv SW5saW5lRGlzcGxheUNvbnRlbnRCdWlsZGVyLmgKaW5kZXggMjBkNWUxYzI5MTYzNzE1MGEzNmFl YmVmOTE3OTIxMWUzZmJhODAwYS4uYzE2OGY4OGJjYjdiOWEwZjQxMWRjM2M4YTExZTRhNDEwNjBl OTBlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0 cy9pbmxpbmUvSW5saW5lRGlzcGxheUNvbnRlbnRCdWlsZGVyLmgKKysrIGIvU291cmNlL1dlYkNv cmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9pbmxpbmUvSW5saW5lRGlzcGxheUNvbnRlbnRC dWlsZGVyLmgKQEAgLTQ1LDcgKzQ1LDcgQEAgcHVibGljOgogCiBwcml2YXRlOgogICAgIHZvaWQg Y3JlYXRlUnVuc0FuZFVwZGF0ZUdlb21ldHJ5Rm9yTGluZUNvbnRlbnQoY29uc3QgTGluZUJ1aWxk ZXI6OkxpbmVDb250ZW50JiwgY29uc3QgTGluZUJveCYsIGNvbnN0IElubGluZUxheW91dFBvaW50 JiBsaW5lQm94TG9naWNhbFRvcExlZnQsIGNvbnN0IHNpemVfdCBsaW5lSW5kZXgpOwotICAgIHZv aWQgY3JlYXRlUnVuc0FuZFVwZGF0ZUdlb21ldHJ5Rm9yTGluZVNwYW5uaW5nSW5saW5lQm94ZXMo Y29uc3QgTGluZUJveCYsIGNvbnN0IElubGluZUxheW91dFBvaW50JiBsaW5lQm94TG9naWNhbFRv cExlZnQsIGNvbnN0IHNpemVfdCBsaW5lSW5kZXgsIHNpemVfdCBsaW5lU3Bhbm5pbmdJbmxpbmVC b3hJbmRleCk7CisgICAgdm9pZCBjcmVhdGVSdW5zQW5kVXBkYXRlR2VvbWV0cnlGb3JMaW5lU3Bh bm5pbmdJbmxpbmVCb3hlcyhjb25zdCBMaW5lQm94JiwgY29uc3QgSW5saW5lTGF5b3V0UG9pbnQm IGxpbmVCb3hMb2dpY2FsVG9wTGVmdCwgY29uc3Qgc2l6ZV90IGxpbmVJbmRleCk7CiAKICAgICBj b25zdCBDb250YWluZXJCb3gmIHJvb3QoKSBjb25zdCB7IHJldHVybiBtX2Zvcm1hdHRpbmdDb250 ZXh0Um9vdDsgfQogICAgIElubGluZUZvcm1hdHRpbmdTdGF0ZSYgZm9ybWF0dGluZ1N0YXRlKCkg Y29uc3QgeyByZXR1cm4gbV9mb3JtYXR0aW5nU3RhdGU7IH0gCg==