230003 2021-09-07 08:39:18 -0700 Make webrtc/datachannel/getStats-no-prflx-remote-candidate.html provide more meaningful errors 2021-09-13 10:29:53 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=229877 InRadar P2 Normal --- 1 youennf youennf eric.carlson ews-watchlist tsavell webkit-bug-importer youennf oldest_to_newest 1791031 0 youennf 2021-09-07 08:39:18 -0700 Make webrtc/datachannel/getStats-no-prflx-remote-candidate.html provide more meaningful errors 1791033 1 437513 youennf 2021-09-07 08:42:28 -0700 Created attachment 437513 Patch 1791034 2 437514 youennf 2021-09-07 08:44:11 -0700 Created attachment 437514 Patch 1791525 3 ews-feeder 2021-09-08 10:20:50 -0700 Committed r282151 (241447@main): <https://commits.webkit.org/241447@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437514. 1791527 4 webkit-bug-importer 2021-09-08 10:22:16 -0700 <rdar://problem/82879629> 1792994 5 tsavell 2021-09-13 10:29:53 -0700 Looks like this change has made webrtc/datachannel/getStats-no-prflx-remote-candidate.html fail now History: https://results.webkit.org/?suite=layout-tests&test=webrtc%2Fdatachannel%2FgetStats-no-prflx-remote-candidate.html Diff: --- /Volumes/Data/worker/bigsur-release-tests-wk1/build/layout-test-results/webrtc/datachannel/getStats-no-prflx-remote-candidate-expected.txt +++ /Volumes/Data/worker/bigsur-release-tests-wk1/build/layout-test-results/webrtc/datachannel/getStats-no-prflx-remote-candidate-actual.txt @@ -1,3 +1,4 @@ +CONSOLE MESSAGE: Unhandled Promise Rejection: localDataChannelPromise -PASS Make sure remote peer reflexive candidates are not exposed in stats +FAIL Make sure remote peer reflexive candidates are not exposed in stats 437513 2021-09-07 08:42:28 -0700 2021-09-07 08:44:07 -0700 Patch bug-230003-20210907174226.patch text/plain 2425 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxOTc4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggN2JhZWZkNjY3ZTFkZjBjNjM3MTdm N2ZmZWU2MTQ5N2MzOWNiYTBiNi4uZTYxYWEzMWZlYTI4YzNjNmQxZDE5OGE5ODdiMjJiMDFkYTMx ZWYwYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTA5LTA3ICBZb3Vlbm4gRmFibGV0ICA8 eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIHdlYnJ0Yy9kYXRhY2hhbm5lbC9nZXRT dGF0cy1uby1wcmZseC1yZW1vdGUtY2FuZGlkYXRlLmh0bWwgcHJvdmlkZSBtb3JlIG1lYW5pbmdm dWwgZXJyb3JzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMzAwMDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHdlYnJ0Yy9kYXRhY2hhbm5lbC9nZXRTdGF0cy1uby1wcmZseC1yZW1vdGUtY2FuZGlkYXRl Lmh0bWw6CisgICAgICAgIFRoZSB0ZXN0IGlzIHRpbWluZyBvdXQgZmxha2lseSwgYWRkIHNvbWUg ZXJyb3JzIHRvIGtub3cgd2hlcmUgaXQgaXMgdGltaW5nIG91dC4KKyAgICAgICAgTWFrZSBzdXJl IHRvIGNhbGwgc2VuZCBvbmNlIHRoZSBsb2NhbCBjaGFubmVsIGlzIG9wZW5lZC4KKwogMjAyMS0w OS0wNyAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHN1 cHBvcnQgZm9yIFJUQ0RhdGFDaGFubmVsIGNsb3NpbmcgZXZlbnQKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL3dlYnJ0Yy9kYXRhY2hhbm5lbC9nZXRTdGF0cy1uby1wcmZseC1yZW1vdGUtY2FuZGlk YXRlLmh0bWwgYi9MYXlvdXRUZXN0cy93ZWJydGMvZGF0YWNoYW5uZWwvZ2V0U3RhdHMtbm8tcHJm bHgtcmVtb3RlLWNhbmRpZGF0ZS5odG1sCmluZGV4IDg2NDc5NzYyODkxY2MxZDczNzAwMTk4YTlk Nzk5OTAxYmE2ZWJiMWIuLjY5ZDg5YmU5ZTg4ZTU5YTMwNzgwOTE3MTQyZWU4Y2NjMmUzNDkyMDEg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3dlYnJ0Yy9kYXRhY2hhbm5lbC9nZXRTdGF0cy1uby1w cmZseC1yZW1vdGUtY2FuZGlkYXRlLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvd2VicnRjL2RhdGFj aGFubmVsL2dldFN0YXRzLW5vLXByZmx4LXJlbW90ZS1jYW5kaWRhdGUuaHRtbApAQCAtMzQsNiAr MzQsMTAgQEAgYXN5bmMgZnVuY3Rpb24gZG9UZXN0KCkKICAgICB9KTsKIAogICAgIGNvbnN0IGxv Y2FsRGF0YUNoYW5uZWwgPSBsb2NhbFBjLmNyZWF0ZURhdGFDaGFubmVsKCd0ZXN0Jyk7CisgICAg bGV0IGxvY2FsRGF0YUNoYW5uZWxQcm9taXNlID0gbmV3IFByb21pc2UoKHJlc29sdmUsIHJlamVj dCkgPT4geworICAgICAgICBsb2NhbERhdGFDaGFubmVsLm9ub3BlbiA9IHJlc29sdmU7CisgICAg ICAgIHNldFRpbWVvdXQoKCkgPT4gcmVqZWN0KCdsb2NhbERhdGFDaGFubmVsUHJvbWlzZScpLCA1 MDAwKTsKKyAgICB9KTsKIAogICAgIGxvY2FsUGMuYWRkRXZlbnRMaXN0ZW5lcignaWNlY2FuZGlk YXRlJywgZXZlbnQgPT4gewogICAgICAgICByZW1vdGVQYy5hZGRJY2VDYW5kaWRhdGUoZXZlbnQu Y2FuZGlkYXRlKTsKQEAgLTQzLDExICs0NywxNyBAQCBhc3luYyBmdW5jdGlvbiBkb1Rlc3QoKQog ICAgIGNvbnN0IHJlbW90ZURhdGFDaGFubmVsID0gYXdhaXQgcHJvbWlzZURhdGFDaGFubmVsOwog CiAgICAgYXNzZXJ0X3RydWUoISFyZW1vdGVEYXRhQ2hhbm5lbCwgInJlbW90ZURhdGFDaGFubmVs IGlzIGRlZmluZWQiKTsKLSAgICBhd2FpdCBuZXcgUHJvbWlzZShyZXNvbHZlID0+IHsKKworICAg IGxldCByZW1vdGVEYXRhQ2hhbm5lbFByb21pc2UgPSBuZXcgUHJvbWlzZSgocmVzb2x2ZSwgcmVq ZWN0KSA9PiB7CiAgICAgICAgIHJlbW90ZURhdGFDaGFubmVsLm9ubWVzc2FnZSA9IHJlc29sdmU7 Ci0gICAgICAgIGxvY2FsRGF0YUNoYW5uZWwuc2VuZCgidGVzdCIpOworICAgICAgICBzZXRUaW1l b3V0KCgpID0+IHJlamVjdCgncmVtb3RlRGF0YUNoYW5uZWxQcm9taXNlJyksIDUwMDApOwogICAg IH0pOwogCisgICAgYXdhaXQgbG9jYWxEYXRhQ2hhbm5lbFByb21pc2U7CisgICAgbG9jYWxEYXRh Q2hhbm5lbC5zZW5kKCJ0ZXN0Iik7CisKKyAgICBhd2FpdCByZW1vdGVEYXRhQ2hhbm5lbFByb21p c2U7CisKICAgICBjb25zdCByZW1vdGVDYW5kaWRhdGVTdGF0cyA9IGdldFJlcXVpcmVkU3RhdHMo YXdhaXQgbG9jYWxQYy5nZXRTdGF0cygpLCAicmVtb3RlLWNhbmRpZGF0ZSIpOwogICAgIGFzc2Vy dF9lcXVhbHMocmVtb3RlQ2FuZGlkYXRlU3RhdHMuYWRkcmVzcywgdW5kZWZpbmVkLCAiYWRkcmVz cyBzaG91bGQgcmVtYWluIHVuZGVmaW5lZCIpOwogCg== 437514 2021-09-07 08:44:11 -0700 2021-09-08 10:20:51 -0700 Patch bug-230003-20210907174409.patch text/plain 2429 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxOTc4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggN2JhZWZkNjY3ZTFkZjBjNjM3MTdm N2ZmZWU2MTQ5N2MzOWNiYTBiNi4uZTYxYWEzMWZlYTI4YzNjNmQxZDE5OGE5ODdiMjJiMDFkYTMx ZWYwYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTA5LTA3ICBZb3Vlbm4gRmFibGV0ICA8 eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIHdlYnJ0Yy9kYXRhY2hhbm5lbC9nZXRT dGF0cy1uby1wcmZseC1yZW1vdGUtY2FuZGlkYXRlLmh0bWwgcHJvdmlkZSBtb3JlIG1lYW5pbmdm dWwgZXJyb3JzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMzAwMDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHdlYnJ0Yy9kYXRhY2hhbm5lbC9nZXRTdGF0cy1uby1wcmZseC1yZW1vdGUtY2FuZGlkYXRl Lmh0bWw6CisgICAgICAgIFRoZSB0ZXN0IGlzIHRpbWluZyBvdXQgZmxha2lseSwgYWRkIHNvbWUg ZXJyb3JzIHRvIGtub3cgd2hlcmUgaXQgaXMgdGltaW5nIG91dC4KKyAgICAgICAgTWFrZSBzdXJl IHRvIGNhbGwgc2VuZCBvbmNlIHRoZSBsb2NhbCBjaGFubmVsIGlzIG9wZW5lZC4KKwogMjAyMS0w OS0wNyAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHN1 cHBvcnQgZm9yIFJUQ0RhdGFDaGFubmVsIGNsb3NpbmcgZXZlbnQKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL3dlYnJ0Yy9kYXRhY2hhbm5lbC9nZXRTdGF0cy1uby1wcmZseC1yZW1vdGUtY2FuZGlk YXRlLmh0bWwgYi9MYXlvdXRUZXN0cy93ZWJydGMvZGF0YWNoYW5uZWwvZ2V0U3RhdHMtbm8tcHJm bHgtcmVtb3RlLWNhbmRpZGF0ZS5odG1sCmluZGV4IDg2NDc5NzYyODkxY2MxZDczNzAwMTk4YTlk Nzk5OTAxYmE2ZWJiMWIuLjk3YjU5MWFmZTNhMTJiMWZhYmM0OWY3ZDM2ZjdiYjgzNDY3YWE0NTgg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3dlYnJ0Yy9kYXRhY2hhbm5lbC9nZXRTdGF0cy1uby1w cmZseC1yZW1vdGUtY2FuZGlkYXRlLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvd2VicnRjL2RhdGFj aGFubmVsL2dldFN0YXRzLW5vLXByZmx4LXJlbW90ZS1jYW5kaWRhdGUuaHRtbApAQCAtMzQsNiAr MzQsMTAgQEAgYXN5bmMgZnVuY3Rpb24gZG9UZXN0KCkKICAgICB9KTsKIAogICAgIGNvbnN0IGxv Y2FsRGF0YUNoYW5uZWwgPSBsb2NhbFBjLmNyZWF0ZURhdGFDaGFubmVsKCd0ZXN0Jyk7CisgICAg Y29uc3QgbG9jYWxEYXRhQ2hhbm5lbFByb21pc2UgPSBuZXcgUHJvbWlzZSgocmVzb2x2ZSwgcmVq ZWN0KSA9PiB7CisgICAgICAgIGxvY2FsRGF0YUNoYW5uZWwub25vcGVuID0gcmVzb2x2ZTsKKyAg ICAgICAgc2V0VGltZW91dCgoKSA9PiByZWplY3QoJ2xvY2FsRGF0YUNoYW5uZWxQcm9taXNlJyks IDUwMDApOworICAgIH0pOwogCiAgICAgbG9jYWxQYy5hZGRFdmVudExpc3RlbmVyKCdpY2VjYW5k aWRhdGUnLCBldmVudCA9PiB7CiAgICAgICAgIHJlbW90ZVBjLmFkZEljZUNhbmRpZGF0ZShldmVu dC5jYW5kaWRhdGUpOwpAQCAtNDMsMTEgKzQ3LDE3IEBAIGFzeW5jIGZ1bmN0aW9uIGRvVGVzdCgp CiAgICAgY29uc3QgcmVtb3RlRGF0YUNoYW5uZWwgPSBhd2FpdCBwcm9taXNlRGF0YUNoYW5uZWw7 CiAKICAgICBhc3NlcnRfdHJ1ZSghIXJlbW90ZURhdGFDaGFubmVsLCAicmVtb3RlRGF0YUNoYW5u ZWwgaXMgZGVmaW5lZCIpOwotICAgIGF3YWl0IG5ldyBQcm9taXNlKHJlc29sdmUgPT4geworCisg ICAgY29uc3QgcmVtb3RlRGF0YUNoYW5uZWxQcm9taXNlID0gbmV3IFByb21pc2UoKHJlc29sdmUs IHJlamVjdCkgPT4gewogICAgICAgICByZW1vdGVEYXRhQ2hhbm5lbC5vbm1lc3NhZ2UgPSByZXNv bHZlOwotICAgICAgICBsb2NhbERhdGFDaGFubmVsLnNlbmQoInRlc3QiKTsKKyAgICAgICAgc2V0 VGltZW91dCgoKSA9PiByZWplY3QoJ3JlbW90ZURhdGFDaGFubmVsUHJvbWlzZScpLCA1MDAwKTsK ICAgICB9KTsKIAorICAgIGF3YWl0IGxvY2FsRGF0YUNoYW5uZWxQcm9taXNlOworICAgIGxvY2Fs RGF0YUNoYW5uZWwuc2VuZCgidGVzdCIpOworCisgICAgYXdhaXQgcmVtb3RlRGF0YUNoYW5uZWxQ cm9taXNlOworCiAgICAgY29uc3QgcmVtb3RlQ2FuZGlkYXRlU3RhdHMgPSBnZXRSZXF1aXJlZFN0 YXRzKGF3YWl0IGxvY2FsUGMuZ2V0U3RhdHMoKSwgInJlbW90ZS1jYW5kaWRhdGUiKTsKICAgICBh c3NlcnRfZXF1YWxzKHJlbW90ZUNhbmRpZGF0ZVN0YXRzLmFkZHJlc3MsIHVuZGVmaW5lZCwgImFk ZHJlc3Mgc2hvdWxkIHJlbWFpbiB1bmRlZmluZWQiKTsKIAo=