22999 2008-12-26 06:10:45 -0800 Database::openAndVerifyVersion() crashes on NULL, if database thread creating failed 2008-12-26 13:20:07 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zalan webkit-unassigned oldest_to_newest 103445 0 zalan 2008-12-26 06:10:45 -0800 Database::openDatabase() calls Database::openAndVerifyVersion() which crashes on m_document->databaseThread()->scheduleImmediateTask(task);, if databaseThread() returns NULL. some of the Database:: functions already have if (m_document->databaseThread()) to check it. 103446 1 26255 zalan 2008-12-26 06:18:09 -0800 Created attachment 26255 check if database thread exists 103459 2 26255 darin 2008-12-26 09:30:52 -0800 Comment on attachment 26255 check if database thread exists r=me 103495 3 koivisto 2008-12-26 13:20:07 -0800 Sending WebCore/ChangeLog Sending WebCore/storage/Database.cpp Transmitting file data .. Committed revision 39484. 26255 2008-12-26 06:18:09 -0800 2008-12-26 09:30:52 -0800 check if database thread exists database.patch text/plain 2024 zalan SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzOTQ3NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDgtMTItMjYgIFphbGFuIEJ1anRhcyAgPHpidWp0YXNAZ21haWwu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjk5OQorICAgICAgICBDaGVj ayBpZiBkYXRhYmFzZSB0aHJlYWQgZXhpc3RzLgorCisgICAgICAgICogc3RvcmFnZS9EYXRhYmFz ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEYXRhYmFzZTo6b3BlbkFuZFZlcmlmeVZlcnNpb24p OgorICAgICAgICAoV2ViQ29yZTo6RGF0YWJhc2U6Om1hcmtBc0RlbGV0ZWRBbmRDbG9zZSk6Cisg ICAgICAgIChXZWJDb3JlOjpEYXRhYmFzZTo6dGFibGVOYW1lcyk6CisKIDIwMDgtMTItMjYgIERt aXRyeSBUaXRvdiAgPGRpbWljaEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGFyaW4gQWRsZXIuCkluZGV4OiBXZWJDb3JlL3N0b3JhZ2UvRGF0YWJhc2UuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvc3RvcmFnZS9EYXRhYmFzZS5jcHAJKHJldmlzaW9uIDM5NDc2KQorKysg V2ViQ29yZS9zdG9yYWdlL0RhdGFiYXNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTgyLDYgKzE4 Miw4IEBAIERhdGFiYXNlOjp+RGF0YWJhc2UoKQogCiBib29sIERhdGFiYXNlOjpvcGVuQW5kVmVy aWZ5VmVyc2lvbihFeGNlcHRpb25Db2RlJiBlKQogeworICAgIGlmICghbV9kb2N1bWVudC0+ZGF0 YWJhc2VUaHJlYWQoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIG1fZGF0YWJhc2VBdXRo b3JpemVyID0gRGF0YWJhc2VBdXRob3JpemVyOjpjcmVhdGUoKTsKIAogICAgIFJlZlB0cjxEYXRh YmFzZU9wZW5UYXNrPiB0YXNrID0gRGF0YWJhc2VPcGVuVGFzazo6Y3JlYXRlKHRoaXMpOwpAQCAt MjgyLDcgKzI4NCw3IEBAIGJvb2wgRGF0YWJhc2U6OnZlcnNpb25NYXRjaGVzRXhwZWN0ZWQoKSAK IAogdm9pZCBEYXRhYmFzZTo6bWFya0FzRGVsZXRlZEFuZENsb3NlKCkKIHsKLSAgICBpZiAobV9k ZWxldGVkKQorICAgIGlmIChtX2RlbGV0ZWQgfHwgIW1fZG9jdW1lbnQtPmRhdGFiYXNlVGhyZWFk KCkpCiAgICAgICAgIHJldHVybjsKIAogICAgIExPRyhTdG9yYWdlQVBJLCAiTWFya2luZyAlcyAo JXApIGFzIGRlbGV0ZWQiLCBzdHJpbmdJZGVudGlmaWVyKCkuYXNjaWkoKS5kYXRhKCksIHRoaXMp OwpAQCAtMjkzLDcgKzI5NSw3IEBAIHZvaWQgRGF0YWJhc2U6Om1hcmtBc0RlbGV0ZWRBbmRDbG9z ZSgpCiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBkb2N1bWVudCgpLT5kYXRhYmFzZVRo cmVhZCgpLT51bnNjaGVkdWxlRGF0YWJhc2VUYXNrcyh0aGlzKTsKKyAgICBtX2RvY3VtZW50LT5k YXRhYmFzZVRocmVhZCgpLT51bnNjaGVkdWxlRGF0YWJhc2VUYXNrcyh0aGlzKTsKIAogICAgIFJl ZlB0cjxEYXRhYmFzZUNsb3NlVGFzaz4gdGFzayA9IERhdGFiYXNlQ2xvc2VUYXNrOjpjcmVhdGUo dGhpcyk7CiAKQEAgLTU2NSw2ICs1NjcsOCBAQCB2b2lkIERhdGFiYXNlOjpkZWxpdmVyUGVuZGlu Z0NhbGxiYWNrKHZvCiAKIFZlY3RvcjxTdHJpbmc+IERhdGFiYXNlOjp0YWJsZU5hbWVzKCkKIHsK KyAgICBpZiAoIW1fZG9jdW1lbnQtPmRhdGFiYXNlVGhyZWFkKCkpCisgICAgICAgIHJldHVybiBW ZWN0b3I8U3RyaW5nPigpOwogICAgIFJlZlB0cjxEYXRhYmFzZVRhYmxlTmFtZXNUYXNrPiB0YXNr ID0gRGF0YWJhc2VUYWJsZU5hbWVzVGFzazo6Y3JlYXRlKHRoaXMpOwogCiAgICAgdGFzay0+bG9j a0ZvclN5bmNocm9ub3VzU2NoZWR1bGluZygpOwo=