229976 2021-09-06 17:12:16 -0700 [WinCairo] Support prefers-color-scheme media query 2021-09-08 20:20:52 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 230032 230077 1 fujii fujii annulen don.olmstead ews-watchlist gyuyoung.kim ross.kirsling ryuan.choi sergio webkit-bug-importer oldest_to_newest 1790824 0 fujii 2021-09-06 17:12:16 -0700 [WinCairo] Support prefers-color-scheme media query See also: Bug 190499 – Add support for prefers-color-scheme media query Bug 196685 – [GTK] Support prefers-color-scheme media query 1790829 1 fujii 2021-09-06 17:16:11 -0700 https://kuro.netlify.app/ doesn't have a background image in WinCairo. It doesn't support browsers not supporting prefers-color-scheme. > @media (prefers-color-scheme: light) { > body{ > background: url("img/bglight.svg") no-repeat; > } > } > > @media (prefers-color-scheme: dark) { > body{ > background: url("img/bgdark.svg") no-repeat; > } > } 1790849 2 fujii 2021-09-06 18:49:40 -0700 The dark mode win32 API is still undocumented. Discussion: Dark mode for applications · Issue #41 · microsoft/WindowsAppSDK https://github.com/microsoft/WindowsAppSDK/issues/41 windows - Win10 dark theme - how to use in WINAPI? - Stack Overflow https://stackoverflow.com/q/53501268 1790853 3 437445 fujii 2021-09-06 19:23:45 -0700 Created attachment 437445 Patch 1791299 4 437445 don.olmstead 2021-09-07 18:21:19 -0700 Comment on attachment 437445 Patch r=me Can you open a bug for an actual implementation of dark mode on Windows? 1791315 5 437445 fujii 2021-09-07 19:02:49 -0700 Comment on attachment 437445 Patch Clearing flags on attachment: 437445 Committed r282123 (241420@main): <https://commits.webkit.org/241420@main> 1791316 6 fujii 2021-09-07 19:02:53 -0700 All reviewed patches have been landed. Closing bug. 1791317 7 webkit-bug-importer 2021-09-07 19:03:16 -0700 <rdar://problem/82850531> 1791319 8 fujii 2021-09-07 19:07:03 -0700 Filed: Bug 230032 – [WinCairo] Add dark mode support 1791742 9 fujii 2021-09-08 20:20:52 -0700 (In reply to Fujii Hironori from comment #5) > Committed r282123 (241420@main): <https://commits.webkit.org/241420@main> This change causes new test failures for WinCairo. Filed: Bug 230077 – [Win] REGRESSION(r282123): some layout tests are failing because the bgcolor of text input forms are unexpectedly black 437445 2021-09-06 19:23:45 -0700 2021-09-07 19:02:49 -0700 Patch bug-229976-20210907112343.patch text/plain 3639 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyMDY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc1dpbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV2luLmNtYWtlCmluZGV4IGFlMmFi NGQxMDM2N2RiZjZiYzM4ZjlhMDI0NmNhYjI0ODViNmZiNjcuLjY3YjQyNmU1OGM3NDA5ZjY2ODg5 ZWQxZDgzNWFmNjYzNmFkMjc2NDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zV2lu LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV2luLmNtYWtlCkBAIC02Myw2ICs2Myw3 IEBAIGlmICgke1dURl9QTEFURk9STV9XSU5fQ0FJUk99KQogICAgIFdFQktJVF9PUFRJT05fREVG SU5FKEVOQUJMRV9UTFNfREVCVUcgIkVuYWJsZSBUTFMga2V5IGxvZyBzdXBwb3J0IiBQUklWQVRF IE9GRikKIAogICAgIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9DU1Nf Q09OSUNfR1JBRElFTlRTIFBSSVZBVEUgT04pCisgICAgV0VCS0lUX09QVElPTl9ERUZBVUxUX1BP UlRfVkFMVUUoRU5BQkxFX0RBUktfTU9ERV9DU1MgUFJJVkFURSBPTikKICAgICBXRUJLSVRfT1BU SU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfRklMVEVSU19MRVZFTF8yIFBSSVZBVEUgT04p CiAgICAgV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0xFR0FDWV9FTkNS WVBURURfTUVESUEgUFVCTElDIE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9W QUxVRShFTkFCTEVfUFVCTElDX1NVRkZJWF9MSVNUIFBSSVZBVEUgT04pCmRpZmYgLS1naXQgYS9T b3VyY2UvY21ha2UvT3B0aW9uc1dpbkNhaXJvLmNtYWtlIGIvU291cmNlL2NtYWtlL09wdGlvbnNX aW5DYWlyby5jbWFrZQppbmRleCAzY2NlNGI5ZjgzODAwMWQ5M2ExNjBiZDBjNzUzYWU1NjNmMzMx MDc3Li5lYjQwYjRjNjZkZDhiMGE4NDU4Y2YyYTZhNTQ0MTYxOWZlMDMxZTdjIDEwMDY0NAotLS0g YS9Tb3VyY2UvY21ha2UvT3B0aW9uc1dpbkNhaXJvLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9P cHRpb25zV2luQ2Fpcm8uY21ha2UKQEAgLTU1LDYgKzU1LDggQEAgU0VUX0FORF9FWFBPU0VfVE9f QlVJTEQoVVNFX0lOU1BFQ1RPUl9TT0NLRVRfU0VSVkVSICR7RU5BQkxFX1JFTU9URV9JTlNQRUNU T1J9KQogCiBTRVRfQU5EX0VYUE9TRV9UT19CVUlMRChFTkFCTEVfREVWRUxPUEVSX01PREUgJHtE RVZFTE9QRVJfTU9ERX0pCiAKK1NFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKEhBVkVfT1NfREFSS19N T0RFX1NVUFBPUlQgMSkKKwogc2V0KENPUkVGT1VOREFUSU9OX0xJQlJBUlkgQ0ZsaXRlKQogCiBh ZGRfZGVmaW5pdGlvbnMoLURXVEZfUExBVEZPUk1fV0lOX0NBSVJPPTEpCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjIzN2Q3 OGI0MDE1ODA1OGNkYjQzNzNiODY5NDQ1NmRiOTlkZWU1Mi4uYzU2NzMxZjZmMGQ1Yjg4MjQ1OTUw MmYxMWMyMjljNThlNGQzZDk1NSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisr KyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIxLTA5LTA2ICBG dWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5D YWlyb10gU3VwcG9ydCBwcmVmZXJzLWNvbG9yLXNjaGVtZSBtZWRpYSBxdWVyeQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5OTc2CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS93aW5jYWly by9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDIxLTA5LTA2ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5m cmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIyODAwMTcpOiBDYWxsaW5n IGdldEJvdW5kaW5nQ2xpZW50UmVjdCgpIG9uIGFuIGVtcHR5IGVsZW1lbnQgd2l0aCAiYnJlYWst YmVmb3JlOiBjb2x1bW4iIGluIGNvbHVtbnMgcmV0dXJucyBhIHJlY3Qgd2l0aCBhbGwgemVyb3MK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbmNhaXJvL1Rlc3RFeHBlY3RhdGlv bnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW5jYWlyby9UZXN0RXhwZWN0YXRpb25zCmluZGV4 IDQ1OWUzNjBhZGIxOTU0OWMyMGMwODBkNDg1MDc3Y2MzZjA0Y2I0MmYuLjA1MTNkMzkyZDg4ZTgx MTkzNDExOWU3NjZlYzI0NDYzNjY3ZWUwZjcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRm b3JtL3dpbmNhaXJvL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v d2luY2Fpcm8vVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTEwNiw3ICsxMTA2LDEzIEBAIGZhc3QvY3Nz LWN1c3RvbS1wYWludC8gWyBTa2lwIF0KIGNzcy10eXBlZG9tIFsgU2tpcCBdCiAKICMgRGFyayBt b2RlIG5vdCBzdXBwb3J0ZWQgb24gV2luZG93cwotY3NzLWRhcmstbW9kZSBbIFNraXAgXQorY3Nz LWRhcmstbW9kZSBbIFBhc3MgXQorY3NzLWRhcmstbW9kZS9jb2xvci1zY2hlbWUtY3NzLmh0bWwg WyBGYWlsdXJlIF0KK2Nzcy1kYXJrLW1vZGUvY29sb3Itc2NoZW1lLW1ldGEuaHRtbCBbIEZhaWx1 cmUgXQorY3NzLWRhcmstbW9kZS9jb2xvci1zY2hlbWUtcHJpb3JpdHkuaHRtbCBbIEZhaWx1cmUg XQorY3NzLWRhcmstbW9kZS9kZWZhdWx0LWNvbG9ycy5odG1sIFsgRmFpbHVyZSBdCitjc3MtZGFy ay1tb2RlL29sZGVyLXN5bnRheC9zdXBwb3J0ZWQtY29sb3Itc2NoZW1lcy1jc3MuaHRtbCBbIEZh aWx1cmUgXQorY3NzLWRhcmstbW9kZS9vbGRlci1zeW50YXgvc3VwcG9ydGVkLWNvbG9yLXNjaGVt ZXMtbWV0YS5odG1sIFsgRmFpbHVyZSBdCiAKIHdlYmtpdC5vcmcvYi8xNDIyNjAgZmFzdC9jc3Mv aGFzLWF0dGFjaG1lbnQuaHRtbCBbIFNraXAgXQogCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9D aGFuZ2VMb2cKaW5kZXggZTY3Mjk5ODdmMzZiMGI2MzE5ZDE0MWQxMzNiOWUxY2UwMzEzNDQyZi4u ZGI4ZjczNGQxYTMyZDM1OWRjZGJmYWM4NGNiOGRkMTI5YzQyNzFiOCAxMDA2NDQKLS0tIGEvQ2hh bmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA5LTA2ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5DYWly b10gU3VwcG9ydCBwcmVmZXJzLWNvbG9yLXNjaGVtZSBtZWRpYSBxdWVyeQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5OTc2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSnVzdCB0dXJuZWQgb24gRU5BQkxF X0RBUktfTU9ERV9DU1MgYW5kIEhBVkVfT1NfREFSS19NT0RFX1NVUFBPUlQuCisgICAgICAgIEl0 J3MgYWx3YXlzIHRoZSBsaWdodCBtb2RlLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlv bnNXaW4uY21ha2U6CisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNXaW5DYWlyby5jbWFr ZToKKwogMjAyMS0wOS0wMyAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGdub21lLm9y Zz4KIAogICAgICAgICBEaXNhYmxlIEdDQ19PRkZMSU5FQVNNX1NPVVJDRV9NQVAK