229971 2021-09-06 15:58:41 -0700 run_webkit_tests failed to print error message in python3 in linux_get_crash_log.py 2021-09-07 08:45:19 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain jbedard aakash_jain ews-watchlist glenn jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1790798 0 aakash_jain 2021-09-06 15:58:41 -0700 run_webkit_tests failed to print error message in python3 in linux_get_crash_log.py From https://build.webkit.org/#/builders/63/builds/2245/steps/11/logs/stdio 17:18:52.297 3 worker/11 stopping 17:18:52.614 3 Some workers failed to gracefully shut down, but in-flight exception taking precedence 17:18:52.725 3 TypeError("can only concatenate str (not "bytes") to str (from worker/3)") raised, exiting 17:18:52.725 3 Flushing stdout 17:18:52.725 3 Flushing stderr 17:18:52.725 3 Stopping helper 17:18:52.725 3 Cleaning up port TypeError raised: can only concatenate str (not "bytes") to str (from worker/3) Traceback (most recent call last): File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 92, in main run_details = run(port, options, args, stderr) File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 494, in run run_details = manager.run(args) File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 413, in run temp_initial_results, temp_retry_results, temp_enabled_pixel_tests_in_retry = self._run_test_subset(test_inputs, device_type=device_type) File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 487, in _run_test_subset initial_results = self._run_tests(test_inputs, self._options.repeat_each, self._options.iterations, int(self._options.child_processes), retrying=False, device_type=device_type) File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 566, in _run_tests return self._runner.run_tests(self._expectations[device_type], new_test_inputs, num_workers, retrying, device_type) File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 179, in run_tests pool.wait() File "/app/webkit/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py", line 451, in __exit__ reraise(*inflight) File "/app/webkit/Tools/Scripts/libraries/autoinstalled/python-3/six.py", line 703, in reraise raise value File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 179, in run_tests pool.wait() File "/app/webkit/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py", line 423, in wait self.queue.receive()(self) File "/app/webkit/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py", line 133, in __call__ reraise(*self.exc_info) File "/app/webkit/Tools/Scripts/libraries/autoinstalled/python-3/six.py", line 702, in reraise raise value.with_traceback(tb) File "/app/webkit/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py", line 296, in main queue.send(_Result(value=task(None), id=task.id)) File "/app/webkit/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py", line 56, in __call__ return self.function(*self.args, **self.kwargs) File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 76, in run_shard return Worker.instance.run_tests(shard) File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 318, in run_tests Worker.instance.run_test(input, shard.name) File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 346, in run_test result = self._run_test_with_or_without_timeout(test_input, test_timeout_sec, stop_when_done) File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 403, in _run_test_with_or_without_timeout return self._run_test_in_this_thread(test_input, stop_when_done) File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 489, in _run_test_in_this_thread return self._run_single_test(self._driver, test_input, stop_when_done) File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 492, in _run_single_test return single_test_runner.run_single_test( File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 46, in run_single_test return runner.run() File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 121, in run return self._run_compare_test() File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 124, in _run_compare_test driver_output = self._driver.run_test(self._driver_input(), self._stop_when_done) File "/app/webkit/Tools/Scripts/webkitpy/port/driver.py", line 834, in run_test return self._driver.run_test(driver_input, stop_when_done) File "/app/webkit/Tools/Scripts/webkitpy/port/driver.py", line 255, in run_test self.error_from_test, crash_log = self._get_crash_log(text, self.error_from_test, newer_than=start_time) File "/app/webkit/Tools/Scripts/webkitpy/port/driver.py", line 324, in _get_crash_log return self._port._get_crash_log(self._crashed_process_name, self._crashed_pid, stdout, stderr, newer_than, target_host=self._target_host) File "/app/webkit/Tools/Scripts/webkitpy/port/gtk.py", line 246, in _get_crash_log return GDBCrashLogGenerator(self._executive, name, pid, newer_than, File "/app/webkit/Tools/Scripts/webkitpy/port/linux_get_crash_log.py", line 156, in generate_crash_log crash_log, errors = self._get_gdb_output(coredump_path) File "/app/webkit/Tools/Scripts/webkitpy/port/linux_get_crash_log.py", line 63, in _get_gdb_output stdout = ('ERROR: The gdb process exited with non-zero return code %s\n\n' % proc.returncode) + stdout TypeError: can only concatenate str (not "bytes") to str (from worker/3) 1791008 1 437503 jbedard 2021-09-07 07:57:23 -0700 Created attachment 437503 Patch 1791012 2 437503 aakash_jain 2021-09-07 08:09:32 -0700 Comment on attachment 437503 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437503&action=review > Tools/Scripts/webkitpy/port/linux_get_crash_log.py:63 > + stdout = (b'ERROR: The gdb process exited with non-zero return code %s\n\n' % str(proc.returncode)) + stdout should we use {} and .format() instead of %s 1791017 3 437503 jbedard 2021-09-07 08:17:07 -0700 Comment on attachment 437503 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437503&action=review >> Tools/Scripts/webkitpy/port/linux_get_crash_log.py:63 >> + stdout = (b'ERROR: The gdb process exited with non-zero return code %s\n\n' % str(proc.returncode)) + stdout > > should we use {} and .format() instead of %s Bytes don't have `.format()`, so we need to use %. 1791035 4 ews-feeder 2021-09-07 08:44:48 -0700 Committed r282087 (241387@main): <https://commits.webkit.org/241387@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437503. 1791037 5 webkit-bug-importer 2021-09-07 08:45:19 -0700 <rdar://problem/82823545> 437503 2021-09-07 07:57:23 -0700 2021-09-07 08:44:48 -0700 Patch bug-229971-20210907075722.patch text/plain 1669 jbedard U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyMDg0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjMyMmEyODNkYTEyMzdjM2NmYmMxMjE0MjBjMGYzYjUx OGE3ZjFhYS4uODg5MGQ2ZTIwNDU5Y2VlMDc0ODAwYzlkMTNhY2E0YzNlZTUzZGQzMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDIxLTA5LTA3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKwor ICAgICAgICBydW5fd2Via2l0X3Rlc3RzIGZhaWxlZCB0byBwcmludCBlcnJvciBtZXNzYWdlIGlu IHB5dGhvbjMgaW4gbGludXhfZ2V0X2NyYXNoX2xvZy5weQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5OTcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvbGludXhf Z2V0X2NyYXNoX2xvZy5weToKKyAgICAgICAgKEdEQkNyYXNoTG9nR2VuZXJhdG9yLl9nZXRfZ2Ri X291dHB1dCk6CisKIDIwMjEtMDktMDcgIENhcmxvcyBBbGJlcnRvIExvcGV6IFBlcmV6ICA8Y2xv cGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gVGhlIFh2ZmIgZGlzcGxheSBzZXJ2ZXIg bWF5IGZhaWwgdG8gc3RhcnQgc29tZXRpbWVzIGNhdXNpbmcgdGVzdHMgdG8gcmFuZG9tbHkgY3Jh c2ggKHYzKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2xpbnV4X2dl dF9jcmFzaF9sb2cucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvbGludXhfZ2V0X2Ny YXNoX2xvZy5weQppbmRleCBmMjhiYzc5ZWQ5NmRkOTlhMzQ4YmY1MzQzZDVkZjFhY2ViNTgzZWM3 Li5lMzQ5YjZjMDE5MzY3M2E0Mzc5MDM0NzU4OGYwZDEyNDA3MjA4YzJhIDEwMDY0NAotLS0gYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvbGludXhfZ2V0X2NyYXNoX2xvZy5weQorKysgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvbGludXhfZ2V0X2NyYXNoX2xvZy5weQpAQCAtNjAs NyArNjAsNyBAQCBjbGFzcyBHREJDcmFzaExvZ0dlbmVyYXRvcihvYmplY3QpOgogICAgICAgICBz dGRvdXQsIHN0ZGVyciA9IHByb2MuY29tbXVuaWNhdGUoKQogICAgICAgICBlcnJvcnMgPSBbc3Rk ZXJyX2xpbmUuc3RyaXAoKS5kZWNvZGUoJ3V0ZjgnLCAnaWdub3JlJykgZm9yIHN0ZGVycl9saW5l IGluIHN0ZGVyci5zcGxpdGxpbmVzKCldCiAgICAgICAgIGlmIHByb2MucmV0dXJuY29kZSAhPSAw OgotICAgICAgICAgICAgc3Rkb3V0ID0gKCdFUlJPUjogVGhlIGdkYiBwcm9jZXNzIGV4aXRlZCB3 aXRoIG5vbi16ZXJvIHJldHVybiBjb2RlICVzXG5cbicgJSBwcm9jLnJldHVybmNvZGUpICsgc3Rk b3V0CisgICAgICAgICAgICBzdGRvdXQgPSAoYidFUlJPUjogVGhlIGdkYiBwcm9jZXNzIGV4aXRl ZCB3aXRoIG5vbi16ZXJvIHJldHVybiBjb2RlICVzXG5cbicgJSBzdHIocHJvYy5yZXR1cm5jb2Rl KSkgKyBzdGRvdXQKICAgICAgICAgcmV0dXJuIChzdGRvdXQuZGVjb2RlKCd1dGY4JywgJ2lnbm9y ZScpLCBlcnJvcnMpCiAKICAgICBkZWYgX2dldF90bXBfZmlsZV9uYW1lKHNlbGYsIGNvcmVkdW1w Y3RsLCBmaWxlbmFtZSk6Cg==