229961 2021-09-06 07:06:01 -0700 Gracefully handle security bugs in apply-watchlist 2021-09-24 15:11:50 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap ews-watchlist glenn jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1790696 0 aakash_jain 2021-09-06 07:06:01 -0700 Currently security bugs fails in apply-watchlist ews with a misleading exception which doesn't really indicate the reason for failure. e.g.: https://ews-build.webkit.org/#/builders/21/builds/52652/steps/9/logs/stdio File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run step(tool, options).run(state) File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/tool/steps/applywatchlist.py", line 53, in run bug = self._tool.bugs.fetch_bug(bug_id) File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 493, in fetch_bug return Bug(self.fetch_bug_dictionary(bug_id), self) File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 486, in fetch_bug_dictionary return self._parse_bug_dictionary_from_xml(self._fetch_bug_page(bug_id)) File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 462, in _parse_bug_dictionary_from_xml bug["title"] = self._string_contents(soup.find("short_desc")) File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 402, in _string_contents return unicode(soup.string) AttributeError: 'NoneType' object has no attribute 'string' The real reason is that the bots which run the webkitpy command to apply watchlist do not have access to security bugs. We should gracefully handle this case and improve the error message to clearly indicate what's happening. 1792938 1 webkit-bug-importer 2021-09-13 07:06:27 -0700 <rdar://problem/83053278> 1795837 2 438878 aakash_jain 2021-09-21 16:09:56 -0700 Created attachment 438878 Patch 1797048 3 ews-feeder 2021-09-24 15:11:48 -0700 Committed r283061 (242119@main): <https://commits.webkit.org/242119@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438878. 438878 2021-09-21 16:09:56 -0700 2021-09-24 15:11:49 -0700 Patch bug-229961-20210921190955.patch text/plain 1973 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI4Mjg0OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIxLTA5LTIxICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBHcmFjZWZ1bGx5IGhhbmRsZSBzZWN1cml0eSBidWdzIGluIGFwcGx5LXdh dGNobGlzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjI5OTYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVnemlsbGEvYnVnemlsbGEucHk6CisgICAg ICAgIChCdWd6aWxsYS5fcGFyc2VfYnVnX2RpY3Rpb25hcnlfZnJvbV94bWwpOgorICAgICAgICAo QnVnemlsbGEuZmV0Y2hfYnVnKToKKwogMjAyMS0wOS0yMSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpA YXBwbGUuY29tPgogCiAgICAgICAgIERyb3AgbWFrZVJlZlB0cigpIGFuZCB1c2UgUmVmUHRyIHsg fSBkaXJlY3RseSBpbnN0ZWFkCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9u ZXQvYnVnemlsbGEvYnVnemlsbGEucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tb24vbmV0L2J1Z3ppbGxhL2J1Z3ppbGxhLnB5CShyZXZpc2lvbiAyODI4NDgpCisr KyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVnemlsbGEvYnVnemlsbGEucHkJ KHdvcmtpbmcgY29weSkKQEAgLTQ1Nyw2ICs0NTcsMTAgQEAgY2xhc3MgQnVnemlsbGEob2JqZWN0 KToKIAogICAgIGRlZiBfcGFyc2VfYnVnX2RpY3Rpb25hcnlfZnJvbV94bWwoc2VsZiwgcGFnZSk6 CiAgICAgICAgIHNvdXAgPSBCZWF1dGlmdWxTdG9uZVNvdXAocGFnZSwgY29udmVydEVudGl0aWVz PUJlYXV0aWZ1bFN0b25lU291cC5YTUxfRU5USVRJRVMpCisgICAgICAgIGJ1Z19lbGVtZW50ID0g c291cC5maW5kKCdidWcnKQorICAgICAgICBpZiBidWdfZWxlbWVudCBhbmQgYnVnX2VsZW1lbnQu Z2V0KCdlcnJvcicsICcnKSA9PSAnTm90UGVybWl0dGVkJzoKKyAgICAgICAgICAgIF9sb2cud2Fy bmluZygiWW91IGRvbid0IGhhdmUgcGVybWlzc2lvbiB0byB2aWV3IHRoaXMgYnVnLiIpCisgICAg ICAgICAgICByZXR1cm4ge30KICAgICAgICAgYnVnID0ge30KICAgICAgICAgYnVnWyJpZCJdID0g aW50KHNvdXAuZmluZCgiYnVnX2lkIikuc3RyaW5nKQogICAgICAgICBidWdbInRpdGxlIl0gPSBz ZWxmLl9zdHJpbmdfY29udGVudHMoc291cC5maW5kKCJzaG9ydF9kZXNjIikpCkBAIC00OTAsNyAr NDk0LDEwIEBAIGNsYXNzIEJ1Z3ppbGxhKG9iamVjdCk6CiAgICAgIyBGSVhNRTogQSBCdWd6aWxs YUNhY2hlIG9iamVjdCBzaG91bGQgcHJvdmlkZSBhbGwgdGhlc2UgZmV0Y2hfIG1ldGhvZHMuCiAK ICAgICBkZWYgZmV0Y2hfYnVnKHNlbGYsIGJ1Z19pZCk6Ci0gICAgICAgIHJldHVybiBCdWcoc2Vs Zi5mZXRjaF9idWdfZGljdGlvbmFyeShidWdfaWQpLCBzZWxmKQorICAgICAgICBidWdfZGljdGlv bmFyeSA9IHNlbGYuZmV0Y2hfYnVnX2RpY3Rpb25hcnkoYnVnX2lkKQorICAgICAgICBpZiBidWdf ZGljdGlvbmFyeToKKyAgICAgICAgICAgIHJldHVybiBCdWcoYnVnX2RpY3Rpb25hcnksIHNlbGYp CisgICAgICAgIHJldHVybiBOb25lCiAKICAgICBkZWYgZmV0Y2hfYXR0YWNobWVudF9jb250ZW50 cyhzZWxmLCBhdHRhY2htZW50X2lkKToKICAgICAgICAgYXR0YWNobWVudF91cmwgPSBzZWxmLmF0 dGFjaG1lbnRfdXJsX2Zvcl9pZChhdHRhY2htZW50X2lkKQo=