229960 2021-09-06 07:05:40 -0700 Add layout test for performance of adding children to a shadow host 2021-09-06 23:35:22 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 229680 1 koivisto webkit-unassigned ap darin gsnedders rniwa webkit-bug-importer oldest_to_newest 1790695 0 koivisto 2021-09-06 07:05:40 -0700 It was very O(n^2). 1790698 1 437411 koivisto 2021-09-06 07:09:43 -0700 Created attachment 437411 patch 1790744 2 437426 koivisto 2021-09-06 11:11:03 -0700 Created attachment 437426 patch 1790780 3 437426 rniwa 2021-09-06 14:11:28 -0700 Comment on attachment 437426 patch View in context: https://bugs.webkit.org/attachment.cgi?id=437426&action=review > LayoutTests/fast/shadow-dom/host-child-append-performance.html:11 > +for (i = 0; i < 10000; ++i) > + host.appendChild(document.createElement("div")); Wouldn't this test start passing on a very fast machine even if this got broken or start failing on a very slow machine without any regression? I guess there is no way around it. 1790868 4 koivisto 2021-09-06 23:11:58 -0700 In theory, but this is really far from passing, especially on debug build. 1790869 5 koivisto 2021-09-06 23:13:14 -0700 (without the fix that is) 1790871 6 ews-feeder 2021-09-06 23:34:42 -0700 Committed r282073 (241373@main): <https://commits.webkit.org/241373@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437426. 1790872 7 webkit-bug-importer 2021-09-06 23:35:22 -0700 <rdar://problem/82808890> 437411 2021-09-06 07:09:43 -0700 2021-09-06 11:11:03 -0700 patch host-perf-test.patch text/plain 1630 koivisto ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhYmNlZWJiYjYwOWUuLmZlOTdiZDk2ODhhYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBA CisyMDIxLTA5LTA2ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAg ICBBZGQgbGF5b3V0IHRlc3QgZm9yIHBlcmZvcm1hbmNlIG9mIGFkZGluZyBjaGlsZHJlbiB0byBh IHNoYWRvdyBob3N0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjk5NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGZhc3Qvc2hhZG93LWRvbS9ob3N0LWNoaWxkLWFwcGVuZC1wZXJmb3JtYW5jZS1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3Qvc2hhZG93LWRvbS9ob3N0LWNoaWxkLWFw cGVuZC1wZXJmb3JtYW5jZS5odG1sOiBBZGRlZC4KKwogMjAyMS0wOS0wNiAgWW91ZW5uIEZhYmxl dCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IGxpYndlYnJ0YyBuZXR3 b3JrIG1hbmFnZXIgR2V0TWRuc1Jlc3BvbmRlcgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9zaGFkb3ctZG9tL2hvc3QtY2hpbGQtYXBwZW5kLXBlcmZvcm1hbmNlLWV4cGVjdGVkLnR4dCBi L0xheW91dFRlc3RzL2Zhc3Qvc2hhZG93LWRvbS9ob3N0LWNoaWxkLWFwcGVuZC1wZXJmb3JtYW5j ZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwLi40 NTgyYmViYmM3NTkKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3NoYWRvdy1k b20vaG9zdC1jaGlsZC1hcHBlbmQtcGVyZm9ybWFuY2UtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEs MiBAQAorVGhpcyB0ZXN0IHBhc3NlcyBpZiBpdCBkb2Vzbid0IHRpbWUgb3V0CisKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2Zhc3Qvc2hhZG93LWRvbS9ob3N0LWNoaWxkLWFwcGVuZC1wZXJmb3Jt YW5jZS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9zaGFkb3ctZG9tL2hvc3QtY2hpbGQtYXBwZW5k LXBlcmZvcm1hbmNlLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw Li5lMDNlNmFmZjYwMTEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3NoYWRv dy1kb20vaG9zdC1jaGlsZC1hcHBlbmQtcGVyZm9ybWFuY2UuaHRtbApAQCAtMCwwICsxLDEyIEBA Cis8ZGl2IGlkPWhvc3Q+VGhpcyB0ZXN0IHBhc3NlcyBpZiBpdCBkb2Vzbid0IHRpbWUgb3V0PC9k aXY+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgIHRlc3RSdW5uZXIuZHVt cEFzVGV4dCgpOworCitjb25zdCBzaGFkb3cgPSBob3N0LmF0dGFjaFNoYWRvdyh7IG1vZGU6ICJv cGVuIiB9KTsKK3NoYWRvdy5pbm5lckhUTUwgPSBgCisgICAgPHNsb3Q+PC9zbG90PgorYDsKK2Zv ciAoaSA9IDA7IGkgPCAxMDAwMDsgKytpKQorICAgIGhvc3QuYXBwZW5kQ2hpbGQoZG9jdW1lbnQu Y3JlYXRlRWxlbWVudCgiZGl2IikpOworPC9zY3JpcHQ+Cg== 437426 2021-09-06 11:11:03 -0700 2021-09-06 23:34:43 -0700 patch host-perf-test-3.patch text/plain 1702 koivisto ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhYmNlZWJiYjYwOWUuLmYzZDM3NDNmODhlYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBA CisyMDIxLTA5LTA2ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAg ICBBZGQgbGF5b3V0IHRlc3QgZm9yIHBlcmZvcm1hbmNlIG9mIGFkZGluZyBjaGlsZHJlbiB0byBh IHNoYWRvdyBob3N0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjk5NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBZGQgdGVzdCBmb3IgaHR0cHM6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzI4MTgx My93ZWJraXQKKworICAgICAgICAqIGZhc3Qvc2hhZG93LWRvbS9ob3N0LWNoaWxkLWFwcGVuZC1w ZXJmb3JtYW5jZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3Qvc2hhZG93LWRv bS9ob3N0LWNoaWxkLWFwcGVuZC1wZXJmb3JtYW5jZS5odG1sOiBBZGRlZC4KKwogMjAyMS0wOS0w NiAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50 IGxpYndlYnJ0YyBuZXR3b3JrIG1hbmFnZXIgR2V0TWRuc1Jlc3BvbmRlcgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZmFzdC9zaGFkb3ctZG9tL2hvc3QtY2hpbGQtYXBwZW5kLXBlcmZvcm1hbmNl LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3Qvc2hhZG93LWRvbS9ob3N0LWNoaWxkLWFw cGVuZC1wZXJmb3JtYW5jZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMDAwMDAwLi40NTgyYmViYmM3NTkKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L3NoYWRvdy1kb20vaG9zdC1jaGlsZC1hcHBlbmQtcGVyZm9ybWFuY2UtZXhwZWN0ZWQu dHh0CkBAIC0wLDAgKzEsMiBAQAorVGhpcyB0ZXN0IHBhc3NlcyBpZiBpdCBkb2Vzbid0IHRpbWUg b3V0CisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qvc2hhZG93LWRvbS9ob3N0LWNoaWxk LWFwcGVuZC1wZXJmb3JtYW5jZS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9zaGFkb3ctZG9tL2hv c3QtY2hpbGQtYXBwZW5kLXBlcmZvcm1hbmNlLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwLi5lMDNlNmFmZjYwMTEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L3NoYWRvdy1kb20vaG9zdC1jaGlsZC1hcHBlbmQtcGVyZm9ybWFuY2UuaHRtbApA QCAtMCwwICsxLDEyIEBACis8ZGl2IGlkPWhvc3Q+VGhpcyB0ZXN0IHBhc3NlcyBpZiBpdCBkb2Vz bid0IHRpbWUgb3V0PC9kaXY+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAg IHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworCitjb25zdCBzaGFkb3cgPSBob3N0LmF0dGFjaFNo YWRvdyh7IG1vZGU6ICJvcGVuIiB9KTsKK3NoYWRvdy5pbm5lckhUTUwgPSBgCisgICAgPHNsb3Q+ PC9zbG90PgorYDsKK2ZvciAoaSA9IDA7IGkgPCAxMDAwMDsgKytpKQorICAgIGhvc3QuYXBwZW5k Q2hpbGQoZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2IikpOworPC9zY3JpcHQ+Cg==