229928 2021-09-05 18:28:14 -0700 [Win] PlatformWebView::simulateSpacebarKeyPress sends wrong scan code for the space key and Alt key 2021-09-07 19:13:15 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii don.olmstead ross.kirsling webkit-bug-importer oldest_to_newest 1790590 0 fujii 2021-09-05 18:28:14 -0700 [Win] PlatformWebView::simulateSpacebarKeyPress sends a wrong scan code for the space key PlatformWebView::simulateSpacebarKeyPress sends 39, but it should be 0x39. PlatformWebView::simulateAltKeyPress send 38, but it should be 0x38. These code were originally added by r69671. The scan codes are defined in WindowsKeyNames.cpp. https://github.com/WebKit/WebKit/blob/1447dba3960bb20229b5caefdcd61a3f9a2bf276/Source/WebCore/platform/win/WindowsKeyNames.cpp#L362,L363 > { 0x0038, "AltLeft"_s }, > { 0x0039, "Space"_s }, 1790591 1 437372 fujii 2021-09-05 18:33:04 -0700 Created attachment 437372 Patch 1791322 2 437372 fujii 2021-09-07 19:12:15 -0700 Comment on attachment 437372 Patch Clearing flags on attachment: 437372 Committed r282124 (241421@main): <https://commits.webkit.org/241421@main> 1791323 3 fujii 2021-09-07 19:12:18 -0700 All reviewed patches have been landed. Closing bug. 1791324 4 webkit-bug-importer 2021-09-07 19:13:15 -0700 <rdar://problem/82850842> 437372 2021-09-05 18:33:04 -0700 2021-09-07 19:12:15 -0700 Patch bug-229928-20210906103303.patch text/plain 3238 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxOTcxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWRkMjU2YmNiMTM3MTA3YzZmNWE0ODA2NmI3Y2FmMDlh NjI1NWU3NS4uZmM5YjhkMDA0ZmI0N2UxNzc1MTRkNGUwOWMyZjljOTM5ZTk3MTQ1MCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDIxLTA5LTA1ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIFtXaW5dIFBsYXRmb3JtV2ViVmlldzo6c2ltdWxhdGVTcGFjZWJhcktleVBy ZXNzIHNlbmRzIHdyb25nIHNjYW4gY29kZSBmb3IgdGhlIHNwYWNlIGtleSBhbmQgQWx0IGtleQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5OTI4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGxhdGZvcm1X ZWJWaWV3OjpzaW11bGF0ZVNwYWNlYmFyS2V5UHJlc3Mgc2VudCAzOSwgYnV0IGl0IHNob3VsZCBi ZSAweDM5LgorICAgICAgICBQbGF0Zm9ybVdlYlZpZXc6OnNpbXVsYXRlQWx0S2V5UHJlc3Mgc2Vu dCAzOCwgYnV0IGl0IHNob3VsZCBiZSAweDM4LgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS93 aW4vUGxhdGZvcm1XZWJWaWV3V2luLmNwcDoKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlBsYXRm b3JtV2ViVmlldzo6c2ltdWxhdGVTcGFjZWJhcktleVByZXNzKToKKyAgICAgICAgKFRlc3RXZWJL aXRBUEk6OlBsYXRmb3JtV2ViVmlldzo6c2ltdWxhdGVBbHRLZXlQcmVzcyk6CisKIDIwMjEtMDkt MDIgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAgIFt3ZWJr aXQtcGF0Y2hdIGFwcGx5LXdhdGNobGlzdCBjb21tYW5kIGZhaWxzIG9uIHB5dGhvbiAzIChGb2xs b3ctdXAgZml4KQpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS93aW4vUGxhdGZvcm1X ZWJWaWV3V2luLmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvd2luL1BsYXRmb3JtV2ViVmlld1dp bi5jcHAKaW5kZXggZmJkN2MwOTNiYTE1MzA0MzY0M2RkZjM0OGE0ZGJhMzdjN2ZhNTNiNC4uMGNl M2I3MTU2ZTVjMGNkYmNlMjE1YjhjODJjODA0NDZiZWJiYzZkMiAxMDA2NDQKLS0tIGEvVG9vbHMv VGVzdFdlYktpdEFQSS93aW4vUGxhdGZvcm1XZWJWaWV3V2luLmNwcAorKysgYi9Ub29scy9UZXN0 V2ViS2l0QVBJL3dpbi9QbGF0Zm9ybVdlYlZpZXdXaW4uY3BwCkBAIC0xMTEsOSArMTExLDkgQEAg dm9pZCBQbGF0Zm9ybVdlYlZpZXc6OnNpbXVsYXRlU3BhY2ViYXJLZXlQcmVzcygpCiAgICAgSFdO RCB3aW5kb3cgPSBXS1ZpZXdHZXRXaW5kb3cobV92aWV3KTsKIAogICAgIC8vIFRoZXNlIHZhbHVl cyBtYXRjaCB3aGF0IGhhcHBlbnMgd2hlbiB5b3UgcHJlc3MgdGhlIHNwYWNlYmFyIGluIE5vdGVw YWQsIGFzIG9ic2VydmVkIGJ5IFNweSsrLgotICAgIDo6U2VuZE1lc3NhZ2VXKHdpbmRvdywgV01f S0VZRE9XTiwgVktfU1BBQ0UsICgxIDw8IHJlcGVhdENvdW50Qml0T2Zmc2V0KSB8ICgzOSA8PCBz Y2FuQ29kZUJpdE9mZnNldCkpOwotICAgIDo6U2VuZE1lc3NhZ2VXKHdpbmRvdywgV01fQ0hBUiwg JyAnLCAoMSA8PCByZXBlYXRDb3VudEJpdE9mZnNldCkgfCAoMzkgPDwgc2NhbkNvZGVCaXRPZmZz ZXQpKTsKLSAgICA6OlNlbmRNZXNzYWdlVyh3aW5kb3csIFdNX0tFWVVQLCBWS19TUEFDRSwgKDEg PDwgcmVwZWF0Q291bnRCaXRPZmZzZXQpIHwgKDM5IDw8IHNjYW5Db2RlQml0T2Zmc2V0KSB8ICgx IDw8IHByZXZpb3VzU3RhdGVCaXRPZmZzZXQpIHwgKDEgPDwgdHJhbnNpdGlvblN0YXRlQml0T2Zm c2V0KSk7CisgICAgOjpTZW5kTWVzc2FnZVcod2luZG93LCBXTV9LRVlET1dOLCBWS19TUEFDRSwg KDEgPDwgcmVwZWF0Q291bnRCaXRPZmZzZXQpIHwgKDB4MzkgPDwgc2NhbkNvZGVCaXRPZmZzZXQp KTsKKyAgICA6OlNlbmRNZXNzYWdlVyh3aW5kb3csIFdNX0NIQVIsICcgJywgKDEgPDwgcmVwZWF0 Q291bnRCaXRPZmZzZXQpIHwgKDB4MzkgPDwgc2NhbkNvZGVCaXRPZmZzZXQpKTsKKyAgICA6OlNl bmRNZXNzYWdlVyh3aW5kb3csIFdNX0tFWVVQLCBWS19TUEFDRSwgKDEgPDwgcmVwZWF0Q291bnRC aXRPZmZzZXQpIHwgKDB4MzkgPDwgc2NhbkNvZGVCaXRPZmZzZXQpIHwgKDEgPDwgcHJldmlvdXNT dGF0ZUJpdE9mZnNldCkgfCAoMSA8PCB0cmFuc2l0aW9uU3RhdGVCaXRPZmZzZXQpKTsKIH0KIAog dm9pZCBQbGF0Zm9ybVdlYlZpZXc6OnNpbXVsYXRlQWx0S2V5UHJlc3MoKQpAQCAtMTIxLDggKzEy MSw4IEBAIHZvaWQgUGxhdGZvcm1XZWJWaWV3OjpzaW11bGF0ZUFsdEtleVByZXNzKCkKICAgICBI V05EIHdpbmRvdyA9IFdLVmlld0dldFdpbmRvdyhtX3ZpZXcpOwogCiAgICAgLy8gVGhlc2UgdmFs dWVzIG1hdGNoIHdoYXQgaGFwcGVucyB3aGVuIHlvdSBwcmVzcyB0aGUgQWx0IGtleSBpbiBOb3Rl cGFkLCBhcyBvYnNlcnZlZCBieSBTcHkrKy4KLSAgICA6OlNlbmRNZXNzYWdlVyh3aW5kb3csIFdN X1NZU0tFWURPV04sIFZLX01FTlUsICgxIDw8IHJlcGVhdENvdW50Qml0T2Zmc2V0KSB8ICgzOCA8 PCBzY2FuQ29kZUJpdE9mZnNldCkgfCAoMSA8PCBjb250ZXh0Q29kZUJpdE9mZnNldCkpOwotICAg IDo6U2VuZE1lc3NhZ2VXKHdpbmRvdywgV01fU1lTS0VZVVAsIFZLX01FTlUsICgxIDw8IHJlcGVh dENvdW50Qml0T2Zmc2V0KSB8ICgzOCA8PCBzY2FuQ29kZUJpdE9mZnNldCkgfCAoMSA8PCBwcmV2 aW91c1N0YXRlQml0T2Zmc2V0KSB8ICgxIDw8IHRyYW5zaXRpb25TdGF0ZUJpdE9mZnNldCkpOwor ICAgIDo6U2VuZE1lc3NhZ2VXKHdpbmRvdywgV01fU1lTS0VZRE9XTiwgVktfTUVOVSwgKDEgPDwg cmVwZWF0Q291bnRCaXRPZmZzZXQpIHwgKDB4MzggPDwgc2NhbkNvZGVCaXRPZmZzZXQpIHwgKDEg PDwgY29udGV4dENvZGVCaXRPZmZzZXQpKTsKKyAgICA6OlNlbmRNZXNzYWdlVyh3aW5kb3csIFdN X1NZU0tFWVVQLCBWS19NRU5VLCAoMSA8PCByZXBlYXRDb3VudEJpdE9mZnNldCkgfCAoMHgzOCA8 PCBzY2FuQ29kZUJpdE9mZnNldCkgfCAoMSA8PCBwcmV2aW91c1N0YXRlQml0T2Zmc2V0KSB8ICgx IDw8IHRyYW5zaXRpb25TdGF0ZUJpdE9mZnNldCkpOwogfQogCiB2b2lkIFBsYXRmb3JtV2ViVmll dzo6c2ltdWxhdGVSaWdodENsaWNrKHVuc2lnbmVkIHgsIHVuc2lnbmVkIHkpCg==