22992 2008-12-25 02:17:23 -0800 Javascript console should not attempt to scroll to end of console if console is not visible 2010-02-25 14:15:01 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 oliver apavlov apavlov commit-queue pfeldman rik timothy oldest_to_newest 103405 0 oliver 2008-12-25 02:17:23 -0800 * SUMMARY Whenever a message is sent to the console the web inspector attempts to scroll the appropriate portion of the console to be visible. Unfortunately if the console is not visible, this is very heavy wait operation as it requires building the rendertree, calculating where it should scroll to, then throwing the rendertree away. * STEPS TO REPRODUCE 1. use javascript along the lines of javascript:while(1) console.log("foo") * RESULTS Shark shows 94% of time being spent in style recalc. <rdar://problem/6467200> 193726 1 apavlov 2010-02-25 08:14:27 -0800 This scenario is also extremely slow when the console is visible. The scrollIntoView calls should be throttled. 193729 2 49489 apavlov 2010-02-25 08:21:40 -0800 Created attachment 49489 [PATCH] Proposed solution 193878 3 49489 commit-queue 2010-02-25 14:14:57 -0800 Comment on attachment 49489 [PATCH] Proposed solution Clearing flags on attachment: 49489 Committed r55255: <http://trac.webkit.org/changeset/55255> 193879 4 commit-queue 2010-02-25 14:15:01 -0800 All reviewed patches have been landed. Closing bug. 49489 2010-02-25 08:21:40 -0800 2010-02-25 14:14:57 -0800 [PATCH] Proposed solution consolescroll.patch text/plain 1928 apavlov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDhhZTdlYi4uM2UzM2E0ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wMi0yNSAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEphdmFzY3JpcHQgY29uc29sZSBzaG91bGQgbm90IGF0dGVt cHQgdG8gc2Nyb2xsIHRvIGVuZCBvZiBjb25zb2xlIGlmIGNvbnNvbGUgaXMgbm90IHZpc2libGUK KworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5OTIK KworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZVZpZXcuanM6CisgICAgICAg IChXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcucHJvdG90eXBlLl9zY2hlZHVsZVNjcm9sbEludG9W aWV3LnNjcm9sbEludG9WaWV3KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db25zb2xlVmlldy5w cm90b3R5cGUuX3NjaGVkdWxlU2Nyb2xsSW50b1ZpZXcpOgorICAgICAgICAoV2ViSW5zcGVjdG9y LkNvbnNvbGVWaWV3LnByb3RvdHlwZS5hZGRNZXNzYWdlKToKKwogMjAxMC0wMi0yMyAgSm9jZWx5 biBUdXJjb3R0ZSAgPGpvY2VseW4udHVyY290dGVAbm9raWEuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IFRvciBBcm5lIFZlc3Riw7guCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvQ29uc29sZVZpZXcuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29u c29sZVZpZXcuanMKaW5kZXggMDdkOTgxMi4uNDg5Yzc4OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9Db25zb2xlVmlldy5qcwpAQCAtMjE1LDYgKzIxNSwxOSBAQCBXZWJJbnNwZWN0 b3IuQ29uc29sZVZpZXcucHJvdG90eXBlID0gewogICAgICAgICB0aGlzLnRvZ2dsZUNvbnNvbGVC dXR0b24udGl0bGUgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlNob3cgY29uc29sZS4iKTsKICAg ICB9LAogCisgICAgX3NjaGVkdWxlU2Nyb2xsSW50b1ZpZXc6IGZ1bmN0aW9uKCkKKyAgICB7Cisg ICAgICAgIGlmICh0aGlzLl9zY3JvbGxJbnRvVmlld1RpbWVyKQorICAgICAgICAgICAgcmV0dXJu OworCisgICAgICAgIGZ1bmN0aW9uIHNjcm9sbEludG9WaWV3KCkKKyAgICAgICAgeworICAgICAg ICAgICAgdGhpcy5wcm9tcHRFbGVtZW50LnNjcm9sbEludG9WaWV3KGZhbHNlKTsKKyAgICAgICAg ICAgIGRlbGV0ZSB0aGlzLl9zY3JvbGxJbnRvVmlld1RpbWVyOworICAgICAgICB9CisgICAgICAg IHRoaXMuX3Njcm9sbEludG9WaWV3VGltZXIgPSBzZXRUaW1lb3V0KHNjcm9sbEludG9WaWV3LmJp bmQodGhpcyksIDIwKTsKKyAgICB9LAorCiAgICAgYWRkTWVzc2FnZTogZnVuY3Rpb24obXNnKQog ICAgIHsKICAgICAgICAgaWYgKG1zZyBpbnN0YW5jZW9mIFdlYkluc3BlY3Rvci5Db25zb2xlTWVz c2FnZSAmJiAhKG1zZyBpbnN0YW5jZW9mIFdlYkluc3BlY3Rvci5Db25zb2xlQ29tbWFuZFJlc3Vs dCkpIHsKQEAgLTI1Niw3ICsyNjksNyBAQCBXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcucHJvdG90 eXBlID0gewogICAgICAgICAgICAgdGhpcy5jdXJyZW50R3JvdXAuYWRkTWVzc2FnZShtc2cpOwog ICAgICAgICB9CiAKLSAgICAgICAgdGhpcy5wcm9tcHRFbGVtZW50LnNjcm9sbEludG9WaWV3KGZh bHNlKTsKKyAgICAgICAgdGhpcy5fc2NoZWR1bGVTY3JvbGxJbnRvVmlldygpOwogICAgIH0sCiAK ICAgICB1cGRhdGVNZXNzYWdlUmVwZWF0Q291bnQ6IGZ1bmN0aW9uKGNvdW50KQo=