229909 2021-09-03 19:25:17 -0700 -webkit-image-set() should be an alias of image-set() 2023-02-27 08:14:25 -0800 1 1 1 Unclassified WebKit CSS WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=206909 https://github.com/web-platform-tests/wpt/pull/38394 https://bugs.webkit.org/show_bug.cgi?id=251811 https://wpt.fyi/results/css/css-images/image-set/image-set-parsing.html?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&view=interop&q=label%3Ainterop-2023-webcompat BrowserCompat, InRadar, WPTImpact P2 Normal --- 203788 1 gsnedders rreno karlcow rreno webkit-bug-importer oldest_to_newest 1790466 0 gsnedders 2021-09-03 19:25:17 -0700 Per https://github.com/w3c/csswg-drafts/issues/6285, it was decided to make -webkit-image-set a parse-time alias. 1792639 1 webkit-bug-importer 2021-09-10 19:26:17 -0700 <rdar://problem/82999675> 1799277 2 gsnedders 2021-10-01 06:52:20 -0700 per bug 206909 we did actually briefly do this, but this then got reverted due to Gmail breakage, gonna file a new bug for fixing the underlying issue there and mark this as blocked on that 1909280 3 gsnedders 2022-10-31 04:05:51 -0700 The prior Gmail issue no longer seems to trivially reproduce, as empty URLs in image-set no longer cause a broken image icon to be shown. 1928542 4 karlcow 2023-01-26 00:13:10 -0800 Not sure why some of these tests are failing http://wpt.live/css/css-images/image-set/image-set-parsing.html But manually it is working. > document.body.style.backgroundImage < "" > document.body.style['background-image'] < "" > document.body.style.backgroundImage = "-webkit-image-set(url('example.png') 1x)" < "-webkit-image-set(url('example.png') 1x)" > document.body.style.backgroundImage < "image-set(url(\"example.png\") 1x)" > document.body.style['background-image'] < "image-set(url(\"example.png\") 1x)" > document.body.style.getPropertyValue("background-image") < "image-set(url(\"example.png\") 1x)" 1928543 5 karlcow 2023-01-26 00:14:07 -0800 Probably necessary for Interop2023. Note that -webkit-image-set() is already an alias of image-set 1929360 6 gsnedders 2023-01-30 04:31:14 -0800 It sorta is and sorta isn't. It still has its own parser: https://github.com/WebKit/WebKit/blob/1e76207c4357149a69994b53bb756f31996c13df/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp#L4666 1929361 7 karlcow 2023-01-30 04:41:32 -0800 Ah thanks for the link, Sam. I need to dig into this for understanding the differences. 1931515 8 rreno 2023-02-06 15:04:17 -0800 I can't reproduce the gmail issue with this simple diff: diff --git a/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp b/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp index 173d2397e7c4..5c836404e9ba 100644 --- a/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp +++ b/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp @@ -4672,10 +4672,8 @@ RefPtr<CSSValue> consumeImage(CSSParserTokenRange& range, const CSSParserContext return consumeGeneratedImage(range, context); if (allowedImageTypes.contains(AllowedImageType::ImageSet)) { - if (functionId == CSSValueImageSet) + if (functionId == CSSValueImageSet || functionId == CSSValueWebkitImageSet) return consumeImageSet(range, context, (allowedImageTypes | AllowedImageType::RawStringAsURL) - AllowedImageType::ImageSet); - if (functionId == CSSValueWebkitImageSet) - return consumeImageSet(range, context, AllowedImageType::URLFunction); } } But that diff does progress some of the WPT subtests we are currently failing because we don't implement -webkit-image-set as an alias. 1931521 9 rreno 2023-02-06 15:21:02 -0800 Pull request: https://github.com/WebKit/WebKit/pull/9718 1931778 10 rreno 2023-02-07 11:20:39 -0800 Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/38394 1931937 11 ews-feeder 2023-02-07 22:50:51 -0800 Committed 259994@main (5e38273c02f7): <https://commits.webkit.org/259994@main> Reviewed commits have been landed. Closing PR #9718 and removing active labels.