229903 2021-09-03 16:04:56 -0700 Clean up some mask-related properties in CSSProperties.json 2021-09-04 10:02:52 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 229082 1 simon.fraser simon.fraser darin esprehn+autocc ews-watchlist glenn gyuyoung.kim joepeck macpherson menard simon.fraser oldest_to_newest 1790420 0 simon.fraser 2021-09-03 16:04:56 -0700 Clean up some mask-related properties in CSSProperties.json 1790421 1 437321 simon.fraser 2021-09-03 16:07:26 -0700 Created attachment 437321 Patch 1790432 2 437321 darin 2021-09-03 16:46:07 -0700 Comment on attachment 437321 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437321&action=review > Source/WebCore/ChangeLog:10 > + Remove "status": "experimental" from a bunch of mask-related properties, since they are no longer > + experimental. Mark -webkit-mask-position-x and -webkit-mask-position-y as internal-only, since they don't > + appear in the css-masking spec. Fix some formatting issues. What does it mean to mark -webkit-mask-position-x as internal only? Does it mean the property won’t be exposed to websites? 1790437 3 simon.fraser 2021-09-03 17:09:38 -0700 (In reply to Darin Adler from comment #2) > Comment on attachment 437321 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=437321&action=review > > > Source/WebCore/ChangeLog:10 > > + Remove "status": "experimental" from a bunch of mask-related properties, since they are no longer > > + experimental. Mark -webkit-mask-position-x and -webkit-mask-position-y as internal-only, since they don't > > + appear in the css-masking spec. Fix some formatting issues. > > What does it mean to mark -webkit-mask-position-x as internal only? Does it > mean the property won’t be exposed to websites? It means that they don't appear in computed style or style properties, and they don't parse. 1790438 4 simon.fraser 2021-09-03 17:13:35 -0700 It's possible that this is not web compatible. https://www.chromestatus.com/metrics/css/popularity says that -webkit-mask-position-x is used on 0.093755% of page loads. I may have to only make the unprefixed versions internal. 437321 2021-09-03 16:07:26 -0700 2021-09-03 21:47:55 -0700 Patch bug-229903-20210903160725.patch text/plain 6977 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxOTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzk5MWI1ZjA2NjlkNDNk ODA3YzMzMzRmYWMzYmM1MjgwOGJlZjRhYy4uZmIyMzk4Y2NjZDBjOTZhYTgyN2Q3OGNiMzMxYWE4 ZmIxYjk3NDE3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA5LTAzICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIENsZWFuIHVwIHNv bWUgbWFzay1yZWxhdGVkIHByb3BlcnRpZXMgaW4gQ1NTUHJvcGVydGllcy5qc29uCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjk5MDMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgInN0YXR1cyI6 ICJleHBlcmltZW50YWwiIGZyb20gYSBidW5jaCBvZiBtYXNrLXJlbGF0ZWQgcHJvcGVydGllcywg c2luY2UgdGhleSBhcmUgbm8gbG9uZ2VyCisgICAgICAgIGV4cGVyaW1lbnRhbC4gTWFyayAtd2Vi a2l0LW1hc2stcG9zaXRpb24teCBhbmQgLXdlYmtpdC1tYXNrLXBvc2l0aW9uLXkgYXMgaW50ZXJu YWwtb25seSwgc2luY2UgdGhleSBkb24ndAorICAgICAgICBhcHBlYXIgaW4gdGhlIGNzcy1tYXNr aW5nIHNwZWMuIEZpeCBzb21lIGZvcm1hdHRpbmcgaXNzdWVzLgorCisgICAgICAgICogY3NzL0NT U1Byb3BlcnRpZXMuanNvbjoKKwogMjAyMS0wOS0wMyAgUGVuZyBMaXUgIDxwZW5nLmxpdTZAYXBw bGUuY29tPgogCiAgICAgICAgIFtpT1NdIE1lZGlhIHBsYXliYWNrIGNvbnRpbnVlcyBhZnRlciBi YWNrZ3JvdW5kaW5nIFNhZmFyaQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1By b3BlcnRpZXMuanNvbiBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcm9wZXJ0aWVzLmpzb24KaW5k ZXggNzJkNzE2ZDljMGU1ZjlkMjUzZDExNDg2OWI3ZDg4ODRjNDQ5NzQ1MS4uZDZlOTBmNGU5OTY1 NjgyMGRlNzQzMDc4YTY0OWU5YzZiMjEyMGE3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv Y3NzL0NTU1Byb3BlcnRpZXMuanNvbgorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJvcGVy dGllcy5qc29uCkBAIC02MjE5LDkgKzYyMTksNiBAQAogICAgICAgICAgICAgICAgICAgICAiLXdl YmtpdC1tYXNrLWNsaXAiCiAgICAgICAgICAgICAgICAgXQogICAgICAgICAgICAgfSwKLSAgICAg ICAgICAgICJzdGF0dXMiOiB7Ci0gICAgICAgICAgICAgICAgInN0YXR1cyI6ICJleHBlcmltZW50 YWwiCi0gICAgICAgICAgICB9LAogICAgICAgICAgICAgInNwZWNpZmljYXRpb24iOiB7CiAgICAg ICAgICAgICAgICAgImNhdGVnb3J5IjogImNzcy1tYXNraW5nIiwKICAgICAgICAgICAgICAgICAi dXJsIjogImh0dHBzOi8vd3d3LnczLm9yZy9UUi9jc3MtbWFza2luZy0xLyNwcm9wZGVmLW1hc2si CkBAIC02MjMzLDY5ICs2MjMwLDQyIEBACiAgICAgICAgICAgICAgICAgImNvbnZlcnRlciI6ICJC b3JkZXJNYXNrPENTU1Byb3BlcnR5V2Via2l0TWFza0JveEltYWdlPiIKICAgICAgICAgICAgIH0s CiAgICAgICAgICAgICAic3RhdHVzIjogIm5vbi1zdGFuZGFyZCIKLSwKLSAgICAgICAgICAgICJz cGVjaWZpY2F0aW9uIjogewotICAgICAgICAgICAgICAgICJjYXRlZ29yeSI6ICJjc3MtbWFza2lu ZyIKLSAgICAgICAgICAgIH0KICAgICAgICAgfSwKICAgICAgICAgIi13ZWJraXQtbWFzay1ib3gt aW1hZ2Utb3V0c2V0IjogewogICAgICAgICAgICAgImNvZGVnZW4tcHJvcGVydGllcyI6IHsKICAg ICAgICAgICAgICAgICAiY3VzdG9tIjogIkFsbCIKICAgICAgICAgICAgIH0sCiAgICAgICAgICAg ICAic3RhdHVzIjogIm5vbi1zdGFuZGFyZCIKLSwKLSAgICAgICAgICAgICJzcGVjaWZpY2F0aW9u IjogewotICAgICAgICAgICAgICAgICJjYXRlZ29yeSI6ICJjc3MtbWFza2luZyIKLSAgICAgICAg ICAgIH0KICAgICAgICAgfSwKICAgICAgICAgIi13ZWJraXQtbWFzay1ib3gtaW1hZ2UtcmVwZWF0 IjogewogICAgICAgICAgICAgImNvZGVnZW4tcHJvcGVydGllcyI6IHsKICAgICAgICAgICAgICAg ICAiY3VzdG9tIjogIkFsbCIKICAgICAgICAgICAgIH0sCiAgICAgICAgICAgICAic3RhdHVzIjog Im5vbi1zdGFuZGFyZCIKLSwKLSAgICAgICAgICAgICJzcGVjaWZpY2F0aW9uIjogewotICAgICAg ICAgICAgICAgICJjYXRlZ29yeSI6ICJjc3MtbWFza2luZyIKLSAgICAgICAgICAgIH0KICAgICAg ICAgfSwKICAgICAgICAgIi13ZWJraXQtbWFzay1ib3gtaW1hZ2Utc2xpY2UiOiB7CiAgICAgICAg ICAgICAiY29kZWdlbi1wcm9wZXJ0aWVzIjogewogICAgICAgICAgICAgICAgICJjdXN0b20iOiAi QWxsIgogICAgICAgICAgICAgfSwKICAgICAgICAgICAgICJzdGF0dXMiOiAibm9uLXN0YW5kYXJk IgotLAotICAgICAgICAgICAgInNwZWNpZmljYXRpb24iOiB7Ci0gICAgICAgICAgICAgICAgImNh dGVnb3J5IjogImNzcy1tYXNraW5nIgotICAgICAgICAgICAgfQogICAgICAgICB9LAogICAgICAg ICAiLXdlYmtpdC1tYXNrLWJveC1pbWFnZS1zb3VyY2UiOiB7CiAgICAgICAgICAgICAiY29kZWdl bi1wcm9wZXJ0aWVzIjogewogICAgICAgICAgICAgICAgICJjb252ZXJ0ZXIiOiAiU3R5bGVJbWFn ZTxDU1NQcm9wZXJ0eVdlYmtpdE1hc2tCb3hJbWFnZVNvdXJjZT4iCiAgICAgICAgICAgICB9LAog ICAgICAgICAgICAgInN0YXR1cyI6ICJub24tc3RhbmRhcmQiCi0sCi0gICAgICAgICAgICAic3Bl Y2lmaWNhdGlvbiI6IHsKLSAgICAgICAgICAgICAgICAiY2F0ZWdvcnkiOiAiY3NzLW1hc2tpbmci Ci0gICAgICAgICAgICB9CiAgICAgICAgIH0sCiAgICAgICAgICItd2Via2l0LW1hc2stYm94LWlt YWdlLXdpZHRoIjogewogICAgICAgICAgICAgImNvZGVnZW4tcHJvcGVydGllcyI6IHsKICAgICAg ICAgICAgICAgICAiY3VzdG9tIjogIkFsbCIKICAgICAgICAgICAgIH0sCiAgICAgICAgICAgICAi c3RhdHVzIjogIm5vbi1zdGFuZGFyZCIKLSwKLSAgICAgICAgICAgICJzcGVjaWZpY2F0aW9uIjog ewotICAgICAgICAgICAgICAgICJjYXRlZ29yeSI6ICJjc3MtbWFza2luZyIKLSAgICAgICAgICAg IH0KICAgICAgICAgfSwKICAgICAgICAgIi13ZWJraXQtbWFzay1jbGlwIjogewogICAgICAgICAg ICAgImNvZGVnZW4tcHJvcGVydGllcyI6IHsKICAgICAgICAgICAgICAgICAibmFtZS1mb3ItbWV0 aG9kcyI6ICJDbGlwIiwKICAgICAgICAgICAgICAgICAiZmlsbC1sYXllci1wcm9wZXJ0eSI6IHRy dWUKICAgICAgICAgICAgIH0sCi0gICAgICAgICAgICAic3RhdHVzIjogewotICAgICAgICAgICAg ICAgICJzdGF0dXMiOiAiZXhwZXJpbWVudGFsIgotICAgICAgICAgICAgfSwKICAgICAgICAgICAg ICJzcGVjaWZpY2F0aW9uIjogewogICAgICAgICAgICAgICAgICJjYXRlZ29yeSI6ICJjc3MtbWFz a2luZyIsCiAgICAgICAgICAgICAgICAgInVybCI6ICJodHRwczovL3d3dy53My5vcmcvVFIvY3Nz LW1hc2tpbmctMS8jcHJvcGRlZi1tYXNrLWNsaXAiCkBAIC02MzA2LDkgKzYyNzYsNiBAQAogICAg ICAgICAgICAgICAgICJuYW1lLWZvci1tZXRob2RzIjogIkNvbXBvc2l0ZSIsCiAgICAgICAgICAg ICAgICAgImZpbGwtbGF5ZXItcHJvcGVydHkiOiB0cnVlCiAgICAgICAgICAgICB9LAotICAgICAg ICAgICAgInN0YXR1cyI6IHsKLSAgICAgICAgICAgICAgICAic3RhdHVzIjogImV4cGVyaW1lbnRh bCIKLSAgICAgICAgICAgIH0sCiAgICAgICAgICAgICAic3BlY2lmaWNhdGlvbiI6IHsKICAgICAg ICAgICAgICAgICAiY2F0ZWdvcnkiOiAiY3NzLW1hc2tpbmciLAogICAgICAgICAgICAgICAgICJ1 cmwiOiAiaHR0cHM6Ly93d3cudzMub3JnL1RSL2Nzcy1tYXNraW5nLTEvI3Byb3BkZWYtbWFzay1j b21wb3NpdGUiCkBAIC02MzE5LDkgKzYyODYsNiBAQAogICAgICAgICAgICAgICAgICJuYW1lLWZv ci1tZXRob2RzIjogIkltYWdlIiwKICAgICAgICAgICAgICAgICAiZmlsbC1sYXllci1wcm9wZXJ0 eSI6IHRydWUKICAgICAgICAgICAgIH0sCi0gICAgICAgICAgICAic3RhdHVzIjogewotICAgICAg ICAgICAgICAgICJzdGF0dXMiOiAiZXhwZXJpbWVudGFsIgotICAgICAgICAgICAgfSwKICAgICAg ICAgICAgICJzcGVjaWZpY2F0aW9uIjogewogICAgICAgICAgICAgICAgICJjYXRlZ29yeSI6ICJj c3MtbWFza2luZyIsCiAgICAgICAgICAgICAgICAgInVybCI6ICJodHRwczovL3d3dy53My5vcmcv VFIvY3NzLW1hc2tpbmctMS8jcHJvcGRlZi1tYXNrLWltYWdlIgpAQCAtNjMzMiw5ICs2Mjk2LDYg QEAKICAgICAgICAgICAgICAgICAibmFtZS1mb3ItbWV0aG9kcyI6ICJPcmlnaW4iLAogICAgICAg ICAgICAgICAgICJmaWxsLWxheWVyLXByb3BlcnR5IjogdHJ1ZQogICAgICAgICAgICAgfSwKLSAg ICAgICAgICAgICJzdGF0dXMiOiB7Ci0gICAgICAgICAgICAgICAgInN0YXR1cyI6ICJleHBlcmlt ZW50YWwiCi0gICAgICAgICAgICB9LAogICAgICAgICAgICAgInNwZWNpZmljYXRpb24iOiB7CiAg ICAgICAgICAgICAgICAgImNhdGVnb3J5IjogImNzcy1tYXNraW5nIiwKICAgICAgICAgICAgICAg ICAidXJsIjogImh0dHBzOi8vd3d3LnczLm9yZy9UUi9jc3MtbWFza2luZy0xLyNwcm9wZGVmLW1h c2stb3JpZ2luIgpAQCAtNjM0Nyw5ICs2MzA4LDYgQEAKICAgICAgICAgICAgICAgICAgICAgIi13 ZWJraXQtbWFzay1wb3NpdGlvbi15IgogICAgICAgICAgICAgICAgIF0KICAgICAgICAgICAgIH0s Ci0gICAgICAgICAgICAic3RhdHVzIjogewotICAgICAgICAgICAgICAgICJzdGF0dXMiOiAiZXhw ZXJpbWVudGFsIgotICAgICAgICAgICAgfSwKICAgICAgICAgICAgICJzcGVjaWZpY2F0aW9uIjog ewogICAgICAgICAgICAgICAgICJjYXRlZ29yeSI6ICJjc3MtbWFza2luZyIsCiAgICAgICAgICAg ICAgICAgInVybCI6ICJodHRwczovL3d3dy53My5vcmcvVFIvY3NzLW1hc2tpbmctMS8jcHJvcGRl Zi1tYXNrLXBvc2l0aW9uIgpAQCAtNjM1OCwxMCArNjMxNiw4IEBACiAgICAgICAgICItd2Via2l0 LW1hc2stcG9zaXRpb24teCI6IHsKICAgICAgICAgICAgICJjb2RlZ2VuLXByb3BlcnRpZXMiOiB7 CiAgICAgICAgICAgICAgICAgIm5hbWUtZm9yLW1ldGhvZHMiOiAiWFBvc2l0aW9uIiwKLSAgICAg ICAgICAgICAgICAiZmlsbC1sYXllci1wcm9wZXJ0eSI6IHRydWUKLSAgICAgICAgICAgIH0sCi0g ICAgICAgICAgICAic3RhdHVzIjogewotICAgICAgICAgICAgICAgICJzdGF0dXMiOiAiZXhwZXJp bWVudGFsIgorICAgICAgICAgICAgICAgICJmaWxsLWxheWVyLXByb3BlcnR5IjogdHJ1ZSwKKyAg ICAgICAgICAgICAgICAiaW50ZXJuYWwtb25seSI6IHRydWUKICAgICAgICAgICAgIH0sCiAgICAg ICAgICAgICAic3BlY2lmaWNhdGlvbiI6IHsKICAgICAgICAgICAgICAgICAiY2F0ZWdvcnkiOiAi Y3NzLW1hc2tpbmciLApAQCAtNjM3MSwxMCArNjMyNyw4IEBACiAgICAgICAgICItd2Via2l0LW1h c2stcG9zaXRpb24teSI6IHsKICAgICAgICAgICAgICJjb2RlZ2VuLXByb3BlcnRpZXMiOiB7CiAg ICAgICAgICAgICAgICAgIm5hbWUtZm9yLW1ldGhvZHMiOiAiWVBvc2l0aW9uIiwKLSAgICAgICAg ICAgICAgICAiZmlsbC1sYXllci1wcm9wZXJ0eSI6IHRydWUKLSAgICAgICAgICAgIH0sCi0gICAg ICAgICAgICAic3RhdHVzIjogewotICAgICAgICAgICAgICAgICJzdGF0dXMiOiAiZXhwZXJpbWVu dGFsIgorICAgICAgICAgICAgICAgICJmaWxsLWxheWVyLXByb3BlcnR5IjogdHJ1ZSwKKyAgICAg ICAgICAgICAgICAiaW50ZXJuYWwtb25seSI6IHRydWUKICAgICAgICAgICAgIH0sCiAgICAgICAg ICAgICAic3BlY2lmaWNhdGlvbiI6IHsKICAgICAgICAgICAgICAgICAiY2F0ZWdvcnkiOiAiY3Nz LW1hc2tpbmciLApAQCAtNjM4OCw5ICs2MzQyLDYgQEAKICAgICAgICAgICAgICAgICAgICAgIi13 ZWJraXQtbWFzay1yZXBlYXQteSIKICAgICAgICAgICAgICAgICBdCiAgICAgICAgICAgICB9LAot ICAgICAgICAgICAgInN0YXR1cyI6IHsKLSAgICAgICAgICAgICAgICAic3RhdHVzIjogImV4cGVy aW1lbnRhbCIKLSAgICAgICAgICAgIH0sCiAgICAgICAgICAgICAic3BlY2lmaWNhdGlvbiI6IHsK ICAgICAgICAgICAgICAgICAiY2F0ZWdvcnkiOiAiY3NzLW1hc2tpbmciLAogICAgICAgICAgICAg ICAgICJ1cmwiOiAiaHR0cHM6Ly93d3cudzMub3JnL1RSL2Nzcy1tYXNraW5nLTEvI3Byb3BkZWYt bWFzay1yZXBlYXQiCkBAIC02NDE1LDkgKzYzNjYsNiBAQAogICAgICAgICAgICAgICAgICJuYW1l LWZvci1tZXRob2RzIjogIlNpemUiLAogICAgICAgICAgICAgICAgICJmaWxsLWxheWVyLXByb3Bl cnR5IjogdHJ1ZQogICAgICAgICAgICAgfSwKLSAgICAgICAgICAgICJzdGF0dXMiOiB7Ci0gICAg ICAgICAgICAgICAgInN0YXR1cyI6ICJleHBlcmltZW50YWwiCi0gICAgICAgICAgICB9LAogICAg ICAgICAgICAgInNwZWNpZmljYXRpb24iOiB7CiAgICAgICAgICAgICAgICAgImNhdGVnb3J5Ijog ImNzcy1tYXNraW5nIiwKICAgICAgICAgICAgICAgICAidXJsIjogImh0dHBzOi8vd3d3LnczLm9y Zy9UUi9jc3MtbWFza2luZy0xLyNwcm9wZGVmLW1hc2stc2l6ZSIKQEAgLTY0MjgsOCArNjM3Niw2 IEBACiAgICAgICAgICAgICAgICAgIm5hbWUtZm9yLW1ldGhvZHMiOiAiTWFza1NvdXJjZVR5cGUi LAogICAgICAgICAgICAgICAgICJmaWxsLWxheWVyLXByb3BlcnR5IjogdHJ1ZQogICAgICAgICAg ICAgfSwKLSAgICAgICAgICAgICJzdGF0dXMiOiAibm9uLXN0YW5kYXJkIgotLAogICAgICAgICAg ICAgInNwZWNpZmljYXRpb24iOiB7CiAgICAgICAgICAgICAgICAgImNhdGVnb3J5IjogImNzcy1t YXNraW5nIgogICAgICAgICAgICAgfQo=