<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>229894</bug_id>
          
          <creation_ts>2021-09-03 14:03:54 -0700</creation_ts>
          <short_desc>Fix for debug mode on MSVC after r281998</short_desc>
          <delta_ts>2021-09-03 16:41:21 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Stephan Szabo">stephan.szabo</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1790353</commentid>
    <comment_count>0</comment_count>
    <who name="Stephan Szabo">stephan.szabo</who>
    <bug_when>2021-09-03 14:03:54 -0700</bug_when>
    <thetext>Unfortunately my previous fix for having ENABLE(SERVICE_WORKER) off in debug seems to have failed on wincairo complaining about uses of #if inside the ASSERT() macro.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1790373</commentid>
    <comment_count>1</comment_count>
      <attachid>437313</attachid>
    <who name="Stephan Szabo">stephan.szabo</who>
    <bug_when>2021-09-03 14:42:52 -0700</bug_when>
    <thetext>Created attachment 437313
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1790430</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-09-03 16:40:50 -0700</bug_when>
    <thetext>Committed r282036 (241337@main): &lt;https://commits.webkit.org/241337@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437313.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1790431</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-09-03 16:41:21 -0700</bug_when>
    <thetext>&lt;rdar://problem/82744760&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>437313</attachid>
            <date>2021-09-03 14:42:52 -0700</date>
            <delta_ts>2021-09-03 16:40:50 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>229894.1.diff</filename>
            <type>text/plain</type>
            <size>1700</size>
            <attacher name="Stephan Szabo">stephan.szabo</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu
Z2VMb2cKaW5kZXggYmE2MzFkYjEzMTUwLi44ZWUxM2FiYzU5YTAgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg
KzEsMTYgQEAKKzIwMjEtMDktMDMgIFN0ZXBoYW4gU3phYm8gIDxzdGVwaGFuLnN6YWJvQHNvbnku
Y29tPgorCisgICAgICAgIEZpeCBmb3IgZGVidWcgbW9kZSBvbiBNU1ZDIGFmdGVyIHIyODE5OTgK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyOTg5NAor
CisgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4IGZvciB3aW5jYWlybyBkZWJ1Zy4KKworICAg
ICAgICBObyBuZXcgdGVzdHMsIGJ1aWxkIGZpeCBvbmx5LgorCisgICAgICAgIFB1bGwgdGhlICNp
ZiBvdXQgZnJvbSBpbnNpZGUgdGhlIEFTU0VSVC4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNz
L05ldHdvcmtSZXNvdXJjZUxvYWRlci5jcHA6CisKIDIwMjEtMDktMDMgIFBlciBBcm5lICA8cHZv
bGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0dQVVBdIFRlbXBvcmFyaWx5IGFsbG93IGFjY2Vz
cyB0byBwb3dlciBsb2dnaW5nIHNlcnZpY2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0
d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvTmV0
d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcAppbmRleCBiMjU0ZjdjOTU2MmIu
LjIzZDk0ODc1ZTJjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9O
ZXR3b3JrUmVzb3VyY2VMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nl
c3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcApAQCAtNTI4LDExICs1MjgsMTEgQEAgdm9pZCBO
ZXR3b3JrUmVzb3VyY2VMb2FkZXI6OnRyYW5zZmVyVG9OZXdXZWJQcm9jZXNzKE5ldHdvcmtDb25u
ZWN0aW9uVG9XZWJQcm9jZXMKICAgICBtX2Nvbm5lY3Rpb24gPSBuZXdDb25uZWN0aW9uOwogICAg
IG1fcGFyYW1ldGVycy5pZGVudGlmaWVyID0gbmV3Q29yZUlkZW50aWZpZXI7CiAKLSAgICBBU1NF
UlQobV9yZXNwb25zZUNvbXBsZXRpb25IYW5kbGVyIHx8IG1fY2FjaGVFbnRyeVdhaXRpbmdGb3JD
b250aW51ZURpZFJlY2VpdmVSZXNwb25zZQogI2lmIEVOQUJMRShTRVJWSUNFX1dPUktFUikKLSAg
ICAgICAgfHwgbV9zZXJ2aWNlV29ya2VyRmV0Y2hUYXNrCisgICAgQVNTRVJUKG1fcmVzcG9uc2VD
b21wbGV0aW9uSGFuZGxlciB8fCBtX2NhY2hlRW50cnlXYWl0aW5nRm9yQ29udGludWVEaWRSZWNl
aXZlUmVzcG9uc2UgfHwgbV9zZXJ2aWNlV29ya2VyRmV0Y2hUYXNrKTsKKyNlbHNlCisgICAgQVNT
RVJUKG1fcmVzcG9uc2VDb21wbGV0aW9uSGFuZGxlciB8fCBtX2NhY2hlRW50cnlXYWl0aW5nRm9y
Q29udGludWVEaWRSZWNlaXZlUmVzcG9uc2UpOwogI2VuZGlmCi0gICAgKTsKICAgICBib29sIHdp
bGxXYWl0Rm9yQ29udGludWVEaWRSZWNlaXZlUmVzcG9uc2UgPSB0cnVlOwogICAgIHNlbmQoTWVz
c2FnZXM6OldlYlJlc291cmNlTG9hZGVyOjpEaWRSZWNlaXZlUmVzcG9uc2UgeyBtX3Jlc3BvbnNl
LCB3aWxsV2FpdEZvckNvbnRpbnVlRGlkUmVjZWl2ZVJlc3BvbnNlIH0pOwogfQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>