22987 2008-12-24 15:18:37 -0800 Regression: LayoutTests/editing/execCommand/5763082.html crashes 2008-12-26 00:47:38 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dimich webkit-unassigned darin oldest_to_newest 103387 0 dimich 2008-12-24 15:18:37 -0800 This test started crashing after r39456 because the function CompositeEditCommand::mergeIdenticalElements now has PassRefPtr parameters and passes them into more then one other function, losing their value along the way. The fix is to store parameters in local RefPtr variables and use those. 103388 1 26242 dimich 2008-12-24 15:37:23 -0800 Created attachment 26242 Proposed patch 103413 2 26242 darin 2008-12-25 10:04:11 -0800 Comment on attachment 26242 Proposed patch r=me Thanks for fixing the regression I caused! 103436 3 ap 2008-12-26 00:47:38 -0800 Committed revision 39475. 26242 2008-12-24 15:37:23 -0800 2008-12-25 10:04:11 -0800 Proposed patch fix.txt text/plain 1525 dimich SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzOTQ2OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDgtMTItMjQgIERtaXRyeSBUaXRvdiAgPGRpbWljaEBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Rml4IGZvciBicm9rZW4gdGVzdCBlZGl0aW5nL2V4ZWNDb21tYW5kLzU3NjMwODIuaHRtbAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5ODcKKworICAg ICAgICAqIGVkaXRpbmcvQ29tcG9zaXRlRWRpdENvbW1hbmQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6Q29tcG9zaXRlRWRpdENvbW1hbmQ6Om1lcmdlSWRlbnRpY2FsRWxlbWVudHMpOiBVc2VkIGxv Y2FsIFJlZlB0ciB0byBob2xkIG9udG8gZnVuY3Rpb24gcGFyYW1ldGVyIGFjcm9zcyBtdWx0aXBs ZSBjYWxscy4KKwogMjAwOC0xMi0yNCAgSG9sZ2VyIEhhbnMgUGV0ZXIgRnJleXRoZXIgIDx6ZWNr ZUBzZWxmaXNoLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeCB0byBmaW5kIGFk ZFN1YnJlc291cmNlVVJMCkluZGV4OiBXZWJDb3JlL2VkaXRpbmcvQ29tcG9zaXRlRWRpdENvbW1h bmQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZWRpdGluZy9Db21wb3NpdGVFZGl0Q29tbWFu ZC5jcHAJKHJldmlzaW9uIDM5NDY5KQorKysgV2ViQ29yZS9lZGl0aW5nL0NvbXBvc2l0ZUVkaXRD b21tYW5kLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjQ1LDggKzI0NSwxMCBAQCB2b2lkIENvbXBv c2l0ZUVkaXRDb21tYW5kOjpzcGxpdEVsZW1lbnQoCiAgICAgYXBwbHlDb21tYW5kVG9Db21wb3Np dGUoU3BsaXRFbGVtZW50Q29tbWFuZDo6Y3JlYXRlKGVsZW1lbnQsIGF0Q2hpbGQpKTsKIH0KIAot dm9pZCBDb21wb3NpdGVFZGl0Q29tbWFuZDo6bWVyZ2VJZGVudGljYWxFbGVtZW50cyhQYXNzUmVm UHRyPEVsZW1lbnQ+IGZpcnN0LCBQYXNzUmVmUHRyPEVsZW1lbnQ+IHNlY29uZCkKK3ZvaWQgQ29t cG9zaXRlRWRpdENvbW1hbmQ6Om1lcmdlSWRlbnRpY2FsRWxlbWVudHMoUGFzc1JlZlB0cjxFbGVt ZW50PiBwcnBGaXJzdCwgUGFzc1JlZlB0cjxFbGVtZW50PiBwcnBTZWNvbmQpCiB7CisgICAgUmVm UHRyPEVsZW1lbnQ+IGZpcnN0ID0gcHJwRmlyc3Q7CisgICAgUmVmUHRyPEVsZW1lbnQ+IHNlY29u ZCA9IHBycFNlY29uZDsKICAgICBBU1NFUlQoIWZpcnN0LT5pc0Rlc2NlbmRhbnRPZihzZWNvbmQu Z2V0KCkpICYmIHNlY29uZCAhPSBmaXJzdCk7CiAgICAgaWYgKGZpcnN0LT5uZXh0U2libGluZygp ICE9IHNlY29uZCkgewogICAgICAgICByZW1vdmVOb2RlKHNlY29uZCk7Cg==