22985 2008-12-24 13:59:59 -0800 RenderLayer cached clip rects are sometimes incorrect 2009-01-05 21:38:00 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser hyatt oldest_to_newest 103382 0 simon.fraser 2008-12-24 13:59:59 -0800 I added an assertion to test that cached clip rects are used with the same rootLayer as they were computed with. This caught a couple of problems, which I'll submit a patch for. 103384 1 26241 simon.fraser 2008-12-24 14:11:22 -0800 Created attachment 26241 Patch, changelog I wasn't able to easily create a LayoutTest to exercise these fixes, but the assertion provides testing. 103385 2 simon.fraser 2008-12-24 14:13:22 -0800 Also, did you know that clipRects are cleared on every mouse move, because MouseRelatedEvent::receivedTarget() calls layer->updateLayerPosition() before setting event->layerX and event->layerY (which are totally bogus anyway, bug 21868). 104485 3 26241 hyatt 2009-01-05 14:23:48 -0800 Comment on attachment 26241 Patch, changelog r=me. If you can make a test case please do so. If not, ok. 104528 4 simon.fraser 2009-01-05 21:38:00 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/rendering/RenderLayer.cpp M WebCore/rendering/RenderLayer.h M WebCore/rendering/RenderTreeAsText.cpp Committed r39640 26241 2008-12-24 14:11:22 -0800 2009-01-05 14:23:48 -0800 Patch, changelog 22985_patch.txt text/plain 4428 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MGQwOGZkZC4uYTM4OTdmMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNyBAQAorMjAwOC0xMi0yNCAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjI5ODUKKyAgICAgICAgCisgICAgICAgIEFkZCBhbiBhc3NlcnRpb24gdGhhdCBjbGlwIHJl Y3RzIGFyZSBiZWluZyB1c2VkIHdoZW4gcGFpbnRpbmcgd2l0aCB0aGUgc2FtZQorICAgICAgICBy b290TGF5ZXIgdGhhdCB0aGV5IHdlcmUgY29tcHV0ZWQgd2l0aC4KKyAgICAgICAgCisgICAgICAg IEZpeCB0d28gaXNzdWVzIGRldGVjdGVkIGJ5IHRoZSBhc3NlcnRpb246CisKKyAgICAgICAgUmVu ZGVyTGF5ZXI6OnVwZGF0ZUNsaXBSZWN0cygpIHNob3VsZCBub3QgdW5jb25kaXRpb25hbGx5IHVw ZGF0ZSB0aGUgY2xpcCByZWN0cworICAgICAgICBvbiBpdHMgcGFyZW50LCBidXQgc3RvcCB3aGVu IHJlYWNoaW5nIHJvb3RMYXllciAoanVzdCBsaWtlIGNhbGN1bGF0ZUNsaXBSZWN0cygpKS4KKyAg ICAgICAgCisgICAgICAgIFdlIG5lZWQgdG8gcGFzcyB0aGUgdGVtcG9yYXJ5Q2xpcFJlY3RzIGZs YWcgZG93biB0aHJvdWdoIHJlZmxlY3Rpb24gcGFpbnRpbmcKKyAgICAgICAgdG8gaGFuZGxlIHRo ZSBjYXNlIG9mIG5lc3RlZCByZWZsZWN0aW9ucy4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5k ZXJMYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6UmVuZGVyTGF5ZXIp OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OnBhaW50TGF5ZXIpOgorICAgICAgICAo V2ViQ29yZTo6UmVuZGVyTGF5ZXI6OnVwZGF0ZUNsaXBSZWN0cyk6CisgICAgICAgIChXZWJDb3Jl OjpSZW5kZXJMYXllcjo6Y2xlYXJDbGlwUmVjdHMpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5k ZXJMYXllci5oOgorCiAyMDA4LTEyLTI0ICBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlciAgPHpl Y2tlQHNlbGZpc2gub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4IHRvIGZpbmQg YWRkU3VicmVzb3VyY2VVUkwKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxh eWVyLmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAppbmRleCBjNzlmZjE3 Li43YjVlNTM2IDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAK KysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCkBAIC0xNDAsNiArMTQwLDkg QEAgUmVuZGVyTGF5ZXI6OlJlbmRlckxheWVyKFJlbmRlck9iamVjdCogb2JqZWN0KQogICAgICwg bV9uZWdaT3JkZXJMaXN0KDApCiAgICAgLCBtX292ZXJmbG93TGlzdCgwKQogICAgICwgbV9jbGlw UmVjdHMoMCkgCisjaWZuZGVmIE5ERUJVRyAgICAKKyAgICAsIG1fY2xpcFJlY3RzUm9vdCgwKQor I2VuZGlmCiAgICAgLCBtX3Njcm9sbERpbWVuc2lvbnNEaXJ0eSh0cnVlKQogICAgICwgbV96T3Jk ZXJMaXN0c0RpcnR5KHRydWUpCiAgICAgLCBtX292ZXJmbG93TGlzdERpcnR5KHRydWUpCkBAIC0x NzEyLDcgKzE3MTUsNyBAQCBSZW5kZXJMYXllcjo6cGFpbnRMYXllcihSZW5kZXJMYXllciogcm9v dExheWVyLCBHcmFwaGljc0NvbnRleHQqIHAsCiAgICAgaWYgKG1fcmVmbGVjdGlvbiAmJiAhbV9w YWludGluZ0luc2lkZVJlZmxlY3Rpb24gJiYgKCFtX3RyYW5zZm9ybSB8fCBhcHBsaWVkVHJhbnNm b3JtKSkgewogICAgICAgICAvLyBNYXJrIHRoYXQgd2UgYXJlIG5vdyBpbnNpZGUgcmVwbGljYSBw YWludGluZy4KICAgICAgICAgbV9wYWludGluZ0luc2lkZVJlZmxlY3Rpb24gPSB0cnVlOwotICAg ICAgICByZWZsZWN0aW9uTGF5ZXIoKS0+cGFpbnRMYXllcihyb290TGF5ZXIsIHAsIHBhaW50RGly dHlSZWN0LCBoYXZlVHJhbnNwYXJlbmN5LCBwYWludFJlc3RyaWN0aW9uLCBwYWludGluZ1Jvb3Qp OworICAgICAgICByZWZsZWN0aW9uTGF5ZXIoKS0+cGFpbnRMYXllcihyb290TGF5ZXIsIHAsIHBh aW50RGlydHlSZWN0LCBoYXZlVHJhbnNwYXJlbmN5LCBwYWludFJlc3RyaWN0aW9uLCBwYWludGlu Z1Jvb3QsIGZhbHNlLCB0ZW1wb3JhcnlDbGlwUmVjdHMpOwogICAgICAgICBtX3BhaW50aW5nSW5z aWRlUmVmbGVjdGlvbiA9IGZhbHNlOwogICAgIH0KIApAQCAtMjAwMiwyMCArMjAwNSwyOCBAQCBS ZW5kZXJMYXllciogUmVuZGVyTGF5ZXI6OmhpdFRlc3RMYXllcihSZW5kZXJMYXllciogcm9vdExh eWVyLCBjb25zdCBIaXRUZXN0UmVxdQogCiB2b2lkIFJlbmRlckxheWVyOjp1cGRhdGVDbGlwUmVj dHMoY29uc3QgUmVuZGVyTGF5ZXIqIHJvb3RMYXllcikKIHsKLSAgICBpZiAobV9jbGlwUmVjdHMp CisgICAgaWYgKG1fY2xpcFJlY3RzKSB7CisgICAgICAgIEFTU0VSVChyb290TGF5ZXIgPT0gbV9j bGlwUmVjdHNSb290KTsKICAgICAgICAgcmV0dXJuOyAvLyBXZSBoYXZlIHRoZSBjb3JyZWN0IGNh Y2hlZCB2YWx1ZS4KLQotICAgIGlmIChwYXJlbnQoKSkKLSAgICAgICAgcGFyZW50KCktPnVwZGF0 ZUNsaXBSZWN0cyhyb290TGF5ZXIpOworICAgIH0KKyAgICAKKyAgICAvLyBGb3IgdHJhbnNmb3Jt ZWQgbGF5ZXJzLCB0aGUgcm9vdCBsYXllciB3YXMgc2hpZnRlZCB0byBiZSB1cywgc28gdGhlcmUg aXMgbm8gbmVlZCB0bworICAgIC8vIGV4YW1pbmUgdGhlIHBhcmVudC4gIFdlIHdhbnQgdG8gY2Fj aGUgY2xpcCByZWN0cyB3aXRoIHVzIGFzIHRoZSByb290LgorICAgIFJlbmRlckxheWVyKiBwYXJl bnRMYXllciA9IHJvb3RMYXllciAhPSB0aGlzID8gcGFyZW50KCkgOiAwOworICAgIGlmIChwYXJl bnRMYXllcikKKyAgICAgICAgcGFyZW50TGF5ZXItPnVwZGF0ZUNsaXBSZWN0cyhyb290TGF5ZXIp OwogCiAgICAgQ2xpcFJlY3RzIGNsaXBSZWN0czsKICAgICBjYWxjdWxhdGVDbGlwUmVjdHMocm9v dExheWVyLCBjbGlwUmVjdHMsIHRydWUpOwogCi0gICAgaWYgKHBhcmVudCgpICYmIHBhcmVudCgp LT5jbGlwUmVjdHMoKSAmJiBjbGlwUmVjdHMgPT0gKnBhcmVudCgpLT5jbGlwUmVjdHMoKSkKLSAg ICAgICAgbV9jbGlwUmVjdHMgPSBwYXJlbnQoKS0+Y2xpcFJlY3RzKCk7CisgICAgaWYgKHBhcmVu dExheWVyICYmIHBhcmVudExheWVyLT5jbGlwUmVjdHMoKSAmJiBjbGlwUmVjdHMgPT0gKnBhcmVu dExheWVyLT5jbGlwUmVjdHMoKSkKKyAgICAgICAgbV9jbGlwUmVjdHMgPSBwYXJlbnRMYXllci0+ Y2xpcFJlY3RzKCk7CiAgICAgZWxzZQogICAgICAgICBtX2NsaXBSZWN0cyA9IG5ldyAobV9vYmpl Y3QtPnJlbmRlckFyZW5hKCkpIENsaXBSZWN0cyhjbGlwUmVjdHMpOwogICAgIG1fY2xpcFJlY3Rz LT5yZWYoKTsKKyNpZm5kZWYgTkRFQlVHCisgICAgbV9jbGlwUmVjdHNSb290ID0gcm9vdExheWVy OworI2VuZGlmCiB9CiAKIHZvaWQgUmVuZGVyTGF5ZXI6OmNhbGN1bGF0ZUNsaXBSZWN0cyhjb25z dCBSZW5kZXJMYXllciogcm9vdExheWVyLCBDbGlwUmVjdHMmIGNsaXBSZWN0cywgYm9vbCB1c2VD YWNoZWQpIGNvbnN0CkBAIC0yMjY5LDYgKzIyODAsOSBAQCB2b2lkIFJlbmRlckxheWVyOjpjbGVh ckNsaXBSZWN0cygpCiAgICAgaWYgKG1fY2xpcFJlY3RzKSB7CiAgICAgICAgIG1fY2xpcFJlY3Rz LT5kZXJlZihtX29iamVjdC0+cmVuZGVyQXJlbmEoKSk7CiAgICAgICAgIG1fY2xpcFJlY3RzID0g MDsKKyNpZm5kZWYgTkRFQlVHCisgICAgICAgIG1fY2xpcFJlY3RzUm9vdCA9IDA7CisjZW5kaWYg ICAgCiAgICAgfQogfQogCmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXll ci5oIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuaAppbmRleCBmMDYwOGMxLi5lZmIw NTJhIDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5oCisrKyBiL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgKQEAgLTQ3OCw2ICs0NzgsOSBAQCBwcm90ZWN0 ZWQ6CiAgICAgVmVjdG9yPFJlbmRlckxheWVyKj4qIG1fb3ZlcmZsb3dMaXN0OwogCiAgICAgQ2xp cFJlY3RzKiBtX2NsaXBSZWN0czsgICAgICAvLyBDYWNoZWQgY2xpcCByZWN0cyB1c2VkIHdoZW4g cGFpbnRpbmcgYW5kIGhpdCB0ZXN0aW5nLgorI2lmbmRlZiBOREVCVUcKKyAgICBjb25zdCBSZW5k ZXJMYXllciogbV9jbGlwUmVjdHNSb290OyAgIC8vIFJvb3QgbGF5ZXIgdXNlZCB0byBjb21wdXRl IGNsaXAgcmVjdHMuCisjZW5kaWYKIAogICAgIGJvb2wgbV9zY3JvbGxEaW1lbnNpb25zRGlydHkg OiAxOwogICAgIGJvb2wgbV96T3JkZXJMaXN0c0RpcnR5IDogMTsK