229845 2021-09-02 18:52:41 -0700 Fix for debug mode with ENABLE_SERVICE_WORKER=OFF after r281706 2021-09-03 09:15:26 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 stephan.szabo stephan.szabo achristensen cdumez don.olmstead webkit-bug-importer oldest_to_newest 1790012 0 stephan.szabo 2021-09-02 18:52:41 -0700 There's an ASSERT that used m_serviceWorkerFetchTask outside of an #if ENABLE(SERVICE_WORKER) block. 1790017 1 437231 stephan.szabo 2021-09-02 18:57:50 -0700 Created attachment 437231 Patch I'm not sure stylistically how we want to handle cases like this, so just put the only sometimes enabled bit on its own inside the if and made the assert go across lines. 1790195 2 ews-feeder 2021-09-03 09:14:37 -0700 Committed r281998 (241305@main): <https://commits.webkit.org/241305@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437231. 1790197 3 webkit-bug-importer 2021-09-03 09:15:26 -0700 <rdar://problem/82726075> 437231 2021-09-02 18:57:50 -0700 2021-09-03 09:14:38 -0700 Patch 229845.1.diff text/plain 1652 stephan.szabo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZDNiZjk0NTRhZTYxLi5hMzNjZGY0MzIyZTMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTYgQEAKKzIwMjEtMDktMDIgIFN0ZXBoYW4gU3phYm8gIDxzdGVwaGFuLnN6YWJvQHNvbnku Y29tPgorCisgICAgICAgIEZpeCBmb3IgZGVidWcgbW9kZSB3aXRoIEVOQUJMRV9TRVJWSUNFX1dP UktFUj1PRkYgYWZ0ZXIgcjI4MTcwNgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjI5ODQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUHV0IG1fc2VydmljZVdvcmtlckZldGNoVGFzayBjaGVjayBpbnRvICNp Zi4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGlzIGEgYnVpbGQgZml4IGZvciBoYXZpbmcgc2Vy dmljZSB3b3JrZXJzIG9mZi4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNv dXJjZUxvYWRlci5jcHA6CisKIDIwMjEtMDktMDIgIEFkaXR5YSBLZWVydGhpICA8YWtlZXJ0aGlA YXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIFNpbXBsaWZ5IGRhdGUgcGlja2VyIGxvZ2ljIGZv ciBkYXRldGltZS1sb2NhbCBpbnB1dHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29y a1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvTmV0d29y a1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcAppbmRleCAzZjliMWU1MzhkMzkuLjUz M2JhYjM3Y2Y0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3 b3JrUmVzb3VyY2VMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mv TmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcApAQCAtNTI3LDcgKzUyNywxMSBAQCB2b2lkIE5ldHdv cmtSZXNvdXJjZUxvYWRlcjo6dHJhbnNmZXJUb05ld1dlYlByb2Nlc3MoTmV0d29ya0Nvbm5lY3Rp b25Ub1dlYlByb2NlcwogICAgIG1fY29ubmVjdGlvbiA9IG5ld0Nvbm5lY3Rpb247CiAgICAgbV9w YXJhbWV0ZXJzLmlkZW50aWZpZXIgPSBuZXdDb3JlSWRlbnRpZmllcjsKIAotICAgIEFTU0VSVCht X3Jlc3BvbnNlQ29tcGxldGlvbkhhbmRsZXIgfHwgbV9jYWNoZUVudHJ5V2FpdGluZ0ZvckNvbnRp bnVlRGlkUmVjZWl2ZVJlc3BvbnNlIHx8IG1fc2VydmljZVdvcmtlckZldGNoVGFzayk7CisgICAg QVNTRVJUKG1fcmVzcG9uc2VDb21wbGV0aW9uSGFuZGxlciB8fCBtX2NhY2hlRW50cnlXYWl0aW5n Rm9yQ29udGludWVEaWRSZWNlaXZlUmVzcG9uc2UKKyNpZiBFTkFCTEUoU0VSVklDRV9XT1JLRVIp CisgICAgICAgIHx8IG1fc2VydmljZVdvcmtlckZldGNoVGFzaworI2VuZGlmCisgICAgKTsKICAg ICBib29sIHdpbGxXYWl0Rm9yQ29udGludWVEaWRSZWNlaXZlUmVzcG9uc2UgPSB0cnVlOwogICAg IHNlbmQoTWVzc2FnZXM6OldlYlJlc291cmNlTG9hZGVyOjpEaWRSZWNlaXZlUmVzcG9uc2UgeyBt X3Jlc3BvbnNlLCB3aWxsV2FpdEZvckNvbnRpbnVlRGlkUmVjZWl2ZVJlc3BvbnNlIH0pOwogfQo=