<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>229839</bug_id>
          
          <creation_ts>2021-09-02 16:21:10 -0700</creation_ts>
          <short_desc>FontFaceSet.status needs to react to style changes</short_desc>
          <delta_ts>2021-09-07 23:52:26 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=229975</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>229850</blocked>
    
    <blocked>229911</blocked>
    
    <blocked>229975</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Myles C. Maxfield">mmaxfield</reporter>
          <assigned_to name="Myles C. Maxfield">mmaxfield</assigned_to>
          <cc>clopez</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>fujii</cc>
    
    <cc>glenn</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>macpherson</cc>
    
    <cc>menard</cc>
    
    <cc>sam</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1789961</commentid>
    <comment_count>0</comment_count>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2021-09-02 16:21:10 -0700</bug_when>
    <thetext>FontFaceSet.status needs to react to style changes</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1789963</commentid>
    <comment_count>1</comment_count>
      <attachid>437212</attachid>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2021-09-02 16:23:33 -0700</bug_when>
    <thetext>Created attachment 437212
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1790009</commentid>
    <comment_count>2</comment_count>
      <attachid>437212</attachid>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2021-09-02 18:50:02 -0700</bug_when>
    <thetext>Comment on attachment 437212
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437212&amp;action=review

&gt; LayoutTests/ChangeLog:8
&gt; +        This is not a WPT test because it requires webfont/slow-ahem-loading.cgi.

Oh, I think I can actually turn this into a WPT test</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1790016</commentid>
    <comment_count>3</comment_count>
      <attachid>437212</attachid>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2021-09-02 18:55:10 -0700</bug_when>
    <thetext>Comment on attachment 437212
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437212&amp;action=review

&gt;&gt; LayoutTests/ChangeLog:8
&gt;&gt; +        This is not a WPT test because it requires webfont/slow-ahem-loading.cgi.
&gt; 
&gt; Oh, I think I can actually turn this into a WPT test

Oh, no, I can&apos;t, because the font may be cached, which will make the status update synchronously. So this needs internals.clearMemoryCache().

But I can at least make it less racey.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1790020</commentid>
    <comment_count>4</comment_count>
      <attachid>437233</attachid>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2021-09-02 19:13:35 -0700</bug_when>
    <thetext>Created attachment 437233
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1790208</commentid>
    <comment_count>5</comment_count>
      <attachid>437233</attachid>
    <who name="Sam Weinig">sam</who>
    <bug_when>2021-09-03 09:43:17 -0700</bug_when>
    <thetext>Comment on attachment 437233
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437233&amp;action=review

&gt; Source/WebCore/css/FontFaceSet.cpp:191
&gt; +    auto protect = m_backing;

Hm. This clearly does the right thing, but I usually like to ensure we are actually in a Ref or RefPtr when using the protect idiom by doing something like:

Ref protect = backing;

just to make sure that if m_backing ever changes type this is still doing what we expect.

Since m_backing is a Ref, I guess the posibilities here are that either &apos;this&apos; got deleted or m_backing got replaced and the original value got deleted. Would be interesting to try and add tests for either of those cases if possible.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1790307</commentid>
    <comment_count>6</comment_count>
      <attachid>437233</attachid>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2021-09-03 12:51:51 -0700</bug_when>
    <thetext>Comment on attachment 437233
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437233&amp;action=review

&gt;&gt; Source/WebCore/css/FontFaceSet.cpp:191
&gt;&gt; +    auto protect = m_backing;
&gt; 
&gt; Hm. This clearly does the right thing, but I usually like to ensure we are actually in a Ref or RefPtr when using the protect idiom by doing something like:
&gt; 
&gt; Ref protect = backing;
&gt; 
&gt; just to make sure that if m_backing ever changes type this is still doing what we expect.
&gt; 
&gt; Since m_backing is a Ref, I guess the posibilities here are that either &apos;this&apos; got deleted or m_backing got replaced and the original value got deleted. Would be interesting to try and add tests for either of those cases if possible.

Yeah. I&apos;ll land this with &quot;Ref&quot; instead of &quot;auto&quot; and I&apos;ll try to come up with a test that exercises the deletion problem in a follow-up.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1790317</commentid>
    <comment_count>7</comment_count>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2021-09-03 13:03:31 -0700</bug_when>
    <thetext>Committed r282015 (241320@main): &lt;https://commits.webkit.org/241320@main&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1790318</commentid>
    <comment_count>8</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-09-03 13:04:22 -0700</bug_when>
    <thetext>&lt;rdar://problem/82735622&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1790563</commentid>
    <comment_count>9</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2021-09-05 12:50:48 -0700</bug_when>
    <thetext>fast/text/FontFaceSet-status-after-style-update.html is flaky.
https://results.webkit.org/?suite=layout-tests&amp;test=fast%2Ftext%2FFontFaceSet-status-after-style-update.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1790822</commentid>
    <comment_count>10</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2021-09-06 16:49:44 -0700</bug_when>
    <thetext>(In reply to Fujii Hironori from comment #9)
&gt; fast/text/FontFaceSet-status-after-style-update.html is flaky.
&gt; https://results.webkit.org/?suite=layout-
&gt; tests&amp;test=fast%2Ftext%2FFontFaceSet-status-after-style-update.html

Reported it on bug 229975</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>437212</attachid>
            <date>2021-09-02 16:23:33 -0700</date>
            <delta_ts>2021-09-02 19:13:34 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-229839-20210902162332.patch</filename>
            <type>text/plain</type>
            <size>4879</size>
            <attacher name="Myles C. Maxfield">mmaxfield</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxOTQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzlmZDIyYjg4M2I2MGM1
YmExYjgyNGU2MzE5ZjJiNDBlMTcxNjRmNS4uNmMzNGI0OWZiOThhZWI1YTE3MjIzMjdlNDUxODVl
YjIzYTQ1MDc0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTA5LTAyICBNeWxl
cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgRm9udEZhY2VT
ZXQuc3RhdHVzIG5lZWRzIHRvIHJlYWN0IHRvIHN0eWxlIGNoYW5nZXMKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyOTgzOQorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gY29udGVudCBzYXlzICJkb2N1
bWVudC5mb250cy5zdGF0dXMiLCB0aGUgIi5zdGF0dXMiIHBhcnQgbmVlZHMgdG8KKyAgICAgICAg
dXBkYXRlIHN0eWxlIGluc3RlYWQgb2YgdGhlICJkb2N1bWVudC5mb250cyIgcGFydC4gVGhpcyBp
cyBiZWNhdXNlIGl0J3MKKyAgICAgICAgdG90YWxseSBsZWdhbCBmb3IgY29udGVudCB0byBzYXk6
CisKKyAgICAgICAgdmFyIGYgPSBkb2N1bWVudC5mb250czsKKyAgICAgICAgLy8gTW9kaWZ5IHN0
eWxlIGhlcmUKKyAgICAgICAgLi4uIGYuc3RhdHVzIC4uLiA8PT09IFRoaXMgbmVlZHMgdG8gcmVm
bGVjdCB0aGUgc3R5bGUgY2hhbmdlcy4KKworICAgICAgICBUZXN0OiBodHRwL3Rlc3RzL3dlYmZv
bnQvRm9udEZhY2VTZXQtc3RhdHVzLWFmdGVyLXN0eWxlLXVwZGF0ZS5odG1sCisKKyAgICAgICAg
KiBjc3MvRm9udEZhY2VTZXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9udEZhY2VTZXQ6OnN0
YXR1cyBjb25zdCk6CisKIDIwMjEtMDktMDIgIFBlbmcgTGl1ICA8cGVuZy5saXU2QGFwcGxlLmNv
bT4KIAogICAgICAgICBbTVNFXVtHUFVQXSBTb3VyY2VCdWZmZXJQcml2YXRlQVZGT2JqQyBkb2Vz
IG5vdCB3b3JrIHByb3Blcmx5IHdoZW4gYXVkaW8gYW5kIHZpZGVvIGV4Y2hhbmdlIHRoZWlyIHRy
YWNrIElEcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0ZvbnRGYWNlU2V0LmNwcCBi
L1NvdXJjZS9XZWJDb3JlL2Nzcy9Gb250RmFjZVNldC5jcHAKaW5kZXggNGI2YmFmNzA1MjYwZmQx
NWRkYWQ4MjM1YmE4NTY5Zjc2NDhhN2JkNy4uZjdjNThmMzM0ODY4MWMzYzRkYmIzNWU3NTcyYjY2
N2UyNTM2MGMzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0ZvbnRGYWNlU2V0LmNw
cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvRm9udEZhY2VTZXQuY3BwCkBAIC0xODgsNyArMTg4
LDEwIEBAIEV4Y2VwdGlvbk9yPGJvb2w+IEZvbnRGYWNlU2V0OjpjaGVjayhjb25zdCBTdHJpbmcm
IGZhbWlseSwgY29uc3QgU3RyaW5nJiB0ZXh0KQogICAgIAogYXV0byBGb250RmFjZVNldDo6c3Rh
dHVzKCkgY29uc3QgLT4gTG9hZFN0YXR1cwogewotICAgIHN3aXRjaCAobV9iYWNraW5nLT5zdGF0
dXMoKSkgeworICAgIGF1dG8gcHJvdGVjdCA9IG1fYmFja2luZzsKKyAgICBwcm90ZWN0LT51cGRh
dGVTdHlsZUlmTmVlZGVkKCk7CisKKyAgICBzd2l0Y2ggKHByb3RlY3QtPnN0YXR1cygpKSB7CiAg
ICAgY2FzZSBDU1NGb250RmFjZVNldDo6U3RhdHVzOjpMb2FkaW5nOgogICAgICAgICByZXR1cm4g
TG9hZFN0YXR1czo6TG9hZGluZzsKICAgICBjYXNlIENTU0ZvbnRGYWNlU2V0OjpTdGF0dXM6Okxv
YWRlZDoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0No
YW5nZUxvZwppbmRleCAxYWVmOGE2YTU0NDI4MzljNWJkZjVkMjEzNTBhMGVlZTgwZmNhMzM1Li5l
ZmNiMjc2Nzc3NTU5MTM2YWJjYmRjZWM3ODVkZGFjZmRjZGI2Y2FhIDEwMDY0NAotLS0gYS9MYXlv
dXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs
MTUgQEAKKzIwMjEtMDktMDIgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNv
bT4KKworICAgICAgICBGb250RmFjZVNldC5zdGF0dXMgbmVlZHMgdG8gcmVhY3QgdG8gc3R5bGUg
Y2hhbmdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
MjI5ODM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
VGhpcyBpcyBub3QgYSBXUFQgdGVzdCBiZWNhdXNlIGl0IHJlcXVpcmVzIHdlYmZvbnQvc2xvdy1h
aGVtLWxvYWRpbmcuY2dpLgorCisgICAgICAgICogaHR0cC90ZXN0cy93ZWJmb250L0ZvbnRGYWNl
U2V0LXN0YXR1cy1hZnRlci1zdHlsZS11cGRhdGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAg
ICAgKiBodHRwL3Rlc3RzL3dlYmZvbnQvRm9udEZhY2VTZXQtc3RhdHVzLWFmdGVyLXN0eWxlLXVw
ZGF0ZS5odG1sOiBBZGRlZC4KKwogMjAyMS0wOS0wMiAgUGVuZyBMaXUgIDxwZW5nLmxpdTZAYXBw
bGUuY29tPgogCiAgICAgICAgIFtNU0VdW0dQVVBdIFNvdXJjZUJ1ZmZlclByaXZhdGVBVkZPYmpD
IGRvZXMgbm90IHdvcmsgcHJvcGVybHkgd2hlbiBhdWRpbyBhbmQgdmlkZW8gZXhjaGFuZ2UgdGhl
aXIgdHJhY2sgSURzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3dlYmZvbnQv
Rm9udEZhY2VTZXQtc3RhdHVzLWFmdGVyLXN0eWxlLXVwZGF0ZS1leHBlY3RlZC50eHQgYi9MYXlv
dXRUZXN0cy9odHRwL3Rlc3RzL3dlYmZvbnQvRm9udEZhY2VTZXQtc3RhdHVzLWFmdGVyLXN0eWxl
LXVwZGF0ZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOTRmZmE0NDNlMmM5YWEwY2RjNTE2ZTk5
MzdlZTMzMzM2NGJmNjU0YQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVz
dHMvd2ViZm9udC9Gb250RmFjZVNldC1zdGF0dXMtYWZ0ZXItc3R5bGUtdXBkYXRlLWV4cGVjdGVk
LnR4dApAQCAtMCwwICsxLDEzIEBACitUaGlzIGZ1bmN0aW9uIG1ha2VzIHN1cmUgZG9jdW1lbnQu
Zm9udHMuc3RhdHVzIGdldHMgdXBkYXRlZCBhZnRlciBzdHlsZSBjaGFuZ2VzLgorCitPbiBzdWNj
ZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBi
eSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBmb250cy5zdGF0dXMgaXMgImxvYWRlZCIKK1BB
U1MgZm9udHMuc3RhdHVzIGlzICJsb2FkaW5nIgorUEFTUyBmb250cy5zdGF0dXMgaXMgImxvYWRp
bmciCitQQVNTIGZvbnRzLnN0YXR1cyBpcyAibG9hZGVkIgorUEFTUyBzdWNjZXNzZnVsbHlQYXJz
ZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCitIaQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv
aHR0cC90ZXN0cy93ZWJmb250L0ZvbnRGYWNlU2V0LXN0YXR1cy1hZnRlci1zdHlsZS11cGRhdGUu
aHRtbCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd2ViZm9udC9Gb250RmFjZVNldC1zdGF0dXMt
YWZ0ZXItc3R5bGUtdXBkYXRlLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMDdiYTUxMjg3OGEzNTUwY2FjODI4
NTQ5MDcyODc0MzZjYjdmMWJkMAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAv
dGVzdHMvd2ViZm9udC9Gb250RmFjZVNldC1zdGF0dXMtYWZ0ZXItc3R5bGUtdXBkYXRlLmh0bWwK
QEAgLTAsMCArMSwzNyBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkIGlkPSJoZWFk
Ij4KKzxzdHlsZSBpZD0ic3R5bGUiPgorQGZvbnQtZmFjZSB7CisgICAgZm9udC1mYW1pbHk6ICJX
ZWJGb250IjsKKyAgICBzcmM6IHVybCgic2xvdy1haGVtLWxvYWRpbmcuY2dpIikgZm9ybWF0KCJ0
cnVldHlwZSIpOworfQorPC9zdHlsZT4KKzxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMvanMtdGVz
dC1wcmUuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KK2lmICh3aW5kb3cuaW50ZXJuYWxzKSB7Cisg
ICAgaW50ZXJuYWxzLmludmFsaWRhdGVGb250Q2FjaGUoKTsKKyAgICBpbnRlcm5hbHMuY2xlYXJN
ZW1vcnlDYWNoZSgpOworfQord2luZG93LmpzVGVzdElzQXN5bmMgPSB0cnVlOworPC9zY3JpcHQ+
Cis8L2hlYWQ+Cis8Ym9keT4KKzxzY3JpcHQ+CitkZXNjcmlwdGlvbigiVGhpcyBmdW5jdGlvbiBt
YWtlcyBzdXJlIGRvY3VtZW50LmZvbnRzLnN0YXR1cyBnZXRzIHVwZGF0ZWQgYWZ0ZXIgc3R5bGUg
Y2hhbmdlcy4iKTsKK2xldCBmb250cyA9IGRvY3VtZW50LmZvbnRzOworc2hvdWxkQmVFcXVhbFRv
U3RyaW5nKCJmb250cy5zdGF0dXMiLCAibG9hZGVkIik7Cis8L3NjcmlwdD4KKzxkaXYgc3R5bGU9
ImZvbnQ6IDQ4cHggJ1dlYkZvbnQnOyI+SGk8L2Rpdj4KKzxzY3JpcHQ+CitzaG91bGRCZUVxdWFs
VG9TdHJpbmcoImZvbnRzLnN0YXR1cyIsICJsb2FkaW5nIik7Cit3aW5kb3cuc2V0VGltZW91dChm
dW5jdGlvbigpIHsKKyAgICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoImZvbnRzLnN0YXR1cyIsICJs
b2FkaW5nIik7CisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImhlYWQiKS5yZW1vdmVDaGls
ZChkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgic3R5bGUiKSk7CisgICAgc2hvdWxkQmVFcXVhbFRv
U3RyaW5nKCJmb250cy5zdGF0dXMiLCAibG9hZGVkIik7CisgICAgZmluaXNoSlNUZXN0KCk7Cit9
LCA1MDApOworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL2pzLXRlc3QtcG9z
dC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>437233</attachid>
            <date>2021-09-02 19:13:35 -0700</date>
            <delta_ts>2021-09-03 09:43:17 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-229839-20210902191335.patch</filename>
            <type>text/plain</type>
            <size>4529</size>
            <attacher name="Myles C. Maxfield">mmaxfield</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxOTQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzlmZDIyYjg4M2I2MGM1
YmExYjgyNGU2MzE5ZjJiNDBlMTcxNjRmNS4uYTcwYzBjYmIxZWU4MmQzNzA1NjVlZDBjNWY2NDE3
ZTU5NGZkMjUyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTA5LTAyICBNeWxl
cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgRm9udEZhY2VT
ZXQuc3RhdHVzIG5lZWRzIHRvIHJlYWN0IHRvIHN0eWxlIGNoYW5nZXMKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyOTgzOQorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gY29udGVudCBzYXlzICJkb2N1
bWVudC5mb250cy5zdGF0dXMiLCB0aGUgIi5zdGF0dXMiIHBhcnQgbmVlZHMgdG8KKyAgICAgICAg
dXBkYXRlIHN0eWxlIGluc3RlYWQgb2YgdGhlICJkb2N1bWVudC5mb250cyIgcGFydC4gVGhpcyBp
cyBiZWNhdXNlIGl0J3MKKyAgICAgICAgdG90YWxseSBsZWdhbCBmb3IgY29udGVudCB0byBzYXk6
CisKKyAgICAgICAgdmFyIGYgPSBkb2N1bWVudC5mb250czsKKyAgICAgICAgLy8gTW9kaWZ5IHN0
eWxlIGhlcmUKKyAgICAgICAgLi4uIGYuc3RhdHVzIC4uLiA8PT09IFRoaXMgbmVlZHMgdG8gcmVm
bGVjdCB0aGUgc3R5bGUgY2hhbmdlcy4KKworICAgICAgICBUZXN0OiBmYXN0L3RleHQvRm9udEZh
Y2VTZXQtc3RhdHVzLWFmdGVyLXN0eWxlLXVwZGF0ZS5odG1sCisKKyAgICAgICAgKiBjc3MvRm9u
dEZhY2VTZXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9udEZhY2VTZXQ6OnN0YXR1cyBjb25z
dCk6CisKIDIwMjEtMDktMDIgIFBlbmcgTGl1ICA8cGVuZy5saXU2QGFwcGxlLmNvbT4KIAogICAg
ICAgICBbTVNFXVtHUFVQXSBTb3VyY2VCdWZmZXJQcml2YXRlQVZGT2JqQyBkb2VzIG5vdCB3b3Jr
IHByb3Blcmx5IHdoZW4gYXVkaW8gYW5kIHZpZGVvIGV4Y2hhbmdlIHRoZWlyIHRyYWNrIElEcwpk
aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0ZvbnRGYWNlU2V0LmNwcCBiL1NvdXJjZS9X
ZWJDb3JlL2Nzcy9Gb250RmFjZVNldC5jcHAKaW5kZXggNGI2YmFmNzA1MjYwZmQxNWRkYWQ4MjM1
YmE4NTY5Zjc2NDhhN2JkNy4uZjdjNThmMzM0ODY4MWMzYzRkYmIzNWU3NTcyYjY2N2UyNTM2MGMz
ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0ZvbnRGYWNlU2V0LmNwcAorKysgYi9T
b3VyY2UvV2ViQ29yZS9jc3MvRm9udEZhY2VTZXQuY3BwCkBAIC0xODgsNyArMTg4LDEwIEBAIEV4
Y2VwdGlvbk9yPGJvb2w+IEZvbnRGYWNlU2V0OjpjaGVjayhjb25zdCBTdHJpbmcmIGZhbWlseSwg
Y29uc3QgU3RyaW5nJiB0ZXh0KQogICAgIAogYXV0byBGb250RmFjZVNldDo6c3RhdHVzKCkgY29u
c3QgLT4gTG9hZFN0YXR1cwogewotICAgIHN3aXRjaCAobV9iYWNraW5nLT5zdGF0dXMoKSkgewor
ICAgIGF1dG8gcHJvdGVjdCA9IG1fYmFja2luZzsKKyAgICBwcm90ZWN0LT51cGRhdGVTdHlsZUlm
TmVlZGVkKCk7CisKKyAgICBzd2l0Y2ggKHByb3RlY3QtPnN0YXR1cygpKSB7CiAgICAgY2FzZSBD
U1NGb250RmFjZVNldDo6U3RhdHVzOjpMb2FkaW5nOgogICAgICAgICByZXR1cm4gTG9hZFN0YXR1
czo6TG9hZGluZzsKICAgICBjYXNlIENTU0ZvbnRGYWNlU2V0OjpTdGF0dXM6OkxvYWRlZDoKZGlm
ZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpp
bmRleCAxYWVmOGE2YTU0NDI4MzljNWJkZjVkMjEzNTBhMGVlZTgwZmNhMzM1Li45YmFkMDk2NmU3
MWMzOTcwNWRlMGVlOWM1MTU0NjJmNmRkNjBmNTgwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9D
aGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIw
MjEtMDktMDIgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KKworICAg
ICAgICBGb250RmFjZVNldC5zdGF0dXMgbmVlZHMgdG8gcmVhY3QgdG8gc3R5bGUgY2hhbmdlcwor
ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5ODM5CisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBu
b3QgYSBXUFQgdGVzdCBiZWNhdXNlIGl0IHJlcXVpcmVzIGludGVybmFscy5pbnZhbGlkYXRlRm9u
dENhY2hlKCkuCisKKyAgICAgICAgKiBmYXN0L3RleHQvRm9udEZhY2VTZXQtc3RhdHVzLWFmdGVy
LXN0eWxlLXVwZGF0ZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvdGV4dC9G
b250RmFjZVNldC1zdGF0dXMtYWZ0ZXItc3R5bGUtdXBkYXRlLmh0bWw6IEFkZGVkLgorCiAyMDIx
LTA5LTAyICBQZW5nIExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+CiAKICAgICAgICAgW01TRV1b
R1BVUF0gU291cmNlQnVmZmVyUHJpdmF0ZUFWRk9iakMgZG9lcyBub3Qgd29yayBwcm9wZXJseSB3
aGVuIGF1ZGlvIGFuZCB2aWRlbyBleGNoYW5nZSB0aGVpciB0cmFjayBJRHMKZGlmZiAtLWdpdCBh
L0xheW91dFRlc3RzL2Zhc3QvdGV4dC9Gb250RmFjZVNldC1zdGF0dXMtYWZ0ZXItc3R5bGUtdXBk
YXRlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvdGV4dC9Gb250RmFjZVNldC1zdGF0
dXMtYWZ0ZXItc3R5bGUtdXBkYXRlLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NApp
bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi42MGFlNTEyZmYy
ZjUzMDFlYmRkYmJkN2FjOWY2YzliNjM2OWQwMzlmCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0
VGVzdHMvZmFzdC90ZXh0L0ZvbnRGYWNlU2V0LXN0YXR1cy1hZnRlci1zdHlsZS11cGRhdGUtZXhw
ZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTIgQEAKK1RoaXMgZnVuY3Rpb24gbWFrZXMgc3VyZSBkb2N1
bWVudC5mb250cy5zdGF0dXMgZ2V0cyB1cGRhdGVkIGFmdGVyIHN0eWxlIGNoYW5nZXMuCisKK09u
IHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxv
d2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIGZvbnRzLnN0YXR1cyBpcyAibG9hZGVk
IgorUEFTUyBmb250cy5zdGF0dXMgaXMgImxvYWRpbmciCitQQVNTIGZvbnRzLnN0YXR1cyBpcyAi
bG9hZGVkIgorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRF
CisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvdGV4dC9Gb250RmFjZVNldC1zdGF0dXMt
YWZ0ZXItc3R5bGUtdXBkYXRlLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3RleHQvRm9udEZhY2VT
ZXQtc3RhdHVzLWFmdGVyLXN0eWxlLXVwZGF0ZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu
ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmYwZDU5YjNjNzY5
ZjIzYjY0ODk1N2EyMjAxMzE3ZmFkNTkxNzUxNTEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU
ZXN0cy9mYXN0L3RleHQvRm9udEZhY2VTZXQtc3RhdHVzLWFmdGVyLXN0eWxlLXVwZGF0ZS5odG1s
CkBAIC0wLDAgKzEsMjkgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZCBpZD0iaGVh
ZCI+Cis8c3R5bGUgaWQ9InN0eWxlIj4KK0Bmb250LWZhY2UgeworICAgIGZvbnQtZmFtaWx5OiAi
V2ViRm9udCI7CisgICAgc3JjOiB1cmwoIi4uLy4uL3Jlc291cmNlcy9BaGVtLnR0ZiIpIGZvcm1h
dCgidHJ1ZXR5cGUiKTsKK30KKzwvc3R5bGU+Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2Vz
L2pzLXRlc3QuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KK2lmICh3aW5kb3cuaW50ZXJuYWxzKSB7
CisgICAgaW50ZXJuYWxzLmludmFsaWRhdGVGb250Q2FjaGUoKTsKKyAgICBpbnRlcm5hbHMuY2xl
YXJNZW1vcnlDYWNoZSgpOworfQorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxzY3JpcHQ+
CitkZXNjcmlwdGlvbigiVGhpcyBmdW5jdGlvbiBtYWtlcyBzdXJlIGRvY3VtZW50LmZvbnRzLnN0
YXR1cyBnZXRzIHVwZGF0ZWQgYWZ0ZXIgc3R5bGUgY2hhbmdlcy4iKTsKK2xldCBmb250cyA9IGRv
Y3VtZW50LmZvbnRzOworc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJmb250cy5zdGF0dXMiLCAibG9h
ZGVkIik7Citmb250cy52YWx1ZXMoKS5uZXh0KCkudmFsdWUubG9hZCgpOworc2hvdWxkQmVFcXVh
bFRvU3RyaW5nKCJmb250cy5zdGF0dXMiLCAibG9hZGluZyIpOworZG9jdW1lbnQuZ2V0RWxlbWVu
dEJ5SWQoImhlYWQiKS5yZW1vdmVDaGlsZChkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgic3R5bGUi
KSk7CitzaG91bGRCZUVxdWFsVG9TdHJpbmcoImZvbnRzLnN0YXR1cyIsICJsb2FkZWQiKTsKKzwv
c2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=
</data>
<flag name="review"
          id="460369"
          type_id="1"
          status="+"
          setter="sam"
    />
          </attachment>
      

    </bug>

</bugzilla>