229819 2021-09-02 11:23:49 -0700 Add automatic IDs for all headings on pages and posts 2022-03-10 16:47:44 -0800 1 1 1 Unclassified WebKit WebKit Website WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 1 jond jond jond ntim webkit-bug-importer oldest_to_newest 1789796 0 jond 2021-09-02 11:23:49 -0700 Automatically generate navigation ids for all headings in WordPress pages and posts. 1789797 1 437173 jond 2021-09-02 11:27:20 -0700 Created attachment 437173 Patch 1792002 2 webkit-bug-importer 2021-09-09 11:24:18 -0700 <rdar://problem/82935497> 1837089 3 437173 ntim 2022-02-03 13:41:06 -0800 Comment on attachment 437173 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437173&action=review > Websites/webkit.org/wp-content/themes/webkit/functions.php:140 > +add_filter('the_content', function($content) { > + return preg_replace_callback('/<h([1-6]{1})>([^<\/h]+)/', function ($matches) { > + return '<h'.$matches[1].' id="'.sanitize_title_with_dashes($matches[2]).'">'.$matches[2]; > + }, $content); > +}); Does this avoid conflicts with other IDs on the page? (and do we need to?) 1850322 4 jond 2022-03-10 16:43:38 -0800 No it does not avoid conflicts with other IDs on the page. The likelihood is very low given the only sane IDs that could have a conflict are #logo, and #header. It would require a content author to specify a heading with those exact terms (e.g. <h2>Logo</h2> or <h2>Header</h2>). Other IDs are generated from WordPress machinery that has almost no chance of being used in content headings (e.g. #site-nav, #menu-main-menu-container, #menu-item-6091). 1850324 5 jond 2022-03-10 16:47:44 -0800 We could more easily avoid conflicts with the use of a prefix (e.g. #toc-...) or a suffix (e.g. #...-section). It still isn't foolproof, but adds a measure of extra safety. 437173 2021-09-02 11:27:20 -0700 2021-09-02 11:27:20 -0700 Patch bug-229819-20210902112719.patch text/plain 1516 jond U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxOTM3CmRpZmYgLS1naXQgYS9XZWJzaXRlcy93ZWJraXQu b3JnL0NoYW5nZUxvZyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IDQ0OTdi ZDE3MDkxODMxMGU0ZWFhYTY2NTZjMmZhYTZjOTY2YTUxMmIuLjdiYjE2OTkwYmM0MDM0YTNhM2Fl ZjkxZDk3ZjY5ZTI2MzU2NTQ2ZDcgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hh bmdlTG9nCisrKyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMjEtMDktMDIgIEpvbiBEYXZpcyAgPGpvbmRAYXBwbGUuY29tPgorCisgICAgICAgIEdl bmVyYXRlIGlkIGF0dHJpYnV0ZXMgZm9yIGFsbCBoZWFkaW5ncy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyOTgxOQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3AtY29udGVudC90aGVtZXMvd2Via2l0 L2Z1bmN0aW9ucy5waHA6CisKIDIwMjEtMDktMDIgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRA YXBwbGUuY29tPgogCiAgICAgICAgIFtjb250cmlidXRvcnMuanNvbl0gUmVsb2NhdGlvbiAoUGFy dCAzKQpkaWZmIC0tZ2l0IGEvV2Vic2l0ZXMvd2Via2l0Lm9yZy93cC1jb250ZW50L3RoZW1lcy93 ZWJraXQvZnVuY3Rpb25zLnBocCBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvd3AtY29udGVudC90aGVt ZXMvd2Via2l0L2Z1bmN0aW9ucy5waHAKaW5kZXggOWYyOWZjMjRlODc2N2VjNjQxYzA2OGNmYTdl ZjVlNDY5YWY5ZDVjZC4uYTNlYjY3NTA0NDAyMzZhNmMwMzZiMTcwZGM3NzA0NjJiNGEzNGM2ZCAx MDA2NDQKLS0tIGEvV2Vic2l0ZXMvd2Via2l0Lm9yZy93cC1jb250ZW50L3RoZW1lcy93ZWJraXQv ZnVuY3Rpb25zLnBocAorKysgYi9XZWJzaXRlcy93ZWJraXQub3JnL3dwLWNvbnRlbnQvdGhlbWVz L3dlYmtpdC9mdW5jdGlvbnMucGhwCkBAIC0xMzIsNiArMTMyLDEzIEBAIGFkZF9maWx0ZXIoJ3Ro ZV90aXRsZScsIGZ1bmN0aW9uKCAkdGl0bGUgKSB7CiAgICAgcmV0dXJuICR0aXRsZTsKIH0pOwog CisvLyBBZGQgYXV0b21hdGljIElEcyBmb3IgaGVhZGluZ3MKK2FkZF9maWx0ZXIoJ3RoZV9jb250 ZW50JywgZnVuY3Rpb24oJGNvbnRlbnQpIHsKKyAgICByZXR1cm4gcHJlZ19yZXBsYWNlX2NhbGxi YWNrKCcvPGgoWzEtNl17MX0pPihbXjxcL2hdKykvJywgZnVuY3Rpb24gKCRtYXRjaGVzKSB7Cisg ICAgICAgIHJldHVybiAnPGgnLiRtYXRjaGVzWzFdLicgaWQ9Iicuc2FuaXRpemVfdGl0bGVfd2l0 aF9kYXNoZXMoJG1hdGNoZXNbMl0pLiciPicuJG1hdGNoZXNbMl07CisgICAgfSwgJGNvbnRlbnQp OworfSk7CisKIC8vIEZvciBSU1MgZmVlZHMsIGNvbnZlcnQgcmVsYXRpdmUgVVJJcyB0byBhYnNv bHV0ZQogYWRkX2ZpbHRlcigndGhlX2NvbnRlbnQnLCBmdW5jdGlvbigkY29udGVudCkgewogICAg IGlmICghaXNfZmVlZCgpKSByZXR1cm4gJGNvbnRlbnQ7Cg==