229798 2021-09-02 03:32:14 -0700 Use isRendererReplacedElement for SimplifiedBackwardsTextIterator 2021-09-03 14:45:00 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 229857 1 fred.wang fred.wang cfleizach darin ews-watchlist mifenton webkit-bug-importer oldest_to_newest 1789651 0 fred.wang 2021-09-02 03:32:14 -0700 . 1789652 1 437132 fred.wang 2021-09-02 03:33:45 -0700 Created attachment 437132 Patch 1789696 2 437151 fred.wang 2021-09-02 07:03:37 -0700 Created attachment 437151 Patch 1789905 3 437151 fred.wang 2021-09-02 14:48:30 -0700 Comment on attachment 437151 Patch Hi Chris, I think you reviewed this part of the code in the past. Can you please take a look? 1789928 4 437151 darin 2021-09-02 15:21:49 -0700 Comment on attachment 437151 Patch I assume the real benefits of this fix are more indirect, for the clients of SimplifiedBackwardsTextIterator, such as the visible boundary functions, which presumably give us incorrect results in these cases. It’s unfortunate that we don’t really know what those cases are and so can only detect the improvement with a unit test of the iterator itself. 1790071 5 437151 fred.wang 2021-09-03 00:21:54 -0700 Comment on attachment 437151 Patch It seems the crashes in mac-debug-wk1 are unrelated, the same happens for https://ews-build.webkit.org/#/builders/56/builds/14425 (In reply to Darin Adler from comment #4) > Comment on attachment 437151 [details] > Patch > > I assume the real benefits of this fix are more indirect, for the clients of > SimplifiedBackwardsTextIterator, such as the visible boundary functions, > which presumably give us incorrect results in these cases. > > It’s unfortunate that we don’t really know what those cases are and so can > only detect the improvement with a unit test of the iterator itself. I agree. It seems the new cases were added for the sake of a11y. I wonder if our a11y thing is actually using SimplifiedBackwardsTextIterator. At least the visible boundary function is already emitting "," for some cases, so it looks like we want consistency here. Also wonder if the isMedia() part is actually even used, we are no longer testing it at all after the move to modern media control. Will try to remove in a separate patch. 1790072 6 ews-feeder 2021-09-03 00:25:40 -0700 Committed r281979 (241286@main): <https://commits.webkit.org/241286@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437151. 1790073 7 webkit-bug-importer 2021-09-03 00:26:23 -0700 <rdar://problem/82712284> 1790182 8 fred.wang 2021-09-03 08:44:27 -0700 (In reply to Frédéric Wang (:fredw) from comment #5) > I agree. It seems the new cases were added for the sake of a11y. I wonder if > our a11y thing is actually using SimplifiedBackwardsTextIterator. At least > the visible boundary function is already emitting "," for some cases, so it > looks like we want consistency here. > > Also wonder if the isMedia() part is actually even used, we are no longer > testing it at all after the move to modern media control. Will try to remove > in a separate patch. OK, I checked again and there are actually tests broken if we remove that. More at bug 229857. It seems the a11y code does not use SimplifiedBackwardsTextIterator, I was not able to trigger the code even with previousTextMarker. So I added another case in backwards-text-iterator-basic.html 1790347 9 darin 2021-09-03 13:52:40 -0700 (In reply to Frédéric Wang (:fredw) from comment #8) > It seems the a11y code does not use > SimplifiedBackwardsTextIterator AXObjectCache::previousBoundary uses SimplifiedBackwardsTextIterator, and I believe that is accessibility code. Called by AXObjectCache::startCharacterOffsetOfSentence and AXObjectCache::startCharacterOffsetOfWord. Really surprised that accessibility has its own redundant copy of functions VisibleUnits.cpp; worth fixing that some day. 1790375 10 fred.wang 2021-09-03 14:45:00 -0700 (In reply to Darin Adler from comment #9) > (In reply to Frédéric Wang (:fredw) from comment #8) > > It seems the a11y code does not use > > SimplifiedBackwardsTextIterator > > AXObjectCache::previousBoundary uses SimplifiedBackwardsTextIterator, and I > believe that is accessibility code. Called by > AXObjectCache::startCharacterOffsetOfSentence and > AXObjectCache::startCharacterOffsetOfWord. Really surprised that > accessibility has its own redundant copy of functions VisibleUnits.cpp; > worth fixing that some day. OK, thanks I hadn't tried to dig more into the code actually. what I meant is that I did changes to text-marker-previous-next.html in https://bugs.webkit.org/attachment.cgi?id=437274&action=review which uses nextTextMarker/previousTextMarker ; I'm able to break that new test by tweaking TextIterator but not with SimplifiedBackwardsTextIterator. 437132 2021-09-02 03:33:45 -0700 2021-09-02 07:03:37 -0700 Patch 0001-Bug-229798-Use-isRendererReplacedElement-for-Simplif.patch text/plain 4277 fred.wang RnJvbSA1MGRiMjIzYjhjYjRjN2ZhZTZiMTdhNThkMjgyMmIxMDhjY2M1YTJjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RnI9QzM9QTlkPUMzPUE5cmljPTIwV2FuZz89 IDxmd2FuZ0BpZ2FsaWEuY29tPgpEYXRlOiBUaHUsIDIgU2VwIDIwMjEgMTI6MzI6MTcgKzAyMDAK U3ViamVjdDogW1BBVENIXSBCdWcgMjI5Nzk4IC0gVXNlIGlzUmVuZGVyZXJSZXBsYWNlZEVsZW1l bnQgZm9yCiBTaW1wbGlmaWVkQmFja3dhcmRzVGV4dEl0ZXJhdG9yCgotLS0KIC4uLmFyZHMtdGV4 dC1pdGVyYXRvci1hdHRhY2htZW50LWV4cGVjdGVkLnR4dCB8IDEwICsrKysrKysrKysKIC4uLi9i YWNrd2FyZHMtdGV4dC1pdGVyYXRvci1hdHRhY2htZW50Lmh0bWwgICB8IDE5ICsrKysrKysrKysr KysrKysrKysKIC4uLi9iYWNrd2FyZHMtdGV4dC1pdGVyYXRvci1iYXNpYy5odG1sICAgICAgICB8 ICA1ICsrKysrCiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1RleHRJdGVyYXRvci5jcHAgICAgICAg fCAgMiArLQogNCBmaWxlcyBjaGFuZ2VkLCAzNSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0p CiBjcmVhdGUgbW9kZSAxMDA2NDQgTGF5b3V0VGVzdHMvZWRpdGluZy90ZXh0LWl0ZXJhdG9yL2Jh Y2t3YXJkcy10ZXh0LWl0ZXJhdG9yLWF0dGFjaG1lbnQtZXhwZWN0ZWQudHh0CiBjcmVhdGUgbW9k ZSAxMDA2NDQgTGF5b3V0VGVzdHMvZWRpdGluZy90ZXh0LWl0ZXJhdG9yL2JhY2t3YXJkcy10ZXh0 LWl0ZXJhdG9yLWF0dGFjaG1lbnQuaHRtbAoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRp bmcvdGV4dC1pdGVyYXRvci9iYWNrd2FyZHMtdGV4dC1pdGVyYXRvci1hdHRhY2htZW50LWV4cGVj dGVkLnR4dCBiL0xheW91dFRlc3RzL2VkaXRpbmcvdGV4dC1pdGVyYXRvci9iYWNrd2FyZHMtdGV4 dC1pdGVyYXRvci1hdHRhY2htZW50LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwLi4yMzI5OTgyM2ZjCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvZWRpdGluZy90ZXh0LWl0ZXJhdG9yL2JhY2t3YXJkcy10ZXh0LWl0ZXJhdG9yLWF0dGFjaG1l bnQtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTAgQEAKK1ZlcmlmeSB0aGF0IFNpbXBsaWZpZWRC YWNrd2FyZHNUZXh0SXRlcmF0b3IgdHJlYXRzCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBh IHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4K KworCitQQVNTIGludGVybmFscy5yYW5nZUFzVGV4dFVzaW5nQmFja3dhcmRzVGV4dEl0ZXJhdG9y KHJhbmdlKSBpcyAic29tZSx0ZXh0IgorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQor CitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvdGV4dC1p dGVyYXRvci9iYWNrd2FyZHMtdGV4dC1pdGVyYXRvci1hdHRhY2htZW50Lmh0bWwgYi9MYXlvdXRU ZXN0cy9lZGl0aW5nL3RleHQtaXRlcmF0b3IvYmFja3dhcmRzLXRleHQtaXRlcmF0b3ItYXR0YWNo bWVudC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAuLmVmMWU0YjU4 YWQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3RleHQtaXRlcmF0b3Iv YmFja3dhcmRzLXRleHQtaXRlcmF0b3ItYXR0YWNobWVudC5odG1sCkBAIC0wLDAgKzEsMTkgQEAK KzwhRE9DVFlQRSBodG1sPjwhLS0gd2Via2l0LXRlc3QtcnVubmVyIFsgQXR0YWNobWVudEVsZW1l bnRFbmFibGVkPXRydWUgXSAtLT4KKzxodG1sPgorPGJvZHk+Cis8ZGl2IGlkPSJjb250YWluZXIi PnNvbWU8YXR0YWNobWVudCBpZD0iYXR0YWNobWVudCIgdGl0bGU9InRpdGxlIiBzdWJ0aXRsZT0i c3VidGl0bGUiIGFjdGlvbj0iYWN0aW9uIiBwcm9ncmVzcz0iMC41Ij48L2F0dGFjaG1lbnQ+dGV4 dDwvZGl2PgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LmpzIj48L3Njcmlw dD4KKzxzY3JpcHQ+CisKK2Rlc2NyaXB0aW9uKCdWZXJpZnkgdGhhdCBTaW1wbGlmaWVkQmFja3dh cmRzVGV4dEl0ZXJhdG9yIHRyZWF0cyA8YXR0YWNobWVudD4gYXMgZWxlbWVudHMgYXMgcmVwbGFj ZWQgZWxlbWVudCcpOworCitjb25zdCByYW5nZSA9IG5ldyBSYW5nZTsKK3JhbmdlLnNlbGVjdE5v ZGVDb250ZW50cyhjb250YWluZXIpOworc2hvdWxkQmUoJ2ludGVybmFscy5yYW5nZUFzVGV4dFVz aW5nQmFja3dhcmRzVGV4dEl0ZXJhdG9yKHJhbmdlKScsICcic29tZSx0ZXh0IicpOworCitjb250 YWluZXIuaW5uZXJIVE1MID0gJyc7CisKK3N1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cis8L3Nj cmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcv dGV4dC1pdGVyYXRvci9iYWNrd2FyZHMtdGV4dC1pdGVyYXRvci1iYXNpYy5odG1sIGIvTGF5b3V0 VGVzdHMvZWRpdGluZy90ZXh0LWl0ZXJhdG9yL2JhY2t3YXJkcy10ZXh0LWl0ZXJhdG9yLWJhc2lj Lmh0bWwKaW5kZXggYjgwZTMwY2QwOS4uMDhjNWQ2OWRhNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvZWRpdGluZy90ZXh0LWl0ZXJhdG9yL2JhY2t3YXJkcy10ZXh0LWl0ZXJhdG9yLWJhc2ljLmh0 bWwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy90ZXh0LWl0ZXJhdG9yL2JhY2t3YXJkcy10ZXh0 LWl0ZXJhdG9yLWJhc2ljLmh0bWwKQEAgLTUwLDYgKzUwLDExIEBAIGRlYnVnKCcnKTsKIHNob3Vs ZEJlKCdwbGFpblRleHRXaXRoVGV4dEl0ZXJhdG9yKCI8dGFibGU+PHRyPjx0ZD5oZWxsbzwvdGQ+ PHRkPndvcmxkPC90ZD48L3RhYmxlPiIpJywgJyJoZWxsb1x0d29ybGQiJyk7CiBzaG91bGRCZSgn cGxhaW5UZXh0V2l0aEJhY2t3YXJkc1RleHRJdGVyYXRvcigiPHRhYmxlPjx0cj48dGQ+aGVsbG88 L3RkPjx0ZD53b3JsZDwvdGQ+PC90YWJsZT4iKScsICciXFxuXFxuaGVsbG9cXG53b3JsZCInKTsK IAorZGVidWcoJycpOworCisvLyBWZXJpZnkgdGhhdCByZXBsYWNlZCBlbGVtZW50cyBlbWl0IGEg Y29tbWEuCitzaG91bGRCZShgcGxhaW5UZXh0V2l0aEJhY2t3YXJkc1RleHRJdGVyYXRvcigiaW1n PGltZz5pZnJhbWU8aWZyYW1lPjwvaWZyYW1lPmF1ZGlvPGF1ZGlvIHdpZHRoPScxMCcgaGVpZ2h0 PScxMCcgY29udHJvbHM+PC9hdWRpbz5tZXRlcjxtZXRlcj48L21ldGVyPnByb2dyZXNzPHByb2dy ZXNzPjwvcHJvZ3Jlc3M+PGxlZ2VuZD5sZWdlbmQ8L2xlZ2VuZD5pbWdyb2xlPHNwYW4gcm9sZT0n aW1nJz48L3NwYW4+YnV0dG9uPGJ1dHRvbj48L2J1dHRvbj4iKWAsICciaW1nLGlmcmFtZSxhdWRp byxtZXRlcixwcm9ncmVzcyxcXG5sZWdlbmQsaW1ncm9sZSxidXR0b24sIicpOworCiBjb250YWlu ZXIuaW5uZXJIVE1MID0gJyc7CiAKIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1RleHRJdGVyYXRvci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9lZGl0aW5nL1RleHRJdGVyYXRvci5jcHAKaW5kZXggZDc0ZTZkZTU0OS4uNWI5ODMxYTgx MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9UZXh0SXRlcmF0b3IuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvVGV4dEl0ZXJhdG9yLmNwcApAQCAtMTE5OSw3ICsx MTk5LDcgQEAgdm9pZCBTaW1wbGlmaWVkQmFja3dhcmRzVGV4dEl0ZXJhdG9yOjphZHZhbmNlKCkK ICAgICAgICAgICAgIGlmIChyZW5kZXJlciAmJiByZW5kZXJlci0+aXNUZXh0KCkgJiYgbV9ub2Rl LT5pc1RleHROb2RlKCkpIHsKICAgICAgICAgICAgICAgICBpZiAocmVuZGVyZXItPnN0eWxlKCku dmlzaWJpbGl0eSgpID09IFZpc2liaWxpdHk6OlZpc2libGUgJiYgbV9vZmZzZXQgPiAwKQogICAg ICAgICAgICAgICAgICAgICBtX2hhbmRsZWROb2RlID0gaGFuZGxlVGV4dE5vZGUoKTsKLSAgICAg ICAgICAgIH0gZWxzZSBpZiAocmVuZGVyZXIgJiYgKHJlbmRlcmVyLT5pc0ltYWdlKCkgfHwgcmVu ZGVyZXItPmlzV2lkZ2V0KCkpKSB7CisgICAgICAgICAgICB9IGVsc2UgaWYgKGlzUmVuZGVyZXJS ZXBsYWNlZEVsZW1lbnQocmVuZGVyZXIpKSB7CiAgICAgICAgICAgICAgICAgaWYgKHJlbmRlcmVy LT5zdHlsZSgpLnZpc2liaWxpdHkoKSA9PSBWaXNpYmlsaXR5OjpWaXNpYmxlICYmIG1fb2Zmc2V0 ID4gMCkKICAgICAgICAgICAgICAgICAgICAgbV9oYW5kbGVkTm9kZSA9IGhhbmRsZVJlcGxhY2Vk RWxlbWVudCgpOwogICAgICAgICAgICAgfSBlbHNlCi0tIAoyLjMwLjEgKEFwcGxlIEdpdC0xMzAp Cgo= 437151 2021-09-02 07:03:37 -0700 2021-09-03 00:25:41 -0700 Patch 0001-Bug-229798-Use-isRendererReplacedElement-for-Simplif.patch text/plain 8299 fred.wang RnJvbSAzOTEyYzQzMzFiNTkwNjlkNGU3YzU4ZjAwMjkzMTA4MjBiMjViM2MwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RnI9QzM9QTlkPUMzPUE5cmljPTIwV2FuZz89 IDxmd2FuZ0BpZ2FsaWEuY29tPgpEYXRlOiBUaHUsIDIgU2VwIDIwMjEgMTU6NTc6NTcgKzAyMDAK U3ViamVjdDogW1BBVENIXSBCdWcgMjI5Nzk4IC0gVXNlIGlzUmVuZGVyZXJSZXBsYWNlZEVsZW1l bnQgZm9yCiBTaW1wbGlmaWVkQmFja3dhcmRzVGV4dEl0ZXJhdG9yCgotLS0KIExheW91dFRlc3Rz L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICB8IDIwICsrKysrKysrKysrKysrKysr KwogLi4uYXJkcy10ZXh0LWl0ZXJhdG9yLWF0dGFjaG1lbnQtZXhwZWN0ZWQudHh0IHwgMTAgKysr KysrKysrCiAuLi4vYmFja3dhcmRzLXRleHQtaXRlcmF0b3ItYXR0YWNobWVudC5odG1sICAgfCAx OSArKysrKysrKysrKysrKysrKwogLi4uYmFja3dhcmRzLXRleHQtaXRlcmF0b3ItYmFzaWMtZXhw ZWN0ZWQudHh0IHwgIDIgKysKIC4uLi9iYWNrd2FyZHMtdGV4dC1pdGVyYXRvci1iYXNpYy5odG1s ICAgICAgICB8ICA1ICsrKysrCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgICAgICAgfCAyMSArKysrKysrKysrKysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5n L1RleHRJdGVyYXRvci5jcHAgICAgICAgfCAgMiArLQogNyBmaWxlcyBjaGFuZ2VkLCA3OCBpbnNl cnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCiBjcmVhdGUgbW9kZSAxMDA2NDQgTGF5b3V0VGVzdHMv ZWRpdGluZy90ZXh0LWl0ZXJhdG9yL2JhY2t3YXJkcy10ZXh0LWl0ZXJhdG9yLWF0dGFjaG1lbnQt ZXhwZWN0ZWQudHh0CiBjcmVhdGUgbW9kZSAxMDA2NDQgTGF5b3V0VGVzdHMvZWRpdGluZy90ZXh0 LWl0ZXJhdG9yL2JhY2t3YXJkcy10ZXh0LWl0ZXJhdG9yLWF0dGFjaG1lbnQuaHRtbAoKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRl eCAxOGQ1YTJiNWJlLi44Y2ZiMzVlYmU4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMjEtMDkt MDIgIEZyw6lkw6lyaWMgV2FuZyAgPGZ3YW5nQGlnYWxpYS5jb20+CisKKyAgICAgICAgVXNlIGlz UmVuZGVyZXJSZXBsYWNlZEVsZW1lbnQgZm9yIFNpbXBsaWZpZWRCYWNrd2FyZHNUZXh0SXRlcmF0 b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyOTc5 OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBu ZXcgdGVzdHMgZm9yIFNpbXBsaWZpZWRCYWNrd2FyZHNUZXh0SXRlcmF0b3IsIGNvdmVyaW5nIGFs bCBuZXcgY2FzZXMgZXhjZXB0IG1lZGlhCisgICAgICAgIGVsZW1lbnRzLiBtZWRpYS1lbWl0cy1v YmplY3QtcmVwbGFjZW1lbnQuaHRtbCB3YXMgYWRkZWQgaW4gcjE1ODc0MyBidXQgcmVtb3ZlZCBp biByMjc0ODEwCisgICAgICAgIHdpdGggYWxsIHRoZSB0ZXN0cyByZWx5aW5nIG9uIE1vZGVybk1l ZGlhQ29udHJvbHNFbmFibGVkPWZhbHNlLiBBbHNvLCBzaW1pbGFyIHRlc3RzIGZvcgorICAgICAg ICBUZXh0SXRlcmF0b3IgKHBsYWluVGV4dFdpdGhUZXh0SXRlcmF0b3IpIGFyZSBub3RlIGFkZGVk LCBiZWNhdXNlIGl0cyBoYW5kbGVSZXBsYWNlZEVsZW1lbnQKKyAgICAgICAgZnVuY3Rpb24gaXMg bW9yZSBtb3JlIGNvbXBsZXggYW5kIGRvZXMgbm90IGVtaXQgYSBjb21tYSBieSBkZWZhdWx0Lgor CisgICAgICAgICogZWRpdGluZy90ZXh0LWl0ZXJhdG9yL2JhY2t3YXJkcy10ZXh0LWl0ZXJhdG9y LWF0dGFjaG1lbnQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBlZGl0aW5nL3RleHQt aXRlcmF0b3IvYmFja3dhcmRzLXRleHQtaXRlcmF0b3ItYXR0YWNobWVudC5odG1sOiBBZGRlZC4g Q2hlY2tzIHRoYXQgYSBjb21tYQorICAgICAgICBpcyBlbWl0ZWQgZm9yIDxhdHRhY2htZW50PiBl bGVtZW50LgorICAgICAgICAqIGVkaXRpbmcvdGV4dC1pdGVyYXRvci9iYWNrd2FyZHMtdGV4dC1p dGVyYXRvci1iYXNpYy1leHBlY3RlZC50eHQ6IEFkZCB0aGUgbmV3IHJlc3VsdC4KKyAgICAgICAg KiBlZGl0aW5nL3RleHQtaXRlcmF0b3IvYmFja3dhcmRzLXRleHQtaXRlcmF0b3ItYmFzaWMuaHRt bDogQ2hlY2sgdGhlIHJlbWFpbmluZyBjYXNlcyBiZXNpZGVzCisgICAgICAgIGF0dGFjaG1lbnQg YW5kIG1lZGlhLgorCiAyMDIxLTA4LTI0ICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5lbkBhcHBs ZS5jb20+CiAKICAgICAgICAgQU5HTEUgTWV0YWwgaW5maW5pdGllcyBhbmQgTmFOcyBnZW5lcmF0 ZWQgd2l0aCBpbmNvcnJlY3Qgc3ludGF4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5n L3RleHQtaXRlcmF0b3IvYmFja3dhcmRzLXRleHQtaXRlcmF0b3ItYXR0YWNobWVudC1leHBlY3Rl ZC50eHQgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3RleHQtaXRlcmF0b3IvYmFja3dhcmRzLXRleHQt aXRlcmF0b3ItYXR0YWNobWVudC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMC4uMjMyOTk4MjNmYwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz L2VkaXRpbmcvdGV4dC1pdGVyYXRvci9iYWNrd2FyZHMtdGV4dC1pdGVyYXRvci1hdHRhY2htZW50 LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDEwIEBACitWZXJpZnkgdGhhdCBTaW1wbGlmaWVkQmFj a3dhcmRzVGV4dEl0ZXJhdG9yIHRyZWF0cworCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBz ZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisK KworUEFTUyBpbnRlcm5hbHMucmFuZ2VBc1RleHRVc2luZ0JhY2t3YXJkc1RleHRJdGVyYXRvcihy YW5nZSkgaXMgInNvbWUsdGV4dCIKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKwor VEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL3RleHQtaXRl cmF0b3IvYmFja3dhcmRzLXRleHQtaXRlcmF0b3ItYXR0YWNobWVudC5odG1sIGIvTGF5b3V0VGVz dHMvZWRpdGluZy90ZXh0LWl0ZXJhdG9yL2JhY2t3YXJkcy10ZXh0LWl0ZXJhdG9yLWF0dGFjaG1l bnQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwLi5lZjFlNGI1OGFk Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy90ZXh0LWl0ZXJhdG9yL2Jh Y2t3YXJkcy10ZXh0LWl0ZXJhdG9yLWF0dGFjaG1lbnQuaHRtbApAQCAtMCwwICsxLDE5IEBACis8 IURPQ1RZUEUgaHRtbD48IS0tIHdlYmtpdC10ZXN0LXJ1bm5lciBbIEF0dGFjaG1lbnRFbGVtZW50 RW5hYmxlZD10cnVlIF0gLS0+Cis8aHRtbD4KKzxib2R5PgorPGRpdiBpZD0iY29udGFpbmVyIj5z b21lPGF0dGFjaG1lbnQgaWQ9ImF0dGFjaG1lbnQiIHRpdGxlPSJ0aXRsZSIgc3VidGl0bGU9InN1 YnRpdGxlIiBhY3Rpb249ImFjdGlvbiIgcHJvZ3Jlc3M9IjAuNSI+PC9hdHRhY2htZW50PnRleHQ8 L2Rpdj4KKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC5qcyI+PC9zY3JpcHQ+ Cis8c2NyaXB0PgorCitkZXNjcmlwdGlvbignVmVyaWZ5IHRoYXQgU2ltcGxpZmllZEJhY2t3YXJk c1RleHRJdGVyYXRvciB0cmVhdHMgPGF0dGFjaG1lbnQ+IGFzIGVsZW1lbnRzIGFzIHJlcGxhY2Vk IGVsZW1lbnQnKTsKKworY29uc3QgcmFuZ2UgPSBuZXcgUmFuZ2U7CityYW5nZS5zZWxlY3ROb2Rl Q29udGVudHMoY29udGFpbmVyKTsKK3Nob3VsZEJlKCdpbnRlcm5hbHMucmFuZ2VBc1RleHRVc2lu Z0JhY2t3YXJkc1RleHRJdGVyYXRvcihyYW5nZSknLCAnInNvbWUsdGV4dCInKTsKKworY29udGFp bmVyLmlubmVySFRNTCA9ICcnOworCitzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOworPC9zY3Jp cHQ+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL3Rl eHQtaXRlcmF0b3IvYmFja3dhcmRzLXRleHQtaXRlcmF0b3ItYmFzaWMtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvZWRpdGluZy90ZXh0LWl0ZXJhdG9yL2JhY2t3YXJkcy10ZXh0LWl0ZXJhdG9y LWJhc2ljLWV4cGVjdGVkLnR4dAppbmRleCBhZDMzYTVmMmNkLi43YmIxNDM3YjQ3IDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9lZGl0aW5nL3RleHQtaXRlcmF0b3IvYmFja3dhcmRzLXRleHQtaXRl cmF0b3ItYmFzaWMtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvdGV4dC1p dGVyYXRvci9iYWNrd2FyZHMtdGV4dC1pdGVyYXRvci1iYXNpYy1leHBlY3RlZC50eHQKQEAgLTIw LDYgKzIwLDggQEAgUEFTUyBwbGFpblRleHRXaXRoQmFja3dhcmRzVGV4dEl0ZXJhdG9yKCI8dWw+ PGxpPmhlbGxvPGxpPndvcmxkPC91bD5XZWJLaXQiKSBpcwogCiBQQVNTIHBsYWluVGV4dFdpdGhU ZXh0SXRlcmF0b3IoIjx0YWJsZT48dHI+PHRkPmhlbGxvPC90ZD48dGQ+d29ybGQ8L3RkPjwvdGFi bGU+IikgaXMgImhlbGxvCXdvcmxkIgogUEFTUyBwbGFpblRleHRXaXRoQmFja3dhcmRzVGV4dEl0 ZXJhdG9yKCI8dGFibGU+PHRyPjx0ZD5oZWxsbzwvdGQ+PHRkPndvcmxkPC90ZD48L3RhYmxlPiIp IGlzICJcblxuaGVsbG9cbndvcmxkIgorCitQQVNTIHBsYWluVGV4dFdpdGhCYWNrd2FyZHNUZXh0 SXRlcmF0b3IoImltZzxpbWc+aWZyYW1lPGlmcmFtZT48L2lmcmFtZT5tZXRlcjxtZXRlcj48L21l dGVyPnByb2dyZXNzPHByb2dyZXNzPjwvcHJvZ3Jlc3M+PGxlZ2VuZD5sZWdlbmQ8L2xlZ2VuZD5p bWdyb2xlPHNwYW4gcm9sZT0naW1nJz48L3NwYW4+PGJ1dHRvbj5idXR0b248L2J1dHRvbj4iKSBp cyAiaW1nLGlmcmFtZSxtZXRlcixwcm9ncmVzcyxcbmxlZ2VuZCxpbWdyb2xlLGJ1dHRvbiwiCiBQ QVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExFVEUKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2VkaXRpbmcvdGV4dC1pdGVyYXRvci9iYWNrd2FyZHMtdGV4dC1pdGVy YXRvci1iYXNpYy5odG1sIGIvTGF5b3V0VGVzdHMvZWRpdGluZy90ZXh0LWl0ZXJhdG9yL2JhY2t3 YXJkcy10ZXh0LWl0ZXJhdG9yLWJhc2ljLmh0bWwKaW5kZXggYjgwZTMwY2QwOS4uNzIwMTVmMTky ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZWRpdGluZy90ZXh0LWl0ZXJhdG9yL2JhY2t3YXJk cy10ZXh0LWl0ZXJhdG9yLWJhc2ljLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy90ZXh0 LWl0ZXJhdG9yL2JhY2t3YXJkcy10ZXh0LWl0ZXJhdG9yLWJhc2ljLmh0bWwKQEAgLTUwLDYgKzUw LDExIEBAIGRlYnVnKCcnKTsKIHNob3VsZEJlKCdwbGFpblRleHRXaXRoVGV4dEl0ZXJhdG9yKCI8 dGFibGU+PHRyPjx0ZD5oZWxsbzwvdGQ+PHRkPndvcmxkPC90ZD48L3RhYmxlPiIpJywgJyJoZWxs b1x0d29ybGQiJyk7CiBzaG91bGRCZSgncGxhaW5UZXh0V2l0aEJhY2t3YXJkc1RleHRJdGVyYXRv cigiPHRhYmxlPjx0cj48dGQ+aGVsbG88L3RkPjx0ZD53b3JsZDwvdGQ+PC90YWJsZT4iKScsICci XFxuXFxuaGVsbG9cXG53b3JsZCInKTsKIAorZGVidWcoJycpOworCisvLyBWZXJpZnkgdGhhdCBy ZXBsYWNlZCBlbGVtZW50cyBlbWl0IGEgY29tbWEuCitzaG91bGRCZShgcGxhaW5UZXh0V2l0aEJh Y2t3YXJkc1RleHRJdGVyYXRvcigiaW1nPGltZz5pZnJhbWU8aWZyYW1lPjwvaWZyYW1lPm1ldGVy PG1ldGVyPjwvbWV0ZXI+cHJvZ3Jlc3M8cHJvZ3Jlc3M+PC9wcm9ncmVzcz48bGVnZW5kPmxlZ2Vu ZDwvbGVnZW5kPmltZ3JvbGU8c3BhbiByb2xlPSdpbWcnPjwvc3Bhbj48YnV0dG9uPmJ1dHRvbjwv YnV0dG9uPiIpYCwgJyJpbWcsaWZyYW1lLG1ldGVyLHByb2dyZXNzLFxcbmxlZ2VuZCxpbWdyb2xl LGJ1dHRvbiwiJyk7CisKIGNvbnRhaW5lci5pbm5lckhUTUwgPSAnJzsKIAogc3VjY2Vzc2Z1bGx5 UGFyc2VkID0gdHJ1ZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiYTQ4OTRkMTgwLi4zM2ExMTEwYjhjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMjEtMDktMDIgIEZyw6lkw6lyaWMgV2FuZyAgPGZ3 YW5nQGlnYWxpYS5jb20+CisKKyAgICAgICAgVXNlIGlzUmVuZGVyZXJSZXBsYWNlZEVsZW1lbnQg Zm9yIFNpbXBsaWZpZWRCYWNrd2FyZHNUZXh0SXRlcmF0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyOTc5OAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRleHRJdGVyYXRvcjo6YWR2YW5jZSgpIHJlbGll cyBvbiBpc1JlbmRlcmVyUmVwbGFjZWRFbGVtZW50IHRvIGRldGVybWluZSB3aGV0aGVyIGFuIGVs ZW1lbnQKKyAgICAgICAgc2hvdWxkIGJlIHRyZWF0ZWQgYXMgYSByZXBsYWNlZCBlbGVtZW50IGFu ZCBlbWl0IGEgY29tbWEgJywnLiBTaW1wbGlmaWVkQmFja3dhcmRzVGV4dEl0ZXJhdG9yCisgICAg ICAgIGhhcyBzaW1pbGFyIGxvZ2ljIHRvIGNoZWNrIGZvciByZXBsYWNlZCBlbGVtZW50cywgYnV0 IGl0IGhhcyBub3QgYmVlbiB1cGRhdGVkIGFuZCBpcyBub3cKKyAgICAgICAgb3V0LW9mLXN5bmMu IFRoaXMgcGF0Y2ggbWFrZXMgU2ltcGxpZmllZEJhY2t3YXJkc1RleHRJdGVyYXRvciB1c2UgdGhl IHNhbWUgZnVuY3Rpb24KKyAgICAgICAgaXNSZW5kZXJlclJlcGxhY2VkRWxlbWVudCwgYWRkaW5n IHN1cHBvcnQgZm9yIGF0dGFjaG1lbnQgKHIyMDA1MDkpLCBtZWRpYSAocjE1ODc0MyksCisgICAg ICAgIGVsZW1lbnQgd2l0aCBhMTF5IHJvbGUgImltZyIgKHIxNTIzODgpIGFzIHdlbGwgYXMgdmFy aW91cyBjb250cm9sIGVsZW1lbnRzIChyMTU5NjYpLgorICAgICAgICBUaGlzIG1ha2VzIHRoZSB0 d28gaXRlcmF0b3JzIG1vcmUgY29uc2lzdGVudCBhbmQgZmFjaWxpdGF0ZXMgY29kZSBtYWludGVu YW5jZS4KKworICAgICAgICBUZXN0czogZWRpdGluZy90ZXh0LWl0ZXJhdG9yL2JhY2t3YXJkcy10 ZXh0LWl0ZXJhdG9yLWF0dGFjaG1lbnQuaHRtbAorICAgICAgICAgICAgICAgZWRpdGluZy90ZXh0 LWl0ZXJhdG9yL2JhY2t3YXJkcy10ZXh0LWl0ZXJhdG9yLmh0bWwKKworICAgICAgICAqIGVkaXRp bmcvVGV4dEl0ZXJhdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNpbXBsaWZpZWRCYWNrd2Fy ZHNUZXh0SXRlcmF0b3I6OmFkdmFuY2UpOiBVc2UgaXNSZW5kZXJlclJlcGxhY2VkRWxlbWVudC4K KwogMjAyMS0wOC0yNCAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgVW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIHIyODE1NDAuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9lZGl0aW5nL1RleHRJdGVyYXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0 aW5nL1RleHRJdGVyYXRvci5jcHAKaW5kZXggZDc0ZTZkZTU0OS4uNWI5ODMxYTgxMiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9UZXh0SXRlcmF0b3IuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2VkaXRpbmcvVGV4dEl0ZXJhdG9yLmNwcApAQCAtMTE5OSw3ICsxMTk5LDcgQEAg dm9pZCBTaW1wbGlmaWVkQmFja3dhcmRzVGV4dEl0ZXJhdG9yOjphZHZhbmNlKCkKICAgICAgICAg ICAgIGlmIChyZW5kZXJlciAmJiByZW5kZXJlci0+aXNUZXh0KCkgJiYgbV9ub2RlLT5pc1RleHRO b2RlKCkpIHsKICAgICAgICAgICAgICAgICBpZiAocmVuZGVyZXItPnN0eWxlKCkudmlzaWJpbGl0 eSgpID09IFZpc2liaWxpdHk6OlZpc2libGUgJiYgbV9vZmZzZXQgPiAwKQogICAgICAgICAgICAg ICAgICAgICBtX2hhbmRsZWROb2RlID0gaGFuZGxlVGV4dE5vZGUoKTsKLSAgICAgICAgICAgIH0g ZWxzZSBpZiAocmVuZGVyZXIgJiYgKHJlbmRlcmVyLT5pc0ltYWdlKCkgfHwgcmVuZGVyZXItPmlz V2lkZ2V0KCkpKSB7CisgICAgICAgICAgICB9IGVsc2UgaWYgKGlzUmVuZGVyZXJSZXBsYWNlZEVs ZW1lbnQocmVuZGVyZXIpKSB7CiAgICAgICAgICAgICAgICAgaWYgKHJlbmRlcmVyLT5zdHlsZSgp LnZpc2liaWxpdHkoKSA9PSBWaXNpYmlsaXR5OjpWaXNpYmxlICYmIG1fb2Zmc2V0ID4gMCkKICAg ICAgICAgICAgICAgICAgICAgbV9oYW5kbGVkTm9kZSA9IGhhbmRsZVJlcGxhY2VkRWxlbWVudCgp OwogICAgICAgICAgICAgfSBlbHNlCi0tIAoyLjI1LjEKCg==