229797 2021-09-02 02:24:53 -0700 [css-highlight-api] Use AbstractRange instead of StaticRange in Highlight IDL 2023-07-07 21:07:28 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 257520 InRadar, WebExposed, WPTImpact P2 Normal --- 1 rego webkit-unassigned ahmad.saleem792 cdumez esprehn+autocc ews-watchlist kangil.han kondapallykalyan megan_gardner ntim webkit-bug-importer oldest_to_newest 1789645 0 rego 2021-09-02 02:24:53 -0700 The IDL is using StaticRange: https://github.com/WebKit/WebKit/blob/main/Source/WebCore/Modules/highlight/Highlight.idl AbstractRange was implemented in https://trac.webkit.org/changeset/268648/webkit So we could now update the Highlight API to accept AbstractRange and match the spec: https://drafts.csswg.org/css-highlight-api-1/#highlight Otherwise most of the WPT tests that use Range() will fail in WebKit: https://wpt.fyi/results/css/css-highlight-api 1791816 1 webkit-bug-importer 2021-09-09 02:25:16 -0700 <rdar://problem/82916119> 1796093 2 438953 cdumez 2021-09-22 08:59:10 -0700 Created attachment 438953 WIP patch 1796204 3 cdumez 2021-09-22 14:27:16 -0700 Looks like we haven't imported the css/css-highlight-api WPT tests. 1965738 4 ntim 2023-07-07 21:06:28 -0700 *** This bug has been marked as a duplicate of bug 257520 *** 438953 2021-09-22 08:59:10 -0700 2021-09-22 19:13:29 -0700 WIP patch 229797_wip.patch text/plain 7369 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaGlnaGxpZ2h0L0hpZ2hsaWdodC5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2hpZ2hsaWdodC9IaWdobGlnaHQuY3BwCmluZGV4 IGY0N2JmNDYyNDk4Yi4uZDUwZTM3YTQ0OGRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL2hpZ2hsaWdodC9IaWdobGlnaHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvaGlnaGxpZ2h0L0hpZ2hsaWdodC5jcHAKQEAgLTI3LDQwICsyNywzOSBAQAogI2luY2x1ZGUg IkhpZ2hsaWdodC5oIgogCiAjaW5jbHVkZSAiSURMVHlwZXMuaCIKKyNpbmNsdWRlICJKU0Fic3Ry YWN0UmFuZ2UuaCIKICNpbmNsdWRlICJKU0RPTVNldExpa2UuaCIKLSNpbmNsdWRlICJKU1N0YXRp Y1JhbmdlLmgiCiAjaW5jbHVkZSAiTm9kZVRyYXZlcnNhbC5oIgogI2luY2x1ZGUgIlByb3BlcnR5 U2V0Q1NTU3R5bGVEZWNsYXJhdGlvbi5oIgogI2luY2x1ZGUgIlJlbmRlckJsb2NrRmxvdy5oIgog I2luY2x1ZGUgIlJlbmRlck9iamVjdC5oIgotI2luY2x1ZGUgIlN0YXRpY1JhbmdlLmgiCiAjaW5j bHVkZSAiU3R5bGVQcm9wZXJ0aWVzLmgiCiAjaW5jbHVkZSA8d3RmL1JlZi5oPgogCiBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAKLUhpZ2hsaWdodDo6SGlnaGxpZ2h0KFJlZjxTdGF0aWNSYW5nZT4mJiBy YW5nZSkKK0hpZ2hsaWdodDo6SGlnaGxpZ2h0KFZlY3RvcjxzdGQ6OnJlZmVyZW5jZV93cmFwcGVy PEFic3RyYWN0UmFuZ2U+PiYmIHJhbmdlcykKIHsKLSAgICBhdXRvIG15UmFuZ2UgPSBXVEZNb3Zl KHJhbmdlKTsKLSAgICBhZGRUb1NldExpa2UobXlSYW5nZS5nZXQoKSk7CisgICAgZm9yIChhdXRv JiByYW5nZSA6IHJhbmdlcykKKyAgICAgICAgYWRkVG9TZXRMaWtlKHJhbmdlKTsKIH0KIAotUmVm PEhpZ2hsaWdodD4gSGlnaGxpZ2h0OjpjcmVhdGUoU3RhdGljUmFuZ2UmIHJhbmdlKQorUmVmPEhp Z2hsaWdodD4gSGlnaGxpZ2h0OjpjcmVhdGUoVmVjdG9yPHN0ZDo6cmVmZXJlbmNlX3dyYXBwZXI8 QWJzdHJhY3RSYW5nZT4+JiYgcmFuZ2VzKQogewotICAgIHJldHVybiBhZG9wdFJlZigqbmV3IEhp Z2hsaWdodChyYW5nZSkpOworICAgIHJldHVybiBhZG9wdFJlZigqbmV3IEhpZ2hsaWdodChXVEZN b3ZlKHJhbmdlcykpKTsKIH0KIAogdm9pZCBIaWdobGlnaHQ6OmluaXRpYWxpemVTZXRMaWtlKERP TVNldEFkYXB0ZXImIHNldCkKIHsKICAgICBmb3IgKGF1dG8mIHJhbmdlRGF0YSA6IG1fcmFuZ2Vz RGF0YSkKLSAgICAgICAgc2V0LmFkZDxJRExJbnRlcmZhY2U8U3RhdGljUmFuZ2U+PihyYW5nZURh dGEtPnJhbmdlKTsKKyAgICAgICAgc2V0LmFkZDxJRExJbnRlcmZhY2U8QWJzdHJhY3RSYW5nZT4+ KHJhbmdlRGF0YS0+cmFuZ2UpOwogfQogCiBzdGF0aWMgdm9pZCByZXBhaW50UmFuZ2UoY29uc3Qg U2ltcGxlUmFuZ2UmIHJhbmdlKQogewogICAgIC8vIEZJWE1FOiBVbmNsZWFyIHByZWNpc2VseSB3 aHkgd2UgbmVlZCB0byBoYW5kbGUgb3V0IG9mIG9yZGVyIGNhc2VzIGhlcmUsIGJ1dCBub3QgdW5v cmRlcmVkIGNhc2VzLgogICAgIGF1dG8gc29ydGVkUmFuZ2UgPSByYW5nZTsKLSAgICBpZiAoaXNf Z3QodHJlZU9yZGVyPENvbXBvc2VkVHJlZT4ocmFuZ2Uuc3RhcnQsIHJhbmdlLmVuZCkpKQorICAg IGlmIChpc19ndCh0cmVlT3JkZXI8Q29tcG9zZWRUcmVlPihzb3J0ZWRSYW5nZS5zdGFydCwgc29y dGVkUmFuZ2UuZW5kKSkpCiAgICAgICAgIHN0ZDo6c3dhcChzb3J0ZWRSYW5nZS5zdGFydCwgc29y dGVkUmFuZ2UuZW5kKTsKICAgICBmb3IgKGF1dG8mIG5vZGUgOiBpbnRlcnNlY3RpbmdOb2Rlcyhz b3J0ZWRSYW5nZSkpIHsKICAgICAgICAgaWYgKGF1dG8gcmVuZGVyZXIgPSBub2RlLnJlbmRlcmVy KCkpCkBAIC02OCwxMSArNjcsMTcgQEAgc3RhdGljIHZvaWQgcmVwYWludFJhbmdlKGNvbnN0IFNp bXBsZVJhbmdlJiByYW5nZSkKICAgICB9CiB9CiAKLWJvb2wgSGlnaGxpZ2h0OjpyZW1vdmVGcm9t U2V0TGlrZShjb25zdCBTdGF0aWNSYW5nZSYgcmFuZ2UpCitzdGF0aWMgdm9pZCByZXBhaW50UmFu Z2UoY29uc3QgQWJzdHJhY3RSYW5nZSYgcmFuZ2UpCiB7Ci0gICAgcmV0dXJuIG1fcmFuZ2VzRGF0 YS5yZW1vdmVGaXJzdE1hdGNoaW5nKFsmcmFuZ2VdKGNvbnN0IFJlZjxIaWdobGlnaHRSYW5nZURh dGE+JiBjdXJyZW50KSB7Ci0gICAgICAgIHJlcGFpbnRSYW5nZShyYW5nZSk7Ci0gICAgICAgIHJl dHVybiBjdXJyZW50LmdldCgpLnJhbmdlLmdldCgpID09IHJhbmdlOworICAgIHJlcGFpbnRSYW5n ZShtYWtlU2ltcGxlUmFuZ2UocmFuZ2UpKTsKK30KKworYm9vbCBIaWdobGlnaHQ6OnJlbW92ZUZy b21TZXRMaWtlKGNvbnN0IEFic3RyYWN0UmFuZ2UmIHJhbmdlKQoreworICAgIGF1dG8gc2ltcGxl UmFuZ2UgPSBtYWtlU2ltcGxlUmFuZ2UocmFuZ2UpOworICAgIHJldHVybiBtX3Jhbmdlc0RhdGEu cmVtb3ZlRmlyc3RNYXRjaGluZyhbJnNpbXBsZVJhbmdlXShjb25zdCBSZWY8SGlnaGxpZ2h0UmFu Z2VEYXRhPiYgY3VycmVudCkgeworICAgICAgICByZXBhaW50UmFuZ2Uoc2ltcGxlUmFuZ2UpOwor ICAgICAgICByZXR1cm4gbWFrZVNpbXBsZVJhbmdlKGN1cnJlbnQuZ2V0KCkucmFuZ2UuZ2V0KCkp ID09IHNpbXBsZVJhbmdlOwogICAgIH0pOwogfQogCkBAIC04Myw5ICs4OCwxMCBAQCB2b2lkIEhp Z2hsaWdodDo6Y2xlYXJGcm9tU2V0TGlrZSgpCiAgICAgbV9yYW5nZXNEYXRhLmNsZWFyKCk7CiB9 CiAKLWJvb2wgSGlnaGxpZ2h0OjphZGRUb1NldExpa2UoU3RhdGljUmFuZ2UmIHJhbmdlKQorYm9v bCBIaWdobGlnaHQ6OmFkZFRvU2V0TGlrZShBYnN0cmFjdFJhbmdlJiByYW5nZSkKIHsKLSAgICBp ZiAobm90Rm91bmQgIT0gbV9yYW5nZXNEYXRhLmZpbmRNYXRjaGluZyhbJnJhbmdlXShjb25zdCBS ZWY8SGlnaGxpZ2h0UmFuZ2VEYXRhPiYgY3VycmVudCkgeyByZXR1cm4gY3VycmVudC5nZXQoKS5y YW5nZS5nZXQoKSA9PSByYW5nZTsgfSkpCisgICAgYXV0byBzaW1wbGVSYW5nZSA9IG1ha2VTaW1w bGVSYW5nZShyYW5nZSk7CisgICAgaWYgKG5vdEZvdW5kICE9IG1fcmFuZ2VzRGF0YS5maW5kTWF0 Y2hpbmcoWyZzaW1wbGVSYW5nZV0oY29uc3QgUmVmPEhpZ2hsaWdodFJhbmdlRGF0YT4mIGN1cnJl bnQpIHsgcmV0dXJuIG1ha2VTaW1wbGVSYW5nZShjdXJyZW50LmdldCgpLnJhbmdlLmdldCgpKSA9 PSBzaW1wbGVSYW5nZTsgfSkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICByZXBhaW50UmFu Z2UocmFuZ2UpOwogICAgIG1fcmFuZ2VzRGF0YS5hcHBlbmQoSGlnaGxpZ2h0UmFuZ2VEYXRhOjpj cmVhdGUocmFuZ2UpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaGlnaGxp Z2h0L0hpZ2hsaWdodC5oIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9oaWdobGlnaHQvSGlnaGxp Z2h0LmgKaW5kZXggMDA1MmMzZmJiNTEzLi4wYWRlZjEyMDc2OTAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvaGlnaGxpZ2h0L0hpZ2hsaWdodC5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvaGlnaGxpZ2h0L0hpZ2hsaWdodC5oCkBAIC0yNSw5ICsyNSw5IEBACiAKICNw cmFnbWEgb25jZQogCisjaW5jbHVkZSAiQWJzdHJhY3RSYW5nZS5oIgogI2luY2x1ZGUgIkV4Y2Vw dGlvbk9yLmgiCiAjaW5jbHVkZSAiUG9zaXRpb24uaCIKLSNpbmNsdWRlICJTdGF0aWNSYW5nZS5o IgogI2luY2x1ZGUgPHd0Zi9SZWZDb3VudGVkLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKQEAg LTM1LDI5ICszNSwyOCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBjbGFzcyBDU1NTdHlsZURlY2xh cmF0aW9uOwogY2xhc3MgRE9NU2V0QWRhcHRlcjsKIGNsYXNzIFByb3BlcnR5U2V0Q1NTU3R5bGVE ZWNsYXJhdGlvbjsKLWNsYXNzIFN0YXRpY1JhbmdlOwogCiAKIHN0cnVjdCBIaWdobGlnaHRSYW5n ZURhdGEgOiBSZWZDb3VudGVkPEhpZ2hsaWdodFJhbmdlRGF0YT4sIHB1YmxpYyBDYW5NYWtlV2Vh a1B0cjxIaWdobGlnaHRSYW5nZURhdGE+IHsKLSAgICBIaWdobGlnaHRSYW5nZURhdGEoUmVmPFN0 YXRpY1JhbmdlPiYmIHJhbmdlKQorICAgIEhpZ2hsaWdodFJhbmdlRGF0YShSZWY8QWJzdHJhY3RS YW5nZT4mJiByYW5nZSkKICAgICAgICAgOiByYW5nZShXVEZNb3ZlKHJhbmdlKSkKICAgICB7CiAg ICAgfQotICAgIHN0YXRpYyBSZWY8SGlnaGxpZ2h0UmFuZ2VEYXRhPiBjcmVhdGUoUmVmPFN0YXRp Y1JhbmdlPiYmIHJhbmdlKQorICAgIHN0YXRpYyBSZWY8SGlnaGxpZ2h0UmFuZ2VEYXRhPiBjcmVh dGUoUmVmPEFic3RyYWN0UmFuZ2U+JiYgcmFuZ2UpCiAgICAgewogICAgICAgICByZXR1cm4gYWRv cHRSZWYoKm5ldyBIaWdobGlnaHRSYW5nZURhdGEoV1RGTW92ZShyYW5nZSkpKTsKICAgICB9Ci0g ICAgUmVmPFN0YXRpY1JhbmdlPiByYW5nZTsKKyAgICBSZWY8QWJzdHJhY3RSYW5nZT4gcmFuZ2U7 CiAgICAgc3RkOjpvcHRpb25hbDxQb3NpdGlvbj4gc3RhcnRQb3NpdGlvbjsKICAgICBzdGQ6Om9w dGlvbmFsPFBvc2l0aW9uPiBlbmRQb3NpdGlvbjsKIH07CiAKIGNsYXNzIEhpZ2hsaWdodCA6IHB1 YmxpYyBSZWZDb3VudGVkPEhpZ2hsaWdodD4gewogcHVibGljOgotICAgIFdFQkNPUkVfRVhQT1JU IHN0YXRpYyBSZWY8SGlnaGxpZ2h0PiBjcmVhdGUoU3RhdGljUmFuZ2UmKTsKKyAgICBXRUJDT1JF X0VYUE9SVCBzdGF0aWMgUmVmPEhpZ2hsaWdodD4gY3JlYXRlKFZlY3RvcjxzdGQ6OnJlZmVyZW5j ZV93cmFwcGVyPEFic3RyYWN0UmFuZ2U+PiYmKTsKICAgICB2b2lkIGNsZWFyRnJvbVNldExpa2Uo KTsKLSAgICBib29sIGFkZFRvU2V0TGlrZShTdGF0aWNSYW5nZSYpOwotICAgIGJvb2wgcmVtb3Zl RnJvbVNldExpa2UoY29uc3QgU3RhdGljUmFuZ2UmKTsKKyAgICBib29sIGFkZFRvU2V0TGlrZShB YnN0cmFjdFJhbmdlJik7CisgICAgYm9vbCByZW1vdmVGcm9tU2V0TGlrZShjb25zdCBBYnN0cmFj dFJhbmdlJik7CiAgICAgdm9pZCBpbml0aWFsaXplU2V0TGlrZShET01TZXRBZGFwdGVyJik7CiAg ICAgCiAgICAgdm9pZCByZXBhaW50KCk7CkBAIC02Niw3ICs2NSw3IEBAIHB1YmxpYzoKICAgICAv LyBGSVhNRTogQWRkIFdFQkNPUkVfRVhQT1JUIENTU1N0eWxlRGVjbGFyYXRpb24mIHN0eWxlKCk7 CiBwcml2YXRlOgogICAgIFZlY3RvcjxSZWY8SGlnaGxpZ2h0UmFuZ2VEYXRhPj4gbV9yYW5nZXNE YXRhOyAvLyBGSVhNRTogdXNlIGEgSGFzaFNldCBpbnN0ZWFkIG9mIGEgVmVjdG9yIDxyZGFyOi8v cHJvYmxlbS81Nzc2MDYxND4KLSAgICBleHBsaWNpdCBIaWdobGlnaHQoUmVmPFN0YXRpY1Jhbmdl PiYmKTsKKyAgICBleHBsaWNpdCBIaWdobGlnaHQoVmVjdG9yPHN0ZDo6cmVmZXJlbmNlX3dyYXBw ZXI8QWJzdHJhY3RSYW5nZT4+JiYpOwogfTsKIAogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9oaWdobGlnaHQvSGlnaGxpZ2h0LmlkbCBiL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvaGlnaGxpZ2h0L0hpZ2hsaWdodC5pZGwKaW5kZXggZDVlYjdhOWYyMTZlLi40ZDM0Mzk5MDRl NzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaGlnaGxpZ2h0L0hpZ2hsaWdo dC5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9oaWdobGlnaHQvSGlnaGxpZ2h0Lmlk bApAQCAtMjgsOCArMjgsOCBAQAogICAgIEltcGxlbWVudGF0aW9uTGFja3NWVGFibGUsCiAgICAg RXhwb3NlZD1XaW5kb3cKIF0gaW50ZXJmYWNlIEhpZ2hsaWdodCB7Ci0gICAgY29uc3RydWN0b3Io U3RhdGljUmFuZ2UgcmFuZ2UpOworICAgIGNvbnN0cnVjdG9yKEFic3RyYWN0UmFuZ2UuLi4gcmFu Z2VzKTsKIAotICAgIHNldGxpa2U8U3RhdGljUmFuZ2U+OworICAgIHNldGxpa2U8QWJzdHJhY3RS YW5nZT47CiAgICAgLy8gRklYTUU6IEFkZCByZWFkb25seSBhdHRyaWJ1dGUgQ1NTU3R5bGVEZWNs YXJhdGlvbiBzdHlsZTsKIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2hp Z2hsaWdodC9IaWdobGlnaHRSZWdpc3Rlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2hp Z2hsaWdodC9IaWdobGlnaHRSZWdpc3Rlci5jcHAKaW5kZXggNTYwOTlkYzc5MDgwLi5mNWQxNWM1 MzExY2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaGlnaGxpZ2h0L0hpZ2hs aWdodFJlZ2lzdGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2hpZ2hsaWdodC9I aWdobGlnaHRSZWdpc3Rlci5jcHAKQEAgLTYzLDcgKzYzLDcgQEAgdm9pZCBIaWdobGlnaHRSZWdp c3Rlcjo6YWRkQXBwSGlnaGxpZ2h0KFJlZjxTdGF0aWNSYW5nZT4mJiB2YWx1ZSkKICAgICBpZiAo bV9tYXAuY29udGFpbnMoYXBwSGlnaGxpZ2h0S2V5KCkpKQogICAgICAgICBtX21hcC5nZXQoYXBw SGlnaGxpZ2h0S2V5KCkpLT5hZGRUb1NldExpa2UodmFsdWUpOwogICAgIGVsc2UKLSAgICAgICAg c2V0RnJvbU1hcExpa2UoYXBwSGlnaGxpZ2h0S2V5KCksIEhpZ2hsaWdodDo6Y3JlYXRlKFdURk1v dmUodmFsdWUpKSk7CisgICAgICAgIHNldEZyb21NYXBMaWtlKGFwcEhpZ2hsaWdodEtleSgpLCBI aWdobGlnaHQ6OmNyZWF0ZShWZWN0b3I8c3RkOjpyZWZlcmVuY2Vfd3JhcHBlcjxBYnN0cmFjdFJh bmdlPj4geyB2YWx1ZS5nZXQoKSB9KSk7CiB9CiAKIHZvaWQgSGlnaGxpZ2h0UmVnaXN0ZXI6OnNl dEhpZ2hsaWdodFZpc2liaWxpdHkoSGlnaGxpZ2h0VmlzaWJpbGl0eSBoaWdobGlnaHRWaXNpYmls aXR5KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKaW5kZXggMDU4MTJjMzYxNTkyLi4xNzEwZWZlNTk3 MGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApAQCAtMjg4Nyw3ICsyODg3LDcgQEAgdm9pZCBE b2N1bWVudDo6dXBkYXRlSGlnaGxpZ2h0UG9zaXRpb25zKCkKIAogICAgIGZvciAoYXV0byYgd2Vh a1JhbmdlRGF0YSA6IHJhbmdlc0RhdGEpIHsKICAgICAgICAgaWYgKGF1dG8qIHJhbmdlRGF0YSA9 IHdlYWtSYW5nZURhdGEuZ2V0KCkpIHsKLSAgICAgICAgICAgIFZpc2libGVTZWxlY3Rpb24gdmlz aWJsZVNlbGVjdGlvbihyYW5nZURhdGEtPnJhbmdlKTsKKyAgICAgICAgICAgIFZpc2libGVTZWxl Y3Rpb24gdmlzaWJsZVNlbGVjdGlvbihtYWtlU2ltcGxlUmFuZ2UocmFuZ2VEYXRhLT5yYW5nZSkp OwogICAgICAgICAgICAgUG9zaXRpb24gc3RhcnRQb3NpdGlvbjsKICAgICAgICAgICAgIFBvc2l0 aW9uIGVuZFBvc2l0aW9uOwogICAgICAgICAgICAgaWYgKCFyYW5nZURhdGEtPnN0YXJ0UG9zaXRp b24uaGFzX3ZhbHVlKCkpCg==