229794 2021-09-02 01:27:16 -0700 Revert X86_64 JIT probe code for non DARWIN ports. 2021-09-02 07:24:42 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID https://bugs.webkit.org/show_bug.cgi?id=229618 P2 Normal --- 1 mark.lam mark.lam dpino ews-watchlist keith_miller msaboff saam tzagallo ysuzuki oldest_to_newest 1789625 0 mark.lam 2021-09-02 01:27:16 -0700 This is to address https://bugs.webkit.org/show_bug.cgi?id=229618#c10. 1789630 1 437125 mark.lam 2021-09-02 01:34:41 -0700 Created attachment 437125 proposed patch. 1789631 2 dpino 2021-09-02 01:44:13 -0700 Thanks for the patch! I'm going to give it a try on Ubuntu 18.04. 1789633 3 ysuzuki 2021-09-02 01:47:42 -0700 I tried landing a speculative change. https://github.com/WebKit/WebKit/commit/ed75252f8730bd3006fe76456f427e9b307c43ba @Diago Can you change the buildbot to generate more error messages from ld? 1789649 4 dpino 2021-09-02 03:12:31 -0700 I tested Mark's patch on Ubuntu 18.04 and it built fine. After that, I reverted the patch and tested the speculative main with the speculative fix. It built too. I've triggered a clean build in the bot and I've also increased the verbosity of ld.gold. 1789650 5 dpino 2021-09-02 03:25:15 -0700 Link to the Ubuntu 18.04 build including the speculative fix https://build.webkit.org/#/builders/71/builds/224 1789654 6 dpino 2021-09-02 03:40:58 -0700 There's currently an issue in the bot (it's failing on "jhbuild" step). I stopped the bot temporarily and I'm building manually. 1789697 7 dpino 2021-09-02 07:13:32 -0700 I confirm Yusuke's patch fixes compilation in Ubuntu 18.04, so this patch is not actually needed. Thank you Mark anyway. 437125 2021-09-02 01:34:41 -0700 2021-09-02 07:24:20 -0700 proposed patch. bug-229794.patch text/plain 4952 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjgxOTExKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDIxLTA5LTAyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZXZlcnQgWDg2XzY0IEpJVCBwcm9iZSBjb2RlIGZvciBub24gREFSV0lOIHBvcnRzLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5Nzk0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXBwYXJlbnRseSwgc29t ZSBsaW51eCBwb3J0cyBhcmVuJ3QgY29uZmlndXJlZCB0byBzdXBwb3J0IGRpcmVjdCBicmFuY2hl cyBmcm9tCisgICAgICAgIGlubGluZSBhc20gY29kZS4KKworICAgICAgICAqIGFzc2VtYmxlci9N YWNyb0Fzc2VtYmxlclg4NkNvbW1vbi5jcHA6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVy Ojpwcm9iZSk6CisKIDIwMjEtMDktMDIgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNv bT4KIAogICAgICAgICBVbnJldmlld2VkLCBhbm5vdGF0ZSBleGVjdXRlSlNDSklUUHJvYmUgd2l0 aCBSRUZFUkVOQ0VEX0ZST01fQVNNIFdURl9JTlRFUk5BTApJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclg4NkNvbW1vbi5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclg4NkNvbW1v bi5jcHAJKHJldmlzaW9uIDI4MTkxMSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJs ZXIvTWFjcm9Bc3NlbWJsZXJYODZDb21tb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDUsNyAr MTA1LDcgQEAgSlNDX0FOTk9UQVRFX0pJVF9PUEVSQVRJT05fUFJPQkUoY3RpTWFzbQogI2RlZmlu ZSBQUk9CRV9TSVpFIChQUk9CRV9DUFVfWE1NMTVfT0ZGU0VUICsgWE1NX1NJWkUpCiAjZW5kaWYg Ly8gQ1BVKFg4Nl82NCkKIAotI2lmIENPTVBJTEVSKE1TVkMpIHx8IENQVShYODYpCisjaWYgIU9T KERBUldJTikKICNkZWZpbmUgUFJPQkVfRVhFQ1VUT1JfT0ZGU0VUIFBST0JFX1NJWkUgLy8gU3Rh c2ggdGhlIGV4ZWN1dGVKU0NKSVRQcm9iZSBmdW5jdGlvbiBwb2ludGVyIGF0IHRoZSBlbmQgb2Yg dGhlIFByb2JlQ29udGV4dC4KICNlbmRpZgogCkBAIC0xNjcsNyArMTY3LDcgQEAgc3RhdGljX2Fz c2VydChQUk9CRV9PRkZTRVRPRl9SRUcoY3B1LmZwcgogI2VuZGlmIC8vIENQVShYODZfNjQpCiAK IHN0YXRpY19hc3NlcnQoc2l6ZW9mKFByb2JlOjpTdGF0ZSkgPT0gUFJPQkVfU0laRSwgIlByb2Jl OjpTdGF0ZTo6c2l6ZSdzIG1hdGNoZXMgY3RpTWFzbVByb2JlVHJhbXBvbGluZSIpOwotI2lmIENP TVBJTEVSKE1TVkMpIHx8IENQVShYODYpCisjaWYgIU9TKERBUldJTikKIHN0YXRpY19hc3NlcnQo KFBST0JFX0VYRUNVVE9SX09GRlNFVCArIFBUUl9TSVpFKSA8PSAoUFJPQkVfU0laRSArIE9VVF9T SVpFKSwgIk11c3QgaGF2ZSByb29tIGFmdGVyIFByb2JlQ29udGV4dCB0byBzdGFzaCB0aGUgcHJv YmUgaGFuZGxlciIpOwogI2VuZGlmCiAKQEAgLTUzMiw5ICs1MzIsMTMgQEAgYXNtICgKICAgICAv LyAgICAgcmJwWzEgKiBwdHJTaXplXTogcmV0dXJuIGFkZHJlc3MgLyBzYXZlZCByaXAKICAgICAv LyAgICAgcmJwWzIgKiBwdHJTaXplXTogc2F2ZWQgcmJ4CiAgICAgLy8gICAgIHJicFszICogcHRy U2l6ZV06IHNhdmVkIHJkeAotICAgIC8vICAgICByYnBbNCAqIHB0clNpemVdOiBzYXZlZCByYXgK KyAgICAvLyAgICAgcmJwWzQgKiBwdHJTaXplXTogc2F2ZWQgcmF4IGlmIE9TKERBUldJTikKKyAg ICAvLworICAgIC8vICAgICByYnBbNCAqIHB0clNpemVdOiBzYXZlZCByY3ggaWYgIU9TKERBUldJ TikKKyAgICAvLyAgICAgcmJwWzUgKiBwdHJTaXplXTogc2F2ZWQgcmF4IGlmICFPUyhEQVJXSU4p CiAgICAgLy8KICAgICAvLyBJbmNvbWluZyByZWdpc3RlcnMgY29udGFpbjoKKyAgICAvLyAgICAg cmN4OiBQcm9iZTo6ZXhlY3V0ZVByb2JlIGlmICFPUyhEQVJXSU4pCiAgICAgLy8gICAgIHJkeDog cHJvYmUgZnVuY3Rpb24KICAgICAvLyAgICAgcmJ4OiBwcm9iZSBhcmcKICAgICAvLyAgICAgcmF4 OiBzY3JhdGNoICh3YXMgY3RpTWFzbVByb2JlVHJhbXBvbGluZSkKQEAgLTU0NSwxMyArNTQ5LDE2 IEBAIGFzbSAoCiAgICAgImFuZHEgJH4weDFmLCAlcnNwIiAiXG4iCiAgICAgLy8gU2luY2Ugc3Ag cG9pbnRzIHRvIHRoZSBQcm9iZTo6U3RhdGUsIHdlJ3ZlIGVuc3VyZWQgdGhhdCBpdCdzIHByb3Rl Y3RlZCBmcm9tIGludGVycnVwdHMgYmVmb3JlIHdlIGluaXRpYWxpemUgaXQuCiAKKyNpZiBPUyhE QVJXSU4pCisgICAgIm1vdnEgJXJjeCwgIiBTVFJJTkdJWkVfVkFMVUVfT0YoUFJPQkVfQ1BVX0VD WF9PRkZTRVQpICIoJXJzcCkiICJcbiIKKyNlbHNlCisgICAgIm1vdnEgJXJjeCwgIiBTVFJJTkdJ WkVfVkFMVUVfT0YoUFJPQkVfRVhFQ1VUT1JfT0ZGU0VUKSAiKCVyc3ApIiAiXG4iCisjZW5kaWYK ICAgICAibW92cSAlcmR4LCAiIFNUUklOR0laRV9WQUxVRV9PRihQUk9CRV9QUk9CRV9GVU5DVElP Tl9PRkZTRVQpICIoJXJzcCkiICJcbiIKICAgICAibW92cSAlcmJ4LCAiIFNUUklOR0laRV9WQUxV RV9PRihQUk9CRV9BUkdfT0ZGU0VUKSAiKCVyc3ApIiAiXG4iCiAgICAgIm1vdnEgJXJzaSwgIiBT VFJJTkdJWkVfVkFMVUVfT0YoUFJPQkVfQ1BVX0VTSV9PRkZTRVQpICIoJXJzcCkiICJcbiIKICAg ICAibW92cSAlcmRpLCAiIFNUUklOR0laRV9WQUxVRV9PRihQUk9CRV9DUFVfRURJX09GRlNFVCkg IiglcnNwKSIgIlxuIgogCi0gICAgIm1vdnEgJXJjeCwgIiBTVFJJTkdJWkVfVkFMVUVfT0YoUFJP QkVfQ1BVX0VDWF9PRkZTRVQpICIoJXJzcCkiICJcbiIKLQogICAgICJtb3ZxIC0xICogIiBTVFJJ TkdJWkVfVkFMVUVfT0YoUFRSX1NJWkUpICIoJXJicCksICVyY3giICJcbiIKICAgICAibW92cSAl cmN4LCAiIFNUUklOR0laRV9WQUxVRV9PRihQUk9CRV9DUFVfRUZMQUdTX09GRlNFVCkgIiglcnNw KSIgIlxuIgogICAgICJtb3ZxIDAgKiAiIFNUUklOR0laRV9WQUxVRV9PRihQVFJfU0laRSkgIigl cmJwKSwgJXJjeCIgIlxuIgpAQCAtNTYzLDYgKzU3MCwxMCBAQCBhc20gKAogICAgICJtb3ZxIDMg KiAiIFNUUklOR0laRV9WQUxVRV9PRihQVFJfU0laRSkgIiglcmJwKSwgJXJjeCIgIlxuIgogICAg ICJtb3ZxICVyY3gsICIgU1RSSU5HSVpFX1ZBTFVFX09GKFBST0JFX0NQVV9FRFhfT0ZGU0VUKSAi KCVyc3ApIiAiXG4iCiAgICAgIm1vdnEgNCAqICIgU1RSSU5HSVpFX1ZBTFVFX09GKFBUUl9TSVpF KSAiKCVyYnApLCAlcmN4IiAiXG4iCisjaWYgIU9TKERBUldJTikKKyAgICAibW92cSAlcmN4LCAi IFNUUklOR0laRV9WQUxVRV9PRihQUk9CRV9DUFVfRUNYX09GRlNFVCkgIiglcnNwKSIgIlxuIgor ICAgICJtb3ZxIDUgKiAiIFNUUklOR0laRV9WQUxVRV9PRihQVFJfU0laRSkgIiglcmJwKSwgJXJj eCIgIlxuIgorI2VuZGlmCiAgICAgIm1vdnEgJXJjeCwgIiBTVFJJTkdJWkVfVkFMVUVfT0YoUFJP QkVfQ1BVX0VBWF9PRkZTRVQpICIoJXJzcCkiICJcbiIKIAogICAgICJtb3ZxICVyYnAsICVyY3gi ICJcbiIKQEAgLTU5Niw3ICs2MDcsMTEgQEAgYXNtICgKICAgICAibW92cSAleG1tMTUsICIgU1RS SU5HSVpFX1ZBTFVFX09GKFBST0JFX0NQVV9YTU0xNV9PRkZTRVQpICIoJXJzcCkiICJcbiIKIAog ICAgICJtb3ZxICVyc3AsICVyZGkiICJcbiIgLy8gdGhlIFByb2JlOjpTdGF0ZSogYXJnLgorI2lm IE9TKERBUldJTikKICAgICAiY2FsbCAiIFNZTUJPTF9TVFJJTkcoZXhlY3V0ZUpTQ0pJVFByb2Jl KSAiXG4iCisjZWxzZQorICAgICJjYWxsICoiIFNUUklOR0laRV9WQUxVRV9PRihQUk9CRV9FWEVD VVRPUl9PRkZTRVQpICIoJXJzcCkiICJcbiIKKyNlbmRpZgogCiAgICAgLy8gTWFrZSBzdXJlIHRo ZSBQcm9iZTo6U3RhdGUgaXMgZW50aXJlbHkgYmVsb3cgdGhlIHJlc3VsdCBzdGFjayBwb2ludGVy IHNvCiAgICAgLy8gdGhhdCByZWdpc3RlciB2YWx1ZXMgYXJlIHN0aWxsIHByZXNlcnZlZCB3aGVu IHdlIGNhbGwgdGhlIGluaXRpYWxpemVTdGFjawpAQCAtNzUyLDE0ICs3NjcsMTQgQEAgYXNtICgK IAogdm9pZCBNYWNyb0Fzc2VtYmxlcjo6cHJvYmUoUHJvYmU6OkZ1bmN0aW9uIGZ1bmN0aW9uLCB2 b2lkKiBhcmcpCiB7Ci0jaWYgQ1BVKFg4Nl82NCkgJiYgQ09NUElMRVIoR0NDX0NPTVBBVElCTEUp CisjaWYgT1MoREFSV0lOKQogICAgIC8vIEV4dHJhIHB1c2ggc28gdGhhdCB0aGUgdG90YWwgbnVt YmVyIG9mIHB1c2hlcyBwYWQgb3V0IHRvIDMyLWJ5dGVzLCBhbmQgdGhlCiAgICAgLy8gc3RhY2sg cG9pbnRlciByZW1haW5zIDMyIGJ5dGUgYWxpZ25lZCBhcyByZXF1aXJlZCBieSB0aGUgQUJJLgog ICAgIHB1c2goUmVnaXN0ZXJJRDo6ZWF4KTsKICNlbmRpZgogICAgIHB1c2goUmVnaXN0ZXJJRDo6 ZWF4KTsKICAgICBtb3ZlKFRydXN0ZWRJbW1QdHIocmVpbnRlcnByZXRfY2FzdDx2b2lkKj4oY3Rp TWFzbVByb2JlVHJhbXBvbGluZSkpLCBSZWdpc3RlcklEOjplYXgpOwotI2lmIENPTVBJTEVSKE1T VkMpIHx8IENQVShYODYpCisjaWYgIU9TKERBUldJTikKICAgICBwdXNoKFJlZ2lzdGVySUQ6OmVj eCk7CiAgICAgbW92ZShUcnVzdGVkSW1tUHRyKHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCo+KFByb2Jl OjpleGVjdXRlSlNDSklUUHJvYmUpKSwgUmVnaXN0ZXJJRDo6ZWN4KTsKICNlbmRpZgo=