229781 2021-09-01 17:11:27 -0700 Leak of VTImageRotationSessionRef (176 bytes) in com.apple.WebKit.GPU.Development process 2021-09-02 13:31:40 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 229265 1 ddkilzer ddkilzer darin eric.carlson jer.noble peng.liu6 webkit-bug-importer oldest_to_newest 1789542 0 ddkilzer 2021-09-01 17:11:27 -0700 Leak of VTImageRotationSessionRef (176 bytes) in com.apple.WebKit.GPU.Development process. STACK OF 1 INSTANCE OF 'ROOT LEAK: <VTImageRotationSession>': 21 com.apple.WebKit.GPU.Development 0x102b79000 0x102b79000 + 0 19 dyld 0x10902d4d5 start + 421 18 WebKit 0x104f6ca30 WebKit::XPCServiceMain(int, char const**) + 137 XPCServiceMain.mm:243 17 libxpc.dylib 0x7ff80766dc22 xpc_main + 99 16 libxpc.dylib 0x7ff80766e233 _xpc_objc_main + 825 15 com.apple.Foundation 0x7ff8087f6a03 -[NSRunLoop(NSRunLoop) run] + 76 14 com.apple.Foundation 0x7ff80876c66e -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 216 13 com.apple.CoreFoundation 0x7ff8079e1dd9 CFRunLoopRunSpecific + 567 12 com.apple.CoreFoundation 0x7ff8079e282f __CFRunLoopRun + 897 11 com.apple.CoreFoundation 0x7ff8079e3e13 __CFRunLoopDoSources0 + 242 10 com.apple.CoreFoundation 0x7ff8079e40a0 __CFRunLoopDoSource0 + 180 9 com.apple.CoreFoundation 0x7ff8079e4138 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 8 JavaScriptCore 0x10adcc1c2 WTF::RunLoop::performWork(void*) + 34 RunLoopCF.cpp:47 7 JavaScriptCore 0x10adcb8ef WTF::RunLoop::performWork() + 431 RunLoop.cpp:134 6 WebCore 0x10da46a54 WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged() + 1476 MediaPlayerPrivateAVFoundationObjC.mm:2108 5 WebCore 0x10da48aa5 WebCore::MediaPlayerPrivateAVFoundationObjC::updateRotationSession() + 773 MediaPlayerPrivateAVFoundationObjC.mm:2200 4 WebCore 0x10d9e5bc0 WebCore::ImageRotationSessionVT::ImageRotationSessionVT(WebCore::AffineTransform&&, WebCore::FloatSize, WebCore::ImageRotationSessionVT::IsCGImageCompatible) + 128 ImageRotationSessionVT.mm:0 3 WebCore 0x10d9e5d2c WebCore::ImageRotationSessionVT::initialize(WebCore::ImageRotationSessionVT::RotationProperties const&, WebCore::FloatSize, WebCore::ImageRotationSessionVT::IsCGImageCompatible) + 236 ImageRotationSessionVT.mm:86 2 com.apple.VideoToolbox 0x7ff8142f4930 VTImageRotationSessionCreate + 143 1 com.apple.CoreFoundation 0x7ff807967d90 _CFRuntimeCreateInstance + 580 0 libsystem_malloc.dylib 0x7ff807757d52 _malloc_zone_malloc + 249 ==== 2 (176 bytes) ROOT LEAK: <VTImageRotationSession 0x7fdbbe949ca0> [144] 1 (32 bytes) <NSMutableDictionary 0x7fdbbe9415c0> [32] 1789543 1 ddkilzer 2021-09-01 17:11:43 -0700 <rdar://problem/82651897> 1789544 2 ddkilzer 2021-09-01 17:13:40 -0700 Missing an adoptCF() in Source/WebCore/platform/graphics/cv/ImageRotationSessionVT.mm: VTImageRotationSessionRef rawRotationSession = nullptr; VTImageRotationSessionCreate(kCFAllocatorDefault, m_rotationProperties.angle, &rawRotationSession); m_rotationSession = rawRotationSession; 1789546 3 437089 ddkilzer 2021-09-01 17:16:38 -0700 Created attachment 437089 Patch v1 1789806 4 ddkilzer 2021-09-02 11:37:48 -0700 The mac-debug-wk1 failures are not related to this patch. See: <https://trac.webkit.org/changeset/281934/webkit> 1789865 5 ews-feeder 2021-09-02 13:31:38 -0700 Committed r281950 (241257@main): <https://commits.webkit.org/241257@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437089. 437089 2021-09-01 17:16:38 -0700 2021-09-02 13:31:39 -0700 Patch v1 bug-229781-20210901171638.patch text/plain 1731 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxNzM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmY4MGFmZWU1NTE5M2Rl NzhkODc4MzQ3ODQ2NTYzOTQ0M2E0OTE3ZS4uZWE0NDVhYjM1ZTg2YmNlNTJiYmIwZTUzYWZlNTE1 ODk0N2U3YWZmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTA5LTAxICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgTGVhayBvZiBWVEltYWdl Um90YXRpb25TZXNzaW9uUmVmICgxNzYgYnl0ZXMpIGluIGNvbS5hcHBsZS5XZWJLaXQuR1BVLkRl dmVsb3BtZW50IHByb2Nlc3MKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzIyOTc4MT4K KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzgyNjUxODk3PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY3YvSW1hZ2VS b3RhdGlvblNlc3Npb25WVC5tbToKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlUm90YXRpb25TZXNz aW9uVlQ6OmluaXRpYWxpemUpOgorICAgICAgICAtIEFkZCBtaXNzaW5nIGFkb3B0Q0YoKSB0byBm aXggdGhlIGxlYWsuCisKIDIwMjEtMDgtMjggIEFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29t PgogCiAgICAgICAgIFtMRkNdW0lGQ10gTW92ZSBjb250ZW50IGJ1aWxkZXIgZnVuY3Rpb25hbGl0 eSB0byBhIGRlZGljYXRlZCBjbGFzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY3YvSW1hZ2VSb3RhdGlvblNlc3Npb25WVC5tbSBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2N2L0ltYWdlUm90YXRpb25TZXNzaW9uVlQubW0KaW5kZXggOTBm MzFjMGFkNjlhOThlZDY3NjNmODQxMWUwOWVjMjYzODIwY2ZiZi4uYWNjYmIwYjFhZTJlMzUwMTg4 MTVlMzk2MWNjZGU3MTYzNDRhOGU2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY3YvSW1hZ2VSb3RhdGlvblNlc3Npb25WVC5tbQorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jdi9JbWFnZVJvdGF0aW9uU2Vzc2lvblZULm1tCkBAIC04 Myw3ICs4Myw3IEBAIHZvaWQgSW1hZ2VSb3RhdGlvblNlc3Npb25WVDo6aW5pdGlhbGl6ZShjb25z dCBSb3RhdGlvblByb3BlcnRpZXMmIHJvdGF0aW9uLCBGbG9hCiAKICAgICBWVEltYWdlUm90YXRp b25TZXNzaW9uUmVmIHJhd1JvdGF0aW9uU2Vzc2lvbiA9IG51bGxwdHI7CiAgICAgVlRJbWFnZVJv dGF0aW9uU2Vzc2lvbkNyZWF0ZShrQ0ZBbGxvY2F0b3JEZWZhdWx0LCBtX3JvdGF0aW9uUHJvcGVy dGllcy5hbmdsZSwgJnJhd1JvdGF0aW9uU2Vzc2lvbik7Ci0gICAgbV9yb3RhdGlvblNlc3Npb24g PSByYXdSb3RhdGlvblNlc3Npb247CisgICAgbV9yb3RhdGlvblNlc3Npb24gPSBhZG9wdENGKHJh d1JvdGF0aW9uU2Vzc2lvbik7CiAgICAgVlRJbWFnZVJvdGF0aW9uU2Vzc2lvblNldFByb3BlcnR5 KG1fcm90YXRpb25TZXNzaW9uLmdldCgpLCBrVlRJbWFnZVJvdGF0aW9uUHJvcGVydHlLZXlfRW5h YmxlSGlnaFNwZWVkVHJhbnNmZXIsIGtDRkJvb2xlYW5UcnVlKTsKIAogICAgIGlmIChtX3JvdGF0 aW9uUHJvcGVydGllcy5mbGlwWSkK