22978 2008-12-23 08:51:10 -0800 a couple tweaks to the new strokeBoundingRect functions 2008-12-23 09:23:29 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P3 Minor --- 1 darin darin oldest_to_newest 103300 0 darin 2008-12-23 08:51:10 -0800 I made a tweak or two to the new functions. 103301 1 26227 darin 2008-12-23 08:54:02 -0800 Created attachment 26227 patch 103304 2 darin 2008-12-23 09:23:29 -0800 http://trac.webkit.org/changeset/39451 26227 2008-12-23 08:54:02 -0800 2008-12-23 09:12:50 -0800 patch StrokePatch.txt text/plain 4491 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzOTQ1MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjQgQEAKKzIwMDgtMTItMjMgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyOTc4CisgICAgICAgICAgYSBj b3VwbGUgdHdlYWtzIHRvIHRoZSBuZXcgc3Ryb2tlQm91bmRpbmdSZWN0IGZ1bmN0aW9ucworCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vUGF0aENhaXJvLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlBhdGg6OnN0cm9rZUJvdW5kaW5nUmVjdCk6IE9ubHkgY3JlYXRlIGEgR3JhcGhp Y3NDb250ZXh0CisgICAgICAgIGlmIHRoZSBhcHBsaWVyIGlzIG5vbi1udWxsLgorCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvY2cvUGF0aENHLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnB1 dEJ5dGVzTm93aGVyZSk6IEFkZGVkLgorICAgICAgICAoV2ViQ29yZTo6Y3JlYXRlU2NyYXRjaENv bnRleHQpOiBDaGFuZ2VkIHRvIHVzZSBhICIvZGV2L251bGwiIHR5cGUKKyAgICAgICAgZnVuY3Rp b24gdG8gZGlzY2FyZCBieXRlcyByYXRoZXIgdGhhbiB1c2luZyBhIGRhdGEgb2JqZWN0LiBUaGlz CisgICAgICAgIGVsaW1pbmF0ZXMgdGhlIHBvc3NpYmlsaXR5IHRoYXQgbWVtb3J5IHdpbGwgYmUg dXNlZCBpZiBzb21lb25lIGRyYXdzCisgICAgICAgIGludG8gdGhlIHNjcmF0Y2ggY29udGV4dCBi eSBhY2NpZGVudC4gQWxzbyBtb3ZlZCB0byB0aGUgdG9wIG9mIHRoZQorICAgICAgICBmaWxlOyBp dCB3YXMgaW4gYSBzbGlnaHRseSBzdHJhbmdlIHBsYWNlIGJlZm9yZS4KKyAgICAgICAgKFdlYkNv cmU6OlBhdGg6OnN0cm9rZUJvdW5kaW5nUmVjdCk6IE9ubHkgY3JlYXRlIGEgR3JhcGhpY3NDb250 ZXh0CisgICAgICAgIGlmIHRoZSBhcHBsaWVyIGlzIG5vbi1udWxsLiBTaW1wbGlmeSB0aGUgZW1w dHkgcGF0aCBzcGVjaWFsIGNhc2UuCisKIDIwMDgtMTItMjIgIFNhbSBXZWluaWcgIDxzYW1Ad2Vi a2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJrIFJvd2UuCkluZGV4OiBXZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL1BhdGhDYWlyby5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9QYXRoQ2Fpcm8uY3BwCShyZXZpc2lvbiAzOTQ0 OSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vUGF0aENhaXJvLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTkzLDkgKzE5MywxMCBAQCBGbG9hdFJlY3QgUGF0aDo6Ym91bmRpbmdS ZWN0KCkgY29uc3QKIEZsb2F0UmVjdCBQYXRoOjpzdHJva2VCb3VuZGluZ1JlY3QoU3Ryb2tlU3R5 bGVBcHBsaWVyKiBhcHBsaWVyKQogewogICAgIGNhaXJvX3QqIGNyID0gcGxhdGZvcm1QYXRoKCkt Pm1fY3I7Ci0gICAgR3JhcGhpY3NDb250ZXh0IGdjKGNyKTsKLSAgICBpZiAoYXBwbGllcikKKyAg ICBpZiAoYXBwbGllcikgeworICAgICAgICBHcmFwaGljc0NvbnRleHQgZ2MoY3IpOwogICAgICAg ICBhcHBsaWVyLT5zdHJva2VTdHlsZSgmZ2MpOworICAgIH0KIAogICAgIGRvdWJsZSB4MCwgeDEs IHkwLCB5MTsKICAgICBjYWlyb19zdHJva2VfZXh0ZW50cyhjciwgJngwLCAmeTAsICZ4MSwgJnkx KTsKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvUGF0aENHLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL1BhdGhDRy5jcHAJKHJldmlzaW9u IDM5NDQ5KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9QYXRoQ0cuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC00MSw2ICs0MSwzMSBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKK3N0 YXRpYyBzaXplX3QgcHV0Qnl0ZXNOb3doZXJlKHZvaWQqLCBjb25zdCB2b2lkKiwgc2l6ZV90IGNv dW50KQoreworICAgIHJldHVybiBjb3VudDsKK30KKworc3RhdGljIENHQ29udGV4dFJlZiBjcmVh dGVTY3JhdGNoQ29udGV4dCgpCit7CisgICAgQ0dEYXRhQ29uc3VtZXJDYWxsYmFja3MgY2FsbGJh Y2tzID0geyBwdXRCeXRlc05vd2hlcmUsIDAgfTsKKyAgICBDR0RhdGFDb25zdW1lclJlZiBjb25z dW1lciA9IENHRGF0YUNvbnN1bWVyQ3JlYXRlKDAsICZjYWxsYmFja3MpOworICAgIENHQ29udGV4 dFJlZiBjb250ZXh0ID0gQ0dQREZDb250ZXh0Q3JlYXRlKGNvbnN1bWVyLCAwLCAwKTsKKyAgICBD R0RhdGFDb25zdW1lclJlbGVhc2UoY29uc3VtZXIpOworCisgICAgQ0dGbG9hdCBibGFja1s0XSA9 IHsgMCwgMCwgMCwgMSB9OworICAgIENHQ29udGV4dFNldEZpbGxDb2xvcihjb250ZXh0LCBibGFj ayk7CisgICAgQ0dDb250ZXh0U2V0U3Ryb2tlQ29sb3IoY29udGV4dCwgYmxhY2spOworCisgICAg cmV0dXJuIGNvbnRleHQ7Cit9CisKK3N0YXRpYyBpbmxpbmUgQ0dDb250ZXh0UmVmIHNjcmF0Y2hD b250ZXh0KCkKK3sKKyAgICBzdGF0aWMgQ0dDb250ZXh0UmVmIGNvbnRleHQgPSBjcmVhdGVTY3Jh dGNoQ29udGV4dCgpOworICAgIHJldHVybiBjb250ZXh0OworfQorCiBQYXRoOjpQYXRoKCkKICAg ICA6IG1fcGF0aChDR1BhdGhDcmVhdGVNdXRhYmxlKCkpCiB7CkBAIC02NCwyNiArODksNiBAQCBQ YXRoJiBQYXRoOjpvcGVyYXRvcj0oY29uc3QgUGF0aCYgb3RoZXIpCiAgICAgcmV0dXJuICp0aGlz OwogfQogCi1zdGF0aWMgQ0dDb250ZXh0UmVmIGNyZWF0ZVNjcmF0Y2hDb250ZXh0KCkKLXsKLSAg ICBDRk11dGFibGVEYXRhUmVmIGVtcHR5ID0gQ0ZEYXRhQ3JlYXRlTXV0YWJsZShOVUxMLCAwKTsK LSAgICBDR0RhdGFDb25zdW1lclJlZiBjb25zdW1lciA9IENHRGF0YUNvbnN1bWVyQ3JlYXRlV2l0 aENGRGF0YShlbXB0eSk7Ci0gICAgQ0dDb250ZXh0UmVmIGNvbnRleHRSZWYgPSBDR1BERkNvbnRl eHRDcmVhdGUoY29uc3VtZXIsIE5VTEwsIE5VTEwpOwotICAgIENHRGF0YUNvbnN1bWVyUmVsZWFz ZShjb25zdW1lcik7Ci0gICAgQ0ZSZWxlYXNlKGVtcHR5KTsKLQotICAgIENHRmxvYXQgYmxhY2tb NF0gPSB7MCwgMCwgMCwgMX07Ci0gICAgQ0dDb250ZXh0U2V0RmlsbENvbG9yKGNvbnRleHRSZWYs IGJsYWNrKTsKLSAgICBDR0NvbnRleHRTZXRTdHJva2VDb2xvcihjb250ZXh0UmVmLCBibGFjayk7 Ci0gICAgcmV0dXJuIGNvbnRleHRSZWY7Ci19Ci0KLXN0YXRpYyBpbmxpbmUgQ0dDb250ZXh0UmVm IHNjcmF0Y2hDb250ZXh0KCkKLXsKLSAgICBzdGF0aWMgQ0dDb250ZXh0UmVmIGNvbnRleHQgPSBj cmVhdGVTY3JhdGNoQ29udGV4dCgpOwotICAgIHJldHVybiBjb250ZXh0OwotfQotCiBzdGF0aWMg dm9pZCBjb3B5Q2xvc2luZ1N1YnBhdGhzQXBwbGllckZ1bmN0aW9uKHZvaWQqIGluZm8sIGNvbnN0 IENHUGF0aEVsZW1lbnQqIGVsZW1lbnQpCiB7CiAgICAgQ0dNdXRhYmxlUGF0aFJlZiBwYXRoID0g c3RhdGljX2Nhc3Q8Q0dNdXRhYmxlUGF0aFJlZj4oaW5mbyk7CkBAIC0xNTIsMTYgKzE1NywxMyBA QCBGbG9hdFJlY3QgUGF0aDo6c3Ryb2tlQm91bmRpbmdSZWN0KFN0cm9rCiAgICAgQ0dDb250ZXh0 QmVnaW5QYXRoKGNvbnRleHQpOwogICAgIENHQ29udGV4dEFkZFBhdGgoY29udGV4dCwgcGxhdGZv cm1QYXRoKCkpOwogCi0gICAgR3JhcGhpY3NDb250ZXh0IGdjKGNvbnRleHQpOwotICAgIGlmIChh cHBsaWVyKQotICAgICAgICBhcHBsaWVyLT5zdHJva2VTdHlsZSgmZ2MpOworICAgIGlmIChhcHBs aWVyKSB7CisgICAgICAgIEdyYXBoaWNzQ29udGV4dCBncmFwaGljc0NvbnRleHQoY29udGV4dCk7 CisgICAgICAgIGFwcGxpZXItPnN0cm9rZVN0eWxlKCZncmFwaGljc0NvbnRleHQpOworICAgIH0K IAogICAgIENHQ29udGV4dFJlcGxhY2VQYXRoV2l0aFN0cm9rZWRQYXRoKGNvbnRleHQpOwotICAg IGlmIChDR0NvbnRleHRJc1BhdGhFbXB0eShjb250ZXh0KSkgewotICAgICAgICBDR0NvbnRleHRS ZXN0b3JlR1N0YXRlKGNvbnRleHQpOwotICAgICAgICByZXR1cm4gRmxvYXRSZWN0KCk7Ci0gICAg fQotICAgIENHUmVjdCBib3ggPSBDR0NvbnRleHRHZXRQYXRoQm91bmRpbmdCb3goY29udGV4dCk7 CisgICAgQ0dSZWN0IGJveCA9IENHQ29udGV4dElzUGF0aEVtcHR5KGNvbnRleHQpID8gQ0dSZWN0 WmVybyA6IENHQ29udGV4dEdldFBhdGhCb3VuZGluZ0JveChjb250ZXh0KTsKICAgICBDR0NvbnRl eHRSZXN0b3JlR1N0YXRlKGNvbnRleHQpOwogCiAgICAgcmV0dXJuIGJveDsK