22977 2008-12-23 08:15:53 -0800 New layout test to verify that local vars take precedence in form event handlers 2008-12-29 11:22:55 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED P3 Minor --- 1 gwilson pam pam oldest_to_newest 103294 0 gwilson 2008-12-23 08:15:53 -0800 Adding new test to verify that using a locally-scoped variable in a form event handler takes precedence in evaluation over items (form elements) of that form. Meaning, if a variable with a name of "value" is declared in an event handler of a form element, referring to "value" in that event handler will refer to the variable and not the value of the element. Fortunately, I could not find any bugs that show WebKit ever had this behavior, so I did not link any. Let me know if there's a corresponding bug here. 103295 1 26225 gwilson 2008-12-23 08:17:00 -0800 Created attachment 26225 New layout test Here is the test for this case. 103297 2 26225 darin 2008-12-23 08:29:19 -0800 Comment on attachment 26225 New layout test Looks fine. r=me 103712 3 pam 2008-12-29 10:43:28 -0800 Will land. 103714 4 pam 2008-12-29 11:22:55 -0800 Removed svn:executable property and landed as r39499. 26225 2008-12-23 08:17:00 -0800 2008-12-23 08:29:19 -0800 New layout test patchLayoutTest1.txt text/plain 2550 gwilson SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDM5NDQwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDgtMTItMjIgIEdsZW5uIFdpbHNvbiAgPGd3 aWxzb25AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEFkZGVkIG5ldyBsYXlvdXQgdGVzdHMgdmVyaWZ5aW5nIHRoYXQgdXNpbmcg YSBsb2NhbGx5LXNjb3BlZAorICAgICAgICB2YXJpYWJsZSBpbiBhbiBldmVudCBoYW5kbGVyIG9m IGEgZm9ybSB0YWtlcyBwcmVjZWRlbmNlIG92ZXIKKyAgICAgICAgbmFtZXMgb2YgaXRlbXMgaW4g dGhhdCBmb3JtLgorCisgICAgICAgIFNlZTogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIyOTc3CisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL3Zhci1uYW1lLWNvbmZsaWN0 LWluLWZvcm0tZXZlbnQtaGFuZGxlci1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZh c3QvZm9ybXMvdmFyLW5hbWUtY29uZmxpY3QtaW4tZm9ybS1ldmVudC1oYW5kbGVyLmh0bWw6IEFk ZGVkLgorCiAyMDA4LTEyLTIyICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAd2Via2l0Lm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IExheW91dFRlc3RzL2Zh c3QvZm9ybXMvdmFyLW5hbWUtY29uZmxpY3QtaW4tZm9ybS1ldmVudC1oYW5kbGVyLWV4cGVjdGVk LnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3Zhci1uYW1lLWNvbmZs aWN0LWluLWZvcm0tZXZlbnQtaGFuZGxlci1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBM YXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3Zhci1uYW1lLWNvbmZsaWN0LWluLWZvcm0tZXZlbnQtaGFu ZGxlci1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNCBAQAorVGhpcyB0ZXN0 cyB0aGF0IGEgbG9jYWxseSBzY29wZWQgdmFyaWFibGUgaW4gYW4gZXZlbnQgaGFuZGxlciBvZiBh IGZvcm0gdGFrZXMgcHJlY2VkZW5jZSBvdmVyIGl0ZW1zIG9mIGZvcm0uCisKKworVGhpcyB0ZXN0 OiBQQVNTRUQhCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3Zhci1uYW1lLWNvbmZsaWN0 LWluLWZvcm0tZXZlbnQtaGFuZGxlci5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zh c3QvZm9ybXMvdmFyLW5hbWUtY29uZmxpY3QtaW4tZm9ybS1ldmVudC1oYW5kbGVyLmh0bWwJKHJl dmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3Zhci1uYW1lLWNvbmZsaWN0LWlu LWZvcm0tZXZlbnQtaGFuZGxlci5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDI4IEBACis8 aHRtbD4KKzxib2R5PgorPHA+VGhpcyB0ZXN0cyB0aGF0IGEgbG9jYWxseSBzY29wZWQgdmFyaWFi bGUgaW4gYW4gZXZlbnQgaGFuZGxlciBvZiBhIGZvcm0KK3Rha2VzIHByZWNlZGVuY2Ugb3ZlciBp dGVtcyBvZiBmb3JtLgorCis8Zm9ybT4KKzxzZWxlY3Qgb25DaGFuZ2U9InZhciB2YWx1ZSA9IHRo aXMudmFsdWU7dGhpcy5vcHRpb25zWzBdLnNlbGVjdGVkPXRydWU7IGlmKHZhbHVlPT0nQycpIGRv Y3VtZW50LmdldEVsZW1lbnRCeUlkKCdzb3VyY2VWaWV3RGl2JykuaW5uZXJIVE1MPSdUaGlzIHRl c3Q6IFBBU1NFRCEnIj4KKzxvcHRpb24gdmFsdWU9IkEiPkE8L29wdGlvbj4KKzxvcHRpb24gdmFs dWU9IkIiPkI8L29wdGlvbj4KKzxvcHRpb24gdmFsdWU9IkMiPkM8L29wdGlvbj4KKzwvc2VsZWN0 PgorCis8ZGl2IGlkPSdzb3VyY2VWaWV3RGl2Jz5UaGlzIHRlc3Q6IEZBSUxFRDwvZGl2PgorCis8 c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgbGF5b3V0VGVzdENv bnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCit2YXIgeD1kb2N1bWVudC5nZXRFbGVtZW50c0J5VGFn TmFtZSgnc2VsZWN0JylbMF07Cit4Lm9wdGlvbnNbMl0uc2VsZWN0ZWQ9dHJ1ZTsKK3ZhciBldnQg PSBkb2N1bWVudC5jcmVhdGVFdmVudCgiSFRNTEV2ZW50cyIpOworZXZ0LmluaXRFdmVudCgiY2hh bmdlIiwgdHJ1ZSwgdHJ1ZSk7Cit4LmRpc3BhdGNoRXZlbnQoZXZ0KTsKKzwvc2NyaXB0PgorPC9m b3JtPgorCis8L2JvZHk+Cis8L2h0bWw+CgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBMYXlvdXRUZXN0 cy9mYXN0L2Zvcm1zL3Zhci1uYW1lLWNvbmZsaWN0LWluLWZvcm0tZXZlbnQtaGFuZGxlci5odG1s Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KQWRkZWQ6IHN2bjpleGVjdXRhYmxlCiAgICsgKgoK