229749 2021-08-31 20:54:50 -0700 [CoordinatedGraphics] Schedule rendering after setLayerTreeStateIsFrozen(false) in non-AC mode 2021-09-01 01:46:47 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified CLOSED FIXED InRadar P2 Normal --- 1 tomoki.imai tomoki.imai cgarcia cmarcelo don.olmstead ews-watchlist fujii gyuyoung.kim kkinnunen luiz ryuan.choi sergio webkit-bug-importer zdobersek zeno oldest_to_newest 1789211 0 tomoki.imai 2021-08-31 20:54:50 -0700 We should schedule another rendering when the setLayerTreeStateIsFrozen(false) is called in non-AC mode. In some rare cases, the browser only shows the white page after the page transition, because the rendering is skipped while the layer tree is frozen and there was no guarantee that there is another rendering after setLayerTreeStateIsFrozen(false). 1789212 1 436991 tomoki.imai 2021-08-31 20:57:51 -0700 Created attachment 436991 patch Patch to schedule rendering when setLayerTreeStateIsFrozen(false) is called. 1789217 2 fujii 2021-08-31 21:44:41 -0700 Do you have a test case? 1789228 3 436991 cgarcia 2021-08-31 23:44:49 -0700 Comment on attachment 436991 patch Wait, do we know for sure we are not in AC mode at that point? 1789229 4 436991 cgarcia 2021-08-31 23:46:20 -0700 Comment on attachment 436991 patch View in context: https://bugs.webkit.org/attachment.cgi?id=436991&action=review > Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:246 > + else > + scheduleDisplay(); I think we should only call this if m_layerTreeHost is nullptr 1789238 5 tomoki.imai 2021-09-01 00:36:41 -0700 (In reply to Fujii Hironori from comment #2) > Do you have a test case? Unfortunately no. On PlayStation, the issue is reproducible with the specific webpage (and sorry, I cannot paste url here..) but WinCairo/GTK cannot reproduce the issue even with the same page. I believe there is a chance where the GTK/WinCairo encounter the same issue, but it seems to depend on the timing. 1789243 6 437000 tomoki.imai 2021-09-01 00:45:20 -0700 Created attachment 437000 patch (In reply to Carlos Garcia Campos from comment #4) > Comment on attachment 436991 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=436991&action=review > > > Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:246 > > + else > > + scheduleDisplay(); > > I think we should only call this if m_layerTreeHost is nullptr Thanks for pointing! You're correct, I added "if (!m_layerTreeHost)" guard there. 1789255 7 ews-feeder 2021-09-01 01:32:21 -0700 tomoki.imai@sony.com does not have reviewer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/Tools/Scripts/webkitpy/common/config/contributors.json. Rejecting attachment 437000 from commit queue. 1789262 8 ews-feeder 2021-09-01 01:44:22 -0700 Committed r281841 (241174@main): <https://commits.webkit.org/241174@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437000. 1789263 9 webkit-bug-importer 2021-09-01 01:45:20 -0700 <rdar://problem/82617490> 1789264 10 tomoki.imai 2021-09-01 01:46:47 -0700 Thanks for your review and cq+! (Sorry, I should not have r+) 436991 2021-08-31 20:57:51 -0700 2021-09-01 00:45:20 -0700 patch add-rendering-after-unfrozen-1.patch text/plain 2057 tomoki.imai ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNWJmNzNhZDQ2YzI0Li42OTFhMGFmODEyNGMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMjAgQEAKKzIwMjEtMDgtMzEgIFRvbW9raSBJbWFpICA8VG9tb2tpLkltYWlAc29ueS5jb20+ CisKKyAgICAgICAgW0Nvb3JkaW5hdGVkR3JhcGhpY3NdIFNjaGVkdWxlIHJlbmRlcmluZyBhZnRl ciBzZXRMYXllclRyZWVTdGF0ZUlzRnJvemVuKGZhbHNlKSBpbiBub24tQUMgbW9kZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5NzQ5CisKKyAgICAg ICAgV2Ugc2hvdWxkIHNjaGVkdWxlIGFub3RoZXIgcmVuZGVyaW5nIHdoZW4gdGhlIHNldExheWVy VHJlZVN0YXRlSXNGcm96ZW4oZmFsc2UpIGlzIGNhbGxlZC4KKyAgICAgICAgSW4gc29tZSByYXJl IGNhc2VzLCB0aGUgYnJvd3NlciBvbmx5IHNob3dzIHRoZSB3aGl0ZSBwYWdlIGFmdGVyIHRoZSBw YWdlIHRyYW5zaXRpb24sCisgICAgICAgIGJlY2F1c2UgdGhlIHJlbmRlcmluZyBpcyBza2lwcGVk IHdoaWxlIHRoZSBsYXllciB0cmVlIGlzIGZyb3plbiBhbmQgdGhlcmUgd2FzIG5vIGd1YXJhbnRl ZSB0aGF0IHRoZXJlIGlzCisgICAgICAgIGFub3RoZXIgcmVuZGVyaW5nIGFmdGVyIHNldExheWVy VHJlZVN0YXRlSXNGcm96ZW4oZmFsc2UpLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRlc3RlZCBieSBtYW51YWwuCisKKyAgICAgICAgKiBXZWJQcm9j ZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9EcmF3aW5nQXJlYUNvb3JkaW5hdGVkR3Jh cGhpY3MuY3BwOgorICAgICAgICAoV2ViS2l0OjpEcmF3aW5nQXJlYUNvb3JkaW5hdGVkR3JhcGhp Y3M6OnNldExheWVyVHJlZVN0YXRlSXNGcm96ZW4pOiBTY2hlZHVsZSBhbm90aGVyIHJlbmRlcmlu ZyB3aGVuIHRoZSBsYXllciB0cmVlIGJlY29tZXMgdW5mcm96ZW4uCisKIDIwMjEtMDgtMjkgIEZ1 amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CiAKICAgICAgICAgUkVHUkVT U0lPTihyMjgxMTAyKTogQVNTRVJUSU9OIEZBSUxFRDogIWlzSW5BY2NlbGVyYXRlZENvbXBvc2l0 aW5nTW9kZSgpIGluIERyYXdpbmdBcmVhUHJveHlDb29yZGluYXRlZEdyYXBoaWNzOjppbmNvcnBv cmF0ZVVwZGF0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2Uv Q29vcmRpbmF0ZWRHcmFwaGljcy9EcmF3aW5nQXJlYUNvb3JkaW5hdGVkR3JhcGhpY3MuY3BwIGIv U291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9EcmF3 aW5nQXJlYUNvb3JkaW5hdGVkR3JhcGhpY3MuY3BwCmluZGV4IGFjMDFmMTlmYzI0ZC4uYTU1MzYx ZmI5ZjdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9Db29y ZGluYXRlZEdyYXBoaWNzL0RyYXdpbmdBcmVhQ29vcmRpbmF0ZWRHcmFwaGljcy5jcHAKKysrIGIv U291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9EcmF3 aW5nQXJlYUNvb3JkaW5hdGVkR3JhcGhpY3MuY3BwCkBAIC0yNDIsNiArMjQyLDggQEAgdm9pZCBE cmF3aW5nQXJlYUNvb3JkaW5hdGVkR3JhcGhpY3M6OnNldExheWVyVHJlZVN0YXRlSXNGcm96ZW4o Ym9vbCBpc0Zyb3plbikKICAgICAgICAgbV9leGl0Q29tcG9zaXRpbmdUaW1lci5zdG9wKCk7CiAg ICAgZWxzZSBpZiAobV93YW50c1RvRXhpdEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdNb2RlKQogICAg ICAgICBleGl0QWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGVTb29uKCk7CisgICAgZWxzZQorICAg ICAgICBzY2hlZHVsZURpc3BsYXkoKTsKIH0KIAogdm9pZCBEcmF3aW5nQXJlYUNvb3JkaW5hdGVk R3JhcGhpY3M6OnVwZGF0ZVByZWZlcmVuY2VzKGNvbnN0IFdlYlByZWZlcmVuY2VzU3RvcmUmIHN0 b3JlKQo= 437000 2021-09-01 00:45:20 -0700 2021-09-01 01:44:24 -0700 patch add-rendering-after-unfrozen-2.patch text/plain 2085 tomoki.imai ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNWJmNzNhZDQ2YzI0Li5hMzEyZGU2MWU4NjQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMjAgQEAKKzIwMjEtMDgtMzEgIFRvbW9raSBJbWFpICA8VG9tb2tpLkltYWlAc29ueS5jb20+ CisKKyAgICAgICAgW0Nvb3JkaW5hdGVkR3JhcGhpY3NdIFNjaGVkdWxlIHJlbmRlcmluZyBhZnRl ciBzZXRMYXllclRyZWVTdGF0ZUlzRnJvemVuKGZhbHNlKSBpbiBub24tQUMgbW9kZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5NzQ5CisKKyAgICAg ICAgV2Ugc2hvdWxkIHNjaGVkdWxlIGFub3RoZXIgcmVuZGVyaW5nIHdoZW4gdGhlIHNldExheWVy VHJlZVN0YXRlSXNGcm96ZW4oZmFsc2UpIGlzIGNhbGxlZC4KKyAgICAgICAgSW4gc29tZSByYXJl IGNhc2VzLCB0aGUgYnJvd3NlciBvbmx5IHNob3dzIHRoZSB3aGl0ZSBwYWdlIGFmdGVyIHRoZSBw YWdlIHRyYW5zaXRpb24sCisgICAgICAgIGJlY2F1c2UgdGhlIHJlbmRlcmluZyBpcyBza2lwcGVk IHdoaWxlIHRoZSBsYXllciB0cmVlIGlzIGZyb3plbiBhbmQgdGhlcmUgd2FzIG5vIGd1YXJhbnRl ZSB0aGF0IHRoZXJlIGlzCisgICAgICAgIGFub3RoZXIgcmVuZGVyaW5nIGFmdGVyIHNldExheWVy VHJlZVN0YXRlSXNGcm96ZW4oZmFsc2UpLgorCisgICAgICAgIFJldmlld2VkIGJ5IENhcmxvcyBH YXJjaWEgQ2FtcG9zLgorCisgICAgICAgIFRlc3RlZCBieSBtYW51YWwuCisKKyAgICAgICAgKiBX ZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9EcmF3aW5nQXJlYUNvb3JkaW5h dGVkR3JhcGhpY3MuY3BwOgorICAgICAgICAoV2ViS2l0OjpEcmF3aW5nQXJlYUNvb3JkaW5hdGVk R3JhcGhpY3M6OnNldExheWVyVHJlZVN0YXRlSXNGcm96ZW4pOiBTY2hlZHVsZSBhbm90aGVyIHJl bmRlcmluZyB3aGVuIHRoZSBsYXllciB0cmVlIGJlY29tZXMgdW5mcm96ZW4uCisKIDIwMjEtMDgt MjkgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CiAKICAgICAgICAg UkVHUkVTU0lPTihyMjgxMTAyKTogQVNTRVJUSU9OIEZBSUxFRDogIWlzSW5BY2NlbGVyYXRlZENv bXBvc2l0aW5nTW9kZSgpIGluIERyYXdpbmdBcmVhUHJveHlDb29yZGluYXRlZEdyYXBoaWNzOjpp bmNvcnBvcmF0ZVVwZGF0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dl YlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9EcmF3aW5nQXJlYUNvb3JkaW5hdGVkR3JhcGhpY3Mu Y3BwIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGlj cy9EcmF3aW5nQXJlYUNvb3JkaW5hdGVkR3JhcGhpY3MuY3BwCmluZGV4IGFjMDFmMTlmYzI0ZC4u MzNhYzJlMWQ3NjMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFn ZS9Db29yZGluYXRlZEdyYXBoaWNzL0RyYXdpbmdBcmVhQ29vcmRpbmF0ZWRHcmFwaGljcy5jcHAK KysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGlj cy9EcmF3aW5nQXJlYUNvb3JkaW5hdGVkR3JhcGhpY3MuY3BwCkBAIC0yNDIsNiArMjQyLDggQEAg dm9pZCBEcmF3aW5nQXJlYUNvb3JkaW5hdGVkR3JhcGhpY3M6OnNldExheWVyVHJlZVN0YXRlSXNG cm96ZW4oYm9vbCBpc0Zyb3plbikKICAgICAgICAgbV9leGl0Q29tcG9zaXRpbmdUaW1lci5zdG9w KCk7CiAgICAgZWxzZSBpZiAobV93YW50c1RvRXhpdEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdNb2Rl KQogICAgICAgICBleGl0QWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGVTb29uKCk7CisgICAgZWxz ZSBpZiAoIW1fbGF5ZXJUcmVlSG9zdCkKKyAgICAgICAgc2NoZWR1bGVEaXNwbGF5KCk7CiB9CiAK IHZvaWQgRHJhd2luZ0FyZWFDb29yZGluYXRlZEdyYXBoaWNzOjp1cGRhdGVQcmVmZXJlbmNlcyhj b25zdCBXZWJQcmVmZXJlbmNlc1N0b3JlJiBzdG9yZSkK