229725 2021-08-31 12:16:30 -0700 Baseline JIT's in_by_val and emitHasPrivate should load the property before branching on if the base is a cell 2021-08-31 15:47:19 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam ews-watchlist keith_miller mark.lam msaboff tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1789017 0 saam 2021-08-31 12:16:30 -0700 Just for our own sanity when reasoning about what the slow paths do, we don't want a random value in property when the base isn't a cell. 1789019 1 436926 saam 2021-08-31 12:21:42 -0700 Created attachment 436926 patch 1789021 2 436926 ysuzuki 2021-08-31 12:24:24 -0700 Comment on attachment 436926 patch View in context: https://bugs.webkit.org/attachment.cgi?id=436926&action=review r=me too > Source/JavaScriptCore/jit/JITPropertyAccess.cpp:1519 > emitArrayProfilingSiteWithCell(regT0, profile, regT2); Can you also ensure that AccessCase IC code for InByVal / InById reserves the above registers if we go to the slow path? 1789025 3 saam 2021-08-31 12:32:21 -0700 (In reply to Yusuke Suzuki from comment #2) > Comment on attachment 436926 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=436926&action=review > > r=me too > > > Source/JavaScriptCore/jit/JITPropertyAccess.cpp:1519 > > emitArrayProfilingSiteWithCell(regT0, profile, regT2); > > Can you also ensure that AccessCase IC code for InByVal / InById reserves > the above registers if we go to the slow path? Confirmed that they do not clobber these registers. 1789125 4 ews-feeder 2021-08-31 15:46:14 -0700 Committed r281826 (241160@main): <https://commits.webkit.org/241160@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436926. 1789126 5 webkit-bug-importer 2021-08-31 15:47:19 -0700 <rdar://problem/82600217> 436926 2021-08-31 12:21:42 -0700 2021-08-31 15:46:15 -0700 patch a-backup.diff text/plain 2284 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjgxODE0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDIxLTA4LTMxICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IEJhc2VsaW5lIEpJVCdzIGluX2J5X3ZhbCBhbmQgZW1pdEhhc1ByaXZhdGUgc2hvdWxkIGxvYWQg dGhlIHByb3BlcnR5IGJlZm9yZSBicmFuY2hpbmcgb24gaWYgdGhlIGJhc2UgaXMgYSBjZWxsCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjk3MjUKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZiB0aGUgYmFz ZSBpc24ndCBhIGNlbGwsIHdlJ3JlIGNhbGxpbmcgdGhlIHNsb3cgcGF0aCB3aXRoIGEgcmFuZG9t IHZhbHVlCisgICAgICAgIGluIHRoZSBwcm9wZXJ0eS4gVGhpcyB3b3JrcywgYmVjYXVzZSB0aGUg c2xvdyBwYXRocyBmaXJzdCBicmFuY2ggb24gaWYKKyAgICAgICAgdGhlIGJhc2UgaXMgYSBjZWxs IG9yIG5vdCwgYW5kIHRocm93IGFuIGV4Y2VwdGlvbi4gQnV0IHdlIGZpeCB0aGlzIGZvciBvdXIK KyAgICAgICAgb3duIHNhbml0eSwgc2luY2UgaXQncyBuZXZlciBhIGdvb2QgaWRlYSB0byBnbyB0 byBhIHNsb3cgcGF0aCB3aXRoIGEKKyAgICAgICAgSlNWYWx1ZSBhcmd1bWVudCBjb250YWluaW5n IHVua25vd24gYml0cy4KKworICAgICAgICAqIGppdC9KSVRQcm9wZXJ0eUFjY2Vzcy5jcHA6Cisg ICAgICAgIChKU0M6OkpJVDo6ZW1pdF9vcF9pbl9ieV92YWwpOgorICAgICAgICAoSlNDOjpKSVQ6 OmVtaXRIYXNQcml2YXRlKToKKwogMjAyMS0wOC0zMSAgQWRpdGkgU2luZ2ggIDxhc2luZ2hAaWdh bGlhLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgT2JqZWN0Lmhhc093bigpCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFByb3BlcnR5QWNjZXNzLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFByb3BlcnR5QWNjZXNzLmNwcAkocmV2aXNp b24gMjgxNzcxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRQcm9wZXJ0eUFjY2Vz cy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE1MTQsOCArMTUxNCw4IEBAIHZvaWQgSklUOjplbWl0 X29wX2luX2J5X3ZhbChjb25zdCBJbnN0cnUKICAgICBBcnJheVByb2ZpbGUqIHByb2ZpbGUgPSAm bWV0YWRhdGEubV9hcnJheVByb2ZpbGU7CiAKICAgICBlbWl0R2V0VmlydHVhbFJlZ2lzdGVyKGJh c2UsIHJlZ1QwKTsKLSAgICBlbWl0SnVtcFNsb3dDYXNlSWZOb3RKU0NlbGwocmVnVDAsIGJhc2Up OwogICAgIGVtaXRHZXRWaXJ0dWFsUmVnaXN0ZXIocHJvcGVydHksIHJlZ1QxKTsKKyAgICBlbWl0 SnVtcFNsb3dDYXNlSWZOb3RKU0NlbGwocmVnVDAsIGJhc2UpOwogICAgIGVtaXRBcnJheVByb2Zp bGluZ1NpdGVXaXRoQ2VsbChyZWdUMCwgcHJvZmlsZSwgcmVnVDIpOwogCiAgICAgSklUSW5CeVZh bEdlbmVyYXRvciBnZW4oCkBAIC0xNTg0LDggKzE1ODQsOCBAQCB2b2lkIEpJVDo6ZW1pdFNsb3df b3BfaW5fYnlfdmFsKGNvbnN0IEluCiB2b2lkIEpJVDo6ZW1pdEhhc1ByaXZhdGUoVmlydHVhbFJl Z2lzdGVyIGRzdCwgVmlydHVhbFJlZ2lzdGVyIGJhc2UsIFZpcnR1YWxSZWdpc3RlciBwcm9wZXJ0 eU9yQnJhbmQsIEFjY2Vzc1R5cGUgdHlwZSkKIHsKICAgICBlbWl0R2V0VmlydHVhbFJlZ2lzdGVy KGJhc2UsIHJlZ1QwKTsKLSAgICBlbWl0SnVtcFNsb3dDYXNlSWZOb3RKU0NlbGwocmVnVDAsIGJh c2UpOwogICAgIGVtaXRHZXRWaXJ0dWFsUmVnaXN0ZXIocHJvcGVydHlPckJyYW5kLCByZWdUMSk7 CisgICAgZW1pdEp1bXBTbG93Q2FzZUlmTm90SlNDZWxsKHJlZ1QwLCBiYXNlKTsKIAogICAgIEpJ VEluQnlWYWxHZW5lcmF0b3IgZ2VuKAogICAgICAgICBtX2NvZGVCbG9jaywgSklUVHlwZTo6QmFz ZWxpbmVKSVQsIENvZGVPcmlnaW4obV9ieXRlY29kZUluZGV4KSwgQ2FsbFNpdGVJbmRleChtX2J5 dGVjb2RlSW5kZXgpLCB0eXBlLCBSZWdpc3RlclNldDo6c3R1YlVuYXZhaWxhYmxlUmVnaXN0ZXJz KCksCg==