229697 2021-08-30 21:13:55 -0700 keyboard scrolling spring damping animation doesn't finish and leads to endless flickering scrolling 2022-10-07 19:10:32 -0700 1 1 1 Unclassified WebKit Scrolling WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=228009 InRadar P2 Normal --- 1 fujii fujii bdakin clord dana.estra destra richard_robinson2 simon.fraser thorton webkit-bug-importer oldest_to_newest 1788781 0 fujii 2021-08-30 21:13:55 -0700 keyboard scrolling spring damping animation doesn't finish in WinCairo Debug with debug logging 1. Start WinCairo Debug with enabling some debug logging $env:WebCoreLogging = "Scrolling" devenv -debugexe .\WebKitBuild\Debug\bin64\MiniBrowser.exe Turn "Enable child process debugging" on Start Debugging 2. Go to a heavy and long page. For example, https://news.google.com/ and https://edition.cnn.com/ 3. Press Page-Down key Expected: The scrolling animation stops. Actual: The scrolling animation never stops. It goes back and forth. 1788782 1 fujii 2021-08-30 21:17:28 -0700 https://github.com/WebKit/WebKit/blob/b736c55b81845e8e159eb97b3fcba1a8315da7d1/Source/WebCore/platform/KeyboardScrollingAnimator.cpp#L125,L127 > FloatSize acceleration = force.scaled(1. / params.springMass); > m_velocity += acceleration.scaled(frameDuration); > FloatPoint newPosition = m_scrollAnimator.currentPosition() + m_velocity.scaled(frameDuration); This expressions are assuming that frameDuration is short. 1788798 2 fujii 2021-08-31 00:33:42 -0700 https://en.wikipedia.org/wiki/Damping https://en.wikipedia.org/wiki/Mass-spring-damper_model 1788801 3 thorton 2021-08-31 00:38:53 -0700 This feature isn't ready yet, how did it get turned on? 1788802 4 thorton 2021-08-31 00:39:26 -0700 That said, I don't think we were aware of this particular problem. 1789063 5 fujii 2021-08-31 13:42:32 -0700 (In reply to Tim Horton from comment #3) > This feature isn't ready yet, how did it get turned on? Good to know. Then, it's another bug. Filed: Bug 229733 – REGRESSION(r280928) The smooth keyboard scrolling is enabled only for PageUp and PageDown keys 1811938 6 fujii 2021-11-04 13:01:04 -0700 Epiphany (WebKitGTK) has a bug report. Bug 232701 – [GTK] Pressing "End" keyboard key on instagram.com leads to endless flickering scrolling 1850169 7 webkit-bug-importer 2022-03-10 10:21:57 -0800 <rdar://problem/90106824> 1902726 8 fujii 2022-10-02 13:41:47 -0700 255031@main (bug#228159) enabled EventHandlerDrivenSmoothKeyboardScrollingEnabled by default. Now, I can reproduce this issue even with WinCairo MiniBrowser Release build. 1902730 9 thorton 2022-10-02 16:05:18 -0700 Oops, sorry. We probably should have only enabled for cocoa ports. Richard? 1902734 10 richard_robinson2 2022-10-02 16:11:09 -0700 (In reply to Tim Horton from comment #9) > Oops, sorry. We probably should have only enabled for cocoa ports. Richard? Yup, I'm on it. 1902735 11 richard_robinson2 2022-10-02 16:15:31 -0700 Pull request: https://github.com/WebKit/WebKit/pull/4914 1902736 12 fujii 2022-10-02 17:06:12 -0700 It's assuming that frameDuration is short (comment#1). I think we should choose more robust algorithm. 1902754 13 thorton 2022-10-02 23:02:16 -0700 (In reply to Fujii Hironori from comment #12) > It's assuming that frameDuration is short (comment#1). I think we should > choose more robust algorithm. This has been shipping for years on iOS. Why is frameDuration *not* short for you? 1902759 14 462767 fujii 2022-10-03 01:01:35 -0700 Created attachment 462767 log I added the following log. I pressed down arrow key and page down key in https://webkit.org/ . The sprint went into divergent vibration. diff --git a/Source/WebCore/platform/KeyboardScrollingAnimator.cpp b/Source/WebCore/platform/KeyboardScrollingAnimator.cpp index 9863ebac3fd6..d604c3e15560 100644 --- a/Source/WebCore/platform/KeyboardScrollingAnimator.cpp +++ b/Source/WebCore/platform/KeyboardScrollingAnimator.cpp @@ -218,6 +218,7 @@ void KeyboardScrollingAnimator::updateKeyboardScrollPosition(MonotonicTime curre m_scrollAnimator.scrollToPositionWithoutAnimation(newPosition); + ALWAYS_LOG_WITH_STREAM(stream << "frameDuration:" << frameDuration << " newPosition:" << newPosition << " m_velocity:" << m_velocity); if (!m_scrollTriggeringKeyIsPressed && m_velocity.diagonalLengthSquared() < 1) { m_scrollController.didStopKeyboardScrolling(); m_velocity = { }; 1902934 15 ews-feeder 2022-10-03 14:46:54 -0700 Committed 255099@main (5f888cf9998e): <https://commits.webkit.org/255099@main> Reviewed commits have been landed. Closing PR #4914 and removing active labels. 1902940 16 fujii 2022-10-03 14:56:08 -0700 I misunderstood a little. The problem reproducible by Release build + PageDown is a bit different issue. I filed bug#245982 to the bug. 1902943 17 fujii 2022-10-03 15:03:20 -0700 I tried comment#0 step. I just pressed a single down arrow key in this case. frameDuration:0.01 newPosition:(0,0.05) m_velocity:width=0 height=7.30 frameDuration:0.04 newPosition:(0,1.69) m_velocity:width=0 height=44.33 frameDuration:0.14 newPosition:(0,73.07) m_velocity:width=0 height=507.16 frameDuration:0.20 newPosition:(0,-375.81) m_velocity:width=0 height=-2243.49 frameDuration:0.09 newPosition:(0,193.07) m_velocity:width=0 height=2158.95 frameDuration:0.33 newPosition:(0,-5452.72) m_velocity:width=0 height=-17336.29 frameDuration:0.14 newPosition:(0,4149.97) m_velocity:width=0 height=30474.31 frameDuration:3.10 newPosition:(0,-9244337) m_velocity:width=0 height=-2981108.50 frameDuration:1.02 newPosition:(0,58668016) m_velocity:width=0 height=57673556 frameDuration:1.92 newPosition:(0,-4164551680.00) m_velocity:width=0 height=-2163899648.00 frameDuration:0.98 newPosition:(0,39856992256.00) m_velocity:width=0 height=40464424960.00 frameDuration:0.72 newPosition:(0,-385372749824.00) m_velocity:width=0 height=-538594639872.00 frameDuration:1.12 newPosition:(0,12795050459136.00) m_velocity:width=0 height=11473761861632.00 1903032 18 fujii 2022-10-03 21:41:06 -0700 This bug is reproducible for Mac port MiniBrowser (Debug build) on my Mac mini (2018). 1. Enable "Scrolling" debug log channel 2. Start MiniBrowser (Debug build) 3. Go to https://edition.cnn.com/ 4. Press arrow keys and PageUp and Page Down keys to scroll Not 100% reproducible. But, it's easy to reproduce. 1903889 19 462846 fujii 2022-10-06 15:07:48 -0700 Created attachment 462846 Patch 1904075 20 462846 thorton 2022-10-07 09:34:47 -0700 Comment on attachment 462846 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=462846&action=review > Source/WebCore/platform/KeyboardScrollingAnimator.cpp:223 > + if (axesToApplySpring.width() && displacement.width() * newDisplacement.width() < 0) This is fine, though I bet you want an areEssentiallyEqual / FLT_EPSILON / whatever? (Also separately super confused about what's going on with your frame times, and why this was never necessary on iOS (not sure if there was a mistake when the code got moved here, or what)). But that's ok! Thank you for fixing. 1904162 21 462846 fujii 2022-10-07 14:36:16 -0700 Comment on attachment 462846 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=462846&action=review Thank you very much for the review. >> Source/WebCore/platform/KeyboardScrollingAnimator.cpp:223 >> + if (axesToApplySpring.width() && displacement.width() * newDisplacement.width() < 0) > > This is fine, though I bet you want an areEssentiallyEqual / FLT_EPSILON / whatever? > > (Also separately super confused about what's going on with your frame times, and why this was never necessary on iOS (not sure if there was a mistake when the code got moved here, or what)). But that's ok! > > Thank you for fixing. The first condition "axesToApplySpring.width()" is checking if x-axis is to apply spring. The second condition "displacement.width() * newDisplacement.width() < 0" is checking if either of the previous or next x-axis displacement is negative and the other is positive. I don't think areEssentiallyEqual is needed here. It should be reproducible even for iOS if we can slow down the scrolling somehow or if we use a stronger spring (bigger params.springStiffness). 1904170 22 thorton 2022-10-07 15:06:12 -0700 (In reply to Fujii Hironori from comment #21) > Comment on attachment 462846 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=462846&action=review > > > The first condition "axesToApplySpring.width()" is checking if x-axis is to > apply spring. > The second condition "displacement.width() * newDisplacement.width() < 0" is > checking if either of the previous or next x-axis displacement is negative > and the other is positive. > I don't think areEssentiallyEqual is needed here. Right! I misread. Apologies. 1904202 23 ews-feeder 2022-10-07 19:10:30 -0700 Committed 255306@main (367b4c1a2c7f): <https://commits.webkit.org/255306@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 462846. 462767 2022-10-03 01:01:35 -0700 2022-10-03 01:01:35 -0700 log log.txt text/plain 5245 fujii ZnJhbWVEdXJhdGlvbjowLjA2IG5ld1Bvc2l0aW9uOigwLDEyLjgzKSBtX3ZlbG9jaXR5OndpZHRo PTAgaGVpZ2h0PTEzOS44NwpmcmFtZUR1cmF0aW9uOjAuMDMgbmV3UG9zaXRpb246KDAsMTcuNDEp IG1fdmVsb2NpdHk6d2lkdGg9MCBoZWlnaHQ9MTQ1LjA3CmZyYW1lRHVyYXRpb246MC4wMyBuZXdQ b3NpdGlvbjooMCwyMS40NCkgbV92ZWxvY2l0eTp3aWR0aD0wIGhlaWdodD0xMzEuNjEKZnJhbWVE dXJhdGlvbjowLjA2IG5ld1Bvc2l0aW9uOigwLDI3LjMwKSBtX3ZlbG9jaXR5OndpZHRoPTAgaGVp Z2h0PTkzLjM3CmZyYW1lRHVyYXRpb246MC4wNiBuZXdQb3NpdGlvbjooMCwzMS4yOCkgbV92ZWxv Y2l0eTp3aWR0aD0wIGhlaWdodD02Mi43MwpmcmFtZUR1cmF0aW9uOjAuMDMgbmV3UG9zaXRpb246 KDAsMzIuODUpIG1fdmVsb2NpdHk6d2lkdGg9MCBoZWlnaHQ9NTMuODYKZnJhbWVEdXJhdGlvbjow LjA2IG5ld1Bvc2l0aW9uOigwLDM1LjA2KSBtX3ZlbG9jaXR5OndpZHRoPTAgaGVpZ2h0PTM1LjE0 CmZyYW1lRHVyYXRpb246MC4wMiBuZXdQb3NpdGlvbjooMCwzNS44MCkgbV92ZWxvY2l0eTp3aWR0 aD0wIGhlaWdodD0zMS4yMQpmcmFtZUR1cmF0aW9uOjAuMDUgbmV3UG9zaXRpb246KDAsMzcuMDAp IG1fdmVsb2NpdHk6d2lkdGg9MCBoZWlnaHQ9MjIuMjAKZnJhbWVEdXJhdGlvbjowLjA0IG5ld1Bv c2l0aW9uOigwLDM3LjcwKSBtX3ZlbG9jaXR5OndpZHRoPTAgaGVpZ2h0PTE3LjU4CmZyYW1lRHVy YXRpb246MC4wNiBuZXdQb3NpdGlvbjooMCwzOC4zNikgbV92ZWxvY2l0eTp3aWR0aD0wIGhlaWdo dD0xMS45NgpmcmFtZUR1cmF0aW9uOjAuMDQgbmV3UG9zaXRpb246KDAsMzguNzcpIG1fdmVsb2Np dHk6d2lkdGg9MCBoZWlnaHQ9OS4zMwpmcmFtZUR1cmF0aW9uOjAuMDUgbmV3UG9zaXRpb246KDAs MzkuMTEpIG1fdmVsb2NpdHk6d2lkdGg9MCBoZWlnaHQ9Ni42NgpmcmFtZUR1cmF0aW9uOjAuMDQg bmV3UG9zaXRpb246KDAsMzkuMzIpIG1fdmVsb2NpdHk6d2lkdGg9MCBoZWlnaHQ9NS4xNwpmcmFt ZUR1cmF0aW9uOjAuMDUgbmV3UG9zaXRpb246KDAsMzkuNTEpIG1fdmVsb2NpdHk6d2lkdGg9MCBo ZWlnaHQ9My42MgpmcmFtZUR1cmF0aW9uOjAuMDQgbmV3UG9zaXRpb246KDAsMzkuNjIpIG1fdmVs b2NpdHk6d2lkdGg9MCBoZWlnaHQ9Mi45NApmcmFtZUR1cmF0aW9uOjAuMDIgbmV3UG9zaXRpb246 KDAsMzkuNjgpIG1fdmVsb2NpdHk6d2lkdGg9MCBoZWlnaHQ9Mi41NApmcmFtZUR1cmF0aW9uOjAu MDUgbmV3UG9zaXRpb246KDAsMzkuNzYpIG1fdmVsb2NpdHk6d2lkdGg9MCBoZWlnaHQ9MS44Mgpm cmFtZUR1cmF0aW9uOjAuMDMgbmV3UG9zaXRpb246KDAsNzY4LjU5KSBtX3ZlbG9jaXR5OndpZHRo PTAgaGVpZ2h0PS0yODIzLjEyCmZyYW1lRHVyYXRpb246MC4xMyBuZXdQb3NpdGlvbjooMCw0MC42 MykgbV92ZWxvY2l0eTp3aWR0aD0wIGhlaWdodD0tNTczNi4xNQpmcmFtZUR1cmF0aW9uOjAuMjIg bmV3UG9zaXRpb246KDAsNDM3OC44MSkgbV92ZWxvY2l0eTp3aWR0aD0wIGhlaWdodD0xOTYxNy44 NQpmcmFtZUR1cmF0aW9uOjAuMTMgbmV3UG9zaXRpb246KDAsLTQ3MDguNzkpIG1fdmVsb2NpdHk6 d2lkdGg9MCBoZWlnaHQ9LTQyODg1Ljc3CmZyYW1lRHVyYXRpb246MC4yNiBuZXdQb3NpdGlvbjoo MCw0OTA0My40NikgbV92ZWxvY2l0eTp3aWR0aD0wIGhlaWdodD0xODUyOTEuMTQKZnJhbWVEdXJh dGlvbjowLjExIG5ld1Bvc2l0aW9uOigwLC0yNTc5MC41MikgbV92ZWxvY2l0eTp3aWR0aD0wIGhl aWdodD0tMjM4NTg1LjM2CmZyYW1lRHVyYXRpb246MC4yOCBuZXdQb3NpdGlvbjooMCwyOTc1MTUp IG1fdmVsb2NpdHk6d2lkdGg9MCBoZWlnaHQ9MTA3ODY5OC4yNQpmcmFtZUR1cmF0aW9uOjAuMTMg bmV3UG9zaXRpb246KDAsLTIxNjAzMS40NCkgbV92ZWxvY2l0eTp3aWR0aD0wIGhlaWdodD0tMTY5 NDM0Ny41MApmcmFtZUR1cmF0aW9uOjAuMjggbmV3UG9zaXRpb246KDAsMjEyODMxOC41MCkgbV92 ZWxvY2l0eTp3aWR0aD0wIGhlaWdodD03Njg4MDAxLjUwCmZyYW1lRHVyYXRpb246MC4xNCBuZXdQ b3NpdGlvbjooMCwtMTg3MDE4My44OCkgbV92ZWxvY2l0eTp3aWR0aD0wIGhlaWdodD0tMTM1NTIz OTYKZnJhbWVEdXJhdGlvbjowLjI2IG5ld1Bvc2l0aW9uOigwLDE1MTAxNTk0KSBtX3ZlbG9jaXR5 OndpZHRoPTAgaGVpZ2h0PTU3NTYwNzE2CmZyYW1lRHVyYXRpb246MC4xMyBuZXdQb3NpdGlvbjoo MCwtMTI5MDc3MTMpIG1fdmVsb2NpdHk6d2lkdGg9MCBoZWlnaHQ9LTk2NDc5MzQ0CmZyYW1lRHVy YXRpb246MC4yNyBuZXdQb3NpdGlvbjooMCwxMTY2MDQzMTIpIG1fdmVsb2NpdHk6d2lkdGg9MCBo ZWlnaHQ9NDI4NTQ3MjAwCmZyYW1lRHVyYXRpb246MC4xMyBuZXdQb3NpdGlvbjooMCwtODMxOTc2 MDApIG1fdmVsb2NpdHk6d2lkdGg9MCBoZWlnaHQ9LTY1NjkzODExMgpmcmFtZUR1cmF0aW9uOjAu MjkgbmV3UG9zaXRpb246KDAsODk3NTYzMjY0KSBtX3ZlbG9jaXR5OndpZHRoPTAgaGVpZ2h0PTMx MjEyNzk0ODguMDAKZnJhbWVEdXJhdGlvbjowLjEzIG5ld1Bvc2l0aW9uOigwLC02NDk1NTM0MDgp IG1fdmVsb2NpdHk6d2lkdGg9MCBoZWlnaHQ9LTQ5OTU2MTM2OTYuMDAKZnJhbWVEdXJhdGlvbjow LjI5IG5ld1Bvc2l0aW9uOigwLDY5NzU5MjgzMjAuMDApIG1fdmVsb2NpdHk6d2lkdGg9MCBoZWln aHQ9MjQwMjA0ODgxOTIuMDAKZnJhbWVEdXJhdGlvbjowLjE0IG5ld1Bvc2l0aW9uOigwLC02NjA0 ODEwNzUyLjAwKSBtX3ZlbG9jaXR5OndpZHRoPTAgaGVpZ2h0PS00NTU4NTQzNjY3Mi4wMApmcmFt ZUR1cmF0aW9uOjAuMjggbmV3UG9zaXRpb246KDAsNTY0MzM3NjIzMDQuMDApIG1fdmVsb2NpdHk6 d2lkdGg9MCBoZWlnaHQ9MjA1MTc4MDI4MDMyLjAwCmZyYW1lRHVyYXRpb246MC4xNCBuZXdQb3Np dGlvbjooMCwtNDcwODk2Mzk0MjQuMDApIG1fdmVsb2NpdHk6d2lkdGg9MCBoZWlnaHQ9LTM0ODgw ODQ3ODcyMC4wMApmcmFtZUR1cmF0aW9uOjAuMjcgbmV3UG9zaXRpb246KDAsNDE0MTYwMjg5Nzky LjAwKSBtX3ZlbG9jaXR5OndpZHRoPTAgaGVpZ2h0PTE1MzQyOTk3MzQwMTYuMDAKZnJhbWVEdXJh dGlvbjowLjEzIG5ld1Bvc2l0aW9uOigwLC0zMTc3NDkxMzMzMTIuMDApIG1fdmVsb2NpdHk6d2lk dGg9MCBoZWlnaHQ9LTI0NDgyNzY1ODY0OTYuMDAKZnJhbWVEdXJhdGlvbjowLjI3IG5ld1Bvc2l0 aW9uOigwLDI5NzE1OTkxMTAxNDQuMDApIG1fdmVsb2NpdHk6d2lkdGg9MCBoZWlnaHQ9MTA5MDA0 MDA1MDQ4MzIuMDAKZnJhbWVEdXJhdGlvbjowLjEzIG5ld1Bvc2l0aW9uOigwLC0yMDQ5NTA0NTc1 NDg4LjAwKSBtX3ZlbG9jaXR5OndpZHRoPTAgaGVpZ2h0PS0xNjM3ODk3OTQxODExMi4wMApmcmFt ZUR1cmF0aW9uOjAuMjYgbmV3UG9zaXRpb246KDAsMTcyNTU0MDIzMDc1ODQuMDApIG1fdmVsb2Np dHk6d2lkdGg9MCBoZWlnaHQ9Njc0Mzg0NDgyMTQwMTYuMDAKZnJhbWVEdXJhdGlvbjowLjE0IG5l d1Bvc2l0aW9uOigwLC0xNTk5OTk1MDY1MTM5Mi4wMCkgbV92ZWxvY2l0eTp3aWR0aD0wIGhlaWdo dD0tMTE3MDAzMTEzMjAxNjY0LjAwCmZyYW1lRHVyYXRpb246MC4yNiBuZXdQb3NpdGlvbjooMCwx MjgyODAyNzk2NDYyMDguMDApIG1fdmVsb2NpdHk6d2lkdGg9MCBoZWlnaHQ9NDkyNTAzMjI4NzQz NjgwLjAwCmZyYW1lRHVyYXRpb246MC4xMSBuZXdQb3NpdGlvbjooMCwtNzMxNjQxMDUxODczMjgu MDApIG1fdmVsb2NpdHk6d2lkdGg9MCBoZWlnaHQ9LTYzNzY2NjQxMjQ2MjA4MC4wMApmcmFtZUR1 cmF0aW9uOjAuMjcgbmV3UG9zaXRpb246KDAsNzQxNTI5MjU3NzcxMDA4LjAwKSBtX3ZlbG9jaXR5 OndpZHRoPTAgaGVpZ2h0PTI3NzI4Njg0NjcyNjE0NDAuMDAKZnJhbWVEdXJhdGlvbjowLjEzIG5l d1Bvc2l0aW9uOigwLC01NDIxMTM3MjQ4OTExMzYuMDApIG1fdmVsb2NpdHk6d2lkdGg9MCBoZWln aHQ9LTQyNjkyMTc4OTMzMTg2NTYuMDAKZnJhbWVEdXJhdGlvbjowLjI3IG5ld1Bvc2l0aW9uOigw LDUwODI2ODk1MzEwMTkyNjQuMDApIG1fdmVsb2NpdHk6d2lkdGg9MCBoZWlnaHQ9MTg4MDY3MDgz MDY0NDQyODguMDAKZnJhbWVEdXJhdGlvbjowLjEzIG5ld1Bvc2l0aW9uOigwLC00MzAyMjQwNTU0 NjgwMzIwLjAwKSBtX3ZlbG9jaXR5OndpZHRoPTAgaGVpZ2h0PS0zMTkwODE3OTYyNTM3Nzc5Mi4w MApmcmFtZUR1cmF0aW9uOjAuMjcgbmV3UG9zaXRpb246KDAsMzY1NDgxMzU4NzQ0NjE2OTYuMDAp IG1fdmVsb2NpdHk6d2lkdGg9MCBoZWlnaHQ9MTM3NTk3OTI3MzkxNDk0MTQ0LjAwCmZyYW1lRHVy YXRpb246MC4xMyBuZXdQb3NpdGlvbjooMCwtMjgzNTY0NjI4NjI0MDE1MzYuMDApIG1fdmVsb2Np dHk6d2lkdGg9MCBoZWlnaHQ9LTIxODg5NzIzNDQ4ODQ1OTI2NC4wMApmcmFtZUR1cmF0aW9uOjAu MjggbmV3UG9zaXRpb246KDAsMjgzMDcyOTc5NDIyNjc0OTQ0LjAwKSBtX3ZlbG9jaXR5OndpZHRo PTAgaGVpZ2h0PTEwMDkxNDczMDI1NzQ1NTUxMzYuMDAKZnJhbWVEdXJhdGlvbjowLjExIG5ld1Bv c2l0aW9uOigwLC0xNDc1MDA5Nzk1MTQ3Njk0MDguMDApIG1fdmVsb2NpdHk6d2lkdGg9MCBoZWln aHQ9LTEyOTMwOTEyMzI2NDUzODIxNDQuMDAKZnJhbWVEdXJhdGlvbjowLjI5IG5ld1Bvc2l0aW9u OigwLDE3OTU0Mzk1NDExMTc1MTc4MjQuMDApIG1fdmVsb2NpdHk6d2lkdGg9MCBoZWlnaHQ9NjE5 ODI1OTg1NjgzMTQxNDI3Mi4wMApmcmFtZUR1cmF0aW9uOjAuMTMgbmV3UG9zaXRpb246KDAsLTEz MjAwOTI2MjY4ODM0NDQ3MzYuMDApIG1fdmVsb2NpdHk6d2lkdGg9MCBoZWlnaHQ9LTEwMDYzMzIx OTU0NjYxNjk1NDg4LjAwCmZyYW1lRHVyYXRpb246MC4yNyBuZXdQb3NpdGlvbjooMCwxMjQxNjU0 NDAxOTQyNzg4NTA1Ni4wMCkgbV92ZWxvY2l0eTp3aWR0aD0wIGhlaWdodD00NTIxMTI1ODQyNzE3 MjQ1NDQwMC4wMApmcmFtZUR1cmF0aW9uOjAuMTMgbmV3UG9zaXRpb246KDAsLTk2NTE5NTE3NzM3 NTcyMTA2MjQuMDApIG1fdmVsb2NpdHk6d2lkdGg9MCBoZWlnaHQ9LTczNTExNzU1MzQwMjY2MzQw MzUyLjAwCmZyYW1lRHVyYXRpb246MC4yOCBuZXdQb3NpdGlvbjooMCw5Mjc2MjQ4ODcwNDQ4NDc2 OTc5Mi4wMCkgbV92ZWxvY2l0eTp3aWR0aD0wIGhlaWdodD0zMzQzNjg5ODAyNzc5MzY1MjEyMTYu MDAKZnJhbWVEdXJhdGlvbjowLjEyIG5ld1Bvc2l0aW9uOigwLC01NTg4NDg4MTkwMzAxNzI2MzEw NC4wMCkgbV92ZWxvY2l0eTp3aWR0aD0wIGhlaWdodD0tNDY2NTkzMTE3MjI1MTYyMzc1MTY4LjAw Cg== 462846 2022-10-06 15:07:48 -0700 2022-10-07 19:10:31 -0700 Patch bug-229697-20221007070746.patch text/plain 1830 fujii RnJvbSA0MWZjYTFmNDViNWQ5ZTBlYzc1MzgzYjdiZTRlMDdjYzc0NDY4NzZmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBIaXJvbm9yaSA8SGlyb25vcmkuRnVqaWlAc29ueS5j b20+CkRhdGU6IEZyaSwgNyBPY3QgMjAyMiAwNzowMjoyOSArMDkwMApTdWJqZWN0OiBbUEFUQ0hd IGtleWJvYXJkIHNjcm9sbGluZyBzcHJpbmcgZGFtcGluZyBhbmltYXRpb24gZG9lc24ndCBmaW5p c2gKIGFuZCBsZWFkcyB0byBlbmRsZXNzIGZsaWNrZXJpbmcgc2Nyb2xsaW5nCiBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5Njk3CgpSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KClRoZSBkYW1wZWQgb3NjaWxsYXRpb24gYW5pbWF0aW9uIG9mIHRoZSBzbW9vdGgg a2V5Ym9hcmQgc2Nyb2xsaW5nCndlbnQgaW50byBkaXZlcmdlbnQgdmlicmF0aW9uIGlmIHRoZSBm cmFtZUR1cmF0aW9uIGlzbid0IHNob3J0CmVub3VnaC4gSXQgaGFwcGVuZWQgd2l0aCBkZWJ1ZyBi dWlsZHMgd2l0aCBlbmFibGluZyBkZWJ1Zwpsb2dnaW5ncy4KClN0b3AgdGhlIHNwcmluZyBpZiBp dCByZWFjaGVzIHRoZSBpZGVhbCBwb3NpdGlvbi4KCiogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v S2V5Ym9hcmRTY3JvbGxpbmdBbmltYXRvci5jcHA6CihXZWJDb3JlOjpLZXlib2FyZFNjcm9sbGlu Z0FuaW1hdG9yOjp1cGRhdGVLZXlib2FyZFNjcm9sbFBvc2l0aW9uKToKLS0tCiBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9LZXlib2FyZFNjcm9sbGluZ0FuaW1hdG9yLmNwcCB8IDcgKysrKysrKwog MSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL0tleWJvYXJkU2Nyb2xsaW5nQW5pbWF0b3IuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vS2V5Ym9hcmRTY3JvbGxpbmdBbmltYXRvci5jcHAKaW5kZXggOTg2M2ViYWMz ZmQ2Li4wMmRjNDczNGRiOGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0tl eWJvYXJkU2Nyb2xsaW5nQW5pbWF0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L0tleWJvYXJkU2Nyb2xsaW5nQW5pbWF0b3IuY3BwCkBAIC0yMTgsNiArMjE4LDEzIEBAIHZvaWQg S2V5Ym9hcmRTY3JvbGxpbmdBbmltYXRvcjo6dXBkYXRlS2V5Ym9hcmRTY3JvbGxQb3NpdGlvbihN b25vdG9uaWNUaW1lIGN1cnJlCiAKICAgICBtX3Njcm9sbEFuaW1hdG9yLnNjcm9sbFRvUG9zaXRp b25XaXRob3V0QW5pbWF0aW9uKG5ld1Bvc2l0aW9uKTsKIAorICAgIC8vIFN0b3AgdGhlIHNwcmlu ZyBpZiBpdCByZWFjaGVzIHRoZSBpZGVhbCBwb3NpdGlvbi4KKyAgICBGbG9hdFNpemUgbmV3RGlz cGxhY2VtZW50ID0gbmV3UG9zaXRpb24gLSBpZGVhbFBvc2l0aW9uOworICAgIGlmIChheGVzVG9B cHBseVNwcmluZy53aWR0aCgpICYmIGRpc3BsYWNlbWVudC53aWR0aCgpICogbmV3RGlzcGxhY2Vt ZW50LndpZHRoKCkgPCAwKQorICAgICAgICBtX3ZlbG9jaXR5LnNldFdpZHRoKDApOworICAgIGlm IChheGVzVG9BcHBseVNwcmluZy5oZWlnaHQoKSAmJiBkaXNwbGFjZW1lbnQuaGVpZ2h0KCkgKiBu ZXdEaXNwbGFjZW1lbnQuaGVpZ2h0KCkgPCAwKQorICAgICAgICBtX3ZlbG9jaXR5LnNldEhlaWdo dCgwKTsKKwogICAgIGlmICghbV9zY3JvbGxUcmlnZ2VyaW5nS2V5SXNQcmVzc2VkICYmIG1fdmVs b2NpdHkuZGlhZ29uYWxMZW5ndGhTcXVhcmVkKCkgPCAxKSB7CiAgICAgICAgIG1fc2Nyb2xsQ29u dHJvbGxlci5kaWRTdG9wS2V5Ym9hcmRTY3JvbGxpbmcoKTsKICAgICAgICAgbV92ZWxvY2l0eSA9 IHsgfTsK