22968 2008-12-22 12:28:18 -0800 Context menu rendering error when full page zoomed 2008-12-29 21:10:47 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 jroesslein webkit-unassigned oliver oldest_to_newest 103206 0 jroesslein 2008-12-22 12:28:18 -0800 The right click context menu is not rendered in the right position when full page zoom is in use. Also the incorrect context menu type (link, image, etc) is incorrect. Cause of the issue is due to lack of transformation to account for the page zoom. By transforming the context menu's point, this issue is resolved. This is an upstream issue from Chromium --> http://code.google.com/p/chromium/issues/detail?id=3474 I have been working on resolving this issue in chrome, but have determined that this should be an upstreamed patch to webkit. Patch --> http://codereview.chromium.org/16204/show Currently I have fixed the issue in our glue layer between webkit and chrome. I feel this should be moved into the ContextMenuController::handleContextMenuEvent method instead. 103226 1 26214 jroesslein 2008-12-22 14:40:49 -0800 Created attachment 26214 patch to fix issue 103760 2 26214 oliver 2008-12-29 20:13:53 -0800 Comment on attachment 26214 patch to fix issue This is basically okay, i'd just like an updated version of this patch with the 'if (frame->pageZoomFactor() != 1.0f)' branch removed. 103763 3 26309 jroesslein 2008-12-29 20:21:37 -0800 Created attachment 26309 Patch #2 revised orginal patch to remove the if zoomed test 103764 4 oliver 2008-12-29 21:10:47 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/page/ContextMenuController.cpp Committed r39506 26214 2008-12-22 14:40:49 -0800 2008-12-29 20:13:53 -0800 patch to fix issue bugfix_22968.txt text/plain 1660 jroesslein SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzOTQ0MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDgtMTItMjIgIFUtSk9TSC1MQVBUT1BcSm9zaCAgPHNldCBFTUFJ TF9BRERSRVNTIGVudmlyb25tZW50IHZhcmlhYmxlPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVzOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjI5NjgKKyAgICAgICAgQ29udGV4dCBtZW51IHJlbmRlcmluZyBlcnJv ciB3aGVuIGZ1bGwgcGFnZSB6b29tZWQKKworICAgICAgICAqIHBhZ2UvQ29udGV4dE1lbnVDb250 cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNvbnRleHRNZW51Q29udHJvbGxlcjo6aGFu ZGxlQ29udGV4dE1lbnVFdmVudCk6CisKIDIwMDgtMTItMjIgIERoYW5hbmpveSBDaHV0aWEgIDxk aGFucmRAZ21haWwuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIEtpbHplci4KSW5k ZXg6IFdlYkNvcmUvcGFnZS9Db250ZXh0TWVudUNvbnRyb2xsZXIuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUvcGFnZS9Db250ZXh0TWVudUNvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiAzOTQzOCkK KysrIFdlYkNvcmUvcGFnZS9Db250ZXh0TWVudUNvbnRyb2xsZXIuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC04Niw4ICs4NiwxNCBAQCB2b2lkIENvbnRleHRNZW51Q29udHJvbGxlcjo6aGFuZGxlQ29u dGV4CiAgICAgSW50UG9pbnQgcG9pbnQgPSBJbnRQb2ludChtb3VzZUV2ZW50LT5wYWdlWCgpLCBt b3VzZUV2ZW50LT5wYWdlWSgpKTsKICAgICBIaXRUZXN0UmVzdWx0IHJlc3VsdChwb2ludCk7CiAK LSAgICBpZiAoRnJhbWUqIGZyYW1lID0gZXZlbnQtPnRhcmdldCgpLT50b05vZGUoKS0+ZG9jdW1l bnQoKS0+ZnJhbWUoKSkKKyAgICBpZiAoRnJhbWUqIGZyYW1lID0gZXZlbnQtPnRhcmdldCgpLT50 b05vZGUoKS0+ZG9jdW1lbnQoKS0+ZnJhbWUoKSkgeworICAgICAgICBpZiAoZnJhbWUtPnBhZ2Va b29tRmFjdG9yKCkgIT0gMS4wZikgeworICAgICAgICAgICAgZmxvYXQgem9vbUZhY3RvciA9IGZy YW1lLT5wYWdlWm9vbUZhY3RvcigpOworICAgICAgICAgICAgcG9pbnQuc2V0WChzdGF0aWNfY2Fz dDxpbnQ+KHBvaW50LngoKSAqIHpvb21GYWN0b3IpKTsKKyAgICAgICAgICAgIHBvaW50LnNldFko c3RhdGljX2Nhc3Q8aW50Pihwb2ludC55KCkgKiB6b29tRmFjdG9yKSk7CisgICAgICAgIH0KICAg ICAgICAgcmVzdWx0ID0gZnJhbWUtPmV2ZW50SGFuZGxlcigpLT5oaXRUZXN0UmVzdWx0QXRQb2lu dChwb2ludCwgZmFsc2UpOworICAgIH0KICAgICAKICAgICBpZiAoIXJlc3VsdC5pbm5lck5vblNo YXJlZE5vZGUoKSkKICAgICAgICAgcmV0dXJuOwpAQCAtMzA0LDMgKzMxMCw0IEBAIHZvaWQgQ29u dGV4dE1lbnVDb250cm9sbGVyOjpjb250ZXh0TWVudUkKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2Vi Q29yZQorCg== 26309 2008-12-29 20:21:37 -0800 2008-12-29 21:01:43 -0800 Patch #2 bugfix_22968.txt text/plain 1589 jroesslein bmRleDogV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFuZ2VMb2cJ KHJldmlzaW9uIDM5NDQwKQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAg LTEsMyArMSwxMyBAQAorMjAwOC0xMi0yMiAgVS1KT1NILUxBUFRPUFxKb3NoICA8c2V0IEVNQUlM X0FERFJFU1MgZW52aXJvbm1lbnQgdmFyaWFibGU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZXM6IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMjk2OAorICAgICAgICBDb250ZXh0IG1lbnUgcmVuZGVyaW5nIGVycm9y IHdoZW4gZnVsbCBwYWdlIHpvb21lZAorCisgICAgICAgICogcGFnZS9Db250ZXh0TWVudUNvbnRy b2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29udGV4dE1lbnVDb250cm9sbGVyOjpoYW5k bGVDb250ZXh0TWVudUV2ZW50KToKKwogMjAwOC0xMi0yMiAgRGhhbmFuam95IENodXRpYSAgPGRo YW5yZEBnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgS2lsemVyLgpJbmRl eDogV2ViQ29yZS9wYWdlL0NvbnRleHRNZW51Q29udHJvbGxlci5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9wYWdlL0NvbnRleHRNZW51Q29udHJvbGxlci5jcHAJKHJldmlzaW9uIDM5NDM4KQor KysgV2ViQ29yZS9wYWdlL0NvbnRleHRNZW51Q29udHJvbGxlci5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTg2LDggKzg2LDE0IEBAIHZvaWQgQ29udGV4dE1lbnVDb250cm9sbGVyOjpoYW5kbGVDb250 ZXgKICAgICBJbnRQb2ludCBwb2ludCA9IEludFBvaW50KG1vdXNlRXZlbnQtPnBhZ2VYKCksIG1v dXNlRXZlbnQtPnBhZ2VZKCkpOwogICAgIEhpdFRlc3RSZXN1bHQgcmVzdWx0KHBvaW50KTsKIAot ICAgIGlmIChGcmFtZSogZnJhbWUgPSBldmVudC0+dGFyZ2V0KCktPnRvTm9kZSgpLT5kb2N1bWVu dCgpLT5mcmFtZSgpKQorICAgIGlmIChGcmFtZSogZnJhbWUgPSBldmVudC0+dGFyZ2V0KCktPnRv Tm9kZSgpLT5kb2N1bWVudCgpLT5mcmFtZSgpKSB7CisgICAgICAgIGZsb2F0IHpvb21GYWN0b3Ig PSBmcmFtZS0+cGFnZVpvb21GYWN0b3IoKTsKKyAgICAgICAgcG9pbnQuc2V0WChzdGF0aWNfY2Fz dDxpbnQ+KHBvaW50LngoKSAqIHpvb21GYWN0b3IpKTsKKyAgICAgICAgcG9pbnQuc2V0WShzdGF0 aWNfY2FzdDxpbnQ+KHBvaW50LnkoKSAqIHpvb21GYWN0b3IpKTsKICAgICAgICAgcmVzdWx0ID0g ZnJhbWUtPmV2ZW50SGFuZGxlcigpLT5oaXRUZXN0UmVzdWx0QXRQb2ludChwb2ludCwgZmFsc2Up OworICAgIH0KICAgICAKICAgICBpZiAoIXJlc3VsdC5pbm5lck5vblNoYXJlZE5vZGUoKSkKICAg ICAgICAgcmV0dXJuOwpAQCAtMzA0LDMgKzMxMCw0IEBAIHZvaWQgQ29udGV4dE1lbnVDb250cm9s bGVyOjpjb250ZXh0TWVudUkKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQorCgo=