229677 2021-08-30 11:11:36 -0700 [LFC][IFC] Remove unused variables after r281744 2021-08-30 14:31:13 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 lmoura lmoura darin webkit-bug-importer oldest_to_newest 1788580 0 lmoura 2021-08-30 11:11:36 -0700 [LFC][IFC] Remove unused variables after r281744 1788583 1 436796 lmoura 2021-08-30 11:13:10 -0700 Created attachment 436796 Patch 1788643 2 ews-feeder 2021-08-30 13:44:08 -0700 Committed r281773 (241110@main): <https://commits.webkit.org/241110@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436796. 1788645 3 webkit-bug-importer 2021-08-30 13:45:23 -0700 <rdar://problem/82544774> 1788663 4 436796 darin 2021-08-30 14:31:13 -0700 Comment on attachment 436796 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436796&action=review > Source/WebCore/display/css/DisplayBoxFactory.cpp:148 > + UNUSED_PARAM(lineGeometry); Post-review/landing regret: I should have suggested removing the argument name instead of using UNUSED_PARAM! 436796 2021-08-30 11:13:10 -0700 2021-08-30 13:44:08 -0700 Patch bug-229677-20210830151309.patch text/plain 1775 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxNzY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODI5YTZkODNlNjk5MjNj YzUzNTNhMjk3MjBmNGYxMWQwYmE5OTg0MC4uYTljMTgyOTVjNDE4OWY2NWM5ZjM0ODNmNmVlZGUy YWZiZmQ4OTVmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA4LTMwICBMYXVy byBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtMRkNdW0lGQ10gUmVtb3Zl IHVudXNlZCB2YXJpYWJsZXMgYWZ0ZXIgcjI4MTc0NAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5Njc3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgU2lsZW5jZSBjb21waWxlciB3YXJuaW5ncy4KKworICAg ICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogZGlzcGxheS9jc3Mv RGlzcGxheUJveEZhY3RvcnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RGlzcGxheTo6Qm94RmFj dG9yeTo6ZGlzcGxheUJveEZvclRleHRSdW4gY29uc3QpOgorCiAyMDIxLTA4LTMwICBBbGFuIEJ1 anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbSUZDXVtJbnRlZ3JhdGlvbl0gUmVt b3ZlIHVudXNlZCBiaWRpIGhhbmRsaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kaXNw bGF5L2Nzcy9EaXNwbGF5Qm94RmFjdG9yeS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kaXNwbGF5L2Nz cy9EaXNwbGF5Qm94RmFjdG9yeS5jcHAKaW5kZXggMjM2YjllNzhhMWU4NmZkMzVhOTlkMjVhYmUx MzA4NzUzYTRiNDllMi4uOTcwMGI2YzM0YzY3YzkzNjQ5ZTQ2ZmNlZmVlMmY3MTZmM2FlZjBkZCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZGlzcGxheS9jc3MvRGlzcGxheUJveEZhY3Rvcnku Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Rpc3BsYXkvY3NzL0Rpc3BsYXlCb3hGYWN0b3J5LmNw cApAQCAtMTQ1LDkgKzE0NSw4IEBAIHN0ZDo6dW5pcXVlX3B0cjxCb3g+IEJveEZhY3Rvcnk6OmRp c3BsYXlCb3hGb3JMYXlvdXRCb3goY29uc3QgTGF5b3V0OjpCb3gmIGxheW91CiAKIHN0ZDo6dW5p cXVlX3B0cjxCb3g+IEJveEZhY3Rvcnk6OmRpc3BsYXlCb3hGb3JUZXh0UnVuKGNvbnN0IExheW91 dDo6TGluZVJ1biYgcnVuLCBjb25zdCBMYXlvdXQ6OkxpbmVHZW9tZXRyeSYgbGluZUdlb21ldHJ5 LCBjb25zdCBDb250YWluaW5nQmxvY2tDb250ZXh0JiBjb250YWluaW5nQmxvY2tDb250ZXh0KSBj b25zdAogeworICAgIFVOVVNFRF9QQVJBTShsaW5lR2VvbWV0cnkpOwogICAgIEFTU0VSVChydW4u dGV4dCgpKTsKLSAgICBhdXRvIGxpbmVSZWN0ID0gbGluZUdlb21ldHJ5LmxpbmVCb3hMb2dpY2Fs UmVjdCgpOwotICAgIGF1dG8gbGluZUxheW91dFJlY3QgPSBMYXlvdXRSZWN0IHsgbGluZVJlY3Qu bGVmdCgpLCBsaW5lUmVjdC50b3AoKSwgbGluZVJlY3Qud2lkdGgoKSwgbGluZVJlY3QuaGVpZ2h0 KCkgfTsKIAogICAgIGF1dG8gcnVuUmVjdCA9IExheW91dFJlY3QgeyBydW4ubG9naWNhbExlZnQo KSwgcnVuLmxvZ2ljYWxUb3AoKSwgcnVuLmxvZ2ljYWxXaWR0aCgpLCBydW4ubG9naWNhbEhlaWdo dCgpIH07CiAgICAgcnVuUmVjdC5tb3ZlKGNvbnRhaW5pbmdCbG9ja0NvbnRleHQub2Zmc2V0RnJv bVJvb3QpOwo=