229660 2021-08-29 17:38:02 -0700 SubmitEvent.submitter property isn't set for <button type="submit"> 2021-08-30 11:31:19 -0700 1 1 1 Unclassified WebKit Forms Safari Technology Preview Mac (Intel) macOS 11 RESOLVED FIXED InRadar P2 Normal --- 202978 1 gilmoreorless cdumez achristensen akeerthi cdumez changseok darin esprehn+autocc ews-watchlist ggaren gyuyoung.kim rniwa sam webkit-bug-importer wenson_hsieh youennf oldest_to_newest 1788425 0 436753 gilmoreorless 2021-08-29 17:38:02 -0700 Created attachment 436753 Reduced test case I was testing out the new `SubmitEvent` interface implemented in Bug 202978, using Tech Preview 130. It appears to only be filling in the `submitter` property when a form is submitted with `<input type="submit">` but not `<button type="submit">`. I've attached a simple HTML page that shows the problem. All the test cases work correctly in Chrome and Firefox, but the `<button type="submit">` case fails in Safari Tech Preview 130. I tried to test the latest raw WebKit build but couldn't run it due to Bug 228060. 1788502 1 cdumez 2021-08-30 08:11:18 -0700 Thanks for the bug report and the test case. I'll fix. 1788509 2 436775 cdumez 2021-08-30 08:24:14 -0700 Created attachment 436775 Patch 1788589 3 ews-feeder 2021-08-30 11:30:30 -0700 Committed r281770 (241107@main): <https://commits.webkit.org/241107@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436775. 1788590 4 webkit-bug-importer 2021-08-30 11:31:19 -0700 <rdar://problem/82538108> 436753 2021-08-29 17:38:02 -0700 2021-08-29 17:38:02 -0700 Reduced test case webkit-submitevent-bug.html text/html 1576 gilmoreorless PCFET0NUWVBFIGh0bWw+CjxodG1sIGxhbmc9ImVuIj4KPGhlYWQ+CiAgPG1ldGEgY2hhcnNldD0i dXRmLTgiPgogIDx0aXRsZT5TdWJtaXRFdmVudCB0ZXN0IGZvcm08L3RpdGxlPgo8L2hlYWQ+Cjxi b2R5PgogIDxmb3JtIG5hbWU9InR3by1pbnB1dHMiIGFjdGlvbj0iIiBtZXRob2Q9IkdFVCI+CiAg ICA8aDM+PGNvZGU+Jmx0O2lucHV0IHR5cGU9InN1Ym1pdCImZ3Q7PC9jb2RlPjwvaDM+CiAgICA8 aW5wdXQgdHlwZT0idGV4dCIgbmFtZT0idGl0bGUiIHZhbHVlPSIyIGlucHV0cyI+CiAgICA8aW5w dXQgdHlwZT0ic3VibWl0IiBuYW1lPSJhY3Rpb24iIHZhbHVlPSJwdWJsaXNoIj4KICAgIDxpbnB1 dCB0eXBlPSJzdWJtaXQiIG5hbWU9ImFjdGlvbiIgdmFsdWU9ImRyYWZ0Ij4KICAgIDxwPuKchSA8 Y29kZT5zdWJtaXR0ZXI8L2NvZGU+IHNob3VsZCBjb250YWluIG9uZSBvZiB0aGUgdHdvIGlucHV0 cy48L3A+CiAgPC9mb3JtPgoKICA8aHI+CiAgPGZvcm0gbmFtZT0idHdvLWJ1dHRvbnMiIGFjdGlv bj0iIiBtZXRob2Q9IkdFVCI+CiAgICA8aDM+PGNvZGU+Jmx0O2J1dHRvbiB0eXBlPSJzdWJtaXQi Jmd0OzwvY29kZT48L2gzPgogICAgPGlucHV0IHR5cGU9InRleHQiIG5hbWU9InRpdGxlIiB2YWx1 ZT0iMiBidXR0b25zIj4KICAgIDxidXR0b24gdHlwZT0ic3VibWl0IiBuYW1lPSJhY3Rpb24iIHZh bHVlPSJwdWJsaXNoIj5QdWJsaXNoPC9idXR0b24+CiAgICA8YnV0dG9uIHR5cGU9InN1Ym1pdCIg bmFtZT0iYWN0aW9uIiB2YWx1ZT0iZHJhZnQiPlNhdmUgYXMgZHJhZnQ8L2J1dHRvbj4KICAgIDxw PuKdjCA8Y29kZT5zdWJtaXR0ZXI8L2NvZGU+IHNob3VsZCBjb250YWluIG9uZSBvZiB0aGUgdHdv IGJ1dHRvbnMuPC9wPgogIDwvZm9ybT4KCiAgPGhyPgogIDxmb3JtIG5hbWU9Im5vLXN1Ym1pdCIg YWN0aW9uPSIiIG1ldGhvZD0iR0VUIj4KICAgIDxoMz5ObyBzdWJtaXQgY29udHJvbHMgKGltcGxp Y2l0IHN1Ym1pc3Npb24gYnkgcHJlc3NpbmcgPGtiZD5FbnRlcjwva2JkPiBpbiB0aGUgdGV4dCBi b3gpPC9oMz4KICAgIDxpbnB1dCB0eXBlPSJ0ZXh0IiBuYW1lPSJ0aXRsZSIgdmFsdWU9Ik5vIHN1 Ym1pdCI+CiAgICA8cD7inIUgPGNvZGU+c3VibWl0dGVyPC9jb2RlPiBzaG91bGQgYmUgPGNvZGU+ bnVsbDwvY29kZT4uPC9wPgogIDwvZm9ybT4KCiAgPGhyPgogIDxwcmUgaWQ9ImRldGFpbHMiPjwv cHJlPgoKICA8c2NyaXB0PgogICAgY29uc3QgZGV0YWlscyA9IGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCdkZXRhaWxzJyk7CiAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcignc3VibWl0JywgKGV2 ZW50KSA9PiB7CiAgICAgIGNvbnNvbGUubG9nKCdTdWJtaXRFdmVudCcsIGV2ZW50KTsKICAgICAg ZXZlbnQucHJldmVudERlZmF1bHQoKTsKICAgICAgZGV0YWlscy50ZXh0Q29udGVudCA9IGAKZm9y bTogW25hbWU9JHtldmVudC50YXJnZXQubmFtZX1dLApzdWJtaXR0ZXI6ICR7ZXZlbnQuc3VibWl0 dGVyID8gZXZlbnQuc3VibWl0dGVyLm91dGVySFRNTCA6ICdudWxsJ30sCiAgICAgIGA7CiAgICB9 LCBmYWxzZSk7CiAgPC9zY3JpcHQ+CjwvYm9keT4KPC9odG1sPg== 436775 2021-08-30 08:24:14 -0700 2021-08-30 11:30:32 -0700 Patch bug-229660-20210830082413.patch text/plain 4249 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxNzA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2JkMjM2MWU2Y2VjNWIw MDc3ZThjZGU0MmE5ZDg0ZTMwYzJiNGNhYS4uYjEyOThhZDgyNzRlM2E5YmI3NTlkNDk3YTU5ZTI1 NTk2OTY0NmRhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTA4LTMwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU3VibWl0RXZlbnQuc3VibWl0 dGVyIHByb3BlcnR5IGlzbid0IHNldCBmb3IgPGJ1dHRvbiB0eXBlPSJzdWJtaXQiPgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5NjYwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBzdXJlIEhUTUxC dXR0b25FbGVtZW50OjpkZWZhdWx0RXZlbnRIYW5kbGVyKCkgcHJvcGVybHkgcGFzc2VzIHx0aGlz fCBhcyBzdWJtaXR0ZXIKKyAgICAgICAgd2hlbiBjYWxsaW5nIEhUTUxGb3JtRWxlbWVudDo6c3Vi bWl0SWZQb3NzaWJsZSgpLiBUaGlzIHdhcyBjYXVzaW5nIHRoZSBTdWJtaXRFdmVudC5zdWJtaXR0 ZXIKKyAgICAgICAgcHJvcGVydHkgdG8gbm90IGJlIHNldCB3aGVuIHN1Ym1pdHRpbmcgYSBmb3Jt IGJ5IGNsaWNraW5nIGEgYDxidXR0b24gdHlwZT0ic3VibWl0Ij5gLgorCisgICAgICAgIFRlc3Q6 IGZhc3QvZm9ybXMvc3VibWl0LWJ1dHRvbi1zdWJtaXQtZXZlbnQuaHRtbAorCisgICAgICAgICog aHRtbC9IVE1MQnV0dG9uRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MQnV0dG9u RWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcik6CisKIDIwMjEtMDgtMjcgIENocmlzIER1bWV6 ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBFbmFibGUgU2hhcmVkQXJyYXlCdWZmZXIg c3VwcG9ydCB3aGVuIENPT1AvQ09FUCBoZWFkZXJzIGFyZSB1c2VkCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxCdXR0b25FbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTEJ1dHRvbkVsZW1lbnQuY3BwCmluZGV4IDI4MTg0NWZhYzMyZmZkNzUwNDJhNDQ1ODZl OGY3OWRmNzg5ZGE0YjQuLjliYzUyMWYxNmNjOGFhOGNjZjA2NGVlNGFlN2QzNDliNGZkNDllMmUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEJ1dHRvbkVsZW1lbnQuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEJ1dHRvbkVsZW1lbnQuY3BwCkBAIC0xMzgsNyAr MTM4LDcgQEAgdm9pZCBIVE1MQnV0dG9uRWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcihFdmVu dCYgZXZlbnQpCiAgICAgICAgICAgICBpZiAoYXV0byBjdXJyZW50Rm9ybSA9IGZvcm0oKSkgewog ICAgICAgICAgICAgICAgIGlmIChtX3R5cGUgPT0gU1VCTUlUKSB7CiAgICAgICAgICAgICAgICAg ICAgIFNldEZvclNjb3BlPGJvb2w+IGFjdGl2YXRlZFN1Ym1pdFN0YXRlKG1faXNBY3RpdmF0ZWRT dWJtaXQsIHRydWUpOwotICAgICAgICAgICAgICAgICAgICBjdXJyZW50Rm9ybS0+c3VibWl0SWZQ b3NzaWJsZSgmZXZlbnQpOworICAgICAgICAgICAgICAgICAgICBjdXJyZW50Rm9ybS0+c3VibWl0 SWZQb3NzaWJsZSgmZXZlbnQsIHRoaXMpOwogICAgICAgICAgICAgICAgIH0KIAogICAgICAgICAg ICAgICAgIGlmIChtX3R5cGUgPT0gUkVTRVQpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOWY4OWVhYTkyNjhhOGUzYzMyZjY4 MWE3MDU3ODllMDQwNjA1Y2ZlZS4uMTYyNGFkODQyMjg3M2YxOTU2ZjVkMTNkNGM0OGJhZGMzZTg0 YmJlNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTA4LTMwICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU3VibWl0RXZlbnQuc3VibWl0dGVyIHByb3BlcnR5 IGlzbid0IHNldCBmb3IgPGJ1dHRvbiB0eXBlPSJzdWJtaXQiPgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5NjYwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGxheW91dCB0ZXN0IGNvdmVyYWdlLgor CisgICAgICAgICogZmFzdC9mb3Jtcy9zdWJtaXQtYnV0dG9uLXN1Ym1pdC1ldmVudC1leHBlY3Rl ZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZm9ybXMvc3VibWl0LWJ1dHRvbi1zdWJtaXQt ZXZlbnQuaHRtbDogQWRkZWQuCisKIDIwMjEtMDgtMjcgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFw cGxlLmNvbT4KIAogICAgICAgICBbV0syXSBSZXVzZSB0aGUgc2FtZSBuZXR3b3JrIGxvYWQgd2hl biBwcm9jZXNzLXN3YXBwaW5nIG9uIHJlc291cmNlIHJlc3BvbnNlIGR1ZSB0byBDT09QCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3N1Ym1pdC1idXR0b24tc3VibWl0LWV2ZW50 LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc3VibWl0LWJ1dHRvbi1zdWJt aXQtZXZlbnQtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjQ3MDVhOTI1MjEwMzFmYzA5MDgzMTUy NmJjMTAyNGFhYjQyOWE5ZWEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zv cm1zL3N1Ym1pdC1idXR0b24tc3VibWl0LWV2ZW50LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDEw IEBACitUZXN0cyB0aGF0IFN1Ym1pdEV2ZW50LnN1Ym1pdHRlciBwcm9wZXJ0eSBpcyBwcm9wZXJs eSBzZXQgZm9yIC4KK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIg bWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCisKK1BBU1Mgc3VibWl0 RXZlbnQuc3VibWl0dGVyIGlzIHRlc3RCdXR0b24KK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlz IHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zv cm1zL3N1Ym1pdC1idXR0b24tc3VibWl0LWV2ZW50Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zv cm1zL3N1Ym1pdC1idXR0b24tc3VibWl0LWV2ZW50Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMzAzNWQwMzIw MGZkNzM0YmZmMDgxYTZlZjBhMTcyMTljMmI1ZmZlOQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL2Zhc3QvZm9ybXMvc3VibWl0LWJ1dHRvbi1zdWJtaXQtZXZlbnQuaHRtbApAQCAtMCww ICsxLDI0IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGJvZHk+Cis8c2NyaXB0IHNyYz0i Li4vLi4vcmVzb3VyY2VzL2pzLXRlc3QuanMiPjwvc2NyaXB0PgorPGZvcm0gaWQ9InRlc3RGb3Jt IiBhY3Rpb249IiIgbWV0aG9kPSJHRVQiIHN0eWxlPSJkaXNwbGF5Om5vbmUiPgorPGlucHV0IHR5 cGU9InRleHQiIG5hbWU9InRpdGxlIiB2YWx1ZT0iZm9vIj4KKzxidXR0b24gdHlwZT0ic3VibWl0 IiBuYW1lPSJhY3Rpb24iIHZhbHVlPSJzdWJtaXQiIGlkPSJ0ZXN0QnV0dG9uIj5TdWJtaXQ8L2J1 dHRvbj4KKzwvZm9ybT4KKzxzY3JpcHQ+CitkZXNjcmlwdGlvbigiVGVzdHMgdGhhdCBTdWJtaXRF dmVudC5zdWJtaXR0ZXIgcHJvcGVydHkgaXMgcHJvcGVybHkgc2V0IGZvciA8YnV0dG9uIHR5cGU9 J3N1Ym1pdCc+LiIpOworanNUZXN0SXNBc3luYyA9IHRydWU7CisKK29ubG9hZCA9ICgpID0+IHsK KyAgICB0ZXN0QnV0dG9uID0gIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0ZXN0QnV0dG9uIik7 CisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3RGb3JtIikub25zdWJtaXQgPSAoX3N1 Ym1pdEV2ZW50KSA9PiB7CisgICAgICAgIHN1Ym1pdEV2ZW50ID0gX3N1Ym1pdEV2ZW50OworICAg ICAgICBzaG91bGRCZSgic3VibWl0RXZlbnQuc3VibWl0dGVyIiwgInRlc3RCdXR0b24iKTsKKyAg ICAgICAgZmluaXNoSlNUZXN0KCk7CisgICAgfTsKKyAgICB0ZXN0QnV0dG9uLmNsaWNrKCk7Cit9 OworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==