22964 2008-12-22 10:33:03 -0800 Build failure - QtWebKit with MinGW toolchain 2008-12-31 09:13:19 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 0 laszlo.gombos webkit-unassigned zecke oldest_to_newest 103193 0 laszlo.gombos 2008-12-22 10:33:03 -0800 WebCore/platform/graphics/qt/SimpleFontDataQt.cpp fails to compile; because the signature of the containsCharacter() function in the base class (SimpleFontData.h) does not match the the function signature in the derived class. 103194 1 26205 laszlo.gombos 2008-12-22 10:35:39 -0800 Created attachment 26205 Patch - fix Fix ! 103197 2 laszlo.gombos 2008-12-22 11:02:26 -0800 (In reply to comment #1) > Created an attachment (id=26205) [review] > Patch - fix > > Fix ! > The proposed fix reverses part of the change (1 line) that was made as part of Changeset 39207 - http://trac.webkit.org/changeset/39207/trunk/WebCore/platform/graphics/qt/SimpleFontDataQt.cpp Laszlo 103307 3 26205 zecke 2008-12-23 09:58:52 -0800 Comment on attachment 26205 Patch - fix > @@ -1,3 +1,14 @@ > +2008-12-22 Laszlo Gombos <laszlo.1.gombos@gmail.com> Any reason to not use the Nokia email address? 103309 4 laszlo.gombos 2008-12-23 10:26:22 -0800 (In reply to comment #3) > (From update of attachment 26205 [review]) > > > @@ -1,3 +1,14 @@ > > +2008-12-22 Laszlo Gombos <laszlo.1.gombos@gmail.com> > > Any reason to not use the Nokia email address? > Sorry, mistyped my e-mail. It should be laszlo.1.gombos@nokia.com Laszlo 103919 5 zecke 2008-12-31 09:13:19 -0800 Landed in r39530. 26205 2008-12-22 10:35:39 -0800 2008-12-23 09:58:52 -0800 Patch - fix patch_22964.txt text/plain 1130 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzOTQzNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDgtMTItMjIgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEZpeGVzOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5 NjQKKworICAgICAgICBNaW5HVyBidWlsZCBmYWlsdXJlLgorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvcXQvU2ltcGxlRm9udERhdGFRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTaW1w bGVGb250RGF0YTo6Y29udGFpbnNDaGFyYWN0ZXJzKToKKwogMjAwOC0xMi0yMiAgQWxleGV5IFBy b3NrdXJ5YWtvdiAgPGFwQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4g QWRsZXIuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L1NpbXBsZUZvbnREYXRh UXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvU2ltcGxl Rm9udERhdGFRdC5jcHAJKHJldmlzaW9uIDM5NDM1KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9xdC9TaW1wbGVGb250RGF0YVF0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzMsNyArMzMs NyBAQCB2b2lkIFNpbXBsZUZvbnREYXRhOjpkZXRlcm1pbmVQaXRjaCgpCiAgICAgbV90cmVhdEFz Rml4ZWRQaXRjaCA9IG1fZm9udC5mb250KCkuZml4ZWRQaXRjaCgpOwogfQogCi1ib29sIFNpbXBs ZUZvbnREYXRhOjpjb250YWluc0NoYXJhY3RlcnModW5zaWduZWQgc2hvcnQgY29uc3QqLCBpbnQp IGNvbnN0Citib29sIFNpbXBsZUZvbnREYXRhOjpjb250YWluc0NoYXJhY3RlcnMoY29uc3QgVUNo YXIqLCBpbnQgbGVuZ3RoKSBjb25zdAogewogICAgIHJldHVybiB0cnVlOwogfQo=