229636 2021-08-27 17:28:31 -0700 MessageArgumentDescriptions.cpp generator incorrectly strips std::optional<> from argument types 2021-08-27 23:04:46 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 heycam heycam darin webkit-bug-importer oldest_to_newest 1788249 0 heycam 2021-08-27 17:28:31 -0700 The substring indexes need updating. 1788250 1 webkit-bug-importer 2021-08-27 17:28:48 -0700 <rdar://problem/82461615> 1788253 2 436697 heycam 2021-08-27 17:33:40 -0700 Created attachment 436697 Patch 1788254 3 436697 darin 2021-08-27 17:43:34 -0700 Comment on attachment 436697 Patch Did I break this when moving from WTF::Optional to std::optional? If so, I wonder how because they are both the same length! 1788255 4 heycam 2021-08-27 17:51:04 -0700 I guess previously the WTF:: prefix must not have been used in the messages.in files? 1788280 5 ews-feeder 2021-08-27 23:04:44 -0700 Committed r281732 (241074@main): <https://commits.webkit.org/241074@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436697. 436697 2021-08-27 17:33:40 -0700 2021-08-27 23:04:45 -0700 Patch bug-229636-20210828103339.patch text/plain 2772 heycam U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxNTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDU0NmZjNDE5NTE1MzcxZDUx MTg2ZjkzNjZmOTY3YTM3MzU1ODhkODEuLmQ3NmFhM2QzNjVkYWI1YTIyYWEyZTQyNjkxODQyZWMz ZDk4NTk3MDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDgtMjcgIENhbWVyb24g TWNDb3JtYWNrICA8aGV5Y2FtQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggc3RkOjpvcHRpb25h bDw+IHN0cmlwcGluZyBpbiBNZXNzYWdlQXJndW1lbnREZXNjcmlwdGlvbnMuY3BwIGdlbmVyYXRv cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5NjM2 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84MjQ2MTYxNT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0L21lc3NhZ2VzLnB5 OgorICAgICAgICAoZ2VuZXJhdGVfanNfYXJndW1lbnRfZGVzY3JpcHRpb25zKToKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdC90ZXN0cy9NZXNzYWdlQXJndW1lbnREZXNjcmlwdGlvbnMuY3BwOgor ICAgICAgICAoSVBDOjptZXNzYWdlUmVwbHlBcmd1bWVudERlc2NyaXB0aW9ucyk6CisKIDIwMjEt MDgtMjMgIENhbWVyb24gTWNDb3JtYWNrICA8aGV5Y2FtQGFwcGxlLmNvbT4KIAogICAgICAgICBN YW51YWxseSByZWxlYXNlIFNoYXJlZEJpdG1hcCBpZiBDR0JpdG1hcENvbnRleHRDcmVhdGVXaXRo RGF0YSBmYWlscyBhbmQgZG9lc24ndCBkbyBpdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9T Y3JpcHRzL3dlYmtpdC9tZXNzYWdlcy5weSBiL1NvdXJjZS9XZWJLaXQvU2NyaXB0cy93ZWJraXQv bWVzc2FnZXMucHkKaW5kZXggNGNiMjBmNDgyODkwODg2MmUwNWZiNTg3ZWY1Y2FlYjhiZDRmZTky Yi4uZDQ0MDI1NWEyNDZlNzVkNmRmZWQ1ZTg4ZjcxZjVkNzgyM2NjNWRjOSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9TY3JpcHRzL3dlYmtpdC9tZXNzYWdlcy5weQorKysgYi9Tb3VyY2UvV2Vi S2l0L1NjcmlwdHMvd2Via2l0L21lc3NhZ2VzLnB5CkBAIC0xMjEwLDcgKzEyMTAsNyBAQCBkZWYg Z2VuZXJhdGVfanNfYXJndW1lbnRfZGVzY3JpcHRpb25zKHJlY2VpdmVycywgZnVuY3Rpb25fbmFt ZSwgYXJndW1lbnRzX2Zyb21fbQogICAgICAgICAgICAgICAgICAgICBlbnVtX3R5cGUgPSAnIiVz IicgJSBhcmd1bWVudF90eXBlCiAgICAgICAgICAgICAgICAgICAgIGFyZ3VtZW50X3R5cGUgPSBh cmd1bWVudC5raW5kWzU6XQogICAgICAgICAgICAgICAgIGlmIGFyZ3VtZW50X3R5cGUuc3RhcnRz d2l0aCgnc3RkOjpvcHRpb25hbDwnKSBhbmQgYXJndW1lbnRfdHlwZS5lbmRzd2l0aCgnPicpOgot ICAgICAgICAgICAgICAgICAgICBhcmd1bWVudF90eXBlID0gYXJndW1lbnRfdHlwZVs5Oi0xXQor ICAgICAgICAgICAgICAgICAgICBhcmd1bWVudF90eXBlID0gYXJndW1lbnRfdHlwZVsxNDotMV0K ICAgICAgICAgICAgICAgICAgICAgaXNfb3B0aW9uYWwgPSBUcnVlCiAgICAgICAgICAgICAgICAg cmVzdWx0LmFwcGVuZCgnICAgICAgICAgICAgeyIlcyIsICIlcyIsICVzLCAlc30sXG4nICUgKGFy Z3VtZW50Lm5hbWUsIGFyZ3VtZW50X3R5cGUsIGVudW1fdHlwZSBvciAnbnVsbHB0cicsICd0cnVl JyBpZiBpc19vcHRpb25hbCBlbHNlICdmYWxzZScpKQogICAgICAgICAgICAgcmVzdWx0LmFwcGVu ZCgnICAgICAgICB9O1xuJykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2NyaXB0cy93ZWJr aXQvdGVzdHMvTWVzc2FnZUFyZ3VtZW50RGVzY3JpcHRpb25zLmNwcCBiL1NvdXJjZS9XZWJLaXQv U2NyaXB0cy93ZWJraXQvdGVzdHMvTWVzc2FnZUFyZ3VtZW50RGVzY3JpcHRpb25zLmNwcAppbmRl eCBjMTBkODk4YzQyMTFlZTA1MThjMTAwN2ZjYmVkZDY5YTcxYmZmNmFlLi43ZDY0YjVlNDE2NjZi MmM0ZjQxYWU3NWRmZDY4NjY5YjgxOWMxYTI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1Nj cmlwdHMvd2Via2l0L3Rlc3RzL01lc3NhZ2VBcmd1bWVudERlc2NyaXB0aW9ucy5jcHAKKysrIGIv U291cmNlL1dlYktpdC9TY3JpcHRzL3dlYmtpdC90ZXN0cy9NZXNzYWdlQXJndW1lbnREZXNjcmlw dGlvbnMuY3BwCkBAIC02MzksNyArNjM5LDcgQEAgc3RkOjpvcHRpb25hbDxWZWN0b3I8QXJndW1l bnREZXNjcmlwdGlvbj4+IG1lc3NhZ2VSZXBseUFyZ3VtZW50RGVzY3JpcHRpb25zKE1lc3MKICAg ICAgICAgfTsKICAgICBjYXNlIE1lc3NhZ2VOYW1lOjpUZXN0V2l0aFN1cGVyY2xhc3NfVGVzdFN5 bmNocm9ub3VzTWVzc2FnZToKICAgICAgICAgcmV0dXJuIFZlY3RvcjxBcmd1bWVudERlc2NyaXB0 aW9uPiB7Ci0gICAgICAgICAgICB7Im9wdGlvbmFsUmVwbHkiLCAib25hbDxXZWJLaXQ6OlRlc3RD bGFzc05hbWUiLCBudWxscHRyLCB0cnVlfSwKKyAgICAgICAgICAgIHsib3B0aW9uYWxSZXBseSIs ICJXZWJLaXQ6OlRlc3RDbGFzc05hbWUiLCBudWxscHRyLCB0cnVlfSwKICAgICAgICAgfTsKICNp ZiAoRU5BQkxFKFdFQktJVDIpICYmIChORVNURURfTUFTVEVSX0NPTkRJVElPTiB8fCBNQVNURVJf T1IgJiYgTUFTVEVSX0FORCkpCiAgICAgY2FzZSBNZXNzYWdlTmFtZTo6VGVzdFdpdGhMZWdhY3lS ZWNlaXZlcl9HZXRQbHVnaW5Qcm9jZXNzQ29ubmVjdGlvbjoK