22963 2008-12-22 08:48:16 -0800 write icons before reading them 2009-01-02 18:36:13 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caryclark webkit-unassigned beidson ddkilzer oldest_to_newest 103182 0 caryclark 2008-12-22 08:48:16 -0800 Write the pending icons to the database before trying to read any requested icons to ensure that a requested icon has the correct data. 103183 1 26204 caryclark 2008-12-22 08:50:50 -0800 Created attachment 26204 reverse order of reading, writing icons to database 103399 2 26204 darin 2008-12-24 23:07:20 -0800 Comment on attachment 26204 reverse order of reading, writing icons to database Looks good. r=me 103523 3 ddkilzer 2008-12-27 03:12:14 -0800 Although this is a good fix, it doesn't appear to resolve the workaround for Bug 21026 in the layout test for Bug 22795. 104210 4 darin 2009-01-02 18:36:13 -0800 http://trac.webkit.org/changeset/39569 26204 2008-12-22 08:50:50 -0800 2008-12-24 23:07:20 -0800 reverse order of reading, writing icons to database patchForBug22963.txt text/plain 1536 caryclark SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzOTQzNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDgtMTItMjIgIENhcnkgQ2xhcmsgIDxjYXJ5Y2xhcmtAZ29vZ2xl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBX QVJOSU5HOiBOTyBURVNUIENBU0VTIEFEREVEIE9SIENIQU5HRUQKKworICAgICAgICBSZXZlcnNl IHRoZSBvcmRlciBpbiB0aGUgaWNvbiBkYXRhYmFzZSBtYWluIHRocmVhZCBsb29wIHRvCisgICAg ICAgIHdyaXRlIHRoZSBwZW5kaW5nIGljb25zIHRvIHRoZSBkYXRhYmFzZSBiZWZvcmUgdHJ5aW5n CisgICAgICAgIHRvIHJlYWQgYW55IHJlcXVlc3RlZCBpY29ucy4gVGhpcyBlbnN1cmVzIHRoYXQg YSByZXF1ZXN0ZWQgaWNvbiAKKyAgICAgICAgaGFzIHRoZSBjb3JyZWN0IGRhdGEgd2hlbiByZWFk LgorICAgICAgICAKKyAgICAgICAgKiBsb2FkZXIvaWNvbi9JY29uRGF0YWJhc2UuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6SWNvbkRhdGFiYXNlOjpzeW5jVGhyZWFkTWFpbkxvb3ApOgorCiAyMDA4 LTEyLTIyICBOaWtvbGFzIFppbW1lcm1hbm4gIDxuaWtvbGFzLnppbW1lcm1hbm5AdG9yY2htb2Jp bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YgJiBHZW9y Z2UgU3RhaWtvcy4KSW5kZXg6IFdlYkNvcmUvbG9hZGVyL2ljb24vSWNvbkRhdGFiYXNlLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJDb3JlL2xvYWRlci9pY29uL0ljb25EYXRhYmFzZS5jcHAJKHJldmlz aW9uIDM5NDM2KQorKysgV2ViQ29yZS9sb2FkZXIvaWNvbi9JY29uRGF0YWJhc2UuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xMzUwLDExICsxMzUwLDExIEBAIHZvaWQqIEljb25EYXRhYmFzZTo6c3lu Y1RocmVhZE1haW5Mb29wKCkKICAgICAgICAgCiAgICAgICAgIGJvb2wgZGlkQW55V29yayA9IHRy dWU7CiAgICAgICAgIHdoaWxlIChkaWRBbnlXb3JrKSB7Ci0gICAgICAgICAgICBkaWRBbnlXb3Jr ID0gcmVhZEZyb21EYXRhYmFzZSgpOworICAgICAgICAgICAgYm9vbCBkaWRXcml0ZSA9IHdyaXRl VG9EYXRhYmFzZSgpOwogICAgICAgICAgICAgaWYgKHNob3VsZFN0b3BUaHJlYWRBY3Rpdml0eSgp KQogICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAgIAotICAgICAgICAgICAg Ym9vbCBkaWRXcml0ZSA9IHdyaXRlVG9EYXRhYmFzZSgpOworICAgICAgICAgICAgZGlkQW55V29y ayA9IHJlYWRGcm9tRGF0YWJhc2UoKTsKICAgICAgICAgICAgIGlmIChzaG91bGRTdG9wVGhyZWFk QWN0aXZpdHkoKSkKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgICAgICAK