229629 2021-08-27 13:55:13 -0700 Changed ARM64 probe trampoline to do ptr auth the standard way. 2021-08-27 14:18:44 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=229618 InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1788152 0 mark.lam 2021-08-27 13:55:13 -0700 Make it check a pointer auth the same way Clang does it. 1788154 1 webkit-bug-importer 2021-08-27 13:56:33 -0700 <rdar://problem/82453220> 1788164 2 436672 mark.lam 2021-08-27 14:10:22 -0700 Created attachment 436672 proposed patch. 1788168 3 mark.lam 2021-08-27 14:17:00 -0700 Thanks for the review. Landed in r281720: <http://trac.webkit.org/r281720>. 1788169 4 mark.lam 2021-08-27 14:18:25 -0700 This patch also fixes a regression introduced in r281718 landed for https://bugs.webkit.org/show_bug.cgi?id=229618. 436672 2021-08-27 14:10:22 -0700 2021-08-27 14:14:02 -0700 proposed patch. bug-229629.patch text/plain 3077 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjgxNzE4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDIxLTA4LTI3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBD aGFuZ2VkIEFSTTY0IHByb2JlIHRyYW1wb2xpbmUgdG8gZG8gcHRyIGF1dGggdGhlIHN0YW5kYXJk IHdheS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIy OTYyOQorICAgICAgICByZGFyOi8vcHJvYmxlbS84MjQ1MzIyMAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsc28gZml4IGEgY29tbWVudCwgYW5kIGFk ZCBiYWNrIDIgbGluZXMgdGhhdCBJIGFjY2lkZW50YWxseSBkZWxldGVkIGluIHIyODE3MTguCisK KyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk02NC5jcHA6CisKIDIwMjEtMDgt MjcgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgQVJNNjQg YW5kIFg4Nl82NCBwcm9iZSBjb2RlIGEgbGl0dGxlIGJpdCBtb3JlIGVmZmljaWVudC4KSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk02NC5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2Vt YmxlckFSTTY0LmNwcAkocmV2aXNpb24gMjgxNzE4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTTY0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTAw LDcgKzUwMCw3IEBAIGFzbSAoCiAgICAgLy8gcmV0dXJucy4gU28sIHRoZSBBUk02NCBwcm9iZSBp bXBsZW1lbnRhdGlvbiB3aWxsIGFsbG93IHRoZSBwcm9iZSBoYW5kbGVyIHRvCiAgICAgLy8gZWl0 aGVyIG1vZGlmeSBsciBvciBwYywgYnV0IG5vdCBib3RoIGluIHRoZSBzYW1lIHByb2JlIGludm9j YXRpb24uIFRoZSBwcm9iZQogICAgIC8vIG1lY2hhbmlzbSBlbnN1cmVzIHRoYXQgd2UgbmV2ZXIg dHJ5IHRvIG1vZGlmeSBib3RoIGxyIGFuZCBwYyB3aXRoIGEgUkVMRUFTRV9BU1NFUlQKLSAgICAv LyBpbiBQcm9iZTo6KCkuCisgICAgLy8gaW4gUHJvYmU6OmV4ZWN1dGVKU0NKSVRQcm9iZSgpLgog CiAgICAgLy8gRGV0ZXJtaW5lIGlmIHRoZSBwcm9iZSBoYW5kbGVyIGNoYW5nZWQgdGhlIHBjLgog ICAgICJsZHIgICAgICAgeDMwLCBbc3AsICMiIFNUUklOR0laRV9WQUxVRV9PRihQUk9CRV9DUFVf U1BfT0ZGU0VUKSAiXSIgIlxuIiAvLyBwcmVsb2FkIHRoZSB0YXJnZXQgc3AuCkBAIC01MjEsMTAg KzUyMSwxMiBAQCBhc20gKAogI2lmIENQVShBUk02NEUpCiAgICAgIm1vdnogICAgICB4MjgsICMi IFNUUklOR0laRV9WQUxVRV9PRihKSVRfUFJPQkVfUENfUFRSX1RBRykgIlxuIgogICAgICJhdXRp YiAgICAgeDI3LCB4MjgiICJcbiIKLSAgICAibHNyICAgICAgIHgyOCwgeDI3LCAjOCIgIlxuIgot ICAgICJhbmQgICAgICAgeDI4LCB4MjgsICMweGZmMDAwMDAwMDAwMDAwIiAiXG4iCi0gICAgIm9y ciAgICAgICB4MjgsIHgyOCwgeDI3IiAiXG4iCi0gICAgImxkcmIgICAgICB3MjgsIFt4MjhdIiAi XG4iCisgICAgIm1vdiAgICAgICB4MjgsIHgyNyIgIlxuIgorICAgICJ4cGFjaSAgICAgeDI4IiAi XG4iCisgICAgImNtcCAgICAgICB4MjgsIHgyNyIgIlxuIgorICAgICJiZXEgICAgICIgTE9DQUxf TEFCRUxfU1RSSU5HKGN0aU1hc21Qcm9iZVRyYW1wb2xpbmVQQ0F1dGhEb25lKSAiXG4iCisgICAg ImJyayAgICAgICAjMHhjNDcxIiAiXG4iCisgICAgTE9DQUxfTEFCRUxfU1RSSU5HKGN0aU1hc21Q cm9iZVRyYW1wb2xpbmVQQ0F1dGhEb25lKSAiOiIgIlxuIgogI2VuZGlmCiAgICAgInN1YiAgICAg ICB4MjcsIHgyNywgIyIgU1RSSU5HSVpFX1ZBTFVFX09GKDIgKiBHUFJFR19TSVpFKSAiXG4iIC8v IFRoZSByZXR1cm4gcG9pbnQgUEMgaXMgYXQgMiBpbnN0cnVjdGlvbnMgYmVmb3JlIHRoZSBlbmQg b2YgdGhlIHByb2JlLgogI2lmIENQVShBUk02NEUpCkBAIC01NDYsMTAgKzU0OCwxNCBAQCBhc20g KAogI2lmIENQVShBUk02NEUpCiAgICAgIm1vdnogICAgICB4MjcsICMiIFNUUklOR0laRV9WQUxV RV9PRihKSVRfUFJPQkVfUENfUFRSX1RBRykgIlxuIgogICAgICJhdXRpYiAgICAgeDI4LCB4Mjci ICJcbiIKLSAgICAibHNyICAgICAgIHgyNywgeDI4LCAjOCIgIlxuIgotICAgICJhbmQgICAgICAg eDI3LCB4MjcsICMweGZmMDAwMDAwMDAwMDAwIiAiXG4iCi0gICAgIm9yciAgICAgICB4MjcsIHgy NywgeDI4IiAiXG4iCi0gICAgImxkcmIgICAgICB3MjcsIFt4MjddIiAiXG4iCisgICAgIm1vdiAg ICAgICB4MjcsIHgyOCIgIlxuIgorICAgICJ4cGFjaSAgICAgeDI3IiAiXG4iCisgICAgImNtcCAg ICAgICB4MjcsIHgyOCIgIlxuIgorICAgICJiZXEgICAgICIgTE9DQUxfTEFCRUxfU1RSSU5HKGN0 aU1hc21Qcm9iZVRyYW1wb2xpbmVQQ0F1dGhEb25lMikgIlxuIgorICAgICJicmsgICAgICAgIzB4 YzQ3MSIgIlxuIgorICAgIExPQ0FMX0xBQkVMX1NUUklORyhjdGlNYXNtUHJvYmVUcmFtcG9saW5l UENBdXRoRG9uZTIpICI6IiAiXG4iCisgICAgImFkZCAgICAgICB4MjcsIHgzMCwgIzQ4IiAiXG4i IC8vIENvbXB1dGUgc3AgYXQgcmV0dXJuIHBvaW50LgorICAgICJwYWNpYiAgICAgeDI4LCB4Mjci ICJcbiIKICNlbmRpZgogICAgICJsZHIgICAgICAgeDI3LCBbc3AsICMiIFNUUklOR0laRV9WQUxV RV9PRihQUk9CRV9DUFVfRlBfT0ZGU0VUKSAiXSIgIlxuIgogICAgICJzdHAgICAgICAgeDI3LCB4 MjgsIFt4MzAsICMiIFNUUklOR0laRV9WQUxVRV9PRihPVVRfRlBfT0ZGU0VUKSAiXSIgIlxuIgo=