229607 2021-08-27 06:25:49 -0700 [GTK][WPE] Add ICU 63.1 to JHBuild minimal dependencies 2022-09-28 04:07:04 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=229608 https://bugs.webkit.org/show_bug.cgi?id=245777 InRadar P2 Normal --- 1 dpino dpino clopez webkit-bug-importer oldest_to_newest 1788000 0 dpino 2021-08-27 06:25:49 -0700 [GTK][WPE] Add ICU 63.1 to JHBuild minimal dependencies 1788001 1 436620 dpino 2021-08-27 06:26:26 -0700 Created attachment 436620 Patch 1788002 2 dpino 2021-08-27 06:33:40 -0700 r281375 introduced a function available only in ICU 61. Ubuntu 18.04 uses ICU systems libraries, which is version 60. Thus, compilation of WebKitGTK and WPE in Ubuntu 18.04 has been failing since then. After discussing this with other WebKitGTK/WPE maintainers we think the best solution is to add ICU v63.1 to the list of minimal dependencies. 1788004 3 436620 clopez 2021-08-27 06:53:14 -0700 Comment on attachment 436620 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436620&action=review > Tools/jhbuild/jhbuild-minimal.modules:96 > + <autotools id="icu" > + autogen-sh="./source/configure" > + autogenargs="--disable-samples --enable-weak-threads"> > + <branch module="icu4c-63_1-src.tgz" version="63.1" checkoutdir="icu" > + repo="webkitgtk-jhbuild-mirror" > + hash="sha256:05c490b69454fce5860b7e8e2821231674af0a11d7ef2febea9a32512998cb9d"> > + <patch file="icudata-stdlibs.patch" strip="1"/> > + </branch> > + </autotools> The idea of the minimal jhbuild moduleset is to use the version of the system is if is new enough. To achieve that we declare how to build the minimum version needed of the library, and in this case the minimum version is ICU 61 and not 63. Also we need a <pkg-config> entry to tell jhbuild to look for the .pc file and use the system version if is new enough. Please consider this version of patch: http://sprunge.us/iyZbDk (it works for me to fix the build) 1788236 4 436693 dpino 2021-08-27 16:59:02 -0700 Created attachment 436693 Patch 1788439 5 ews-feeder 2021-08-29 22:01:27 -0700 Committed r281752 (241094@main): <https://commits.webkit.org/241094@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436693. 1788440 6 webkit-bug-importer 2021-08-29 22:02:20 -0700 <rdar://problem/82509895> 436620 2021-08-27 06:26:26 -0700 2021-08-27 16:58:53 -0700 Patch bug-229607-20210827212623.patch text/plain 3469 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxNjczCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWY0ZjFkZTNiNDMyNmRiZWIyMGNkZGI0OWJiOTY0NjFh YzYzYTMwMC4uZjEyYzcwODUzY2RiNzFjYTNmY2E5ZTg1OTg4YWJkZWJjODljYWZmYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDIxLTA4LTI3ICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisK KyAgICAgICAgW0dUS11bV1BFXSBBZGQgSUNVIDYzLjEgdG8gSkhCdWlsZCBtaW5pbWFsIGRlcGVu ZGVuY2llcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjI5NjA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBqaGJ1aWxkL2poYnVpbGQtbWluaW1hbC5tb2R1bGVzOgorICAgICAgICAqIGpoYnVpbGQvcGF0 Y2hlcy9pY3VkYXRhLXN0ZGxpYnMucGF0Y2g6IEFkZGVkLgorCiAyMDIxLTA4LTI2ICBKb25hdGhh biBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICBba2lsbC1vbGQtcHJvY2Vz c2VzXSBJbnZva2Ugd2l0aCBQeXRob24gMwpkaWZmIC0tZ2l0IGEvVG9vbHMvamhidWlsZC9qaGJ1 aWxkLW1pbmltYWwubW9kdWxlcyBiL1Rvb2xzL2poYnVpbGQvamhidWlsZC1taW5pbWFsLm1vZHVs ZXMKaW5kZXggZGM3ZWUzNmI5NjlmNjQ5MGQ5NmRmNGQ1MzEwZTZiODExMjRhNGE5NC4uNDhjZTI1 N2M1Zjk3NjgzNWUyMWIwZDcxMzNmZjM3ZDQ3ZTJhY2NkNSAxMDA2NDQKLS0tIGEvVG9vbHMvamhi dWlsZC9qaGJ1aWxkLW1pbmltYWwubW9kdWxlcworKysgYi9Ub29scy9qaGJ1aWxkL2poYnVpbGQt bWluaW1hbC5tb2R1bGVzCkBAIC02LDYgKzYsNyBAQAogICA8bWV0YW1vZHVsZSBpZD0id2Via2l0 Z3RrLW1pbmltYWwtZGVwZW5kZW5jaWVzIj4KICAgICA8ZGVwZW5kZW5jaWVzPgogICAgICAgPGRl cCBwYWNrYWdlPSJ3cGViYWNrZW5kLWZkbyIvPgorICAgICAgPGRlcCBwYWNrYWdlPSJpY3UiLz4K ICAgICAgIDxkZXAgcGFja2FnZT0ibGlic291cCIvPgogICAgICAgPGRlcCBwYWNrYWdlPSJtYW5l dHRlIi8+CiAgICAgICA8ZGVwIHBhY2thZ2U9ImxpYnZweCIvPgpAQCAtMTUsNiArMTYsNyBAQAog ICA8bWV0YW1vZHVsZSBpZD0id2Via2l0d3BlLW1pbmltYWwtZGVwZW5kZW5jaWVzIj4KICAgICA8 ZGVwZW5kZW5jaWVzPgogICAgICAgPGRlcCBwYWNrYWdlPSJ3cGViYWNrZW5kLWZkbyIvPgorICAg ICAgPGRlcCBwYWNrYWdlPSJpY3UiLz4KICAgICAgIDxkZXAgcGFja2FnZT0ibGlic291cCIvPgog ICAgICAgPGRlcCBwYWNrYWdlPSJvcGVueHIiLz4KICAgICAgIDxkZXAgcGFja2FnZT0ibGlidnB4 Ii8+CkBAIC04Myw2ICs4NSwxNiBAQAogICAgIDwvYnJhbmNoPgogICA8L2NtYWtlPgogCisgIDxh dXRvdG9vbHMgaWQ9ImljdSIKKyAgICAgICAgICAgICBhdXRvZ2VuLXNoPSIuL3NvdXJjZS9jb25m aWd1cmUiCisgICAgICAgICAgICAgYXV0b2dlbmFyZ3M9Ii0tZGlzYWJsZS1zYW1wbGVzIC0tZW5h YmxlLXdlYWstdGhyZWFkcyI+CisgICAgPGJyYW5jaCBtb2R1bGU9ImljdTRjLTYzXzEtc3JjLnRn eiIgdmVyc2lvbj0iNjMuMSIgY2hlY2tvdXRkaXI9ImljdSIKKyAgICAgICAgICAgIHJlcG89Indl YmtpdGd0ay1qaGJ1aWxkLW1pcnJvciIKKyAgICAgICAgICAgIGhhc2g9InNoYTI1NjowNWM0OTBi Njk0NTRmY2U1ODYwYjdlOGUyODIxMjMxNjc0YWYwYTExZDdlZjJmZWJlYTlhMzI1MTI5OThjYjlk Ij4KKyAgICAgIDxwYXRjaCBmaWxlPSJpY3VkYXRhLXN0ZGxpYnMucGF0Y2giIHN0cmlwPSIxIi8+ CisgICAgPC9icmFuY2g+CisgIDwvYXV0b3Rvb2xzPgorCiAgIDwhLS0gbGlic291cCA+PSAyLjY5 IHJlcXVpcmVkIGZvciBTYW1lU2l0ZSBjb29raWUgc3VwcG9ydCAtLT4KICAgPG1lc29uIGlkPSJs aWJzb3VwIiBtZXNvbmFyZ3M9Ii1EaW50cm9zcGVjdGlvbj1kaXNhYmxlZCAtRGdzc2FwaT1kaXNh YmxlZCAtRHZhcGk9ZGlzYWJsZWQgLUR0ZXN0cz1mYWxzZSI+CiAgICAgPHBrZy1jb25maWc+bGli c291cC0yLjQucGM8L3BrZy1jb25maWc+CkBAIC05OCw2ICsxMTAsOSBAQAogCiAgIDxhdXRvdG9v bHMgaWQ9ImxpYnBzbCIgYXV0b2dlbmFyZ3M9Ii0tZW5hYmxlLXJ1bnRpbWU9bGliaWN1IC0tZW5h YmxlLWJ1aWx0aW49bGliaWN1Ij4KICAgICA8cGtnLWNvbmZpZz5saWJwc2wucGM8L3BrZy1jb25m aWc+CisgICAgPGRlcGVuZGVuY2llcz4KKyAgICAgIDxkZXAgcGFja2FnZT0iaWN1Ii8+CisgICAg PC9kZXBlbmRlbmNpZXM+CiAgICAgPGJyYW5jaCBtb2R1bGU9InJvY2tkYWJvb3QvbGlicHNsL3Jl bGVhc2VzL2Rvd25sb2FkL2xpYnBzbC0ke3ZlcnNpb259L2xpYnBzbC0ke3ZlcnNpb259LnRhci5n eiIKICAgICAgICAgICAgIHZlcnNpb249IjAuMjAuMiIKICAgICAgICAgICAgIHJlcG89ImdpdGh1 Yi10YXJiYWxsIgpkaWZmIC0tZ2l0IGEvVG9vbHMvamhidWlsZC9wYXRjaGVzL2ljdWRhdGEtc3Rk bGlicy5wYXRjaCBiL1Rvb2xzL2poYnVpbGQvcGF0Y2hlcy9pY3VkYXRhLXN0ZGxpYnMucGF0Y2gK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uNWU5MmJkZWMxYjk1NTVkNGFiNjMyN2U1NTI1MmZlZjUyNTM2YTAyZgotLS0g L2Rldi9udWxsCisrKyBiL1Rvb2xzL2poYnVpbGQvcGF0Y2hlcy9pY3VkYXRhLXN0ZGxpYnMucGF0 Y2gKQEAgLTAsMCArMSwxNSBAQAorSW5kZXg6IGljdS01Mn5tMS9zb3VyY2UvY29uZmlnL21oLWxp bnV4Cis9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09CistLS0gaWN1LTUyfm0xLm9yaWcvc291cmNlL2NvbmZpZy9taC1saW51 eAkyMDEzLTA5LTE0IDE4OjUzOjIzLjI4NDA0MDQ2NyAtMDQwMAorKysrIGljdS01Mn5tMS9zb3Vy Y2UvY29uZmlnL21oLWxpbnV4CTIwMTMtMDktMTQgMTg6NTM6MjMuMjg0MDQwNDY3IC0wNDAwCitA QCAtMjEsNyArMjEsOSBAQAorIExEX1JQQVRIX1BSRSA9IC1XbCwtcnBhdGgsCisgCisgIyMgVGhl c2UgYXJlIHRoZSBsaWJyYXJ5IHNwZWNpZmljIExERkxBR1MKKy1MREZMQUdTSUNVRFQ9LW5vZGVm YXVsdGxpYnMgLW5vc3RkbGliCisrI0xERkxBR1NJQ1VEVD0tbm9kZWZhdWx0bGlicyAtbm9zdGRs aWIKKysjIERlYmlhbiBjaGFuZ2U6IGxpbmtpbmcgaWN1ZGF0YSBhcyBkYXRhIG9ubHkgY2F1c2Vz IHRvbyBtYW55IHByb2JsZW1zLgorK0xERkxBR1NJQ1VEVD0KKyAKKyAjIyBDb21waWxlciBzd2l0 Y2ggdG8gZW1iZWQgYSBsaWJyYXJ5IG5hbWUKKyAjIFRoZSBpbml0aWFsIHRhYiBpbiB0aGUgbmV4 dCBsaW5lIGlzIHRvIHByZXZlbnQgaWN1LWNvbmZpZyBmcm9tIHJlYWRpbmcgaXQuCg== 436693 2021-08-27 16:59:02 -0700 2021-08-29 22:01:27 -0700 Patch bug-229607-20210828075858.patch text/plain 3520 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxNjczCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWY0ZjFkZTNiNDMyNmRiZWIyMGNkZGI0OWJiOTY0NjFh YzYzYTMwMC4uZjEyYzcwODUzY2RiNzFjYTNmY2E5ZTg1OTg4YWJkZWJjODljYWZmYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDIxLTA4LTI3ICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisK KyAgICAgICAgW0dUS11bV1BFXSBBZGQgSUNVIDYzLjEgdG8gSkhCdWlsZCBtaW5pbWFsIGRlcGVu ZGVuY2llcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjI5NjA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBqaGJ1aWxkL2poYnVpbGQtbWluaW1hbC5tb2R1bGVzOgorICAgICAgICAqIGpoYnVpbGQvcGF0 Y2hlcy9pY3VkYXRhLXN0ZGxpYnMucGF0Y2g6IEFkZGVkLgorCiAyMDIxLTA4LTI2ICBKb25hdGhh biBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICBba2lsbC1vbGQtcHJvY2Vz c2VzXSBJbnZva2Ugd2l0aCBQeXRob24gMwpkaWZmIC0tZ2l0IGEvVG9vbHMvamhidWlsZC9qaGJ1 aWxkLW1pbmltYWwubW9kdWxlcyBiL1Rvb2xzL2poYnVpbGQvamhidWlsZC1taW5pbWFsLm1vZHVs ZXMKaW5kZXggZGM3ZWUzNmI5NjlmNjQ5MGQ5NmRmNGQ1MzEwZTZiODExMjRhNGE5NC4uM2JhNDQ0 ODJhNjcwNTlmN2E2YmQ2NDI0MWZmNmY2ZjI3ZmU4ZjJkNSAxMDA2NDQKLS0tIGEvVG9vbHMvamhi dWlsZC9qaGJ1aWxkLW1pbmltYWwubW9kdWxlcworKysgYi9Ub29scy9qaGJ1aWxkL2poYnVpbGQt bWluaW1hbC5tb2R1bGVzCkBAIC02LDYgKzYsNyBAQAogICA8bWV0YW1vZHVsZSBpZD0id2Via2l0 Z3RrLW1pbmltYWwtZGVwZW5kZW5jaWVzIj4KICAgICA8ZGVwZW5kZW5jaWVzPgogICAgICAgPGRl cCBwYWNrYWdlPSJ3cGViYWNrZW5kLWZkbyIvPgorICAgICAgPGRlcCBwYWNrYWdlPSJpY3UiLz4K ICAgICAgIDxkZXAgcGFja2FnZT0ibGlic291cCIvPgogICAgICAgPGRlcCBwYWNrYWdlPSJtYW5l dHRlIi8+CiAgICAgICA8ZGVwIHBhY2thZ2U9ImxpYnZweCIvPgpAQCAtMTUsNiArMTYsNyBAQAog ICA8bWV0YW1vZHVsZSBpZD0id2Via2l0d3BlLW1pbmltYWwtZGVwZW5kZW5jaWVzIj4KICAgICA8 ZGVwZW5kZW5jaWVzPgogICAgICAgPGRlcCBwYWNrYWdlPSJ3cGViYWNrZW5kLWZkbyIvPgorICAg ICAgPGRlcCBwYWNrYWdlPSJpY3UiLz4KICAgICAgIDxkZXAgcGFja2FnZT0ibGlic291cCIvPgog ICAgICAgPGRlcCBwYWNrYWdlPSJvcGVueHIiLz4KICAgICAgIDxkZXAgcGFja2FnZT0ibGlidnB4 Ii8+CkBAIC04Myw2ICs4NSwxNSBAQAogICAgIDwvYnJhbmNoPgogICA8L2NtYWtlPgogCisgIDxh dXRvdG9vbHMgaWQ9ImljdSIgYXV0b2dlbi1zaD0iLi9zb3VyY2UvY29uZmlndXJlIiBhdXRvZ2Vu YXJncz0iLS1kaXNhYmxlLXNhbXBsZXMgLS1lbmFibGUtd2Vhay10aHJlYWRzIj4KKyAgICA8cGtn LWNvbmZpZz5pY3UtaTE4bi5wYzwvcGtnLWNvbmZpZz4KKyAgICA8YnJhbmNoIG1vZHVsZT0idW5p Y29kZS1vcmcvaWN1L3JlbGVhc2VzL2Rvd25sb2FkL3JlbGVhc2UtNjEtMi9pY3U0Yy02MV8yLXNy Yy50Z3oiIHZlcnNpb249IjYxLjIiIGNoZWNrb3V0ZGlyPSJpY3UiCisgICAgICAgICAgICByZXBv PSJnaXRodWItdGFyYmFsbCIKKyAgICAgICAgICAgIGhhc2g9InNoYTI1NjpjYjZhOGY4ZTI5ZjAz NTU0Zjg2OGY4MWFlNzBkM2Q1Njg2MTM2NjA0MzA0MDczYmU2YmRlOGU3NWQ4MjA3ODU1Ij4KKyAg ICAgIDxwYXRjaCBmaWxlPSJpY3VkYXRhLXN0ZGxpYnMucGF0Y2giIHN0cmlwPSIxIi8+CisgICAg PC9icmFuY2g+CisgIDwvYXV0b3Rvb2xzPgorCiAgIDwhLS0gbGlic291cCA+PSAyLjY5IHJlcXVp cmVkIGZvciBTYW1lU2l0ZSBjb29raWUgc3VwcG9ydCAtLT4KICAgPG1lc29uIGlkPSJsaWJzb3Vw IiBtZXNvbmFyZ3M9Ii1EaW50cm9zcGVjdGlvbj1kaXNhYmxlZCAtRGdzc2FwaT1kaXNhYmxlZCAt RHZhcGk9ZGlzYWJsZWQgLUR0ZXN0cz1mYWxzZSI+CiAgICAgPHBrZy1jb25maWc+bGlic291cC0y LjQucGM8L3BrZy1jb25maWc+CkBAIC05OCw2ICsxMDksOSBAQAogCiAgIDxhdXRvdG9vbHMgaWQ9 ImxpYnBzbCIgYXV0b2dlbmFyZ3M9Ii0tZW5hYmxlLXJ1bnRpbWU9bGliaWN1IC0tZW5hYmxlLWJ1 aWx0aW49bGliaWN1Ij4KICAgICA8cGtnLWNvbmZpZz5saWJwc2wucGM8L3BrZy1jb25maWc+Cisg ICAgPGRlcGVuZGVuY2llcz4KKyAgICAgIDxkZXAgcGFja2FnZT0iaWN1Ii8+CisgICAgPC9kZXBl bmRlbmNpZXM+CiAgICAgPGJyYW5jaCBtb2R1bGU9InJvY2tkYWJvb3QvbGlicHNsL3JlbGVhc2Vz L2Rvd25sb2FkL2xpYnBzbC0ke3ZlcnNpb259L2xpYnBzbC0ke3ZlcnNpb259LnRhci5neiIKICAg ICAgICAgICAgIHZlcnNpb249IjAuMjAuMiIKICAgICAgICAgICAgIHJlcG89ImdpdGh1Yi10YXJi YWxsIgpkaWZmIC0tZ2l0IGEvVG9vbHMvamhidWlsZC9wYXRjaGVzL2ljdWRhdGEtc3RkbGlicy5w YXRjaCBiL1Rvb2xzL2poYnVpbGQvcGF0Y2hlcy9pY3VkYXRhLXN0ZGxpYnMucGF0Y2gKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uNWU5MmJkZWMxYjk1NTVkNGFiNjMyN2U1NTI1MmZlZjUyNTM2YTAyZgotLS0gL2Rldi9u dWxsCisrKyBiL1Rvb2xzL2poYnVpbGQvcGF0Y2hlcy9pY3VkYXRhLXN0ZGxpYnMucGF0Y2gKQEAg LTAsMCArMSwxNSBAQAorSW5kZXg6IGljdS01Mn5tMS9zb3VyY2UvY29uZmlnL21oLWxpbnV4Cis9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09CistLS0gaWN1LTUyfm0xLm9yaWcvc291cmNlL2NvbmZpZy9taC1saW51eAkyMDEz LTA5LTE0IDE4OjUzOjIzLjI4NDA0MDQ2NyAtMDQwMAorKysrIGljdS01Mn5tMS9zb3VyY2UvY29u ZmlnL21oLWxpbnV4CTIwMTMtMDktMTQgMTg6NTM6MjMuMjg0MDQwNDY3IC0wNDAwCitAQCAtMjEs NyArMjEsOSBAQAorIExEX1JQQVRIX1BSRSA9IC1XbCwtcnBhdGgsCisgCisgIyMgVGhlc2UgYXJl IHRoZSBsaWJyYXJ5IHNwZWNpZmljIExERkxBR1MKKy1MREZMQUdTSUNVRFQ9LW5vZGVmYXVsdGxp YnMgLW5vc3RkbGliCisrI0xERkxBR1NJQ1VEVD0tbm9kZWZhdWx0bGlicyAtbm9zdGRsaWIKKysj IERlYmlhbiBjaGFuZ2U6IGxpbmtpbmcgaWN1ZGF0YSBhcyBkYXRhIG9ubHkgY2F1c2VzIHRvbyBt YW55IHByb2JsZW1zLgorK0xERkxBR1NJQ1VEVD0KKyAKKyAjIyBDb21waWxlciBzd2l0Y2ggdG8g ZW1iZWQgYSBsaWJyYXJ5IG5hbWUKKyAjIFRoZSBpbml0aWFsIHRhYiBpbiB0aGUgbmV4dCBsaW5l IGlzIHRvIHByZXZlbnQgaWN1LWNvbmZpZyBmcm9tIHJlYWRpbmcgaXQuCg==