22959 2008-12-22 01:47:58 -0800 Memory leak in soup during loading & unloading an URL 2008-12-22 13:22:21 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Critical --- 1 dhanrd webkit-unassigned ddkilzer oldest_to_newest 103163 0 dhanrd 2008-12-22 01:47:58 -0800 Hi, I compiled WebKit-r39433 with configuration option --with-target=x11 --with-http-backend=soup. I created a page to refresh at interval of 2000ms with the following source code: <html> <script> function callme() { setTimeout(callme2,2000); } function callme2() { window.location.reload(); } </script> <body onload="callme()"> </body> </html> I also observed the VmSize of GtkLauncher and found the following result. Mon Dec 22 14:10:31 IST 2008 webkit: VmSize: 57348 kB Mon Dec 22 14:37:31 IST 2008 webkit: VmSize: 58708 kB I created a patch which shows no leaks for the same above test. I will post it soon. I have also discussed about these leaks in the following thread: https://lists.webkit.org/pipermail/webkit-dev/2008-December/006074.html 103164 1 26198 dhanrd 2008-12-22 02:10:10 -0800 Created attachment 26198 Memory leak fix for soup Here is my observation for the same test, after applying the patch. Mon Dec 22 15:01:54 IST 2008 webkit: VmSize: 56972 kB Mon Dec 22 15:23:54 IST 2008 webkit: VmSize: 56972 kB It can be seen that there is no leak happened during this test. 103181 2 26198 ddkilzer 2008-12-22 08:44:10 -0800 Comment on attachment 26198 Memory leak fix for soup Seems sane and well-tested. r=me 103212 3 ddkilzer 2008-12-22 13:22:21 -0800 $ git svn dcommit Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/network/soup/ResourceHandleSoup.cpp Committed r39439 http://trac.webkit.org/changeset/39439 26198 2008-12-22 02:10:10 -0800 2008-12-22 08:44:10 -0800 Memory leak fix for soup memleak_fix_for_soup.patch text/plain 1187 dhanrd SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzOTQzNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDgtMTItMjQgIERoYW5hbmpveSBDaHV0aWEgPGRoYW5yZEBnbWFp bC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Rml4ZXM6IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjk1OQorICAg ICAgICBNZW1vcnkgbGVhayBmaXhlcyBmb3IgV2ViS2l0K3NvdXAKKworICAgICAgICAqIHBsYXRm b3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6ZmluaXNoZWRDYWxsYmFjayk6CisKIDIwMDgtMTItMjIgIE5pa29sYXMgWmltbWVybWFubiAg PG5pa29sYXMuemltbWVybWFubkB0b3JjaG1vYmlsZS5jb20+CiAKICAgICAgICAgTm90IHJldmll d2VkLiBUcnkgdG8gZml4IGNsZWFuIE1hYyBidWlsZHMsIHNldCByb2xlPXByaXZhdGUgZm9yIEZv cm1EYXRhQnVpbGRlci5oCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNv dXJjZUhhbmRsZVNvdXAuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAJKHJldmlzaW9uIDM5NDM0KQorKysgV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTYzLDggKzE2Myw2IEBAIHN0YXRpYyB2b2lkIGZpbmlzaGVkQ2FsbGJhY2soU291 cFNlc3Npb24KICAgICAgICAgcmV0dXJuOwogCiAgICAgUmVzb3VyY2VIYW5kbGVJbnRlcm5hbCog ZCA9IGhhbmRsZS0+Z2V0SW50ZXJuYWwoKTsKLSAgICAvLyBUaGUgbWVzc2FnZSBoYXMgYmVlbiBo YW5kbGVkLgotICAgIGQtPm1fbXNnID0gTlVMTDsKIAogICAgIFJlc291cmNlSGFuZGxlQ2xpZW50 KiBjbGllbnQgPSBoYW5kbGUtPmNsaWVudCgpOwogICAgIGlmICghY2xpZW50KQo=